[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649984842 Thanks all the comments. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146019#comment-17146019 ] Michael Stack commented on HBASE-24623: --- No offheap BC, no offheap write path, all defaults. I do

[jira] [Resolved] (HBASE-24382) Flush partial stores of region filtered by seqId when archive wal due to too many wals

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24382. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Thanks

[GitHub] [hbase] saintstack merged pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
saintstack merged pull request #1737: URL: https://github.com/apache/hbase/pull/1737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
saintstack commented on a change in pull request #1737: URL: https://github.com/apache/hbase/pull/1737#discussion_r445967514 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -2386,6 +2386,16 @@ public FlushResult flush(boolean

[jira] [Commented] (HBASE-24603) Zookeeper sync() call is async

2020-06-25 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146009#comment-17146009 ] HBase QA commented on HBASE-24603: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on pull request #1976: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1976: URL: https://github.com/apache/hbase/pull/1976#issuecomment-649965322 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 12m

[GitHub] [hbase] Apache-HBase commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649960349 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] comnetwork edited a comment on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
comnetwork edited a comment on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649947973 > > > That is to say, AsyncFSWAL.getLogFileSizeIfBeingWritten could not reflect the file length which successfully synced to underlying HDFS, which is not as

[GitHub] [hbase] comnetwork commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
comnetwork commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649947973 > > > That is to say, AsyncFSWAL.getLogFileSizeIfBeingWritten could not reflect the file length which successfully synced to underlying HDFS, which is not as

[GitHub] [hbase] comnetwork edited a comment on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
comnetwork edited a comment on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649947973 > > > That is to say, AsyncFSWAL.getLogFileSizeIfBeingWritten could not reflect the file length which successfully synced to underlying HDFS, which is not

[GitHub] [hbase] comnetwork removed a comment on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
comnetwork removed a comment on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649947198 @Apache9 , I already added comments for `WriteBase.getSyncedLength` like following: /** *NOTE: We add this method for {@link

[GitHub] [hbase] comnetwork commented on pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
comnetwork commented on pull request #1970: URL: https://github.com/apache/hbase/pull/1970#issuecomment-649947198 @Apache9 , I already added comments for `WriteBase.getSyncedLength` like following: /** *NOTE: We add this method for {@link WALFileLengthProvider} used

[GitHub] [hbase] comnetwork commented on a change in pull request #1970: HBASE-24625 AsyncFSWAL.getLogFileSizeIfBeingWritten does not return the expected synced file length.

2020-06-25 Thread GitBox
comnetwork commented on a change in pull request #1970: URL: https://github.com/apache/hbase/pull/1970#discussion_r445943229 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java ## @@ -46,6 +46,10 @@ protected

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-649921243 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-22504) Optimize the MultiByteBuff#get(ByteBuffer, offset, len)

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145975#comment-17145975 ] Hudson commented on HBASE-22504: Results for branch branch-2 [build #2719 on

[jira] [Commented] (HBASE-24600) Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145973#comment-17145973 ] Hudson commented on HBASE-24600: Results for branch branch-2 [build #2719 on

[jira] [Commented] (HBASE-24616) Remove BoundedRecoveredHFilesOutputSink dependency on a TableDescriptor

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145976#comment-17145976 ] Hudson commented on HBASE-24616: Results for branch branch-2 [build #2719 on

[jira] [Commented] (HBASE-24631) Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145974#comment-17145974 ] Hudson commented on HBASE-24631: Results for branch branch-2 [build #2719 on

[jira] [Commented] (HBASE-24630) Purge dev javadoc from client bin tarball

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145972#comment-17145972 ] Hudson commented on HBASE-24630: Results for branch branch-2 [build #2719 on

[GitHub] [hbase] Apache-HBase commented on pull request #1977: HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1977: URL: https://github.com/apache/hbase/pull/1977#issuecomment-649910706 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1977: HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1977: URL: https://github.com/apache/hbase/pull/1977#issuecomment-649908257 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24603) Zookeeper sync() call is async

2020-06-25 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24603: - Resolution: Fixed Status: Resolved (was: Patch Available) > Zookeeper

[jira] [Updated] (HBASE-24603) Zookeeper sync() call is async

2020-06-25 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-24603: - Release Note: Fixes a couple of bugs in ZooKeeper interaction. Firstly, zk

[jira] [Comment Edited] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145964#comment-17145964 ] Andrew Kyle Purtell edited comment on HBASE-24637 at 6/26/20, 1:47 AM:

[jira] [Commented] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145964#comment-17145964 ] Andrew Kyle Purtell commented on HBASE-24637: - If you'd like to play around with the

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: parse_call_trace.pl > Filter SKIP hinting regression >

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: W-7665966-FAST_DIFF-FILTER_ALL.pdf > Filter SKIP hinting regression >

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: W-7665966-Instrument-low-level-scan-details-branch-1.patch > Filter

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Attachment: W-7665966-Instrument-low-level-scan-details-branch-2.2.patch > Filter

[jira] [Updated] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-24637: Affects Version/s: 2.2.5 > Filter SKIP hinting regression >

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-649900916 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-24637) Filter SKIP hinting regression

2020-06-25 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-24637: --- Summary: Filter SKIP hinting regression Key: HBASE-24637 URL: https://issues.apache.org/jira/browse/HBASE-24637 Project: HBase Issue Type: Bug

[GitHub] [hbase] bharathv merged pull request #1976: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
bharathv merged pull request #1976: URL: https://github.com/apache/hbase/pull/1976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1976: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1976: URL: https://github.com/apache/hbase/pull/1976#issuecomment-649894137 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24603) Zookeeper sync() call is async

2020-06-25 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145957#comment-17145957 ] HBase QA commented on HBASE-24603: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] Apache-HBase commented on pull request #1975: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1975: URL: https://github.com/apache/hbase/pull/1975#issuecomment-649883607 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24631) Loosen Dockerfile pinned package versions of the "debian-revision"

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145938#comment-17145938 ] Hudson commented on HBASE-24631: Results for branch branch-2.3 [build #156 on

[jira] [Commented] (HBASE-24630) Purge dev javadoc from client bin tarball

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145936#comment-17145936 ] Hudson commented on HBASE-24630: Results for branch branch-2.3 [build #156 on

[jira] [Commented] (HBASE-24600) Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145937#comment-17145937 ] Hudson commented on HBASE-24600: Results for branch branch-2.3 [build #156 on

[jira] [Commented] (HBASE-24630) Purge dev javadoc from client bin tarball

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145933#comment-17145933 ] Hudson commented on HBASE-24630: Results for branch branch-2.2 [build #902 on

[jira] [Commented] (HBASE-24600) Empty RegionAction added to MultiRequest in case of RowMutations/CheckAndMutate batch

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145934#comment-17145934 ] Hudson commented on HBASE-24600: Results for branch branch-2.2 [build #902 on

[GitHub] [hbase] Apache-HBase commented on pull request #1935: HBASE-22146 SpaceQuotaViolationPolicy Disable is not working in Names…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1935: URL: https://github.com/apache/hbase/pull/1935#issuecomment-649870516 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv merged pull request #1975: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
bharathv merged pull request #1975: URL: https://github.com/apache/hbase/pull/1975 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #1975: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1975: URL: https://github.com/apache/hbase/pull/1975#issuecomment-649867229 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1977: HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1977: URL: https://github.com/apache/hbase/pull/1977#issuecomment-649858463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] busbey commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
busbey commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445878539 ## File path: hbase-shell/src/main/ruby/hbase_constants.rb ## @@ -109,8 +109,8 @@ def self.promote_constants(constants) end end -

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-06-25 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145897#comment-17145897 ] Hudson commented on HBASE-11288: Results for branch HBASE-11288.splittable-meta [build #9 on

[GitHub] [hbase] ndimiduk commented on pull request #1977: HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles

2020-06-25 Thread GitBox
ndimiduk commented on pull request #1977: URL: https://github.com/apache/hbase/pull/1977#issuecomment-649842942 FYI @nyl3532016 @wchevreuil This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] ndimiduk opened a new pull request #1977: HBASE-24221 addendum to restore public interface on LoadIncrementalHFiles

2020-06-25 Thread GitBox
ndimiduk opened a new pull request #1977: URL: https://github.com/apache/hbase/pull/1977 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145885#comment-17145885 ] Nick Dimiduk commented on HBASE-21782: -- [~zhangduo] the deprecation comments from this change on

[jira] [Reopened] (HBASE-24221) Support bulkLoadHFile by family

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-24221: -- Reopening to address the compatibility change to  LoadIncrementalHFiles.tryAtomicRegionLoad. >

[jira] [Resolved] (HBASE-9756) HBase shell help info would be better to display only when usage error instead of any exception

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller resolved HBASE-9756. -- Resolution: Duplicate > HBase shell help info would be better to display only when usage error

[jira] [Commented] (HBASE-9756) HBase shell help info would be better to display only when usage error instead of any exception

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145860#comment-17145860 ] Elliot Miller commented on HBASE-9756: -- A different patch (HBASE-20270) was merged in 2018 to

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649824525 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1975: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1975: URL: https://github.com/apache/hbase/pull/1975#issuecomment-649822553 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv opened a new pull request #1976: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
bharathv opened a new pull request #1976: URL: https://github.com/apache/hbase/pull/1976 Writing a test for this is tricky. There is enough coverage for functional tests. Only concern is performance, but there is enough logging for it to detect timed out/badly performing sync calls.

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445838230 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -971,101 +976,103 @@ def enabled?(table_name) end

[GitHub] [hbase] Apache-HBase commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-649816256 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445790978 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -971,101 +976,103 @@ def enabled?(table_name) end

[jira] [Updated] (HBASE-20819) Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread Elliot Miller (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliot Miller updated HBASE-20819: -- Fix Version/s: 3.0.0-alpha-1 > Use TableDescriptor to replace HTableDescriptor in hbase-shell

[jira] [Resolved] (HBASE-7196) 'hbase shell status' throws exception when HBase is not running

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-7196. -- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Assignee: Elliot Miller

[GitHub] [hbase] Apache-HBase commented on pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1945: URL: https://github.com/apache/hbase/pull/1945#issuecomment-649805385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bharathv opened a new pull request #1975: HBASE-24603: Make Zookeeper sync() call synchronous (#1945)

2020-06-25 Thread GitBox
bharathv opened a new pull request #1975: URL: https://github.com/apache/hbase/pull/1975 Writing a test for this is tricky. There is enough coverage for functional tests. Only concern is performance, but there is enough logging for it to detect timed out/badly performing sync calls.

[GitHub] [hbase] bharathv merged pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
bharathv merged pull request #1945: URL: https://github.com/apache/hbase/pull/1945 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (HBASE-24636) Increase default Normalizer interval

2020-06-25 Thread Nick Dimiduk (Jira)
Nick Dimiduk created HBASE-24636: Summary: Increase default Normalizer interval Key: HBASE-24636 URL: https://issues.apache.org/jira/browse/HBASE-24636 Project: HBase Issue Type: Task

[GitHub] [hbase] ndimiduk commented on a change in pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-25 Thread GitBox
ndimiduk commented on a change in pull request #1933: URL: https://github.com/apache/hbase/pull/1933#discussion_r445796219 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/EmptyNormalizationPlan.java ## @@ -44,7 +44,8 @@ public static

[GitHub] [hbase] Apache-HBase commented on pull request #1972: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1972: URL: https://github.com/apache/hbase/pull/1972#issuecomment-649778998 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Updated] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-21879: -- Release Note: Before this issue, read path was 100% offheap when block is in the BucketCache.

[GitHub] [hbase] ndimiduk commented on a change in pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-25 Thread GitBox
ndimiduk commented on a change in pull request #1933: URL: https://github.com/apache/hbase/pull/1933#discussion_r445191420 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -833,6 +833,9 @@ void unassign(byte[] regionName, boolean force)

[jira] [Commented] (HBASE-24627) Normalize one table at a time

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145792#comment-17145792 ] Nick Dimiduk commented on HBASE-24627: -- I'd have a look at existing, similar apis. I think we have

[GitHub] [hbase] Apache-HBase commented on pull request #1972: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1972: URL: https://github.com/apache/hbase/pull/1972#issuecomment-649776738 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Updated] (HBASE-22309) Replace Shipper Interface with Netty's ReferenceCounted; add ExtendCell#retain/ExtendCell#release

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-22309: -- Issue Type: Improvement (was: Bug) Priority: Critical (was: Major) Summary:

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445790978 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -971,101 +976,103 @@ def enabled?(table_name) end

[jira] [Updated] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-21879: -- Release Note: Before this issue, read path was 100% offheap when block is in the BucketCache.

[GitHub] [hbase] Apache-HBase commented on pull request #1971: Backport: HBASE-24552 Replica region needs to check if primary region directory…

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1971: URL: https://github.com/apache/hbase/pull/1971#issuecomment-649773677 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1945: HBASE-24603: Make Zookeeper sync() call synchronous

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1945: URL: https://github.com/apache/hbase/pull/1945#issuecomment-649766401 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-20610) Procedure V2 - Distributed Log Splitting

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20610: -- Release Note: See RN in HBASE-21588 for detail on this feature. It landed in hbase-2.2.0.

[jira] [Updated] (HBASE-20610) Procedure V2 - Distributed Log Splitting

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20610: -- Fix Version/s: (was: 2.3.0) 2.2.0 > Procedure V2 - Distributed Log

[jira] [Updated] (HBASE-20610) Procedure V2 - Distributed Log Splitting

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20610: -- Release Note: See RN in HBASE-21588 for detail on this feature. (was: See RN in

[jira] [Updated] (HBASE-20610) Procedure V2 - Distributed Log Splitting

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20610: -- Fix Version/s: (was: 2.3.1) 2.3.0 > Procedure V2 - Distributed Log

[jira] [Updated] (HBASE-20610) Procedure V2 - Distributed Log Splitting

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-20610: -- Release Note: See RN in https://issues.apache.org/jira/browse/HBASE-21588 > Procedure V2 -

[jira] [Resolved] (HBASE-24585) Failed start recovering crash in standalone mode if procedure-based distributed WAL split & hbase.wal.split.to.hfile=true

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24585. --- Fix Version/s: 2.3.0 3.0.0-alpha-1 Assignee: Michael Stack

[GitHub] [hbase] saintstack commented on pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-25 Thread GitBox
saintstack commented on pull request #1955: URL: https://github.com/apache/hbase/pull/1955#issuecomment-649763073 Merged. The failures vary and are flakies. This is an automated message from the Apache Git Service. To

[jira] [Resolved] (HBASE-24616) Remove BoundedRecoveredHFilesOutputSink dependency on a TableDescriptor

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24616. --- Hadoop Flags: Reviewed Assignee: Michael Stack Resolution: Fixed Pushed on

[jira] [Commented] (HBASE-24603) Zookeeper sync() call is async

2020-06-25 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145751#comment-17145751 ] Bharath Vissapragada commented on HBASE-24603: -- Ok, I'll add a release note. > we have

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-649756191 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #1774: HBASE-24389 Introduce new master rpc methods to locate meta region through root region

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1774: URL: https://github.com/apache/hbase/pull/1774#issuecomment-649753729 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] saintstack merged pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-25 Thread GitBox
saintstack merged pull request #1955: URL: https://github.com/apache/hbase/pull/1955 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on a change in pull request #1955: HBASE-24616 Remove BoundedRecoveredHFilesOutputSink dependency on a T…

2020-06-25 Thread GitBox
saintstack commented on a change in pull request #1955: URL: https://github.com/apache/hbase/pull/1955#discussion_r445765597 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedRecoveredHFilesOutputSink.java ## @@ -191,50 +186,22 @@ public boolean

[jira] [Commented] (HBASE-24633) Remove data locality and StoreFileCostFunction for replica regions out of balancer's cost calculation

2020-06-25 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145729#comment-17145729 ] Huaxiang Sun commented on HBASE-24633: -- {code:java} Data locality of replica regions in balancer

[GitHub] [hbase] bitoffdev commented on a change in pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
bitoffdev commented on a change in pull request #1959: URL: https://github.com/apache/hbase/pull/1959#discussion_r445722179 ## File path: hbase-shell/src/main/ruby/hbase/admin.rb ## @@ -1359,26 +1366,26 @@ def list_locks @admin.getLocks end -# Parse arguments

[GitHub] [hbase] Apache-HBase commented on pull request #1974: Backport "HBASE-22504 Addendum: restore findCommonPrefix" to branch-2.3

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1974: URL: https://github.com/apache/hbase/pull/1974#issuecomment-649743890 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1974: Backport "HBASE-22504 Addendum: restore findCommonPrefix" to branch-2.3

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1974: URL: https://github.com/apache/hbase/pull/1974#issuecomment-649743046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (HBASE-22504) Optimize the MultiByteBuff#get(ByteBuffer, offset, len)

2020-06-25 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-22504. -- Resolution: Fixed Pushed addendum to branch-2 and branch-2.3. The whole class is

[GitHub] [hbase] ndimiduk merged pull request #1974: Backport "HBASE-22504 Addendum: restore findCommonPrefix" to branch-2.3

2020-06-25 Thread GitBox
ndimiduk merged pull request #1974: URL: https://github.com/apache/hbase/pull/1974 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-21946: -- Priority: Critical (was: Major) > Replace the byte[] pread by ByteBuffer pread in HFileBlock

[GitHub] [hbase] virajjasani edited a comment on pull request #1933: HBASE-24588 : Submit task for NormalizationPlan

2020-06-25 Thread GitBox
virajjasani edited a comment on pull request #1933: URL: https://github.com/apache/hbase/pull/1933#issuecomment-649265950 > No, I think it's better to not try to get into that, especially if we think we'll bump the normalizer run interval to something much larger, like every 24 hours.

[GitHub] [hbase] Apache-HBase commented on pull request #1959: HBASE-20819 Use TableDescriptor to replace HTableDescriptor in hbase-shell module

2020-06-25 Thread GitBox
Apache-HBase commented on pull request #1959: URL: https://github.com/apache/hbase/pull/1959#issuecomment-649741835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-21946) Replace the byte[] pread by ByteBuffer pread in HFileBlock reading once HDFS-3246 prepared

2020-06-25 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-21946: -- Fix Version/s: 2.4.0 2.3.1 3.0.0-alpha-1 > Replace the

  1   2   3   >