WenFeiYi commented on a change in pull request #2021:
URL: https://github.com/apache/hbase/pull/2021#discussion_r453449631
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractWALRoller.java
##
@@ -174,18 +170,21 @@ public void run() {
}
Apache-HBase commented on pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#issuecomment-657371625
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
bsglz commented on pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#issuecomment-657370727
@wchevreuil @Apache9
FYI, this PR should be merged to master only, I will push a new PR for
branch-2(change DEFAULT_OVERALL_HREGION_FILES to false )
virajjasani commented on a change in pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#discussion_r453445875
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -608,7 +608,7 @@
/**
* Last row in a table.
*/
-
Apache-HBase commented on pull request #1986:
URL: https://github.com/apache/hbase/pull/1986#issuecomment-657363669
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2007:
URL: https://github.com/apache/hbase/pull/2007#issuecomment-657356008
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #2052:
URL: https://github.com/apache/hbase/pull/2052#issuecomment-657354558
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
Apache-HBase commented on pull request #1231:
URL: https://github.com/apache/hbase/pull/1231#issuecomment-657354552
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2052:
URL: https://github.com/apache/hbase/pull/2052#issuecomment-657353990
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
Apache-HBase commented on pull request #2049:
URL: https://github.com/apache/hbase/pull/2049#issuecomment-657351859
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #1231:
URL: https://github.com/apache/hbase/pull/1231#issuecomment-657346469
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #1940:
URL: https://github.com/apache/hbase/pull/1940#issuecomment-657344092
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#issuecomment-657342284
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-24704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Wang updated HBASE-24704:
---
Description: Currently we display the column family as vertical, it is not
easy to view, my
infraio commented on pull request #2019:
URL: https://github.com/apache/hbase/pull/2019#issuecomment-657330241
Yes. But I plan to implement it piece by piece and make sure all ut passed,
it will be easy for review. Will finish the complete "decouple" in the follow
on issues. Meanwhile, I
Apache-HBase commented on pull request #2042:
URL: https://github.com/apache/hbase/pull/2042#issuecomment-657328642
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
WenFeiYi closed pull request #2024:
URL: https://github.com/apache/hbase/pull/2024
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bsglz commented on a change in pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#discussion_r453401671
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionSplitPolicy.java
##
@@ -75,7 +75,7 @@ protected void
bsglz commented on a change in pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#discussion_r453399865
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java
##
@@ -94,4 +90,33 @@ long
bsglz commented on a change in pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#discussion_r453399710
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java
##
@@ -38,10 +41,13 @@
*/
bsglz commented on a change in pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#discussion_r453399499
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -382,6 +382,13 @@
/** Default maximum file size */
public static
Apache-HBase commented on pull request #2053:
URL: https://github.com/apache/hbase/pull/2053#issuecomment-657320133
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2053:
URL: https://github.com/apache/hbase/pull/2053#issuecomment-657318009
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 commented on a change in pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#discussion_r453395729
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -608,7 +608,7 @@
/**
* Last row in a table.
*/
- public
Apache-HBase commented on pull request #2053:
URL: https://github.com/apache/hbase/pull/2053#issuecomment-657282934
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
arshadmohammad edited a comment on pull request #2043:
URL: https://github.com/apache/hbase/pull/2043#issuecomment-657278839
Issue is applicable to master branch also. Raised mater branch PR
https://github.com/apache/hbase/pull/2053
arshadmohammad opened a new pull request #2053:
URL: https://github.com/apache/hbase/pull/2053
…group.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
arshadmohammad commented on pull request #2043:
URL: https://github.com/apache/hbase/pull/2043#issuecomment-657278839
issue is applicable to master also. Raised mater PR
https://github.com/apache/hbase/pull/2053
This is an
Apache-HBase commented on pull request #2052:
URL: https://github.com/apache/hbase/pull/2052#issuecomment-657277731
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2052:
URL: https://github.com/apache/hbase/pull/2052#issuecomment-657264721
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
virajjasani opened a new pull request #2052:
URL: https://github.com/apache/hbase/pull/2052
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-24718 started by Viraj Jasani.
> Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[
https://issues.apache.org/jira/browse/HBASE-24528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156365#comment-17156365
]
Viraj Jasani commented on HBASE-24528:
--
Created sub-task HBASE-24718 for refactor work of current
Viraj Jasani created HBASE-24718:
Summary: Generic NamedQueue framework for recent in-memory history
(refactor slowlog)
Key: HBASE-24718
URL: https://issues.apache.org/jira/browse/HBASE-24718
[
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156347#comment-17156347
]
Andrew Kyle Purtell commented on HBASE-11288:
-
Here is my suggestion:
Reset this
[
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156345#comment-17156345
]
Andrew Kyle Purtell commented on HBASE-11288:
-
Glad for the candid language and
virajjasani commented on pull request #2043:
URL: https://github.com/apache/hbase/pull/2043#issuecomment-657235290
This issue is specific to branch-2 only? If not, can you create PR for
master branch?
This is an automated
virajjasani commented on a change in pull request #2047:
URL: https://github.com/apache/hbase/pull/2047#discussion_r453328220
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3000,7 +3001,12 @@ private void
Apache9 commented on a change in pull request #2011:
URL: https://github.com/apache/hbase/pull/2011#discussion_r453313685
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -382,6 +382,13 @@
/** Default maximum file size */
public
Apache-HBase commented on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657210076
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657202809
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
nyl3532016 commented on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657196375
> Let's run a YCSB or at least a PE to see the performance impact?
yes,it is necessary, Let me do it
[
https://issues.apache.org/jira/browse/HBASE-24717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156242#comment-17156242
]
Anoop Sam John commented on HBASE-24717:
Which version? You mean using
Apache9 commented on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657193494
Let's run a YCSB or at least a PE to see the performance impact?
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156240#comment-17156240
]
Duo Zhang commented on HBASE-11288:
---
{quote}
I can file a sub-issue to address as a follow-on – I like
[
https://issues.apache.org/jira/browse/HBASE-24601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156241#comment-17156241
]
dark_num commented on HBASE-24601:
--
Due to there has been no new reply/review for some time.
[~Ddupg]
virajjasani commented on pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#issuecomment-657191967
@cuibo01 you can replace "logic error" with "readability improvement".
Changes look good.
Thanks
This is
virajjasani edited a comment on pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#issuecomment-657191967
@cuibo01 you can replace "logic error" with "readability improvement" in PR
title. Changes look good.
Thanks
virajjasani commented on a change in pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#discussion_r453286330
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -608,7 +608,7 @@
/**
* Last row in a table.
*/
-
virajjasani commented on a change in pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#discussion_r453286330
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##
@@ -608,7 +608,7 @@
/**
* Last row in a table.
*/
-
Apache-HBase commented on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657190566
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2050:
URL: https://github.com/apache/hbase/pull/2050#issuecomment-657188595
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
nyl3532016 edited a comment on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657186954
> _I wonder do we still need the testSizes method in TestHeapSize after this
change? And we need a performance test to see if there are any impact on
nyl3532016 commented on pull request #2018:
URL: https://github.com/apache/hbase/pull/2018#issuecomment-657186954
> I wonder do we still need the testSizes method in TestHeapSize after this
change? And we need a performance test to see if there are any impact on
performance(although I
Apache-HBase commented on pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#issuecomment-657185947
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#issuecomment-657185518
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #2051:
URL: https://github.com/apache/hbase/pull/2051#issuecomment-657185240
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-24693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui updated HBASE-24693:
---
Status: Patch Available (was: In Progress)
> regioninfo#isLast() has a logic error
>
[
https://issues.apache.org/jira/browse/HBASE-24693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-24693 started by Bo Cui.
--
> regioninfo#isLast() has a logic error
> -
>
>
[
https://issues.apache.org/jira/browse/HBASE-24693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bo Cui reassigned HBASE-24693:
--
Assignee: Bo Cui
> regioninfo#isLast() has a logic error
> -
>
>
cuibo01 opened a new pull request #2051:
URL: https://github.com/apache/hbase/pull/2051
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cuibo01 opened a new pull request #2050:
URL: https://github.com/apache/hbase/pull/2050
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
62 matches
Mail list logo
