[GitHub] [hbase] ndimiduk merged pull request #2281: HBASE-24867 Add 2.3.1 to the downloads page

2020-08-20 Thread GitBox
ndimiduk merged pull request #2281: URL: https://github.com/apache/hbase/pull/2281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] 1996fanrui edited a comment on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
1996fanrui edited a comment on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677748719 > Nice patch, do you know of any other callers who can pass `BlockType` argument? @virajjasani Thanks for your comment. The main flow of get() will

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677764605 `To me, I think this is a mistake, it should not be placed in RegionInfo, or at least should be marked as IA.Private? We have lots of IA.Private fields and methods in

[GitHub] [hbase] Apache-HBase commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677761211 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] 1996fanrui edited a comment on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
1996fanrui edited a comment on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677748719 > Nice patch, do you know of any other callers who can pass `BlockType` argument? @virajjasani Thanks for your comment. The main flow of get() will

[GitHub] [hbase] huaxiangsun commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-20 Thread GitBox
huaxiangsun commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677756184 Thanks @ddupg. One quick question, will the new UT fail without changes in refreshSources()? Just want to make sure that the UT really does its job. +1 pending on your

[GitHub] [hbase] Apache-HBase commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-677755141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] 1996fanrui commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
1996fanrui commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677748719 > Nice patch, do you know of any other callers who can pass `BlockType` argument? @virajjasani Thanks for your comment。 The main flow of get() will initialize

[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677743405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-20 Thread GitBox
bsglz commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-677727556 > This will be valid only after #2272 right? Yeah. This is an automated message from the Apache Git Service.

[GitHub] [hbase] bsglz edited a comment on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-20 Thread GitBox
bsglz edited a comment on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677723234 The related logic shows below. > @Override > public boolean isOffPeakHour(int targetHour) { > if (startHour <= endHour) { > return

[GitHub] [hbase] bsglz edited a comment on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-20 Thread GitBox
bsglz edited a comment on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677723234 The related logic shows below. > @Override > public boolean isOffPeakHour(int targetHour) { > if (startHour <= endHour) { > return

[GitHub] [hbase] bsglz commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-20 Thread GitBox
bsglz commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677723234 The related logic shows below. > @Override > public boolean isOffPeakHour(int targetHour) { > if (startHour <= endHour) { > return startHour <=

[GitHub] [hbase] bsglz commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-20 Thread GitBox
bsglz commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677718538 > We have this condition: > > ``` > private static boolean isValidHour(int hour) { > return 0 <= hour && hour <= 23; > } > ``` > > which means 0 and

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-677712834 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani removed a comment on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
virajjasani removed a comment on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677709447 Can you please take care of checkstyle issue reported above? This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677710458 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
virajjasani commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677709447 Can you please take care of checkstyle issue reported above? This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-677709327 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677702979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2288: URL: https://github.com/apache/hbase/pull/2288#issuecomment-677693462 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] 1996fanrui opened a new pull request #2288: HBASE-24915 Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread GitBox
1996fanrui opened a new pull request #2288: URL: https://github.com/apache/hbase/pull/2288 In some cases where BlockType is known, BlockCache read performance can be improved This is an automated message from the Apache Git

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473975181 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[jira] [Created] (HBASE-24915) Improve BlockCache read performance by specifying BlockType

2020-08-20 Thread fanrui (Jira)
fanrui created HBASE-24915: -- Summary: Improve BlockCache read performance by specifying BlockType Key: HBASE-24915 URL: https://issues.apache.org/jira/browse/HBASE-24915 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2287: HBASE-24914 Remove duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677661322 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-20 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r473676689 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerDecisionRequest.java ## @@ -0,0 +1,64 @@ +/* + * + * Licensed to the

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-20 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r473676689 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerDecisionRequest.java ## @@ -0,0 +1,64 @@ +/* + * + * Licensed to the

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-20 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r473904758 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AdminOverAsyncAdmin.java ## @@ -1057,4 +1051,9 @@ public void

[jira] [Updated] (HBASE-24906) Enlarge the wait time in TestReplicationEndpoint#testInterClusterReplication

2020-08-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24906: --- Summary: Enlarge the wait time in TestReplicationEndpoint#testInterClusterReplication

[jira] [Assigned] (HBASE-24904) HBASE-24904 Speed up TestAsyncTableAdminApi/TestSnapshotTemporaryDirectoryWithRegionReplicas/TestRegionReplicaFailover

2020-08-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24904: -- Assignee: Guanghao Zhang > HBASE-24904 Speed up >

[jira] [Assigned] (HBASE-24906) Enlarge the wait time in TestReplicationEndpoint#testInterClusterReplication

2020-08-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-24906: -- Assignee: Guanghao Zhang > Enlarge the wait time in

[jira] [Updated] (HBASE-24914) Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig

2020-08-20 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24914: Summary: Remove duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig

[GitHub] [hbase] ddupg commented on pull request #2287: HBASE-24914 Reomve duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
ddupg commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677643748 > @ddupg There's a typo in the commit message: "Reomve" => "Remove" Oh, thanks, let me fix it. This is an

[GitHub] [hbase] HorizonNet commented on pull request #2287: HBASE-24914 Reomve duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
HorizonNet commented on pull request #2287: URL: https://github.com/apache/hbase/pull/2287#issuecomment-677642198 @ddupg There's a typo in the commit message: "Reomve" => "Remove" This is an automated message from the Apache

[GitHub] [hbase] ddupg commented on a change in pull request #2149: HBASE-24760 Allow system tables fallback to any rs groups

2020-08-20 Thread GitBox
ddupg commented on a change in pull request #2149: URL: https://github.com/apache/hbase/pull/2149#discussion_r473940884 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -88,9 +87,15 @@ */ public static final

[GitHub] [hbase] Apache-HBase commented on pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2286: URL: https://github.com/apache/hbase/pull/2286#issuecomment-677639502 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ddupg opened a new pull request #2287: HBASE-24914 Reomve duplicate code appearing continuously in method Re…

2020-08-20 Thread GitBox
ddupg opened a new pull request #2287: URL: https://github.com/apache/hbase/pull/2287 …plicationPeerManager.updatePeerConfig This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Created] (HBASE-24914) Reomve duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig

2020-08-20 Thread Sun Xin (Jira)
Sun Xin created HBASE-24914: --- Summary: Reomve duplicate code appearing continuously in method ReplicationPeerManager.updatePeerConfig Key: HBASE-24914 URL: https://issues.apache.org/jira/browse/HBASE-24914

[GitHub] [hbase] ddupg opened a new pull request #2286: HBASE-24913 Refactor TestJMXConnectorServer

2020-08-20 Thread GitBox
ddupg opened a new pull request #2286: URL: https://github.com/apache/hbase/pull/2286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (HBASE-24913) Refactor TestJMXConnectorServer

2020-08-20 Thread Sun Xin (Jira)
Sun Xin created HBASE-24913: --- Summary: Refactor TestJMXConnectorServer Key: HBASE-24913 URL: https://issues.apache.org/jira/browse/HBASE-24913 Project: HBase Issue Type: Improvement

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-677573625 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677564667 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enlarge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677554724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24912) Enlarge MemstoreFlusherChore/CompactionChecker period for unit test

2020-08-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24912: --- Summary: Enlarge MemstoreFlusherChore/CompactionChecker period for unit test (was: Enalrge

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-677525455 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2222: HBASE-23834 HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jet…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #: URL: https://github.com/apache/hbase/pull/#issuecomment-677510906 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2222: HBASE-23834 HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jet…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #: URL: https://github.com/apache/hbase/pull/#issuecomment-677508720 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2222: HBASE-23834 HBase fails to run on Hadoop 3.3.0/3.2.2/3.1.4 due to jet…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #: URL: https://github.com/apache/hbase/pull/#issuecomment-677508847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #35: HBASE-24787 [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #35: URL: https://github.com/apache/hbase-thirdparty/pull/35#issuecomment-677505837 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #35: HBASE-24787 [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #35: URL: https://github.com/apache/hbase-thirdparty/pull/35#issuecomment-677499350 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enalrge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677498927 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-thirdparty] Apache9 opened a new pull request #35: HBASE-24787 [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT

2020-08-20 Thread GitBox
Apache9 opened a new pull request #35: URL: https://github.com/apache/hbase-thirdparty/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24787) [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT

2020-08-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24787: -- Fix Version/s: thirdparty-3.5.0 > [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT >

[jira] [Work started] (HBASE-24787) [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT

2020-08-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24787 started by Duo Zhang. - > [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT >

[jira] [Assigned] (HBASE-24787) [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT

2020-08-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24787: - Assignee: Duo Zhang > [hbase-thirdparty] Set version as 3.4.1-SNAPSHOT >

[jira] [Resolved] (HBASE-24891) [hbase-thirdparty] Put up 3.4.0RC2

2020-08-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24891. --- Assignee: Duo Zhang Resolution: Fixed Released 3.4.0RC2 as 3.4.0. > [hbase-thirdparty] Put

[GitHub] [hbase] Apache9 commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache9 commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473802512 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473800695 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473800695 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473796213 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] Apache9 commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache9 commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473790856 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473788969 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] Apache9 commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache9 commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473780685 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473777358 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] Apache-HBase commented on pull request #2095: HBASE-24459 Move the locateMeta logic from AsyncMetaRegionTableLocato…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2095: URL: https://github.com/apache/hbase/pull/2095#issuecomment-677466229 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473775819 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[jira] [Commented] (HBASE-11288) Splittable Meta

2020-08-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-11288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181039#comment-17181039 ] Duo Zhang commented on HBASE-11288: --- And another thing is what I have said in the past, exposing only

[GitHub] [hbase] HorizonNet commented on pull request #2285: HBASE-24912 Enalrge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
HorizonNet commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677460946 @infraio There's a small typo in the commit message: "Enalrge" => "Enlarge" This is an automated message from

[GitHub] [hbase] Apache9 commented on a change in pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache9 commented on a change in pull request #2272: URL: https://github.com/apache/hbase/pull/2272#discussion_r473759936 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java ## @@ -54,11 +56,15 @@ private static

[GitHub] [hbase] Apache-HBase commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-677452861 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677436410 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677435356 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677434755 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677429588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677429362 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677428293 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677399405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2277: HBASE-24906 Enalrge the wait time in TestReplicationEndpoint/TestMetaWithReplicasBasic

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2277: URL: https://github.com/apache/hbase/pull/2277#issuecomment-677394632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2265: URL: https://github.com/apache/hbase/pull/2265#issuecomment-677389172 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677365924 Seems it is ok, will add a unit test for CurrentHourProvider later. This is an automated message from the Apache

[GitHub] [hbase] bsglz edited a comment on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz edited a comment on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677353645 Maybe we can set the time. >Calendar calendar = new GregorianCalendar(); > calendar.setTimeInMillis(EnvironmentEdgeManager.currentTime());

[GitHub] [hbase] ddupg commented on pull request #2249: HBASE-24871 Replication may loss data when refresh recovered replicat…

2020-08-20 Thread GitBox
ddupg commented on pull request #2249: URL: https://github.com/apache/hbase/pull/2249#issuecomment-677355961 > Add a UT for this case? Thank @huaxiangsun for reviewing, I've added an UT for this case. This is an

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677353645 Maybe we could set the time. >Calendar calendar = new GregorianCalendar(); > calendar.setTimeInMillis(EnvironmentEdgeManager.currentTime());

[GitHub] [hbase] Apache9 commented on a change in pull request #2130: HBASE-24765: Dynamic master discovery

2020-08-20 Thread GitBox
Apache9 commented on a change in pull request #2130: URL: https://github.com/apache/hbase/pull/2130#discussion_r473656744 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterAddressRefresher.java ## @@ -0,0 +1,124 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2285: HBASE-24912 Enalrge MemstoreFlusherChore/CompactionChecker period for…

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2285: URL: https://github.com/apache/hbase/pull/2285#issuecomment-677340963 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] infraio commented on a change in pull request #2149: HBASE-24760 Allow system tables fallback to any rs groups

2020-08-20 Thread GitBox
infraio commented on a change in pull request #2149: URL: https://github.com/apache/hbase/pull/2149#discussion_r473659089 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java ## @@ -88,9 +87,15 @@ */ public static final

[GitHub] [hbase] bsglz commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
bsglz commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677324748 > But I'm not sure if we could control the return value of CurrentHourProvider? In nextTick method, we will not use EnvironmentEdge.currentTime() so it will still return the

[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-677319783 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache9 commented on pull request #2189: HBASE-24811 Use class access static filed or method

2020-08-20 Thread GitBox
Apache9 commented on pull request #2189: URL: https://github.com/apache/hbase/pull/2189#issuecomment-677306742 I think there is a typo in the title? 'filed' -> 'field'? This is an automated message from the Apache Git

[GitHub] [hbase] Apache9 commented on pull request #2272: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-20 Thread GitBox
Apache9 commented on pull request #2272: URL: https://github.com/apache/hbase/pull/2272#issuecomment-677291674 But I'm not sure if we could control the return value of CurrentHourProvider? In nextTick method, we will not use EnvironmentEdge.currentTime() so it will still return the

[GitHub] [hbase] Apache-HBase commented on pull request #2279: HBASE-24908 Correct the description of hbase.offpeak.end.hour

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2279: URL: https://github.com/apache/hbase/pull/2279#issuecomment-677288602 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache9 commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
Apache9 commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677266826 > ``` > Could this really solve the problem? > ``` > > Problem is hard to reproduce. > > Reasoning, this patch shoud reduce likelihood of our encountering this

[GitHub] [hbase] saintstack commented on pull request #2274: HBASE-24896 'Stuck' in static initialization creating RegionInfo inst…

2020-08-20 Thread GitBox
saintstack commented on pull request #2274: URL: https://github.com/apache/hbase/pull/2274#issuecomment-677264516 Thanks for the help here. The last push implements @virajjasani 's suggestion. It moves the MutableRegionInfo out of RegionInfoBuilder to be standalone. This allows

[GitHub] [hbase] Apache-HBase commented on pull request #2265: HBASE-24892 config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-20 Thread GitBox
Apache-HBase commented on pull request #2265: URL: https://github.com/apache/hbase/pull/2265#issuecomment-677246835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

<    1   2