[jira] [Updated] (HBASE-25219) Backport HBASE-24369 "Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately" to branch-2.2

2020-10-26 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25219: -- Fix Version/s: 2.2.7 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hbase] petersomogyi merged pull request #2589: HBASE-25219 Backport HBASE-24369 Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediatel

2020-10-26 Thread GitBox
petersomogyi merged pull request #2589: URL: https://github.com/apache/hbase/pull/2589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] infraio commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
infraio commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r512413846 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -3402,4 +3406,33 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716974126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Reidd commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512404932 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4569,13 +4665,29 @@ private void

[GitHub] [hbase] ddupg commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
ddupg commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r512399178 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -3402,4 +3406,33 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716954120 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716933862 The benefit of interrupting the thread is Java's thread sleeps, and futures, etc. will do the right thing and check this status themselves. However that is a mixed bag on the

[GitHub] [hbase] Joseph295 commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-26 Thread GitBox
Joseph295 commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-716932347 > Can we change the jira title/description, as this really deals with recovered edits, not hfiles? > > And just giving a second thought on this issue: here we log only

[GitHub] [hbase] Joseph295 commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-26 Thread GitBox
Joseph295 commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-716931810 > Can we change the jira title/description, as this really deals with recovered edits, not hfiles? > > And just giving a second thought on this issue: here we log only

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716931695 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Joseph295 commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-26 Thread GitBox
Joseph295 commented on a change in pull request #2568: URL: https://github.com/apache/hbase/pull/2568#discussion_r512373857 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -5301,7 +5301,11 @@ private long

[GitHub] [hbase] Joseph295 commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-26 Thread GitBox
Joseph295 commented on a change in pull request #2568: URL: https://github.com/apache/hbase/pull/2568#discussion_r512373857 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -5301,7 +5301,11 @@ private long

[GitHub] [hbase] Joseph295 commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-26 Thread GitBox
Joseph295 commented on a change in pull request #2568: URL: https://github.com/apache/hbase/pull/2568#discussion_r512373549 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -5324,22 +5328,25 @@ private long

[GitHub] [hbase] infraio commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
infraio commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r512361785 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HReplicationServer.java ## @@ -388,4 +446,152 @@ protected

[GitHub] [hbase] infraio commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
infraio commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r512355359 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java ## @@ -3402,4 +3406,33 @@ public

[GitHub] [hbase] bharathv commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
bharathv commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716907446 > The original motivation for interrupting RPCs in flight was to address the case where we get stuck closing the region, so we can be less aggressive and wait until we actually

[GitHub] [hbase] infraio edited a comment on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
infraio edited a comment on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716902255 > Thanks @infraio for reviewing. I have fixed as comments. > > > Add master UI to show ReplicationServer? > > Do it in this PR? I was going to do it in a new

[GitHub] [hbase] infraio commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
infraio commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716902255 > Thanks @infraio for reviewing. I have fixed as comments. > > > Add master UI to show ReplicationServer? > > Do it in this PR? I was going to do it in a new PR?

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-716901251 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716896021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221039#comment-17221039 ] Hudson commented on HBASE-25189: Results for branch branch-2.2 [build #107 on

[GitHub] [hbase] Apache-HBase commented on pull request #2589: HBASE-25219 Backport HBASE-24369 Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed imme

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2589: URL: https://github.com/apache/hbase/pull/2589#issuecomment-716884250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-716884000 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-716881489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716880573 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716878459 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716875344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-10-26 Thread Prathyusha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221018#comment-17221018 ] Prathyusha commented on HBASE-24972: Thanks [~sandeep.guggilam]  > Wait for connection attempt to

[jira] [Assigned] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-10-26 Thread Prathyusha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prathyusha reassigned HBASE-24972: -- Assignee: Prathyusha > Wait for connection attempt to succeed before performing operations

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716859524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2578: HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2578: URL: https://github.com/apache/hbase/pull/2578#issuecomment-716843830 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716828893 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-716822076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sguggilam commented on pull request #2578: HBASE-24768 Clear cached service kerberos ticket in case of SASL fail…

2020-10-26 Thread GitBox
sguggilam commented on pull request #2578: URL: https://github.com/apache/hbase/pull/2578#issuecomment-716815878 @apurtell Incorporated the comments, please review This is an automated message from the Apache Git Service.

[jira] [Updated] (HBASE-25219) Backport HBASE-24369 "Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately" to branch-2.2

2020-10-26 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25219: -- Status: Patch Available (was: Open) > Backport HBASE-24369 "Provide more information about

[GitHub] [hbase] petersomogyi opened a new pull request #2589: HBASE-25219 Backport HBASE-24369 Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed imme

2020-10-26 Thread GitBox
petersomogyi opened a new pull request #2589: URL: https://github.com/apache/hbase/pull/2589 Signed-off-by: Viraj Jasani Signed-off-by: Jan Hentschel Signed-off-by: Clara Xiong Signed-off-by: stack This is an

[GitHub] [hbase] apurtell commented on pull request #2576: HBASE-25212 [branch-1] Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on pull request #2576: URL: https://github.com/apache/hbase/pull/2576#issuecomment-716802337 Rebase. Sync with updates to master branch patch. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] apurtell commented on pull request #2575: HBASE-25212 [branch-2] Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on pull request #2575: URL: https://github.com/apache/hbase/pull/2575#issuecomment-716802279 Rebase. Sync with updates to master branch patch. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716802100 Rebased. Address review feedback. Address my two comments above. This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716799487 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25220) Backport HBASE-24246 "Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration" to br

2020-10-26 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-25220. --- Fix Version/s: 2.2.7 Resolution: Fixed > Backport HBASE-24246 "Miscellaneous hbck2

[GitHub] [hbase] petersomogyi merged pull request #2588: HBASE-25220 Backport HBASE-24246 Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overl

2020-10-26 Thread GitBox
petersomogyi merged pull request #2588: URL: https://github.com/apache/hbase/pull/2588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716774965 Uploaded a new patch. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] petersomogyi commented on a change in pull request #2588: HBASE-25220 Backport HBASE-24246 Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, '

2020-10-26 Thread GitBox
petersomogyi commented on a change in pull request #2588: URL: https://github.com/apache/hbase/pull/2588#discussion_r512216019 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java ## @@ -135,8 +134,8 @@ private

[GitHub] [hbase] saintstack commented on a change in pull request #2588: HBASE-25220 Backport HBASE-24246 Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HB

2020-10-26 Thread GitBox
saintstack commented on a change in pull request #2588: URL: https://github.com/apache/hbase/pull/2588#discussion_r512196004 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java ## @@ -247,6 +247,10 @@ void fixOverlaps(CatalogJanitor.Report

[GitHub] [hbase] huaxiangsun commented on pull request #2584: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-26 Thread GitBox
huaxiangsun commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-716751088 Changing the newly added test to Parameterized one, will load a new patch shortly. This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2588: HBASE-25220 Backport HBASE-24246 Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report'

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2588: URL: https://github.com/apache/hbase/pull/2588#issuecomment-716744178 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512176656 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java ## @@ -0,0 +1,356 @@ +/* + * Licensed to the

[GitHub] [hbase] virajjasani commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
virajjasani commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512174196 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7366,157 @@ protected

[jira] [Commented] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220897#comment-17220897 ] Hudson commented on HBASE-25189: Results for branch branch-2 [build #84 on

[jira] [Commented] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-10-26 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220891#comment-17220891 ] Sandeep Guggilam commented on HBASE-24972: -- [~pratg] Sure , feel free to pick this one > Wait

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512168388 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java ## @@ -0,0 +1,356 @@ +/* + * Licensed to the

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512165464 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -1679,22 +1688,82 @@ public void

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716726888 Also I think upon reflection if interrupted while waiting on this lock to close the region we shouldn't abort the RS, just throw an IO exception like in the timeout case

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716726888 Also I think upon reflection if interrupted while waiting on this lock to close the region we shouldn't abort the RS, just throw an IO exception like in the timeout case where

[GitHub] [hbase] apurtell edited a comment on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell edited a comment on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716699603 I have found one test where interrupt by default causes a repeatable problem. TestSyncReplicationActive [ERROR]

[GitHub] [hbase] apurtell commented on pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716699603 I have found one test where interrupt by default causes a repeatable problem. TestSyncReplicationActive [ERROR] TestSyncReplicationActive.testActive:99

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512090958 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java ## @@ -0,0 +1,356 @@ +/* + * Licensed to the

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512090958 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java ## @@ -0,0 +1,356 @@ +/* + * Licensed to the

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512090958 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInterrupt.java ## @@ -0,0 +1,356 @@ +/* + * Licensed to the

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512089577 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -688,14 +688,17 @@ void sawNoSuchFamily() { // Last

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512087407 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -9000,6 +9129,49 @@ public long getReadPoint() {

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512087013 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -8793,7 +8921,7 @@ public void

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512083604 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7366,157 @@ protected

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512084799 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -1679,22 +1688,82 @@ public void

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512083604 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7366,157 @@ protected

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512084523 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7366,157 @@ protected

[GitHub] [hbase] apurtell commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
apurtell commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512083604 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7366,157 @@ protected

[GitHub] [hbase] virajjasani commented on a change in pull request #2574: HBASE-25212 Optionally abort requests in progress after deciding a region should close

2020-10-26 Thread GitBox
virajjasani commented on a change in pull request #2574: URL: https://github.com/apache/hbase/pull/2574#discussion_r512006608 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java ## @@ -7364,4 +7366,157 @@ protected

[jira] [Commented] (HBASE-24015) Coverage for Assign and Unassign of Regions on RegionServer on failure

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220761#comment-17220761 ] Hudson commented on HBASE-24015: Results for branch branch-2.3 [build #90 on

[jira] [Commented] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220762#comment-17220762 ] Hudson commented on HBASE-25189: Results for branch branch-2.3 [build #90 on

[GitHub] [hbase] petersomogyi opened a new pull request #2588: HBASE-25220 Backport HBASE-24246 Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report'

2020-10-26 Thread GitBox
petersomogyi opened a new pull request #2588: URL: https://github.com/apache/hbase/pull/2588 Includes addendum hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Fix weird brackets around each region name when logging.

[jira] [Created] (HBASE-25220) Backport HBASE-24246 "Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration" to bra

2020-10-26 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-25220: - Summary: Backport HBASE-24246 "Miscellaneous hbck2 fixMeta bulk merge fixes: better logging around merges/overlap-fixing, 'HBCK Report' overlap listing, and configuration" to branch-2.2 Key:

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716572121 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220698#comment-17220698 ] Hudson commented on HBASE-25189: Results for branch master [build #106 on

[jira] [Commented] (HBASE-25215) TestClientOperationTimeout.testScanTimeout is flaky

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220699#comment-17220699 ] Hudson commented on HBASE-25215: Results for branch master [build #106 on

[jira] [Commented] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220682#comment-17220682 ] Hudson commented on HBASE-25194: Results for branch branch-1.4 [build #14 on

[jira] [Commented] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220683#comment-17220683 ] Hudson commented on HBASE-25203: Results for branch branch-1.4 [build #14 on

[jira] [Commented] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220684#comment-17220684 ] Hudson commented on HBASE-25204: Results for branch branch-1.4 [build #14 on

[jira] [Created] (HBASE-25219) Backport HBASE-24369 "Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately" to branch-2.2

2020-10-26 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-25219: - Summary: Backport HBASE-24369 "Provide more information about merged child regions in Hbck Overlaps section, which cannot be fixed immediately" to branch-2.2 Key: HBASE-25219

[jira] [Commented] (HBASE-25195) [branch-1] getNumOpenConnections is not effective

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220672#comment-17220672 ] Hudson commented on HBASE-25195: Results for branch branch-1 [build #47 on

[jira] [Commented] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220673#comment-17220673 ] Hudson commented on HBASE-25194: Results for branch branch-1 [build #47 on

[jira] [Commented] (HBASE-25193) Add support for row prefix and type in the WAL Pretty Printer and some minor fixes

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220676#comment-17220676 ] Hudson commented on HBASE-25193: Results for branch branch-1 [build #47 on

[jira] [Commented] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220674#comment-17220674 ] Hudson commented on HBASE-25203: Results for branch branch-1 [build #47 on

[jira] [Commented] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220675#comment-17220675 ] Hudson commented on HBASE-25204: Results for branch branch-1 [build #47 on

[jira] [Commented] (HBASE-25189) [Metrics] Add checkAndPut and checkAndDelete latency metrics at table level

2020-10-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220677#comment-17220677 ] Hudson commented on HBASE-25189: Results for branch branch-1 [build #47 on

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716533757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2587: HBASE-25213 Should request Compaction after bulkLoadHFiles is done

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2587: URL: https://github.com/apache/hbase/pull/2587#issuecomment-716478119 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716476519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2585: HBASE-25217 [Metrics] Add metrics for Call in IPC response queue

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2585: URL: https://github.com/apache/hbase/pull/2585#issuecomment-716474064 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-716471729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] ddupg commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
ddupg commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716453008 Thanks @infraio for reviewing. I have fixed as comments. > Add master UI to show ReplicationServer? Do it in this PR? I was going to do it in a new PR?

[GitHub] [hbase] ddupg commented on a change in pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
ddupg commented on a change in pull request #2579: URL: https://github.com/apache/hbase/pull/2579#discussion_r511852023 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java ## @@ -445,7 +418,7 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-716450300 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2445: HBASE-11288 Splittable Meta (WIP) Draft

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2445: URL: https://github.com/apache/hbase/pull/2445#issuecomment-716446598 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2587: HBASE-25213 Should request Compaction after bulkLoadHFiles is done

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2587: URL: https://github.com/apache/hbase/pull/2587#issuecomment-716441418 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2579: HBASE-24999 Master manages ReplicationServers

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2579: URL: https://github.com/apache/hbase/pull/2579#issuecomment-716382359 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 13m

[GitHub] [hbase] Apache-HBase commented on pull request #2587: HBASE-25213 Should request Compaction after bulkLoadHFiles is done

2020-10-26 Thread GitBox
Apache-HBase commented on pull request #2587: URL: https://github.com/apache/hbase/pull/2587#issuecomment-716381049 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2020-10-26 Thread Prathyusha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220549#comment-17220549 ] Prathyusha commented on HBASE-24972: [~sandeep.guggilam] If you have not already started working on

  1   2   >