Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124534722
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
[
https://issues.apache.org/jira/browse/HBASE-18045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HBASE-18045:
Assignee: Narasimha Sharma (was: Kiran Kumar Maturi)
> Add ' -o ConnectTimeout=10' to
[
https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tao Li updated HBASE-27026:
---
Description:
By default Style/FrozenStringLiteralComment is enabled in rubocop. If we update
a ruby file,
[
https://issues.apache.org/jira/browse/HBASE-18045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535861#comment-17535861
]
Narasimha Sharma commented on HBASE-18045:
--
Hi [~kiran.maturi] I would like to work on this
[
https://issues.apache.org/jira/browse/HBASE-26296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani reassigned HBASE-26296:
Assignee: shyam kumar
> Make it easier to orchestrate rolling upgrades
>
[
https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tao Li updated HBASE-27026:
---
Description:
By default Style/FrozenStringLiteralComment is open in rubocop. If we update a
ruby file,
Apache-HBase commented on PR #4423:
URL: https://github.com/apache/hbase/pull/4423#issuecomment-1124496153
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 4s |
Apache-HBase commented on PR #4423:
URL: https://github.com/apache/hbase/pull/4423#issuecomment-1124495627
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 22s |
Apache-HBase commented on PR #4423:
URL: https://github.com/apache/hbase/pull/4423#issuecomment-1124495581
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 57s |
tomscut commented on PR #4423:
URL: https://github.com/apache/hbase/pull/4423#issuecomment-1124494366
Hi @Apache9 @apurtell @virajjasani @ndimiduk, could you please have a look.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tomscut opened a new pull request, #4423:
URL: https://github.com/apache/hbase/pull/4423
By default Style/FrozenStringLiteralComment is open in rubocop. If we update
a ruby file, rubocop prompts `Missing frozen string literal comment` (see
[
https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tao Li updated HBASE-27026:
---
Description:
By default Style/FrozenStringLiteralComment is open in rubocop. If we update a
ruby file,
[
https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tao Li updated HBASE-27026:
---
Description:
By default Style/FrozenStringLiteralComment is open in rubocop. If we update a
ruby file,
Tao Li created HBASE-27026:
--
Summary: Disable Style/FrozenStringLiteralComment for ruby
Key: HBASE-27026
URL: https://issues.apache.org/jira/browse/HBASE-27026
Project: HBase
Issue Type:
[
https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535831#comment-17535831
]
Duo Zhang commented on HBASE-27024:
---
Ah, it is something conflicts...
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1124475368
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 22s |
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1124474628
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
[
https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535819#comment-17535819
]
Duo Zhang commented on HBASE-27024:
---
I guess it may be related to HBASE-25983.
In hbase-testing-util,
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1124472557
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 2s |
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1124463136
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 21s |
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1124462153
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1124459866
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 1s |
joshelser commented on code in PR #4414:
URL: https://github.com/apache/hbase/pull/4414#discussion_r870885671
##
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockIOUtils.java:
##
@@ -92,6 +108,102 @@ public void testReadFully() throws IOException {
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535794#comment-17535794
]
Andrew Kyle Purtell edited comment on HBASE-27023 at 5/12/22 12:41 AM:
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535794#comment-17535794
]
Andrew Kyle Purtell edited comment on HBASE-27023 at 5/12/22 12:41 AM:
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535794#comment-17535794
]
Andrew Kyle Purtell commented on HBASE-27023:
-
Why does spotless remove extra headers? It
Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124406540
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s |
Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124403953
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
Huaxiang Sun created HBASE-27025:
Summary: Change Hbase book's description for "74.7.3. Load
Balancing META table load"
Key: HBASE-27025
URL: https://issues.apache.org/jira/browse/HBASE-27025
apurtell commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124365339
If no objections I will commit this from master -> branch-2.5 tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/HBASE-26905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-26905:
Fix Version/s: 2.5.0
3.0.0-alpha-3
Status: Patch
Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124314255
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 9s |
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1124300785
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 9s |
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1124297605
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
shahrs87 commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124252642
The failed test is succeeding locally.
```
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO]
Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124182383
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 19s |
Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1124175284
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s |
[
https://issues.apache.org/jira/browse/HBASE-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535059#comment-17535059
]
Hudson commented on HBASE-27020:
Results for branch master
[build #584 on
[
https://issues.apache.org/jira/browse/HBASE-27003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535058#comment-17535058
]
Hudson commented on HBASE-27003:
Results for branch master
[build #584 on
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1124140083
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #4419:
URL: https://github.com/apache/hbase/pull/4419#issuecomment-1124053181
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 45s |
Apache-HBase commented on PR #4419:
URL: https://github.com/apache/hbase/pull/4419#issuecomment-1124051112
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 57s |
[
https://issues.apache.org/jira/browse/HBASE-27003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535029#comment-17535029
]
Hudson commented on HBASE-27003:
Results for branch branch-2
[build #538 on
[
https://issues.apache.org/jira/browse/HBASE-27003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535023#comment-17535023
]
Hudson commented on HBASE-27003:
Results for branch branch-2.5
[build #116 on
Apache-HBase commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1124018068
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
[
https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535003#comment-17535003
]
Sean Busbey commented on HBASE-27024:
-
did something change for the website generation job?
> The
[
https://issues.apache.org/jira/browse/HBASE-27003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534999#comment-17534999
]
Hudson commented on HBASE-27003:
Results for branch branch-2.4
[build #350 on
[
https://issues.apache.org/jira/browse/HBASE-26905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rushabh Shah reassigned HBASE-26905:
Assignee: Rushabh Shah
> ReplicationPeerManager#checkPeerExists should throw
>
Apache-HBase commented on PR #4422:
URL: https://github.com/apache/hbase/pull/4422#issuecomment-1123973030
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 59s |
[
https://issues.apache.org/jira/browse/HBASE-27024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534996#comment-17534996
]
Duo Zhang commented on HBASE-27024:
---
[~busbey] FYI. Seems our website is already broken...
> The User
Duo Zhang created HBASE-27024:
-
Summary: The User API and Developer API links are broken on
hbase.apache.org
Key: HBASE-27024
URL: https://issues.apache.org/jira/browse/HBASE-27024
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534993#comment-17534993
]
Peter Somogyi commented on HBASE-27023:
---
Thanks for the details on licensing, [~busbey]!
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534983#comment-17534983
]
Sean Busbey commented on HBASE-27023:
-
any files with a third party notice, yes.
> Add protobuf to
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1123950718
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1123950107
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 7s |
Apache-HBase commented on PR #4416:
URL: https://github.com/apache/hbase/pull/4416#issuecomment-1123942289
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 8s |
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534952#comment-17534952
]
Duo Zhang commented on HBASE-27023:
---
Ah, so then maybe we should exclude this file from spotless, at
[
https://issues.apache.org/jira/browse/HBASE-27023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534939#comment-17534939
]
Sean Busbey commented on HBASE-27023:
-
copying some comments over from the PR.
3-Clause BSD
busbey commented on PR #4421:
URL: https://github.com/apache/hbase/pull/4421#issuecomment-1123872716
we should add the protobuf credit back in order to remain in compliance with
the [ASF policy on third party works included in our project
busbey commented on PR #4421:
URL: https://github.com/apache/hbase/pull/4421#issuecomment-1123866736
this is already covered in our [LICENSE file, currently around line
255](https://github.com/apache/hbase/blob/master/LICENSE.txt#L255)
```
This project incorporates portions of the
busbey commented on PR #4421:
URL: https://github.com/apache/hbase/pull/4421#issuecomment-1123863825
3-Clause BSD licensed items should not be in the NOTICE file. they should be
in the LICENSE file.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache-HBase commented on PR #4419:
URL: https://github.com/apache/hbase/pull/4419#issuecomment-1123804417
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 17s |
Apache9 commented on code in PR #4392:
URL: https://github.com/apache/hbase/pull/4392#discussion_r870295934
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##
@@ -3372,8 +3372,8 @@ public abstract void prepareMiniBatchOperations(
* Write
Apache-HBase commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1123751285
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
Apache-HBase commented on PR #4421:
URL: https://github.com/apache/hbase/pull/4421#issuecomment-1123596105
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 59s |
Apache-HBase commented on PR #4421:
URL: https://github.com/apache/hbase/pull/4421#issuecomment-1123595156
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s |
Apache-HBase commented on PR #4421:
URL: https://github.com/apache/hbase/pull/4421#issuecomment-1123594086
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123582629
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 22s |
wchevreuil commented on PR #4419:
URL: https://github.com/apache/hbase/pull/4419#issuecomment-1123521414
> I assume you've spot-checked the output of TestHStore after this and
verified things work as expected?
>
> +1 from me if so
Yep, TestHStore was fine, but noticed
wchevreuil commented on code in PR #4419:
URL: https://github.com/apache/hbase/pull/4419#discussion_r870126641
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,18 +119,18 @@ public class StoreFileInfo implements Configurable {
Peter Somogyi created HBASE-27023:
-
Summary: Add protobuf to NOTICE file
Key: HBASE-27023
URL: https://issues.apache.org/jira/browse/HBASE-27023
Project: HBase
Issue Type: Task
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123301558
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #4417:
URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123299149
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 14s |
Apache-HBase commented on PR #4410:
URL: https://github.com/apache/hbase/pull/4410#issuecomment-1123293745
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #4417:
URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123289605
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
anoopsjohn commented on code in PR #4410:
URL: https://github.com/apache/hbase/pull/4410#discussion_r869931403
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCacheFactory.java:
##
@@ -113,7 +117,17 @@ public static BlockCache createBlockCache(Configuration
tomscut commented on PR #4417:
URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123250230
Thanks @Apache9 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/HBASE-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-27020.
---
Fix Version/s: 3.0.0-alpha-3
Hadoop Flags: Reviewed
Resolution: Fixed
Merged to master.
Apache9 merged PR #4417:
URL: https://github.com/apache/hbase/pull/4417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
taklwu commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123234022
@Apache9 or @ndimiduk , what is the right way to run `mvn spotless:apply` on
a commit? everything looks fine locally, but when running on precommit job, it
found those errors.
```
taklwu commented on PR #4417:
URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123232586
so, it's very strange to me as well in
https://github.com/apache/hbase/pull/4414.
I'm looking for the right instructions to run `mvn spotless:apply` for my
change on top of master
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123224727
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #4414:
URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123221980
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
83 matches
Mail list logo
