[jira] [Commented] (HBASE-27658) HBase token expired because the connection was not released

2023-08-02 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750581#comment-17750581 ] Zhen Wang commented on HBASE-27658: --- [~reidchan]  Could you please take a look at this issue? I have

[jira] [Commented] (HBASE-27896) Disable hdfs readahead for pread reads

2023-08-02 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750580#comment-17750580 ] Hudson commented on HBASE-27896: Results for branch branch-2 [build #857 on

[GitHub] [hbase] Apache-HBase commented on pull request #5342: HBASE-27998 Enhance region metrics to include prefetch ratio for each…

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5342: URL: https://github.com/apache/hbase/pull/5342#issuecomment-1663320386 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #117: URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1663272409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #95: HBASE-26863 fix incorrect rowkey pushdown

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #95: URL: https://github.com/apache/hbase-connectors/pull/95#issuecomment-1663269886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s

[GitHub] [hbase-connectors] Reidddddd commented on pull request #117: HBASE-27883: Use log4j2 instead of log4j for logging.

2023-08-02 Thread via GitHub
Reidd commented on PR #117: URL: https://github.com/apache/hbase-connectors/pull/117#issuecomment-1663263767 re-trigger the check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase-connectors] Reidddddd commented on a diff in pull request #95: HBASE-26863 fix incorrect rowkey pushdown

2023-08-02 Thread via GitHub
Reidd commented on code in PR #95: URL: https://github.com/apache/hbase-connectors/pull/95#discussion_r1282620228 ## spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala: ## @@ -593,11 +593,11 @@ class ScanRange(var upperBound:Array[Byte], var

[GitHub] [hbase-connectors] Reidddddd commented on a diff in pull request #95: HBASE-26863 fix incorrect rowkey pushdown

2023-08-02 Thread via GitHub
Reidd commented on code in PR #95: URL: https://github.com/apache/hbase-connectors/pull/95#discussion_r1282620067 ## spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/DefaultSource.scala: ## @@ -593,11 +593,11 @@ class ScanRange(var upperBound:Array[Byte], var

[GitHub] [hbase-connectors] Reidddddd commented on pull request #95: HBASE-26863 fix incorrect rowkey pushdown

2023-08-02 Thread via GitHub
Reidd commented on PR #95: URL: https://github.com/apache/hbase-connectors/pull/95#issuecomment-1663261163 re-trigger the QA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HBASE-27705) Respect SparkContext hadoop configuration

2023-08-02 Thread Zhen Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750522#comment-17750522 ] Zhen Wang commented on HBASE-27705: --- We have multiple HBase clusters independent of Spark's computing

[GitHub] [hbase] Apache-HBase commented on pull request #5341: HBASE-28004 Persistent cache map can get corrupt if crash happens midway through the write

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5341: URL: https://github.com/apache/hbase/pull/5341#issuecomment-1662991132 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache-HBase commented on pull request #5341: HBASE-28004 Persistent cache map can get corrupt if crash happens midway through the write

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5341: URL: https://github.com/apache/hbase/pull/5341#issuecomment-1662991006 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

[jira] [Commented] (HBASE-27997) Enhance prefetch executor to record region prefetch information along with the list of hfiles prefetched

2023-08-02 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750426#comment-17750426 ] Wellington Chevreuil commented on HBASE-27997: -- [~ragarkar], I have merged the PR into this

[jira] [Created] (HBASE-28005) Tunable hdfs readahead for STREAM reads

2023-08-02 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-28005: - Summary: Tunable hdfs readahead for STREAM reads Key: HBASE-28005 URL: https://issues.apache.org/jira/browse/HBASE-28005 Project: HBase Issue

[jira] [Resolved] (HBASE-27896) Disable hdfs readahead for pread reads

2023-08-02 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-27896. --- Fix Version/s: 2.6.0 3.0.0-beta-1 Release Note: PREAD reads

[GitHub] [hbase] Apache-HBase commented on pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5339: URL: https://github.com/apache/hbase/pull/5339#issuecomment-1662204506 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[GitHub] [hbase] bbeaudreault commented on pull request #5336: HBASE-27896 Disable hdfs readahead for pread reads

2023-08-02 Thread via GitHub
bbeaudreault commented on PR #5336: URL: https://github.com/apache/hbase/pull/5336#issuecomment-1662195636 Thanks @Reidd! Here's the list thread: https://lists.apache.org/thread/pokw1bwtr26hdbmlmx4tx1g1fczqrtxt. I'll add it to the ticket as well. -- This is an automated message from

[GitHub] [hbase] Apache-HBase commented on pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5339: URL: https://github.com/apache/hbase/pull/5339#issuecomment-1662137252 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5339: URL: https://github.com/apache/hbase/pull/5339#issuecomment-1662091464 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

[jira] [Resolved] (HBASE-27488) [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-27488. --- Fix Version/s: hbase-connectors-1.0.1 Hadoop Flags: Reviewed Resolution: Fixed >

[GitHub] [hbase-connectors] Reidddddd merged pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
Reidd merged PR #106: URL: https://github.com/apache/hbase-connectors/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] ragarkar commented on a diff in pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
ragarkar commented on code in PR #5339: URL: https://github.com/apache/hbase/pull/5339#discussion_r1281784116 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java: ## @@ -53,7 +56,8 @@ public final class PrefetchExecutor { private static final

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#issuecomment-1662031215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #5336: HBASE-27896 Disable hdfs readahead for pread reads

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5336: URL: https://github.com/apache/hbase/pull/5336#issuecomment-1662013041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[GitHub] [hbase] Apache-HBase commented on pull request #5336: HBASE-27896 Disable hdfs readahead for pread reads

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5336: URL: https://github.com/apache/hbase/pull/5336#issuecomment-1662009555 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
wchevreuil commented on code in PR #5339: URL: https://github.com/apache/hbase/pull/5339#discussion_r1281706889 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java: ## @@ -53,7 +56,8 @@ public final class PrefetchExecutor { private static

[GitHub] [hbase] ragarkar commented on a diff in pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
ragarkar commented on code in PR #5339: URL: https://github.com/apache/hbase/pull/5339#discussion_r1281684251 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java: ## @@ -53,7 +56,8 @@ public final class PrefetchExecutor { private static final

[GitHub] [hbase] ragarkar commented on a diff in pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
ragarkar commented on code in PR #5339: URL: https://github.com/apache/hbase/pull/5339#discussion_r1281683185 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java: ## @@ -120,9 +124,35 @@ public static void request(Path path, Runnable runnable) {

[GitHub] [hbase-connectors] ILuffZhe commented on pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
ILuffZhe commented on PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#issuecomment-1661862192 > Reason Tests > Failed junit tests hadoop.hbase.spark.DefaultSourceSuite > @ILuffZhe please help check if it is related Sure, I'm already on it. -- This is an

[GitHub] [hbase-connectors] Reidddddd commented on pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
Reidd commented on PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#issuecomment-1661857034 Reason | Tests -- | -- Failed junit tests | hadoop.hbase.spark.DefaultSourceSuite @ILuffZhe please help check if it is related -- This is an automated

[GitHub] [hbase] wchevreuil commented on a diff in pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
wchevreuil commented on code in PR #5339: URL: https://github.com/apache/hbase/pull/5339#discussion_r1281631574 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PrefetchExecutor.java: ## @@ -53,7 +56,8 @@ public final class PrefetchExecutor { private static

[GitHub] [hbase-connectors] Apache-HBase commented on pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#issuecomment-1661811441 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55s

[GitHub] [hbase-connectors] Reidddddd commented on pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
Reidd commented on PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#issuecomment-1661775447 waiting for QA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #5339: HBASE-27997 Enhance prefetch executor to record region prefetch infor…

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5339: URL: https://github.com/apache/hbase/pull/5339#issuecomment-1661768174 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[jira] [Commented] (HBASE-27488) [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread ZheHu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750187#comment-17750187 ] ZheHu commented on HBASE-27488: --- [~reidchan] Thanks for the review. The PR has been updated. >

[GitHub] [hbase-connectors] ILuffZhe commented on a diff in pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
ILuffZhe commented on code in PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#discussion_r1281581225 ## spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBaseTableScanRDD.scala: ## @@ -110,16 +110,20 @@ class

[jira] [Commented] (HBASE-27488) [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750181#comment-17750181 ] Reid Chan commented on HBASE-27488: --- left a comment in the PR > [hbase-connectors] Duplicate result

[GitHub] [hbase-connectors] Reidddddd commented on a diff in pull request #106: HBASE-27488 [hbase-connectors] Duplicate result when searching HBase by Spark

2023-08-02 Thread via GitHub
Reidd commented on code in PR #106: URL: https://github.com/apache/hbase-connectors/pull/106#discussion_r1281559293 ## spark/hbase-spark/src/main/scala/org/apache/hadoop/hbase/spark/datasources/HBaseTableScanRDD.scala: ## @@ -110,16 +110,20 @@ class

[jira] [Resolved] (HBASE-27656) Make sure the close method of the SmartSonnection is called

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-27656. --- Fix Version/s: hbase-connectors-1.0.1 Hadoop Flags: Reviewed Resolution: Fixed > Make

[GitHub] [hbase-connectors] Reidddddd merged pull request #109: HBASE-27656: Make sure the close method of the SmartSonnection is called

2023-08-02 Thread via GitHub
Reidd merged PR #109: URL: https://github.com/apache/hbase-connectors/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-27176) [hbase-connectors] Fail to build hbase-connectors because of checkstyle error

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-27176. --- Fix Version/s: hbase-connectors-1.0.1 Hadoop Flags: Reviewed Resolution: Fixed >

[jira] [Updated] (HBASE-26863) Rowkey pushdown does not work with complex conditions

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26863: -- Fix Version/s: (was: hbase-connectors-1.0.1) > Rowkey pushdown does not work with complex

[jira] [Updated] (HBASE-26863) Rowkey pushdown does not work with complex conditions

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-26863: -- Fix Version/s: hbase-connectors-1.0.1 > Rowkey pushdown does not work with complex conditions >

[jira] [Resolved] (HBASE-27705) Respect SparkContext hadoop configuration

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-27705. --- Hadoop Flags: Reviewed Resolution: Fixed > Respect SparkContext hadoop configuration >

[jira] [Updated] (HBASE-27705) Respect SparkContext hadoop configuration

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-27705: -- Fix Version/s: hbase-connectors-1.0.1 > Respect SparkContext hadoop configuration >

[GitHub] [hbase-connectors] Reidddddd commented on pull request #94: HBASE-26841 Replace log4j with reload4j for hbase-connector

2023-08-02 Thread via GitHub
Reidd commented on PR #94: URL: https://github.com/apache/hbase-connectors/pull/94#issuecomment-1661682946 > Hello guys, I do not see any movement here. Now, do we want to replace log4j with log4j2 here? I could take that task up if others are interested. please go ahead.. --

[GitHub] [hbase-connectors] Reidddddd merged pull request #114: HBASE-27705: Respect SparkContext hadoop configuration

2023-08-02 Thread via GitHub
Reidd merged PR #114: URL: https://github.com/apache/hbase-connectors/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-27705) Respect SparkContext hadoop configuration

2023-08-02 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750160#comment-17750160 ] Reid Chan commented on HBASE-27705: --- could you describe more about what issue you met? and introduced

[GitHub] [hbase] Apache-HBase commented on pull request #5336: HBASE-27896 Disable hdfs readahead for pread reads

2023-08-02 Thread via GitHub
Apache-HBase commented on PR #5336: URL: https://github.com/apache/hbase/pull/5336#issuecomment-1661667596 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] NihalJain commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

2023-08-02 Thread via GitHub
NihalJain commented on code in PR #5323: URL: https://github.com/apache/hbase/pull/5323#discussion_r1281507076 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java: ## @@ -24,10 +24,12 @@ @InterfaceAudience.Private public class MetricsIO { + private

[GitHub] [hbase] NihalJain commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

2023-08-02 Thread via GitHub
NihalJain commented on code in PR #5323: URL: https://github.com/apache/hbase/pull/5323#discussion_r1281507076 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java: ## @@ -24,10 +24,12 @@ @InterfaceAudience.Private public class MetricsIO { + private

[GitHub] [hbase] NihalJain commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

2023-08-02 Thread via GitHub
NihalJain commented on code in PR #5323: URL: https://github.com/apache/hbase/pull/5323#discussion_r1281505795 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java: ## @@ -24,10 +24,12 @@ @InterfaceAudience.Private public class MetricsIO { + private

[GitHub] [hbase] Reidddddd commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

2023-08-02 Thread via GitHub
Reidd commented on code in PR #5323: URL: https://github.com/apache/hbase/pull/5323#discussion_r1281492205 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java: ## @@ -24,10 +24,12 @@ @InterfaceAudience.Private public class MetricsIO { + private

[GitHub] [hbase] Reidddddd commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

2023-08-02 Thread via GitHub
Reidd commented on code in PR #5323: URL: https://github.com/apache/hbase/pull/5323#discussion_r1281485254 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java: ## @@ -24,10 +24,12 @@ @InterfaceAudience.Private public class MetricsIO { + private

[GitHub] [hbase] Reidddddd commented on a diff in pull request #5323: HBASE-27966 HBase Master/RS JVM metrics populated incorrectly

2023-08-02 Thread via GitHub
Reidd commented on code in PR #5323: URL: https://github.com/apache/hbase/pull/5323#discussion_r1281485254 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/MetricsIO.java: ## @@ -24,10 +24,12 @@ @InterfaceAudience.Private public class MetricsIO { + private

[GitHub] [hbase] Reidddddd commented on pull request #5336: HBASE-27896 Disable hdfs readahead for pread reads

2023-08-02 Thread via GitHub
Reidd commented on PR #5336: URL: https://github.com/apache/hbase/pull/5336#issuecomment-1661620471 re-trigger pre-commit check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific