[jira] [Commented] (HBASE-28190) Add slow sync log rolling test in TestAsyncLogRolling

2023-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798834#comment-17798834 ] Hudson commented on HBASE-28190: Results for branch branch-2 [build #947 on

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1863946147 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1863901472 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1863886936 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[jira] [Commented] (HBASE-28256) Enhance ByteBufferUtils.readVLong to read 8 bytes at a time

2023-12-19 Thread Becker Ewing (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798818#comment-17798818 ] Becker Ewing commented on HBASE-28256: -- I want to callout that this is a very similar optimization

Re: [PR] HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS [hbase]

2023-12-19 Thread via GitHub
Kerasone commented on PR #5558: URL: https://github.com/apache/hbase/pull/5558#issuecomment-1863815387 @wchevreuil done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master

2023-12-19 Thread ruanhui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798814#comment-17798814 ] ruanhui commented on HBASE-28271: - [~vjasani] Our users don't need to specify nonce group and nonce for

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1863756303 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5591: URL: https://github.com/apache/hbase/pull/5591#issuecomment-1863738900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[jira] [Commented] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master

2023-12-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798791#comment-17798791 ] Viraj Jasani commented on HBASE-28271: -- [~frostruan] After HBASE-26323, do we have any test for

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5591: URL: https://github.com/apache/hbase/pull/5591#issuecomment-1863556360 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5591: URL: https://github.com/apache/hbase/pull/5591#issuecomment-1863542520 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
bbeaudreault opened a new pull request, #5591: URL: https://github.com/apache/hbase/pull/5591 This is a draft because I expect it to fail for hadoop2. I want to take a stab at making it work on branch-2, but will need to iterate on some reflection stuff. Will convert to real once I'm

[jira] [Resolved] (HBASE-28254) Flaky test: TestTableShell

2023-12-19 Thread Balazs Meszaros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balazs Meszaros resolved HBASE-28254. - Fix Version/s: 2.6.0 2.4.18 3.0.0-beta-1

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
meszibalu merged PR #5590: URL: https://github.com/apache/hbase/pull/5590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-21500) "hbase.jetty.logs.serve.aliases" is broken with jetty 9.x version

2023-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798732#comment-17798732 ] Hudson commented on HBASE-21500: Results for branch branch-3 [build #106 on

[jira] [Commented] (HBASE-21500) "hbase.jetty.logs.serve.aliases" is broken with jetty 9.x version

2023-12-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798726#comment-17798726 ] Hudson commented on HBASE-21500: Results for branch master [build #967 on

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
bbeaudreault commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863389213 Thank you both for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
bbeaudreault merged PR #5579: URL: https://github.com/apache/hbase/pull/5579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863377152 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863368305 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
bbeaudreault commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431852597 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
jojochuang commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431834943 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
jojochuang commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431834943 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
jojochuang commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431834302 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java: ## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1863330566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 24s |

[jira] [Comment Edited] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master

2023-12-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798696#comment-17798696 ] Viraj Jasani edited comment on HBASE-28271 at 12/19/23 6:19 PM:

[jira] [Commented] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master

2023-12-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798696#comment-17798696 ] Viraj Jasani commented on HBASE-28271: -- LockProcedure implementation at high level: Just like any

[jira] [Commented] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master

2023-12-19 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798694#comment-17798694 ] Viraj Jasani commented on HBASE-28271: -- Snapshot is the only consumer of the lock procedure that

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1863134843 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1863133404 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863123181 > If you don't mind, I might file a new jira for this. Sounds good.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1863116951 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 11s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
bbeaudreault commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863113068 > +1 to the change. > > Just realized, we may want to add sample command which sets EC in doc section of `create.rb` and `alter.rb`. We usually add those for any new feature

[jira] [Commented] (HBASE-28271) Infinite waiting on lock acquisition by snapshot can result in unresponsive master

2023-12-19 Thread Rushabh Shah (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798655#comment-17798655 ] Rushabh Shah commented on HBASE-28271: -- Isn't the problem that we don't have timeout for acquiring

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1863098799 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
anmolnar commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1863054410 Discussed with @meszibalu I will change the delay to 1ms. It should enough for the timestamp to be different from the previous put. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28224 ClientSideRegionScanner appears not to shutdown MobFileCache [hbase]

2023-12-19 Thread via GitHub
jbewing commented on PR #5578: URL: https://github.com/apache/hbase/pull/5578#issuecomment-1863042049 @Apache9 any chance you have an idea on when this PR will be merged? Not urgent, I just don't want this PR to get lost -- This is an automated message from the Apache Git Service. To

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1863036847 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1862997997 +1 to the change. Just realized, we may want to add sample command which sets EC in doc section of `create.rb` and `alter.rb`. We usually add those for any new feature that we

Re: [PR] HBASE-28270 Remove the xml-maven-plugin in root pom on branch-3 [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5587: URL: https://github.com/apache/hbase/pull/5587#issuecomment-1862967860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
bbeaudreault commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431558036 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java: ## @@ -70,6 +71,7 @@ public class RestoreSnapshotProcedure

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1862855937 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1862853876 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5590: URL: https://github.com/apache/hbase/pull/5590#issuecomment-1862835970 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[jira] [Assigned] (HBASE-28268) Add option to skip wal while using TableOutputFormat

2023-12-19 Thread Raghavendra B (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raghavendra B reassigned HBASE-28268: - Assignee: Raghavendra B > Add option to skip wal while using TableOutputFormat >

[PR] HBASE-28254 Flaky test: TestTableShell [hbase]

2023-12-19 Thread via GitHub
anmolnar opened a new pull request, #5590: URL: https://github.com/apache/hbase/pull/5590 Add some delay (1/10s) between HBase shell commands in Ruby to avoid two commands ending up with the same version. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HBASE-28270 Remove the xml-maven-plugin in root pom on branch-3 [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5587: URL: https://github.com/apache/hbase/pull/5587#issuecomment-1862764159 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1862680775 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1862674214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28227 Tables to which Stripe Compaction policy is applied cannot be forced to trigger Major Compaction. [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5589: URL: https://github.com/apache/hbase/pull/5589#issuecomment-1862671186 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1862624589 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1862624493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-28151 Option to allow/disallow bypassing pre transit check for assing/unassign [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5493: URL: https://github.com/apache/hbase/pull/5493#issuecomment-1862624305 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862608527 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862605345 In this PR have remove the redundant imports as the scripts run even w/o them. Also removed banned log4j imports as jruby scripts run with `org.jruby.Main` fail without it)

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862546687 Testing out few more things, please hold. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862525411 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862523110 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862522852 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s |

Re: [PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on PR #5588: URL: https://github.com/apache/hbase/pull/5588#issuecomment-1862508524 Will handle `region_status.rb` as part of HBASE-28273. In this PR have remove the redundant imports as the scripts run even w/o them. Tested them as follows: {code} ./hbase

[jira] [Created] (HBASE-28273) region_status.rb is broken

2023-12-19 Thread Nihal Jain (Jira)
Nihal Jain created HBASE-28273: -- Summary: region_status.rb is broken Key: HBASE-28273 URL: https://issues.apache.org/jira/browse/HBASE-28273 Project: HBase Issue Type: Sub-task Affects

[jira] [Updated] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28269: --- Component/s: jruby > Ruby scripts are broken as they import non-existent classes >

[jira] [Updated] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nihal Jain updated HBASE-28269: --- Status: Patch Available (was: Open) > Ruby scripts are broken as they import non-existent classes

[PR] HBASE-28269 Ruby scripts are broken as they import non-existent classes [hbase]

2023-12-19 Thread via GitHub
NihalJain opened a new pull request, #5588: URL: https://github.com/apache/hbase/pull/5588 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (HBASE-28270) Remove the xml-maven-plugin in root pom on branch-3

2023-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28270: -- Summary: Remove the xml-maven-plugin in root pom on branch-3 (was: Remove xml-maven-plugin in root

[jira] [Updated] (HBASE-28270) Remove xml-maven-plugin in root pom on branch-3

2023-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28270: -- Summary: Remove xml-maven-plugin in root pom on branch-3 (was: Remove xml-maven-plugin on branch-3)

Re: [PR] HBASE-28270 Remove the xml-maven-plugin in root pom on branch-3 [hbase]

2023-12-19 Thread via GitHub
Apache9 commented on code in PR #5587: URL: https://github.com/apache/hbase/pull/5587#discussion_r1431200602 ## hbase-archetypes/hbase-archetype-builder/pom.xml: ## @@ -179,6 +179,7 @@ org.codehaus.mojo xml-maven-plugin +${xml.maven.version}

[jira] [Commented] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798528#comment-17798528 ] Duo Zhang commented on HBASE-28269: --- beta-1 is blocked by HBASE-28270. Let's also get this in.

[jira] [Commented] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798514#comment-17798514 ] Nihal Jain commented on HBASE-28269: Ignore I see

[jira] [Comment Edited] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798512#comment-17798512 ] Nihal Jain edited comment on HBASE-28269 at 12/19/23 9:45 AM: -- [~zhangduo] 

[jira] [Comment Edited] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798512#comment-17798512 ] Nihal Jain edited comment on HBASE-28269 at 12/19/23 9:43 AM: -- [~zhangduo] 

[jira] [Commented] (HBASE-28269) Ruby scripts are broken as they import non-existent classes

2023-12-19 Thread Nihal Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17798512#comment-17798512 ] Nihal Jain commented on HBASE-28269: [~zhangduo]  let me know if you want this before you cut the

Re: [PR] HBASE-28270 Remove xml-maven-plugin on branch-3 [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5587: URL: https://github.com/apache/hbase/pull/5587#issuecomment-1862424374 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28270 Remove xml-maven-plugin on branch-3 [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on code in PR #5587: URL: https://github.com/apache/hbase/pull/5587#discussion_r1431153347 ## hbase-archetypes/hbase-archetype-builder/pom.xml: ## @@ -179,6 +179,7 @@ org.codehaus.mojo xml-maven-plugin +${xml.maven.version}

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431122568 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java: ## @@ -70,6 +71,7 @@ public class RestoreSnapshotProcedure

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on PR #5579: URL: https://github.com/apache/hbase/pull/5579#issuecomment-1862405012 Hi @bbeaudreault added a new comment, please have a look. Otherwise changes looks good and all previous feedbacks seemed to be covered. Thanks :) -- This is an automated message from

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431132156 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java: ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431131167 ## hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestManageTableErasureCodingPolicy.java: ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431122568 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java: ## @@ -70,6 +71,7 @@ public class RestoreSnapshotProcedure

[jira] [Updated] (HBASE-28272) After triggering a Major Compaction, clearing the force flag has no effect.

2023-12-19 Thread zhuyaogai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuyaogai updated HBASE-28272: -- Description: In the HStore.java class, in the requestCompaction method, after manually triggering

[jira] [Updated] (HBASE-28272) After triggering a Major Compaction, clearing the force flag has no effect.

2023-12-19 Thread zhuyaogai (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuyaogai updated HBASE-28272: -- Description: In the HStore.java class, in the requestCompaction method, after manually triggering

Re: [PR] HBASE-28216 HDFS erasure coding support for table data dirs [hbase]

2023-12-19 Thread via GitHub
NihalJain commented on code in PR #5579: URL: https://github.com/apache/hbase/pull/5579#discussion_r1431099222 ## hbase-server/src/main/java/org/apache/hadoop/hbase/fs/ErasureCodingUtils.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Updated] (HBASE-28272) After triggering a Major Compaction, clearing the force flag has no effect.

2023-12-19 Thread Longping Jie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Longping Jie updated HBASE-28272: - Description: In the HStore.java class, in the requestCompaction method, after manually

[jira] [Updated] (HBASE-28272) After triggering a Major Compaction, clearing the force flag has no effect.

2023-12-19 Thread Longping Jie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Longping Jie updated HBASE-28272: - Description: In the HStore.java class, in the requestCompaction method, after manually

[jira] [Updated] (HBASE-28272) After triggering a Major Compaction, clearing the force flag has no effect.

2023-12-19 Thread Longping Jie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Longping Jie updated HBASE-28272: - Description: In the HStore.java class, in the requestCompaction method, after manually

Re: [PR] HBASE-28270 Remove xml-maven-plugin on branch-3 [hbase]

2023-12-19 Thread via GitHub
Apache-HBase commented on PR #5587: URL: https://github.com/apache/hbase/pull/5587#issuecomment-1862352116 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

[jira] [Created] (HBASE-28272) After triggering a Major Compaction, clearing the force flag has no effect.

2023-12-19 Thread Longping Jie (Jira)
Longping Jie created HBASE-28272: Summary: After triggering a Major Compaction, clearing the force flag has no effect. Key: HBASE-28272 URL: https://issues.apache.org/jira/browse/HBASE-28272 Project: