[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292048#comment-17292048
]
Ben Manes commented on HBASE-23887:
---
Have you compared against the TinyLFU cache implementation? I'd
[
https://issues.apache.org/jira/browse/HBASE-17028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834105#comment-16834105
]
Ben Manes commented on HBASE-17028:
---
If there is a desire to move it to a larger org, like Apache,
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820436#comment-16820436
]
Ben Manes commented on HBASE-15560:
---
Thank you [~apurtell], [~busbey], [~stack], [~ebortnik], and
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809144#comment-16809144
]
Ben Manes commented on HBASE-15560:
---
That's wonderful, thank you.
> TinyLFU-based BlockCache
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809108#comment-16809108
]
Ben Manes edited comment on HBASE-15560 at 4/3/19 6:56 PM:
---
[~apurtell], I'm
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809108#comment-16809108
]
Ben Manes commented on HBASE-15560:
---
[~apurtell], I'm sorry for the hassle. In
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802250#comment-16802250
]
Ben Manes commented on HBASE-15560:
---
Caffeine is very much dependent on Java 8 to implement features,
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801995#comment-16801995
]
Ben Manes commented on HBASE-15560:
---
Thanks [~apurtell] and [~busbey]. Can you please upgrade to 2.7.0
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16791215#comment-16791215
]
Ben Manes commented on HBASE-15560:
---
Sorry to hear that. Thanks for trying to move this forward. The
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710972#comment-16710972
]
Ben Manes commented on HBASE-15560:
---
Sorry that this dropped off my radar. I can summarize a few
[
https://issues.apache.org/jira/browse/HBASE-17339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943573#comment-15943573
]
Ben Manes commented on HBASE-17339:
---
I think its really difficult to tell, but I'd guess that there
[
https://issues.apache.org/jira/browse/HBASE-17339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942296#comment-15942296
]
Ben Manes commented on HBASE-17339:
---
Can you compare runs with the TinyLFU patch to observe the impact?
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760517#comment-15760517
]
Ben Manes commented on HBASE-15560:
---
Sorry that I haven't had time to investigate this and wrap up the
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15648257#comment-15648257
]
Ben Manes commented on HBASE-15560:
---
If you can give me the steps to reproduce your observation on
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643283#comment-15643283
]
Ben Manes commented on HBASE-15560:
---
Are the access keys not in the data set so that it is not found? I
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643270#comment-15643270
]
Ben Manes commented on HBASE-15560:
---
In the last run, {{Optimal}} is {{55.50%}}. Sorry for the typo.
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643265#comment-15643265
]
Ben Manes commented on HBASE-15560:
---
{{quote}
Would you want the same dataset loaded too?
{{quote}}
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643227#comment-15643227
]
Ben Manes commented on HBASE-15560:
---
Sorry for not getting to this over the weekend. A bit of a family
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637546#comment-15637546
]
Ben Manes commented on HBASE-15560:
---
Thanks [~stack]! I won't be able to dig into this until the
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621071#comment-15621071
]
Ben Manes commented on HBASE-15560:
---
[~stack], will you have time to test this soon?
> TinyLFU-based
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571276#comment-15571276
]
Ben Manes edited comment on HBASE-15560 at 10/13/16 8:37 AM:
-
The update
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571276#comment-15571276
]
Ben Manes commented on HBASE-15560:
---
The update latencies, except for average, were very similar. Since
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570364#comment-15570364
]
Ben Manes commented on HBASE-15560:
---
YCSB workload B states that each record is 1kb, so that is about
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559308#comment-15559308
]
Ben Manes commented on HBASE-15560:
---
1. I performed "git revert b952e64"
2. Configured YCSB workload B
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549840#comment-15549840
]
Ben Manes commented on HBASE-15560:
---
I can take another stab at (1) and work with [~eshcar] to ensure
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546678#comment-15546678
]
Ben Manes commented on HBASE-15560:
---
I know the frustration and agree that feature flags should have a
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546599#comment-15546599
]
Ben Manes commented on HBASE-15560:
---
This flag was to simplify evaluation. It can either be retained to
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546102#comment-15546102
]
Ben Manes commented on HBASE-15560:
---
As noted previously, please try with a real workload rather than
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541173#comment-15541173
]
Ben Manes commented on HBASE-15560:
---
We can add it now if that's desired, or defer on whether to add or
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530762#comment-15530762
]
Ben Manes commented on HBASE-15560:
---
[~busbey], [~eshcar]: The remaining issues appear unrelated to my
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528256#comment-15528256
]
Ben Manes commented on HBASE-15560:
---
[~busbey], I can't seem to trigger a new build. Can you please
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Status: Patch Available (was: Open)
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Status: Open (was: Patch Available)
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Status: Patch Available (was: Open)
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Status: Open (was: Patch Available)
Cancelling and re-submitting patch, hoping that Hadoop QA will
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
Fixed JavaDoc.
I am unable to reproduce the test failure locally when I
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525151#comment-15525151
]
Ben Manes commented on HBASE-15560:
---
Thanks [~busbey]! I made the update and will fix the definition in
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
> TinyLFU-based BlockCache
>
>
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524953#comment-15524953
]
Ben Manes commented on HBASE-15560:
---
[~eshcar] all of the issues don't appear to be related to my
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
Attached patch from review board
> TinyLFU-based BlockCache
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522658#comment-15522658
]
Ben Manes commented on HBASE-15560:
---
The error appears to be a pre-commit check that fails for
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514311#comment-15514311
]
Ben Manes commented on HBASE-15560:
---
I think that I addressed all of the comments, except where noted
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502152#comment-15502152
]
Ben Manes commented on HBASE-15560:
---
Thanks for the reviews so far. When I originally wrote the patch I
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494432#comment-15494432
]
Ben Manes commented on HBASE-15560:
---
Patch [submitted|https://reviews.apache.org/r/51932/] to review
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Affects Version/s: 2.0.0
Status: Patch Available (was: Open)
> TinyLFU-based
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484585#comment-15484585
]
Ben Manes commented on HBASE-15560:
---
Thanks [~Apache9]. The rebase had no conflicts and I didn't notice
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: HBASE-15560.patch
Rebased and upgraded to Caffeine 2.3.3
> TinyLFU-based BlockCache
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382616#comment-15382616
]
Ben Manes commented on HBASE-15560:
---
Thanks! I'll track that one then.
> TinyLFU-based BlockCache
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381075#comment-15381075
]
Ben Manes commented on HBASE-15560:
---
Can we merge this in?
> TinyLFU-based BlockCache
>
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275490#comment-15275490
]
Ben Manes commented on HBASE-15560:
---
[Druid|http://druid.io/] was recently struck by [JDK-8078490 -
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265087#comment-15265087
]
Ben Manes commented on HBASE-15560:
---
Please let me know if there is anything I can do on my end to
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217054#comment-15217054
]
Ben Manes commented on HBASE-15560:
---
Hi Michael,
I agree that offer a choice is an unnecessary
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Description:
LruBlockCache uses the Segmented LRU (SLRU) policy to capture frequency and
recency of
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Description:
LruBlockCache uses the Segmented LRU (SLRU) policy to capture frequency and
recency of
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Description:
LruBlockCache uses the Segmented LRU (SLRU) policy to capture frequency and
recency of
[
https://issues.apache.org/jira/browse/HBASE-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Manes updated HBASE-15560:
--
Attachment: tinylfu.patch
> TinyLFU-based BlockCache
>
>
>
Ben Manes created HBASE-15560:
-
Summary: TinyLFU-based BlockCache
Key: HBASE-15560
URL: https://issues.apache.org/jira/browse/HBASE-15560
Project: HBase
Issue Type: Improvement
60 matches
Mail list logo
