Re: [PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2.6 [hbase]

Apache-HBase commented on PR #5916: URL: https://github.com/apache/hbase/pull/5916#issuecomment-2117407919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s |

Re: [PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-3 [hbase]

Apache-HBase commented on PR #5914: URL: https://github.com/apache/hbase/pull/5914#issuecomment-2117407709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-3 [hbase]

Apache-HBase commented on PR #5914: URL: https://github.com/apache/hbase/pull/5914#issuecomment-2117399752 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 30s |

Re: [PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2 [hbase]

Apache-HBase commented on PR #5915: URL: https://github.com/apache/hbase/pull/5915#issuecomment-2117391030 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2 [hbase]

Apache-HBase commented on PR #5915: URL: https://github.com/apache/hbase/pull/5915#issuecomment-2117369240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2.6 [hbase]

ndimiduk opened a new pull request, #5916: URL: https://github.com/apache/hbase/pull/5916 The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2117341226 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 19s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

ndimiduk commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604779421 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryURIFactory.java: ## @@ -39,4 +39,10 @@ public interface ConnectionRegistryURIFactory {

[PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-2 [hbase]

ndimiduk opened a new pull request, #5915: URL: https://github.com/apache/hbase/pull/5915 The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2117311588 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

[PR] Backport "HBASE-28568 Incremental backup set does not correctly shrink (#5876)" to branch-3 [hbase]

ndimiduk opened a new pull request, #5914: URL: https://github.com/apache/hbase/pull/5914 The incremental backup set is the set of tables included when an incremental backup is created, it is managed per backup root dir and contains all tables that are present in at least one backup (in

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

ndimiduk merged PR #5876: URL: https://github.com/apache/hbase/pull/5876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

ndimiduk commented on code in PR #5876: URL: https://github.com/apache/hbase/pull/5876#discussion_r1604754534 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java: ## @@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2117286142 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

ndimiduk commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2117281426 > I don't know if there's an existing ticket for them, and haven't done any investigation for it. @DieterDP-ng I filed this as https://issues.apache.org/jira/browse/HBASE-28602

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604736324 ## hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtil.java: ## @@ -3216,6 +3216,24 @@ public static String safeGetAsStr(List lst, int i) { } }

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604734555 ## hbase-server/src/main/java/org/apache/hadoop/hbase/replication/HBaseReplicationEndpoint.java: ## @@ -283,4 +291,8 @@ public AsyncRegionServerAdmin getRegionServer() {

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604734005 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java: ## @@ -402,6 +407,57 @@ public void

Re: [PR] HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.d… [hbase]

Apache-HBase commented on PR #5913: URL: https://github.com/apache/hbase/pull/5913#issuecomment-2117259868 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.d… [hbase]

Apache-HBase commented on PR #5913: URL: https://github.com/apache/hbase/pull/5913#issuecomment-211721 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604729871 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java: ## @@ -402,6 +407,57 @@ public void

Re: [PR] HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.d… [hbase]

Apache-HBase commented on PR #5913: URL: https://github.com/apache/hbase/pull/5913#issuecomment-2117253820 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604727307 ## hbase-replication/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeers.java: ## @@ -166,8 +175,8 @@ public void onConfigurationChange(Configuration

Re: [PR] HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.d… [hbase]

Apache-HBase commented on PR #5913: URL: https://github.com/apache/hbase/pull/5913#issuecomment-2117250839 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604720569 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReservoirSample.java: ## @@ -41,7 +41,7 @@ public class ReservoirSample { private int n; public

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r160471 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcConnectionRegistryURIFactory.java: ## @@ -19,6 +19,7 @@ import java.io.IOException; import

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

Apache9 commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604718022 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryURIFactory.java: ## @@ -39,4 +39,10 @@ public interface ConnectionRegistryURIFactory {

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

ndimiduk commented on code in PR #5865: URL: https://github.com/apache/hbase/pull/5865#discussion_r1604690948 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/ReservoirSample.java: ## @@ -41,7 +41,7 @@ public class ReservoirSample { private int n; public

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

Apache9 commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2117228242 Thanks @ndimiduk Will merge this PR on next Monday if no other concerns this weekend. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1604643337 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,18 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1604643337 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,18 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

Apache-HBase commented on PR #5816: URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117204449 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

ndimiduk commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2117194979 > Ping @anmolnar I don't think we'll hear back. I don't think you need to wait for a response. @Apache9 please feel free to proceed whenever you're ready. -- This is an automated

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

vineet4008 commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2117172626 > Could you please provide more details about how it could be null when calling doShutdown? In the test execution, During MasterRegion#createWAL, if WAL creation fails, then

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2117172498 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 24m 53s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2117157996 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s |

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

jhungund commented on code in PR #5866: URL: https://github.com/apache/hbase/pull/5866#discussion_r1604643337 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -2203,6 +2204,18 @@ public Optional shouldCacheFile(HFileInfo hFileInfo,

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2117134995 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28420 Update the procedure's field to store for ServerRemoteProcedure [hbase]

Umeshkumar9414 commented on PR #5816: URL: https://github.com/apache/hbase/pull/5816#issuecomment-2117121965 I tried to write UT for this by submitting 2 SplitWALProcedure, one before master failover and one after failover. But Till the time another procedure completes on RegionServer stub

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2117108925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

Apache-HBase commented on PR #5905: URL: https://github.com/apache/hbase/pull/5905#issuecomment-2117068544 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2117068013 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2116982950 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116979988 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604514473 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java: ## @@ -275,6 +275,18 @@ public boolean shouldCacheBlockOnRead(BlockCategory category)

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604512451 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -471,6 +474,62 @@ public void testFeatureKeyDisabled() throws

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

jhungund commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604512006 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java: ## @@ -275,6 +275,18 @@ public boolean shouldCacheBlockOnRead(BlockCategory category)

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2116945375 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 17s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116939444 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28467: Add time-based priority caching checks for cacheOnRead code paths. [hbase]

vinayakphegde commented on code in PR #5905: URL: https://github.com/apache/hbase/pull/5905#discussion_r1604469915 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -471,6 +474,62 @@ public void testFeatureKeyDisabled() throws

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

csringhofer commented on code in PR #5910: URL: https://github.com/apache/hbase/pull/5910#discussion_r1604479116 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3787,7 +3798,7 @@ private void closeScanner(HRegion region,

Re: [PR] HBASE-28469: Integration of time-based priority caching into compaction paths [hbase]

Apache-HBase commented on PR #5866: URL: https://github.com/apache/hbase/pull/5866#issuecomment-2116917046 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116904345 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116873570 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116856083 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116851413 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

Apache9 commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2116818996 Ping @anmolnar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116816261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116761057 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116695949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116690161 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

kadirozde commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116606679 > @kadirozde Looks like this needs spotless:apply too. I did run for the last commit. I will do it again if necessary. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28588 Remove deprecated methods in WAL [hbase]

Apache9 commented on code in PR #5893: URL: https://github.com/apache/hbase/pull/5893#discussion_r1604318505 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java: ## @@ -686,12 +686,6 @@ public void abortCacheFlush(byte[] encodedRegionName)

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116577923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

Apache9 commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116573873 Could you please provide more details about how it could be null when calling doShutdown? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache9 commented on code in PR #5910: URL: https://github.com/apache/hbase/pull/5910#discussion_r1604312448 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java: ## @@ -3787,7 +3798,7 @@ private void closeScanner(HRegion region, RegionScanner

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

apurtell commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116555259 @kadirozde Checkstyle nit fix and spotless:apply needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

Apache9 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2116555130 Please run `mvn spotless:apply` before committing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116554682 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

apurtell commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116554565 @kadirozde Looks like this needs spotless:apply too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2116553080 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

apurtell merged PR #5545: URL: https://github.com/apache/hbase/pull/5545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116540777 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

kadirozde commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604284847 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

Apache-HBase commented on PR #5545: URL: https://github.com/apache/hbase/pull/5545#issuecomment-2116510269 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604229161 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-25972 Dual File Compaction [hbase]

virajjasani commented on code in PR #5545: URL: https://github.com/apache/hbase/pull/5545#discussion_r1604229161 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileWriter.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116437408 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116413160 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5912: URL: https://github.com/apache/hbase/pull/5912#issuecomment-2116399777 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

Apache-HBase commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116387909 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116386243 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116380266 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-25972 Dual File Compactor [hbase]

Apache-HBase commented on PR #5911: URL: https://github.com/apache/hbase/pull/5911#issuecomment-2116372709 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116368238 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116366437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[PR] HBASE-25972 Dual File Compactor [hbase]

kadirozde opened a new pull request, #5912: URL: https://github.com/apache/hbase/pull/5912 branch-3 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] HBASE-25972 Dual File Compactor [hbase]

kadirozde opened a new pull request, #5911: URL: https://github.com/apache/hbase/pull/5911 branch-2 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

Apache-HBase commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116324245 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2116289948 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2116170934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2116161208 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2116151131 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2116099063 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28582 ModifyTableProcedure should not reset TRSP on region node… [hbase]

Apache-HBase commented on PR #5903: URL: https://github.com/apache/hbase/pull/5903#issuecomment-2116058076 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28595: check seq id of scan RPCs for closed scanners [hbase]

Apache-HBase commented on PR #5910: URL: https://github.com/apache/hbase/pull/5910#issuecomment-2116053675 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

Apache-HBase commented on PR #5909: URL: https://github.com/apache/hbase/pull/5909#issuecomment-2116013173 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s |

Re: [PR] HBASE-28595: client side fix for partial results when exception from scan RPC is lost [hbase]

csringhofer commented on PR #5904: URL: https://github.com/apache/hbase/pull/5904#issuecomment-2115977393 Uploaded a server side fix for master: https://github.com/apache/hbase/pull/5910 Created a test that seemed consistent so far but had to modify RemoteWithExtrasException to

[PR] HBASE-28598 Fixes NPE for writer object access in AsyncFSWAL#closeWriter [hbase]

vineet4008 opened a new pull request, #5909: URL: https://github.com/apache/hbase/pull/5909 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] HBASE-28596 Optimise BucketCache usage upon regions splits/merges. [hbase]

Apache-HBase commented on PR #5906: URL: https://github.com/apache/hbase/pull/5906#issuecomment-2115727176 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

<    1   2   3   4   5   6   7   8   9   10   >