Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
2005hithlj commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105433912 The failed UTs TestBlockingIPC/TestPrefetchWithBucketCache is not related to the changes, let's see if it will still fail in the new commit. -- This is an automated message from the

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
2005hithlj commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2105430990 I will fix the spotless check errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
2005hithlj commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105431081 I will fix the spotless check errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2105262236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105198103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105194222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105192953 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5307: URL: https://github.com/apache/hbase/pull/5307#issuecomment-2105187283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2105154925 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2105147484 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2105106888 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105106222 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105098107 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2105065234 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2105056577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2105026654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
gvprathyusha6 commented on code in PR #5307: URL: https://github.com/apache/hbase/pull/5307#discussion_r1596939498 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java: ## @@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) { }

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2104811923 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2104700025 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5891: URL: https://github.com/apache/hbase/pull/5891#issuecomment-2104696301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2104678602 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2104671493 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2104670886 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5892: URL: https://github.com/apache/hbase/pull/5892#issuecomment-2104671519 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

[PR] HBASE-28581 Remove deprecated methods in TableDescriotorBuilder [hbase]

2024-05-10 Thread via GitHub
2005hithlj opened a new pull request, #5892: URL: https://github.com/apache/hbase/pull/5892 https://issues.apache.org/jira/browse/HBASE-28581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] HBASE-28576 Remove FirstKeyValueMatchingQualifiersFilter [hbase]

2024-05-10 Thread via GitHub
2005hithlj opened a new pull request, #5891: URL: https://github.com/apache/hbase/pull/5891 https://issues.apache.org/jira/browse/HBASE-28576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
gvprathyusha6 commented on code in PR #5307: URL: https://github.com/apache/hbase/pull/5307#discussion_r1596623746 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java: ## @@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) { }

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5890: URL: https://github.com/apache/hbase/pull/5890#issuecomment-2104568107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5890: URL: https://github.com/apache/hbase/pull/5890#issuecomment-2104567347 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5890: URL: https://github.com/apache/hbase/pull/5890#issuecomment-2104547440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2104543395 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2104540929 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2104536916 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5887: URL: https://github.com/apache/hbase/pull/5887#issuecomment-2104528869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5886: URL: https://github.com/apache/hbase/pull/5886#issuecomment-2104524085 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5887: URL: https://github.com/apache/hbase/pull/5887#issuecomment-2104522568 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5886: URL: https://github.com/apache/hbase/pull/5886#issuecomment-2104519338 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5887: URL: https://github.com/apache/hbase/pull/5887#issuecomment-2104519013 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5886: URL: https://github.com/apache/hbase/pull/5886#issuecomment-2104508357 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2104504007 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 52s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2104503794 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 55s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2104502252 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5889: URL: https://github.com/apache/hbase/pull/5889#issuecomment-2104500875 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2104498549 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2104495321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
szucsvillo opened a new pull request, #5890: URL: https://github.com/apache/hbase/pull/5890 …elativePath method (#2167) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5888: URL: https://github.com/apache/hbase/pull/5888#issuecomment-2104489620 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28578 Remove deprecated methods in HFileScanner [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5885: URL: https://github.com/apache/hbase/pull/5885#issuecomment-2104482388 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5887: URL: https://github.com/apache/hbase/pull/5887#issuecomment-2104480939 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5887: URL: https://github.com/apache/hbase/pull/5887#issuecomment-2104478053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5887: URL: https://github.com/apache/hbase/pull/5887#issuecomment-2104470265 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28578 Remove deprecated methods in HFileScanner [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5885: URL: https://github.com/apache/hbase/pull/5885#issuecomment-2104469371 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5886: URL: https://github.com/apache/hbase/pull/5886#issuecomment-2104465819 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5886: URL: https://github.com/apache/hbase/pull/5886#issuecomment-2104460845 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 54s |

Re: [PR] HBASE-28578 Remove deprecated methods in HFileScanner [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5885: URL: https://github.com/apache/hbase/pull/5885#issuecomment-2104454489 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[PR] HBASE-28579 Hide HFileScanner related methods in StoreFileReader [hbase]

2024-05-10 Thread via GitHub
Apache9 opened a new pull request, #5889: URL: https://github.com/apache/hbase/pull/5889 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
szucsvillo opened a new pull request, #5888: URL: https://github.com/apache/hbase/pull/5888 …elativePath method (#2167) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5886: URL: https://github.com/apache/hbase/pull/5886#issuecomment-2104443192 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
szucsvillo opened a new pull request, #5887: URL: https://github.com/apache/hbase/pull/5887 …elativePath method (#2167) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
gvprathyusha6 commented on code in PR #5307: URL: https://github.com/apache/hbase/pull/5307#discussion_r1596623746 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java: ## @@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) { }

Re: [PR] HBASE-27938 - PE load any custom implementation of tests at runtime [hbase]

2024-05-10 Thread via GitHub
gvprathyusha6 commented on code in PR #5307: URL: https://github.com/apache/hbase/pull/5307#discussion_r1596614929 ## hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java: ## @@ -2308,7 +2316,7 @@ protected byte[] generateRow(final int i) { }

[PR] HBASE-24791 Improve HFileOutputFormat2 to avoid always call getTableR… [hbase]

2024-05-10 Thread via GitHub
szucsvillo opened a new pull request, #5886: URL: https://github.com/apache/hbase/pull/5886 …elativePath method (#2167) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
bbeaudreault commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2104353124 I agree with Nick. I also think it's a bit odd to require two separate configuration points for a working connection. So previously you had to specify a Configuration, and now you can

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2104339577 ``` java.io.IOException: java.io.FileNotFoundException: File

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2104337779 Test failure looks like a failure of the backup system. It's attempting to take an incremental backup, which assumes the existence of a WAL that no longer exists. The test harness ran the

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on code in PR #5876: URL: https://github.com/apache/hbase/pull/5876#discussion_r1596546774 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java: ## @@ -129,20 +128,15 @@ public int deleteBackups(String[] backupIds) throws

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on PR #5871: URL: https://github.com/apache/hbase/pull/5871#issuecomment-2104294247 Looks like both modified test methods were executed and passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HBASE-28502 Cleanup old backup manifest logic [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on code in PR #5871: URL: https://github.com/apache/hbase/pull/5871#discussion_r1596521351 ## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java: ## @@ -102,24 +95,6 @@ public static Path getTableBackupPath(TableName tableName,

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
Apache9 commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2104234526 In real world, after we introduce the connection URI, a possible use case is that, some users may introduce a hbase connector on their system, and let the users of the system submit an URI

Re: [PR] HBASE-28547 Support specifying connection registry configuration thro… [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on code in PR #5850: URL: https://github.com/apache/hbase/pull/5850#discussion_r1596482388 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistryURIFactory.java: ## @@ -30,9 +34,34 @@ * Connection registry creator implementation

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2104221543 From my perspective, on client-side security, the client application is already a "compromised" actor. I assume that whomever controls that application already has full control over the

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
Apache9 commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2104214581 > > This is super scary. What is the use case? > > @anmolnar can you expand on your concerns here? For me, if we allow overriding any configurations through URI queries, it

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on code in PR #5853: URL: https://github.com/apache/hbase/pull/5853#discussion_r1596475339 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/Strings.java: ## @@ -94,4 +102,37 @@ public static String padFront(String input, char padding, int length) {

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
Apache9 commented on code in PR #5853: URL: https://github.com/apache/hbase/pull/5853#discussion_r1596471275 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/Strings.java: ## @@ -94,4 +102,37 @@ public static String padFront(String input, char padding, int length) {

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on code in PR #5853: URL: https://github.com/apache/hbase/pull/5853#discussion_r1596467045 ## hbase-common/src/main/java/org/apache/hadoop/hbase/util/Strings.java: ## @@ -94,4 +102,37 @@ public static String padFront(String input, char padding, int length) {

Re: [PR] HBASE-28547 Support specifying connection configuration through queri… [hbase]

2024-05-10 Thread via GitHub
ndimiduk commented on PR #5853: URL: https://github.com/apache/hbase/pull/5853#issuecomment-2104188713 > This is super scary. What is the use case? @anmolnar can you expand on your concerns here? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HBASE-28578 Remove deprecated methods in HFileScanner [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5885: URL: https://github.com/apache/hbase/pull/5885#issuecomment-2104143549 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 43s |

[PR] HBASE-28578 Remove deprecated methods in HFileScanner [hbase]

2024-05-10 Thread via GitHub
Apache9 opened a new pull request, #5885: URL: https://github.com/apache/hbase/pull/5885 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] fix : HBASE-28585. Add namespace handling method [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5884: URL: https://github.com/apache/hbase/pull/5884#issuecomment-2104027934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] fix : HBASE-28585. Add namespace handling method [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5884: URL: https://github.com/apache/hbase/pull/5884#issuecomment-2104026079 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] fix : HBASE-28585. Add namespace handling method [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5884: URL: https://github.com/apache/hbase/pull/5884#issuecomment-2104025422 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] fix : HBASE-28585. Add namespace handling method [hbase]

2024-05-10 Thread via GitHub
Apache-HBase commented on PR #5884: URL: https://github.com/apache/hbase/pull/5884#issuecomment-2104024904 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s |

[PR] fix : HBASE-28585. Add namespace handling method [hbase]

2024-05-10 Thread via GitHub
SWH12 opened a new pull request, #5884: URL: https://github.com/apache/hbase/pull/5884 When utilizing the copy_tables_desc.rb script to duplicate tables to a target cluster, if the specified table's namespace is nonexistent in the target cluster, the script fails to execute successfully.

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
Apache9 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2103804867 Seems we still reference the oswrite method in test code? Please remove the related test code too. @q977734161 Thanks. -- This is an automated message from the Apache Git

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path (#5771) [hbase]

2024-05-09 Thread via GitHub
jojochuang merged PR #5814: URL: https://github.com/apache/hbase/pull/5814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path (#5771) [hbase]

2024-05-09 Thread via GitHub
jojochuang commented on PR #5814: URL: https://github.com/apache/hbase/pull/5814#issuecomment-2103638431 Test failures are unrelated. I'm merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path (#5771) [hbase]

2024-05-09 Thread via GitHub
jojochuang merged PR #5813: URL: https://github.com/apache/hbase/pull/5813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path (#5771) [hbase]

2024-05-09 Thread via GitHub
jojochuang commented on PR #5813: URL: https://github.com/apache/hbase/pull/5813#issuecomment-2103636744 Test failures are unrelated. I'm merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path (#5771) [hbase]

2024-05-09 Thread via GitHub
jojochuang merged PR #5812: URL: https://github.com/apache/hbase/pull/5812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28448 CompressionTest hangs when run over a Ozone ofs path (#5771) [hbase]

2024-05-09 Thread via GitHub
jojochuang commented on PR #5812: URL: https://github.com/apache/hbase/pull/5812#issuecomment-2103636449 Test errors are unrelated I'm merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5865: URL: https://github.com/apache/hbase/pull/5865#issuecomment-2103282802 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 47s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5865: URL: https://github.com/apache/hbase/pull/5865#issuecomment-2103238475 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28425 Allow specify cluster key without zookeeper in replication [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5865: URL: https://github.com/apache/hbase/pull/5865#issuecomment-2103236641 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28568 Fix incremental backup set shrinking [hbase]

2024-05-09 Thread via GitHub
rmdmattingly commented on PR #5876: URL: https://github.com/apache/hbase/pull/5876#issuecomment-2103196047 The test failure looks relevant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2103020175 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2103002153 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2103000958 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
Apache-HBase commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2102999252 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
q977734161 opened a new pull request, #5883: URL: https://github.com/apache/hbase/pull/5883 API cleanup for 3.0.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28577 Remove deprecated methods in KeyValue [hbase]

2024-05-09 Thread via GitHub
q977734161 commented on PR #5883: URL: https://github.com/apache/hbase/pull/5883#issuecomment-2102959908 HBASE-28577 Remove deprecated methods in KeyValue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

<    4   5   6   7   8   9   10   11   12   13   >