DieterDP-ng opened a new pull request, #5876:
URL: https://github.com/apache/hbase/pull/5876
The incremental backup set is the set of tables included when an incremental
backup is created, it is managed per backup root dir and contains all tables
that are present in at least one backup (in
Apache9 merged PR #5875:
URL: https://github.com/apache/hbase/pull/5875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2096066904
Have you guys find the way to use timer to implement the timeout?
You can see the code in AsyncRpcRetryingCaller.
And for ZKConnectionRegistry, you can pass the TIMER in
Apache9 commented on code in PR #5841:
URL: https://github.com/apache/hbase/pull/5841#discussion_r1591039624
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/InitMetaProcedure.java:
##
@@ -119,6 +122,19 @@ protected Flow executeFromState(MasterProcedureEnv
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2096034672
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2096034131
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 52s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2096024626
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 48s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2096019350
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 11s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2095964897
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 34s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2095963457
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2095962907
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2095960385
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
DieterDP-ng commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1590961068
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
mwkang commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1590948079
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper
Apache9 commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590718878
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RestUtil.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
DieterDP-ng commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1590736669
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
Apache-HBase commented on PR #5875:
URL: https://github.com/apache/hbase/pull/5875#issuecomment-2095517890
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 32s |
DieterDP-ng commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1590736669
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
DieterDP-ng commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1590726707
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
Apache9 commented on PR #5851:
URL: https://github.com/apache/hbase/pull/5851#issuecomment-2095479675
@ksravista Do you have a jira account?
If not, please go to https://selfserve.apache.org/jira-account.html to
register one so I can assign HBASE-28459 to you.
--
This is an
Apache-HBase commented on PR #5875:
URL: https://github.com/apache/hbase/pull/5875#issuecomment-2095468773
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2095466027
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2095447227
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2095446817
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5870:
URL: https://github.com/apache/hbase/pull/5870#issuecomment-2095444854
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
DieterDP-ng commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1590689156
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +298,31 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
Apache-HBase commented on PR #5875:
URL: https://github.com/apache/hbase/pull/5875#issuecomment-2095434788
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 49s |
Apache9 merged PR #5858:
URL: https://github.com/apache/hbase/pull/5858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 merged PR #5851:
URL: https://github.com/apache/hbase/pull/5851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590665528
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ProtobufStreamingOutput.java:
##
@@ -91,15 +89,18 @@ private void writeToStream(CellSetModel model, String
Apache9 merged PR #5874:
URL: https://github.com/apache/hbase/pull/5874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 merged PR #5873:
URL: https://github.com/apache/hbase/pull/5873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 merged PR #5872:
URL: https://github.com/apache/hbase/pull/5872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590543304
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java:
##
@@ -58,10 +61,11 @@
*
*/
@XmlRootElement(name = "Cell")
stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590543304
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java:
##
@@ -58,10 +61,11 @@
*
*/
@XmlRootElement(name = "Cell")
stoty commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590542362
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ProtobufStreamingOutput.java:
##
@@ -91,15 +89,18 @@ private void writeToStream(CellSetModel model, String
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095197152
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5875:
URL: https://github.com/apache/hbase/pull/5875#issuecomment-2095195742
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 27s |
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095193271
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095174322
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095119600
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095119436
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095118959
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095118598
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
vincentpoon commented on code in PR #5874:
URL: https://github.com/apache/hbase/pull/5874#discussion_r1590489672
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java:
##
@@ -460,6 +460,9 @@ public List getMetaReplicaNodes() throws
KeeperException {
vincentpoon commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095102342
Let me attempt to summarize the cases:
- `/hbase/meta-region-server` exists - node is returned all the way ZKUtil
-> ZKWatcher -> MetaRegionLocationCache
- `/hbase` exists but
Apache9 commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095097362
> I am in favor of keeping patch like this, so that we don't have to keep
calling listChildren until `/hbase/meta-region-server` gets created. I know you
have valid concern about not
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095090843
I am in favor of keeping patch like this, so that we don't have to keep
calling listChildren until `/hbase/meta-region-server` gets created. I know you
have valid concern about not
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095081066
Btw just in case if we end up updating
`MetaRegionLocationCache#loadMetaLocationsFromZk`, we might have to keep
`retryCounter.sleepUntilNextRetry()` out of catching KeeperException.
vincentpoon commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095068099
> It is just a bit strange that in ZKUtil we eat the NoNodeException while
at the upper layer we create a new NoNodeException and throw it...
I think the original author of
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095061777
Oh, I see you are talking about breaking this loop:
```
try {
znodes = watcher.getMetaReplicaNodesAndWatchChildren();
break;
} catch
Apache9 commented on code in PR #5870:
URL: https://github.com/apache/hbase/pull/5870#discussion_r1590472140
##
hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableScanResource.java:
##
@@ -87,12 +85,12 @@ public RowModel next() {
if ((rs == null) || (count
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095055933
> Better just return null in ZKWatcher, and in MetaRegionLocationCache, we
do not break the loop if the return value is null.
We need to retry in this case, that's the main
Apache9 commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095053926
> Sure but right now the problem is `ZKWatcher#filterMetaReplicaNodes`
returns empty List if the input nodes is null. So `MetaRegionLocationCache`
can't tell the difference between:
>
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095050613
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095050352
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095049657
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095049227
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
virajjasani commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095045853
I agree, we will need to change ZKWatcher one way or another, and currently
this is the only caller
--
This is an automated message from the Apache Git Service.
To respond to the
vincentpoon commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095044667
Sure but right now the problem is `ZKWatcher#filterMetaReplicaNodes` returns
empty List if the input nodes is null. So `MetaRegionLocationCache` can't tell
the difference between:
Apache9 commented on PR #5874:
URL: https://github.com/apache/hbase/pull/5874#issuecomment-2095042089
I think we should change the logic in MetaRegionLocationCache instead of in
ZKWatcher?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2095038518
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
vincentpoon opened a new pull request, #5874:
URL: https://github.com/apache/hbase/pull/5874
…t watcher to populate meta location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094945213
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 36s |
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094935716
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094928036
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094926368
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094917136
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094910461
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094908672
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094903126
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094892007
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5873:
URL: https://github.com/apache/hbase/pull/5873#issuecomment-2094844472
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5872:
URL: https://github.com/apache/hbase/pull/5872#issuecomment-2094839432
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache9 opened a new pull request, #5873:
URL: https://github.com/apache/hbase/pull/5873
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Apache9 commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1590326516
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper
Apache9 opened a new pull request, #5872:
URL: https://github.com/apache/hbase/pull/5872
…sRegionServerServices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094817759
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2094557152
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2094557005
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2094556868
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 12s |
Apache-HBase commented on PR #5869:
URL: https://github.com/apache/hbase/pull/5869#issuecomment-2094556794
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
mwkang commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1590191451
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper
mwkang commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1590193143
##
hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperHelper.java:
##
@@ -61,6 +61,7 @@ public static ZooKeeper ensureConnectedZooKeeper(ZooKeeper
mwkang commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1590191451
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094350268
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 6s |
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094349695
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094342293
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5865:
URL: https://github.com/apache/hbase/pull/5865#issuecomment-2094247758
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache9 commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1589993413
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper
Apache9 commented on PR #5853:
URL: https://github.com/apache/hbase/pull/5853#issuecomment-2094169410
> This is super scary. What is the use case?
To make sure users can fully initialize a connecton to a HBase cluster with
a single URI.
In the current implementation, we still
anmolnar commented on PR #5853:
URL: https://github.com/apache/hbase/pull/5853#issuecomment-2093807312
This is super scary. What is the use case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
anmolnar commented on code in PR #5869:
URL: https://github.com/apache/hbase/pull/5869#discussion_r1589700781
##
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKMainServer.java:
##
@@ -41,7 +42,8 @@ public String parse(final Configuration c) {
* ZooKeeper
rmdmattingly commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1589682053
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
rmdmattingly commented on code in PR #5868:
URL: https://github.com/apache/hbase/pull/5868#discussion_r1589682053
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java:
##
@@ -295,51 +296,32 @@ public ArrayList getAncestors(BackupInfo
backupInfo)
Apache-HBase commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2093661849
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093660305
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093657474
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 58s |
Apache-HBase commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2093651831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5868:
URL: https://github.com/apache/hbase/pull/5868#issuecomment-2093651839
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 15s |
901 - 1000 of 13732 matches
Mail list logo
