[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminProtos.AdminLogEntry getLogEntries(RpcController

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminProtos.AdminLogEntry getLogEntries(RpcController

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminLogEntry getLogEntries(RpcController controller,

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminLogEntry getLogEntries(RpcController controller,

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-18 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-675434004 I believe we should have generic Admin API for similar use-cases. For existing slowLog use-case, I can make it default implementation pointing to generic API and

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-18 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-675434004 I believe we should have generic Admin API for similar use-cases. For existing slowLog use-case, I can make it default implementation pointing to generic API and