[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

[GitBox]

virajjasani edited a comment on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809


   We have two separate RPC APIs generic for Master and RS Rpcs:
   
   **RSRpcServices:**
   ```
     public AdminLogEntry getLogEntries(RpcController controller,
         AdminLogRequest request) throws ServiceException
   ```
   
   **MasterRpcServices:**
   ```
     public MasterProtos.MasterLogEntry getLogEntries(RpcController controller,
         MasterProtos.MasterLogRequest request) throws ServiceException
   ```
   
   And, we will be using ByteString from request/response objects to RPC APIs.
   
   Admin API for both use-cases (different ring buffers at Master as well as RS 
level) is generic:
   ```
     List<LogEntry> getLogEntries(LogRequest logRequest) throws IOException;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org