virajjasani edited a comment on pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809


   We have two separate RPC APIs generic for Master and RS Rpcs:
   
   **RSRpcServices:**
   ```
     public AdminProtos.AdminLogEntry getLogEntries(RpcController controller,
         AdminProtos.AdminLogRequest request) throws ServiceException
   ```
   
   **MasterRpcServices:**
   ```
     public MasterProtos.MasterLogEntry getLogEntries(RpcController controller,
         MasterProtos.MasterLogRequest request) throws ServiceException
   ```
   
   And, we will be using ByteString from request/response objects to RPC APIs.
   
   **Admin** API for both type of ring-buffer use-cases (Master and RS) is 
generic:
   ```
     List<LogEntry> getLogEntries(LogRequest logRequest) throws IOException;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to