[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126632#comment-14126632
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845562#comment-13845562
]
Ted Yu commented on HBASE-1:
The TestLogRolling#testLogRollOnDatanodeDeath failure
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845884#comment-13845884
]
stack commented on HBASE-1:
---
You did one test fail on the cluster? It had two logs to
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845891#comment-13845891
]
stack commented on HBASE-1:
---
Woud suggest trying to break this feature. Along the way,
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845894#comment-13845894
]
Ted Yu commented on HBASE-1:
bq. It had two logs to split. Is that even realistic?
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845898#comment-13845898
]
Ted Yu commented on HBASE-1:
bq. Woud suggest trying to break this feature
The
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846008#comment-13846008
]
stack commented on HBASE-1:
---
A single test run does not prove resilience. I am working
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846019#comment-13846019
]
Ted Yu commented on HBASE-1:
Stack:
I understand the importance of this part of the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844561#comment-13844561
]
Ted Yu commented on HBASE-1:
Did some cluster testing on a 5 region server cluster:
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844579#comment-13844579
]
stack commented on HBASE-1:
---
How many WALs? How many times did you run the test?
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844592#comment-13844592
]
Ted Yu commented on HBASE-1:
There was one unclosed log, shown below.
{code}
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844663#comment-13844663
]
Ted Yu commented on HBASE-1:
hdfs deployment is hadoop 2.2
From namenode log:
{code}
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844748#comment-13844748
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844756#comment-13844756
]
Ted Yu commented on HBASE-1:
TestNodeHealthCheckChore failure was not related to
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844997#comment-13844997
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845078#comment-13845078
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845114#comment-13845114
]
Ted Yu commented on HBASE-1:
The test failure (taking place around 2013-12-11
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845154#comment-13845154
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843012#comment-13843012
]
Nicolas Liochon commented on HBASE-1:
-
I reviewed the 0.96 version:
I found
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843154#comment-13843154
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843246#comment-13843246
]
Ted Yu commented on HBASE-1:
I believe the test failure is tackled by HBASE-10101
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843364#comment-13843364
]
stack commented on HBASE-1:
---
bq. Patch v6 addresses Nicolas' comments above.
How we
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843373#comment-13843373
]
Ted Yu commented on HBASE-1:
Stack:
Were you referring to the scenario where there is
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843459#comment-13843459
]
Ted Yu commented on HBASE-1:
I tried to add a test which simulates the absence of
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843469#comment-13843469
]
stack commented on HBASE-1:
---
Yes. Sounds like you have no evidence you've addressed
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843572#comment-13843572
]
Ted Yu commented on HBASE-1:
Here is how patch v6 addresses the above scenario:
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843956#comment-13843956
]
Ted Yu commented on HBASE-1:
I tried to add the following test to TestFSHDFSUtils by
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842463#comment-13842463
]
Benoit Sigoure commented on HBASE-1:
Damn I can't believe I missed issue
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842227#comment-13842227
]
stack commented on HBASE-1:
---
Needs evidence works on real cluster and that edits are
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842359#comment-13842359
]
Ted Yu commented on HBASE-1:
Cluster testing would be done next week.
Initiate
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842443#comment-13842443
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841286#comment-13841286
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841623#comment-13841623
]
Ted Yu commented on HBASE-1:
javadoc warning should be covered by HBASE-10099,
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841792#comment-13841792
]
Nicolas Liochon commented on HBASE-1:
-
{code}
+ if
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841843#comment-13841843
]
Ted Yu commented on HBASE-1:
Nicolas: thanks for the valuable comments.
Patch v4
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13841941#comment-13841941
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842031#comment-13842031
]
Enis Soztutar commented on HBASE-1:
---
Skimmed the patch. It looks ok to me.
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842104#comment-13842104
]
Ted Yu commented on HBASE-1:
bq. the expected gain in case num_log_files available
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840793#comment-13840793
]
Jeffrey Zhong commented on HBASE-1:
---
[~te...@apache.org] I didn't see where you
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13840885#comment-13840885
]
Ted Yu commented on HBASE-1:
Thanks for the good catch, Jeff.
New patch, to be
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836196#comment-13836196
]
Andrew Purtell commented on HBASE-1:
Should this be committed?
Initiate
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13836207#comment-13836207
]
Ted Yu commented on HBASE-1:
This patch touches important code path.
More review is
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835562#comment-13835562
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834356#comment-13834356
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834365#comment-13834365
]
Ted Yu commented on HBASE-1:
There are a lot of datanode exceptions in test output
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834384#comment-13834384
]
Ted Yu commented on HBASE-1:
Rebuilt on top of hadoop-1 locally and ran TestHLog - it
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830912#comment-13830912
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830768#comment-13830768
]
Ted Yu commented on HBASE-1:
bq. Make a method of this:
The code modifies two local
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830793#comment-13830793
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830822#comment-13830822
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830853#comment-13830853
]
stack commented on HBASE-1:
---
bq. The code modifies two local variables. Making it a
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830889#comment-13830889
]
Ted Yu commented on HBASE-1:
bq. Why do reflection every time this method is called?
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830078#comment-13830078
]
stack commented on HBASE-1:
---
Make a method of this:
+if (findIsFileClosedMeth) {
+
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830109#comment-13830109
]
Hadoop QA commented on HBASE-1:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830154#comment-13830154
]
Ted Yu commented on HBASE-1:
I am currently in China.
Will test on cluster once I
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830198#comment-13830198
]
Himanshu Vashishtha commented on HBASE-1:
-
bq. patch should have used a
[
https://issues.apache.org/jira/browse/HBASE-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13829765#comment-13829765
]
stack commented on HBASE-1:
---
Patch?
Initiate lease recovery for outstanding WAL files
57 matches
Mail list logo
