[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031869#comment-14031869 ] Hudson commented on HBASE-10771: SUCCESS: Integrated in HBase-TRUNK #5208 (See [https://

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031697#comment-14031697 ] stack commented on HBASE-10771: --- Still +1 on commit. You can add the notes on commit [~anoo

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031519#comment-14031519 ] Anoop Sam John commented on HBASE-10771: bq.Where do you confirm that the long an

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018284#comment-14018284 ] stack commented on HBASE-10771: --- +1 Where do you confirm that the long and int writing is

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008607#comment-14008607 ] Anoop Sam John commented on HBASE-10771: The javadoc warnings and release audit w

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008599#comment-14008599 ] Hadoop QA commented on HBASE-10771: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987363#comment-13987363 ] Anoop Sam John commented on HBASE-10771: bq.Any chance of a unit test that builds

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987362#comment-13987362 ] Anoop Sam John commented on HBASE-10771: bq.Might be interesting to add a test to

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986823#comment-13986823 ] Andrew Purtell commented on HBASE-10771: Visually the get* and put* methods look

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986353#comment-13986353 ] Matt Corgan commented on HBASE-10771: - Looks good to me. It looks like the encoding

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979308#comment-13979308 ] Anoop Sam John commented on HBASE-10771: How it looks now [~mcorgan] ? I just r

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978800#comment-13978800 ] Hadoop QA commented on HBASE-10771: --- {color:green}+1 overall{color}. Here are the resu

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977812#comment-13977812 ] Anoop Sam John commented on HBASE-10771: A BR impl backed by BB will be another c

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977080#comment-13977080 ] Matt Corgan commented on HBASE-10771: - {quote}Why BB compare ?{quote}i was thinking f

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976601#comment-13976601 ] Anoop Sam John commented on HBASE-10771: bq. maybe it should just return a primit

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965067#comment-13965067 ] Matt Corgan commented on HBASE-10771: - taking a look at patch_2 after a mention in HB

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955728#comment-13955728 ] stack commented on HBASE-10771: --- Thanks [~ndimiduk] And I like how you put it. My comment

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955385#comment-13955385 ] Nick Dimiduk commented on HBASE-10771: -- bq. Can we not resolve these difficulties us

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955379#comment-13955379 ] Nick Dimiduk commented on HBASE-10771: -- bq. I will note that only you seemed to rais

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955011#comment-13955011 ] Andrew Purtell commented on HBASE-10771: [~anoop.hbase] and [~ram_krish]: When pr

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955007#comment-13955007 ] Andrew Purtell commented on HBASE-10771: The problems with ByteBuffer as I see it

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954825#comment-13954825 ] Matt Corgan commented on HBASE-10771: - One of the problems with ByteBuffer is that it

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951750#comment-13951750 ] Anoop Sam John commented on HBASE-10771: Yes Stack.. write and read long is for m

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951747#comment-13951747 ] stack commented on HBASE-10771: --- bq. I agree it feels weird to add such basic functionality

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951743#comment-13951743 ] stack commented on HBASE-10771: --- [~ndimiduk] What upstream project you thinking? And what

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951738#comment-13951738 ] Matt Corgan commented on HBASE-10771: - I'm not sure what the best solution is either.

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951730#comment-13951730 ] ramkrishna.s.vasudevan commented on HBASE-10771: Actually I read this jav

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951166#comment-13951166 ] Anoop Sam John commented on HBASE-10771: Oh yes Stack.. We are violating.. My bad

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951143#comment-13951143 ] Nick Dimiduk commented on HBASE-10771: -- IMO, we're better off making use of an upstr

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951095#comment-13951095 ] stack commented on HBASE-10771: --- Why again is it that we don't just do ByteBuffer? ByteRan

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951100#comment-13951100 ] stack commented on HBASE-10771: --- Otherwise, the patch seems fine. bq. Adding of this kind

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950613#comment-13950613 ] ramkrishna.s.vasudevan commented on HBASE-10771: +1 on patch. > Primiti

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950599#comment-13950599 ] Anoop Sam John commented on HBASE-10771: What do u say abt above reply [~stack]?

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947764#comment-13947764 ] ramkrishna.s.vasudevan commented on HBASE-10771: Yes we need in my opinio

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947760#comment-13947760 ] Anoop Sam John commented on HBASE-10771: Also getBytes() call on an offheap impl

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947544#comment-13947544 ] Anoop Sam John commented on HBASE-10771: bq. Now we have to have two code paths..

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946814#comment-13946814 ] stack commented on HBASE-10771: --- bq. Added API which is equivalent to BB#hasArray(). Is th

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946737#comment-13946737 ] Hadoop QA commented on HBASE-10771: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945864#comment-13945864 ] stack commented on HBASE-10771: --- vints good.. just not hadoop vints. Copy/paste the pb vin

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945850#comment-13945850 ] Andrew Purtell commented on HBASE-10771: bq. I would prefer putInt, putShort() st

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945794#comment-13945794 ] stack commented on HBASE-10771: --- The hadoop vint code gets bad review http://grepcode.com/

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945212#comment-13945212 ] Nick Dimiduk commented on HBASE-10771: -- bq. Encode or decode in place of zero-compre

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944845#comment-13944845 ] ramkrishna.s.vasudevan commented on HBASE-10771: bq. If u strongly feel o

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944790#comment-13944790 ] ramkrishna.s.vasudevan commented on HBASE-10771: bq.We have this ,get(int

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944787#comment-13944787 ] Anoop Sam John commented on HBASE-10771: bq.I think we could name the put() as pu

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944784#comment-13944784 ] ramkrishna.s.vasudevan commented on HBASE-10771: Like we have shallowCopy

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944779#comment-13944779 ] ramkrishna.s.vasudevan commented on HBASE-10771: I think we could name th

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944405#comment-13944405 ] Anoop Sam John commented on HBASE-10771: That should be good to add Andy. If no

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944245#comment-13944245 ] Matt Corgan commented on HBASE-10771: - Looks ok to me > Primitive type put/get APIs

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944173#comment-13944173 ] Andrew Purtell commented on HBASE-10771: bq. Any more types support needed Sinc

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944092#comment-13944092 ] Anoop Sam John commented on HBASE-10771: Ping [~mcorgan] Any more types support n

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943739#comment-13943739 ] Nick Dimiduk commented on HBASE-10771: -- Boilerplate looks good to me ;) +1 > Primi

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943357#comment-13943357 ] Hadoop QA commented on HBASE-10771: --- {color:red}-1 overall{color}. Here are the result

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938140#comment-13938140 ] Matt Corgan commented on HBASE-10771: - Nick, I think I was mainly concerned about Byt

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938001#comment-13938001 ] Andrew Purtell commented on HBASE-10771: I suppose we could create a class ByteRa

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937989#comment-13937989 ] Andrew Purtell commented on HBASE-10771: Well then you will force us to not use B

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937983#comment-13937983 ] Nick Dimiduk commented on HBASE-10771: -- Correct me if I'm wrong, [~mcorgan], but my

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937964#comment-13937964 ] Andrew Purtell commented on HBASE-10771: +1 necessary next step > Primitive type

[jira] [Commented] (HBASE-10771) Primitive type put/get APIs in ByteRange

[ https://issues.apache.org/jira/browse/HBASE-10771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937583#comment-13937583 ] ramkrishna.s.vasudevan commented on HBASE-10771: bq.also discussion under