[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957366#comment-15957366
]
Hadoop QA commented on HBASE-13981:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338383#comment-15338383
]
Hadoop QA commented on HBASE-13981:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633398#comment-14633398
]
ramkrishna.s.vasudevan commented on HBASE-13981:
True that it is not
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633474#comment-14633474
]
Ashish Singhi commented on HBASE-13981:
---
Sounds good to me too.
Fix ImportTsv
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14633442#comment-14633442
]
Anoop Sam John commented on HBASE-13981:
+1 to move the Key and default value
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634344#comment-14634344
]
Gabor Liptak commented on HBASE-13981:
--
Would this refactor be done in a followup
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632772#comment-14632772
]
Ashish Singhi commented on HBASE-13981:
---
Looks like it was added as part of
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632505#comment-14632505
]
Hadoop QA commented on HBASE-13981:
---
{color:green}+1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632554#comment-14632554
]
Ashish Singhi commented on HBASE-13981:
---
bq. I do not see references to
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14632562#comment-14632562
]
Gabor Liptak commented on HBASE-13981:
--
[~ashish singhi] I might have missed
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627377#comment-14627377
]
Gabor Liptak commented on HBASE-13981:
--
[~appy] I reformatted the patch. Thanks
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627391#comment-14627391
]
Apekshit Sharma commented on HBASE-13981:
-
Great, comments are fixed and existing
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627454#comment-14627454
]
Apekshit Sharma commented on HBASE-13981:
-
[~gliptak] Yeah, you're right.
+1.
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14627408#comment-14627408
]
Gabor Liptak commented on HBASE-13981:
--
[~appy] As I mentioned above, I do not see
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615940#comment-14615940
]
Apekshit Sharma commented on HBASE-13981:
-
[~gliptak] not sure why
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615783#comment-14615783
]
Gabor Liptak commented on HBASE-13981:
--
[~appy] I uploaded an updated version. I
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611407#comment-14611407
]
Apekshit Sharma commented on HBASE-13981:
-
Thanks for doing additional changes
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611069#comment-14611069
]
Gabor Liptak commented on HBASE-13981:
--
I opened HBASE-14009 to have a backward
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606060#comment-14606060
]
Apekshit Sharma commented on HBASE-13981:
-
While you are at it, maybe fix that
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605202#comment-14605202
]
Anoop Sam John commented on HBASE-13981:
That make sense to me [~ashish singhi].
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604951#comment-14604951
]
Hadoop QA commented on HBASE-13981:
---
{color:red}-1 overall{color}. Here are the
[
https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605170#comment-14605170
]
Ashish Singhi commented on HBASE-13981:
---
The patch changes configuration property
22 matches
Mail list logo
