[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011377#comment-15011377
]
Ted Yu commented on HBASE-14575:
The description from 04/Nov/15 09:00 is mostly accurate:
w.r.t. #4 swap
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011388#comment-15011388
]
stack commented on HBASE-14575:
---
bq. The explanation is pretty long. How about putting the explanation in
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011412#comment-15011412
]
stack commented on HBASE-14575:
---
bq. Browsed some region server log but didn't find exception related to
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011398#comment-15011398
]
Ted Yu commented on HBASE-14575:
Browsed some region server log but didn't find exception related to
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011418#comment-15011418
]
Ted Yu commented on HBASE-14575:
bq. with description of logging regime
You meant 'locking regime', I
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011560#comment-15011560
]
Devaraj Das commented on HBASE-14575:
-
Hmm.. On the unit test, I am not sure it's going to be very
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010625#comment-15010625
]
Hadoop QA commented on HBASE-14575:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15009708#comment-15009708
]
Jerry He commented on HBASE-14575:
--
The v6 patch is clean and bold. Based on the discussion in this
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010325#comment-15010325
]
ramkrishna.s.vasudevan commented on HBASE-14575:
bq.However, before compaction selection,
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010379#comment-15010379
]
stack commented on HBASE-14575:
---
Can we have more test runs please given weird hanging MR tests.
Is the
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007323#comment-15007323
]
Hadoop QA commented on HBASE-14575:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007457#comment-15007457
]
Ted Yu commented on HBASE-14575:
Fetching
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007713#comment-15007713
]
Hadoop QA commented on HBASE-14575:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007722#comment-15007722
]
Ted Yu commented on HBASE-14575:
Ran ITBLL and IntegrationTestBulkLoad with patch v6 on 6 region server
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007979#comment-15007979
]
Ted Yu commented on HBASE-14575:
Patch v6 QA run was clean.
The test failure above is to show what
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007915#comment-15007915
]
Ted Yu commented on HBASE-14575:
>From
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007935#comment-15007935
]
Enis Soztutar commented on HBASE-14575:
---
So it the test failure related?
Agreed that the sync on
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007879#comment-15007879
]
Hadoop QA commented on HBASE-14575:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003903#comment-15003903
]
ramkrishna.s.vasudevan commented on HBASE-14575:
Then it is good. So I don't think you
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003711#comment-15003711
]
ramkrishna.s.vasudevan commented on HBASE-14575:
Am fine with this patch. Just thought of
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003717#comment-15003717
]
Devaraj Das commented on HBASE-14575:
-
I am fine with that [~ram_krish]
> Reduce scope of
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003706#comment-15003706
]
Devaraj Das commented on HBASE-14575:
-
[~jinghe] yeah from my read of things, seems you are right. So
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003838#comment-15003838
]
Ted Yu commented on HBASE-14575:
In HRegion#doClose():
{code}
writestate.writesEnabled = false;
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000966#comment-15000966
]
Devaraj Das commented on HBASE-14575:
-
Don't we need region level write lock to make sure the
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000902#comment-15000902
]
Ted Yu commented on HBASE-14575:
For #4. swap in compacted files, HStore#compact() calls
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001204#comment-15001204
]
Jerry He commented on HBASE-14575:
--
bulk load and compaction don't conflict with against each other on
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997892#comment-14997892
]
Enis Soztutar commented on HBASE-14575:
---
That test scale is pretty small BTW.
> Reduce scope of
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997812#comment-14997812
]
Ted Yu commented on HBASE-14575:
Thanks for the review, Ram.
Let me think about your suggestion.
I ran
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996404#comment-14996404
]
ramkrishna.s.vasudevan commented on HBASE-14575:
Going thro the code and the patch I
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989905#comment-14989905
]
Ted Yu commented on HBASE-14575:
We are trying to remove / relax the region read lock for compaction.
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987797#comment-14987797
]
Hadoop QA commented on HBASE-14575:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987609#comment-14987609
]
stack commented on HBASE-14575:
---
You saw my comments [~ted_yu] I repeat main thrust below:
bq. The
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987615#comment-14987615
]
Ted Yu commented on HBASE-14575:
Yes, I did see the above comment.
Preparation of such paragraph is
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986622#comment-14986622
]
Jerry He commented on HBASE-14575:
--
There is a complex logic with the writestate in HRegion:
{code}
/*
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986635#comment-14986635
]
Ted Yu commented on HBASE-14575:
In HRegion#doClose(), we have :
{code}
synchronized (writestate) {
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985149#comment-14985149
]
ramkrishna.s.vasudevan commented on HBASE-14575:
bq.readLock.lock(); // hold region open
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984739#comment-14984739
]
ramkrishna.s.vasudevan commented on HBASE-14575:
Thanks Ted. My bad. I missed that. True
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984784#comment-14984784
]
Jerry He commented on HBASE-14575:
--
As [~ndimiduk] mentioned, we've been doing a lot of checks for close
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983878#comment-14983878
]
ramkrishna.s.vasudevan commented on HBASE-14575:
Just trying to understand the scope of
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983963#comment-14983963
]
Ted Yu commented on HBASE-14575:
bq. this patch should remove the read lock in the HRegion.compact()
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984073#comment-14984073
]
stack commented on HBASE-14575:
---
The original author says of the approach "... I'm not sure if it's
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983449#comment-14983449
]
Ted Yu commented on HBASE-14575:
{code}
[ERROR] Failed to execute goal
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983719#comment-14983719
]
Hadoop QA commented on HBASE-14575:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983436#comment-14983436
]
Hadoop QA commented on HBASE-14575:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14983101#comment-14983101
]
Ted Yu commented on HBASE-14575:
Without the lock scope reduction, the test fails with:
{code}
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975728#comment-14975728
]
Hadoop QA commented on HBASE-14575:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957943#comment-14957943
]
Devaraj Das commented on HBASE-14575:
-
[~yuzhih...@gmail.com] what's the patch about?
> Reduce scope
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957974#comment-14957974
]
Ted Yu commented on HBASE-14575:
Looks like Nick is busy.
Patch v1 fixes a few mockito errors in the
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958193#comment-14958193
]
Hadoop QA commented on HBASE-14575:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14955946#comment-14955946
]
Devaraj Das commented on HBASE-14575:
-
[~ndimiduk] wondering if you have any update on the testing on
[
https://issues.apache.org/jira/browse/HBASE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949112#comment-14949112
]
Devaraj Das commented on HBASE-14575:
-
[~ndimiduk] the change looks easy to reason about, and it'll
51 matches
Mail list logo
