[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201166#comment-16201166
]
Jerry He commented on HBASE-16010:
--
I am going to close this ticket and post a patch on HBASE-10367,
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16183340#comment-16183340
]
Jerry He commented on HBASE-16010:
--
I'd like to get a closure on this ticket. I am ready to add the
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905501#comment-15905501
]
Jerry He commented on HBASE-16010:
--
I was trying to give myself more time to think, but forgot to get
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905034#comment-15905034
]
Ashish Singhi commented on HBASE-16010:
---
I see this jira is in reopened state but the patch code is
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15797412#comment-15797412
]
Appy commented on HBASE-16010:
--
bq. There is currently a slight difference between 'drain mode' and
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796881#comment-15796881
]
Jerry He commented on HBASE-16010:
--
This is good plan, if I missed it earlier!
Ok. let us change the
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796815#comment-15796815
]
Enis Soztutar commented on HBASE-16010:
---
I actually want to fix the drain script, move away from it
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796779#comment-15796779
]
Jerry He commented on HBASE-16010:
--
bq. Would be great to use Enis's above suggestion. Instead of
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795329#comment-15795329
]
Appy commented on HBASE-16010:
--
Sorry for late review, was away on vacation. Please consider making
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779161#comment-15779161
]
Jerry He commented on HBASE-16010:
--
I think it should require global admin, similar to the 'balance'
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778964#comment-15778964
]
Matt Warhaftig commented on HBASE-16010:
{quote}
"Matt Warhaftig, would you like to work on the
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15774194#comment-15774194
]
Hudson commented on HBASE-16010:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2187 (See
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773763#comment-15773763
]
Jerry He commented on HBASE-16010:
--
Committed to master. v3 is the committed version with the mentioned
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773507#comment-15773507
]
Jerry He commented on HBASE-16010:
--
Thanks, [~enis].
Created the subtasks.
bq. GetDrainingServers
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771486#comment-15771486
]
Enis Soztutar commented on HBASE-16010:
---
bq. Let me open a subtask right away and make sure it will
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768204#comment-15768204
]
Jerry He commented on HBASE-16010:
--
Hi, [~enis]
bq. I think we should have the ACL changes in this
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768178#comment-15768178
]
Jerry He commented on HBASE-16010:
--
bq. MasterRpcServices already has a ServerName import entry
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15767918#comment-15767918
]
Enis Soztutar commented on HBASE-16010:
---
I think we should have the ACL changes in this patch as
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15767600#comment-15767600
]
Matt Warhaftig commented on HBASE-16010:
Thanks Jerry, Feel free to fix the first issue and
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766128#comment-15766128
]
Jerry He commented on HBASE-16010:
--
Can fix on commit.
> Put draining function through Admin API
>
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766066#comment-15766066
]
Jerry He commented on HBASE-16010:
--
+1
Some nit.
In HBaseAdmin, two places:
{noformat}
+
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15765646#comment-15765646
]
Matt Warhaftig commented on HBASE-16010:
[~jinghe],
Can you or someone else please review the
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760183#comment-15760183
]
Hadoop QA commented on HBASE-16010:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687746#comment-15687746
]
Hadoop QA commented on HBASE-16010:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687741#comment-15687741
]
Jerry He commented on HBASE-16010:
--
[~mwarhaftig]
Could you do a rebase with the latest master? The
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360411#comment-15360411
]
Jerry He commented on HBASE-16010:
--
Patch lgtm.
We need a follow-on patch to add ACL to the APIs.
>
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337387#comment-15337387
]
Hadoop QA commented on HBASE-16010:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328275#comment-15328275
]
Matt Warhaftig commented on HBASE-16010:
{quote}
"or was the method supposed to be a List
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328274#comment-15328274
]
Enis Soztutar commented on HBASE-16010:
---
bq. I don't remember anything in the AM or ServerManager
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327817#comment-15327817
]
Jerry He commented on HBASE-16010:
--
Concur with Matteo. We can probably use similar API names as in the
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327694#comment-15327694
]
Matteo Bertozzi commented on HBASE-16010:
-
how does the getDrainingRegions() works? doesn't this
[
https://issues.apache.org/jira/browse/HBASE-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15326049#comment-15326049
]
Matt Warhaftig commented on HBASE-16010:
Proposed Admin drain methods and signatures:
Drain
32 matches
Mail list logo
