[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670240#comment-15670240
]
Sean Busbey commented on HBASE-16972:
-
{quote}
Strong objections Sean Busbey? I guess it's already
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669871#comment-15669871
]
Yu Li commented on HBASE-16972:
---
Thanks for the confirmation [~ndimiduk], just let me know if any action to
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15669687#comment-15669687
]
Nick Dimiduk commented on HBASE-16972:
--
Change appears only to add new fields to a json-ish blob, so
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656484#comment-15656484
]
Hudson commented on HBASE-16972:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #65 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15656165#comment-15656165
]
Hudson commented on HBASE-16972:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #77 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642062#comment-15642062
]
Hudson commented on HBASE-16972:
FAILURE: Integrated in Jenkins build HBase-1.1-JDK7 #1813 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641994#comment-15641994
]
Hudson commented on HBASE-16972:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #58 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641845#comment-15641845
]
Hudson commented on HBASE-16972:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #64 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638958#comment-15638958
]
Yu Li commented on HBASE-16972:
---
Ok, seems no objections for branch-1.1/1.2, will backport HBASE-16033 and
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632166#comment-15632166
]
Yu Li commented on HBASE-16972:
---
Created HBASE-17011 for later backport for branch-1.3
For branch-1.1/1.2,
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632149#comment-15632149
]
Yu Li commented on HBASE-16972:
---
Agreed, let me file a backport JIRA, thanks for the clarification sir.
>
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631891#comment-15631891
]
Mikhail Antonov commented on HBASE-16972:
-
[~carp84] I totally share and support the aspiration
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631514#comment-15631514
]
Yu Li commented on HBASE-16972:
---
We (Alibaba search) are considering upgrade to 1.3.0 when it's out so the
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631502#comment-15631502
]
stack commented on HBASE-16972:
---
I think this a good change [~busbey] Makes a message that looks like it
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15631494#comment-15631494
]
Yu Li commented on HBASE-16972:
---
bq. What's the total change in log message appearance with HBASE-16033 and
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630769#comment-15630769
]
Mikhail Antonov commented on HBASE-16972:
-
I'd target for 2.0.0, 1.4.0 and 1.3.1 then (unsure of
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630766#comment-15630766
]
Mikhail Antonov commented on HBASE-16972:
-
+1 on the patch in general. I wouldn't want to get it
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15630703#comment-15630703
]
Sean Busbey commented on HBASE-16972:
-
I'd rather not change the format of existing log lines on a
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629845#comment-15629845
]
Hudson commented on HBASE-16972:
FAILURE: Integrated in Jenkins build HBase-1.4 #512 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628682#comment-15628682
]
Hudson commented on HBASE-16972:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1901 (See
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15626243#comment-15626243
]
Hadoop QA commented on HBASE-16972:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625950#comment-15625950
]
stack commented on HBASE-16972:
---
+1
> Log more details for Scan#next request when responseTooSlow
>
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625894#comment-15625894
]
Yu Li commented on HBASE-16972:
---
I see, was a little bit confused about what comment to add but clear now.
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625859#comment-15625859
]
stack commented on HBASE-16972:
---
+1 (add comment on commit)
> Log more details for Scan#next request when
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625855#comment-15625855
]
stack commented on HBASE-16972:
---
Yes. RpcServer ipc package should not have regionserver package stuff in
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625840#comment-15625840
]
Yu Li commented on HBASE-16972:
---
Thanks for the note [~anoop.hbase], you are right, let me update the patch
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625798#comment-15625798
]
Yu Li commented on HBASE-16972:
---
Thanks for the note [~anoop.hbase], let me check.
> Log more details for
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625777#comment-15625777
]
Anoop Sam John commented on HBASE-16972:
RpcServer is marked LimitedPrivate and exposed to
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625679#comment-15625679
]
Yu Li commented on HBASE-16972:
---
bq. I don't like the pollution of RpcServer with notions of Region,
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625586#comment-15625586
]
stack commented on HBASE-16972:
---
Ok. Thanks for checking. +1 on the patch. I don't like the pollution of
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624843#comment-15624843
]
Yu Li commented on HBASE-16972:
---
I've also checked the lines printing above trace log, it's
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624834#comment-15624834
]
Yu Li commented on HBASE-16972:
---
I'm afraid we only have such information for openScanner call and don't
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624464#comment-15624464
]
stack commented on HBASE-16972:
---
One suggestion is that you have the ScanRequest protobuf. Elsewhere in
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624153#comment-15624153
]
Yu Li commented on HBASE-16972:
---
bq. Does RpcServer have to have direct references to import
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624143#comment-15624143
]
Yu Li commented on HBASE-16972:
---
Yes, for the first scan request ({{ScannerCallable#openScanner}} or
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622897#comment-15622897
]
stack commented on HBASE-16972:
---
+1 for the sentiment (more info when slow response).
Does RpcServer have
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622864#comment-15622864
]
Jerry He commented on HBASE-16972:
--
The new extra info looks good!
Minor: For the scan request without
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622687#comment-15622687
]
Ted Yu commented on HBASE-16972:
lgtm
> Log more details for Scan#next request when responseTooSlow
>
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621490#comment-15621490
]
Yu Li commented on HBASE-16972:
---
HadoopQA report looks good, the timed out UT cases are known flaky ones
[
https://issues.apache.org/jira/browse/HBASE-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621389#comment-15621389
]
Hadoop QA commented on HBASE-16972:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
40 matches
Mail list logo
