[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139257#comment-16139257
]
Ted Yu commented on HBASE-17442:
I got the following when building:
{code}
[ERROR] [ERROR] Some problems
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139199#comment-16139199
]
Appy commented on HBASE-17442:
--
Pushed to master. Uploading patch for branch-2, will wait for precommit
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139182#comment-16139182
]
Appy commented on HBASE-17442:
--
[~stack] and I went over the pom file together to cleanup unwanted stuff.
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139074#comment-16139074
]
Appy commented on HBASE-17442:
--
This patch is moving replication stuff in hbase-client to new module. There
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138011#comment-16138011
]
Ashish Singhi commented on HBASE-17442:
---
Great work..
We are not moving replication related test
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137793#comment-16137793
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137789#comment-16137789
]
Appy commented on HBASE-17442:
--
Finally! Wohooo!
Please help with the pom.xml [~stack]. Uploading on RB.
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137742#comment-16137742
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137301#comment-16137301
]
Appy commented on HBASE-17442:
--
The last run was with the fix too, but retry sounds good.
> Move most of
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136918#comment-16136918
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136524#comment-16136524
]
Appy commented on HBASE-17442:
--
v003
Rebased to latest master which has timed out tests fix.
> Move most of
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136128#comment-16136128
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135637#comment-16135637
]
stack commented on HBASE-17442:
---
I applied the patch and tried running some of the above failed unit tests.
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135145#comment-16135145
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134627#comment-16134627
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134320#comment-16134320
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133964#comment-16133964
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133949#comment-16133949
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133819#comment-16133819
]
Guanghao Zhang commented on HBASE-17442:
It will be great if we can move all replication classes
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133802#comment-16133802
]
Appy commented on HBASE-17442:
--
btw, i tried looking around hbase-server/.../replication/*.java classes to
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133799#comment-16133799
]
Appy commented on HBASE-17442:
--
Uploaded new patch which is same as [~zghaobac]'s except that we are moving
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133705#comment-16133705
]
stack commented on HBASE-17442:
---
Sounds good @appy. Thanks for doing research. Lets commit and open a new
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133696#comment-16133696
]
Appy commented on HBASE-17442:
--
The only two methods (peerAdded and listReplicationPeers) this patch is
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119433#comment-16119433
]
Guanghao Zhang commented on HBASE-17442:
If we can't remove the public method
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119370#comment-16119370
]
Guanghao Zhang commented on HBASE-17442:
bq. Do we expect users to move to latest branch-1
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109753#comment-16109753
]
Andrew Purtell commented on HBASE-17442:
bq. Do we expect users to move to latest branch-1
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106658#comment-16106658
]
stack commented on HBASE-17442:
---
Good stuff. Let me take on starting a DISCUSS thread on dev.
Yeah, I
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100176#comment-16100176
]
Sean Busbey commented on HBASE-17442:
-
{quote}
Because we want to fix this in hbase 2.0, I thought
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100157#comment-16100157
]
Ashish Singhi commented on HBASE-17442:
---
Do we except client to move to latest branch-1 release
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097872#comment-16097872
]
Guanghao Zhang commented on HBASE-17442:
[~ashish singhi]. Thanks for your review. Because we
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097633#comment-16097633
]
Ashish Singhi commented on HBASE-17442:
---
bq. So I add a patch which more them to hbase-server
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091007#comment-16091007
]
Guanghao Zhang commented on HBASE-17442:
Ping [~stack] [~enis] [~ashish singhi] for reviewing.
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087263#comment-16087263
]
Guanghao Zhang commented on HBASE-17442:
[~stack] [~enis] Any concerns?
> Move most of the
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086942#comment-16086942
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085666#comment-16085666
]
Guanghao Zhang commented on HBASE-17442:
bq. Plan is to first move it to hbase-server package and
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085498#comment-16085498
]
Ashish Singhi commented on HBASE-17442:
---
Plan is to first move it to hbase-server package and then
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085406#comment-16085406
]
Guanghao Zhang commented on HBASE-17442:
Ping [~stack] [~enis] [~ashish singhi] for reviewing.
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085378#comment-16085378
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085207#comment-16085207
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083988#comment-16083988
]
Guanghao Zhang commented on HBASE-17442:
[~stack] I attach a v1 patch which only move the
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083940#comment-16083940
]
Hadoop QA commented on HBASE-17442:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071440#comment-16071440
]
stack commented on HBASE-17442:
---
Or hang on... let me try and make a replication module.
> Move most
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070498#comment-16070498
]
stack commented on HBASE-17442:
---
Ok [~zghaobac] Makes sense.
> Move most of the replication related
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070141#comment-16070141
]
Guanghao Zhang commented on HBASE-17442:
As the parent issue was marked Critical, it is time to
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856859#comment-15856859
]
Enis Soztutar commented on HBASE-17442:
---
Sorry missed this. Agreed with the plan. However, if the
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855980#comment-15855980
]
Guanghao Zhang commented on HBASE-17442:
[~stack] Thanks for your help, sir. Now the job of
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821547#comment-15821547
]
Ashish Singhi commented on HBASE-17442:
---
bq. could we move them to an hbase-replication module
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821053#comment-15821053
]
Guanghao Zhang commented on HBASE-17442:
[~stack] I agree with this. Thanks for your help. :)
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819703#comment-15819703
]
stack commented on HBASE-17442:
---
+1 on what [~busbey] says [~zghaobac] Let me know if you want a skeleton
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818763#comment-15818763
]
Sean Busbey commented on HBASE-17442:
-
precommit runs unit tests in any module that has changed. so
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817025#comment-15817025
]
Guanghao Zhang commented on HBASE-17442:
Now we don't have a hbase-replication module, it means
[
https://issues.apache.org/jira/browse/HBASE-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815032#comment-15815032
]
Sean Busbey commented on HBASE-17442:
-
could we move them to an hbase-replication module instead?
52 matches
Mail list logo