[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-05-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997940#comment-15997940 ] Duo Zhang commented on HBASE-17712: --- Oh we have HBASE-2231 which is aimed to fix the file not found

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-08 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902518#comment-15902518 ] Duo Zhang commented on HBASE-17712: --- {quote} Does the FNFE have the file name in it? {quote} I believe

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-08 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902508#comment-15902508 ] stack commented on HBASE-17712: --- +1 on patch. Nit: Change this ' LOG.warn("A store file got lost",

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901186#comment-15901186 ] Hudson commented on HBASE-17712: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2634 (See

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-08 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15901066#comment-15901066 ] Hudson commented on HBASE-17712: FAILURE: Integrated in Jenkins build HBase-1.4 #659 (See

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900785#comment-15900785 ] Duo Zhang commented on HBASE-17712: --- The failed UTs are unrelated and can pass locally. Will commit

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900771#comment-15900771 ] Hadoop QA commented on HBASE-17712: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-07 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899376#comment-15899376 ] Duo Zhang commented on HBASE-17712: --- Will commit tomorrow if no objections. Then I could start working

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-06 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898535#comment-15898535 ] Duo Zhang commented on HBASE-17712: --- What do you think of the new approach sir? [~stack] Thanks. >

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897471#comment-15897471 ] Hadoop QA commented on HBASE-17712: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897174#comment-15897174 ] Hadoop QA commented on HBASE-17712: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896259#comment-15896259 ] Duo Zhang commented on HBASE-17712: --- Yeah there could still be holes that the RS pauses after writing

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-04 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895761#comment-15895761 ] stack commented on HBASE-17712: --- This patch looks excellent. Tried to reason if any 'holes' such that we

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895752#comment-15895752 ] Hadoop QA commented on HBASE-17712: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895691#comment-15895691 ] Hadoop QA commented on HBASE-17712: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894707#comment-15894707 ] Hadoop QA commented on HBASE-17712: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894490#comment-15894490 ] Duo Zhang commented on HBASE-17712: --- [~stack] The UT is ready sir. If you agree, I can start working on

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894234#comment-15894234 ] Duo Zhang commented on HBASE-17712: --- Yeah I'm currently working on implementing the tests to prove that

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-02 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893086#comment-15893086 ] stack commented on HBASE-17712: --- bq. This not Ted Yu's fault. Not much interested in 'blame'; asking for

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-01 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890495#comment-15890495 ] Ted Yu commented on HBASE-17712: Added a note at the end of HBASE-16304. As Duo pointed out,

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890163#comment-15890163 ] Duo Zhang commented on HBASE-17712: --- This not [~tedyu]'s fault. Skimmed the comments in HBASE-16304, I

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889990#comment-15889990 ] stack commented on HBASE-17712: --- bq. What happens if there is a flush ongoing at the same time? I see.

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889918#comment-15889918 ] Duo Zhang commented on HBASE-17712: --- {quote} Want to give an illustration of what in particular is

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-03-01 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889894#comment-15889894 ] stack commented on HBASE-17712: --- bq. I think sequence id accounting is your favorite part in HBase. Thats

[jira] [Commented] (HBASE-17712) Remove/Simplify the logic of RegionScannerImpl.handleFileNotFound

2017-02-28 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889676#comment-15889676 ] Duo Zhang commented on HBASE-17712: --- This makes me crazy when implementing HBASE-17633 as the sequence