[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427897#comment-16427897
]
stack commented on HBASE-18175:
---
Reverted from branch-2/2.0.0 by HBASE-18817
> Add hbase-spark integration
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090291#comment-16090291
]
Hudson commented on HBASE-18175:
FAILURE: Integrated in Jenkins build HBASE-14070.HLC #69 (See
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088331#comment-16088331
]
Hudson commented on HBASE-18175:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #3376 (See
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088317#comment-16088317
]
Hudson commented on HBASE-18175:
FAILURE: Integrated in Jenkins build HBase-2.0 #174 (See
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087947#comment-16087947
]
Hudson commented on HBASE-18175:
FAILURE: Integrated in Jenkins build HBase-2.0 #173 (See
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087815#comment-16087815
]
Hadoop QA commented on HBASE-18175:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087735#comment-16087735
]
Hudson commented on HBASE-18175:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3375 (See
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087693#comment-16087693
]
Yi Liang commented on HBASE-18175:
--
And I think I also need to change the usage in source code comments,
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087687#comment-16087687
]
Yi Liang commented on HBASE-18175:
--
Hi Sean,
I run it on cluster before attache V9, since I add
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087653#comment-16087653
]
Sean Busbey commented on HBASE-18175:
-
I suspect we probably need to add some additional jars too,
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087643#comment-16087643
]
Sean Busbey commented on HBASE-18175:
-
yes, good catch.
> Add hbase-spark integration test into
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087638#comment-16087638
]
Mike Drob commented on HBASE-18175:
---
On the release note:
{{spark-submit --class
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086693#comment-16086693
]
Mike Drob commented on HBASE-18175:
---
To clarify, I think you've iterated a lot on this patch already
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086579#comment-16086579
]
Yi Liang commented on HBASE-18175:
--
{quote}Please file a follow on JIRA to combine the configuration
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086228#comment-16086228
]
Sean Busbey commented on HBASE-18175:
-
yeah, branch-1 is waiting for the scope doc from me
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085966#comment-16085966
]
Mike Drob commented on HBASE-18175:
---
+1.
QA Test failure is unrelated and known to be flaky.
Please
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085110#comment-16085110
]
Hadoop QA commented on HBASE-18175:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077755#comment-16077755
]
Mike Drob commented on HBASE-18175:
---
hbase-spark-it/pom.xml uses {{maven.assembly.version}} but it's
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075377#comment-16075377
]
Hadoop QA commented on HBASE-18175:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070386#comment-16070386
]
Yi Liang commented on HBASE-18175:
--
oh, it's my bad, will change it back soon.
> Add hbase-spark
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16070316#comment-16070316
]
Mike Drob commented on HBASE-18175:
---
findbugs declaration of going two directories up needs to be
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069143#comment-16069143
]
Yi Liang commented on HBASE-18175:
--
I have add hbase-spark-it as dependency into hbase-assembly/pom.xml,
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068835#comment-16068835
]
Sean Busbey commented on HBASE-18175:
-
(to repro the above, do a build prior to running the given
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068831#comment-16068831
]
Sean Busbey commented on HBASE-18175:
-
Trying to build the source archive failed:
{code}
$ mvn
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068830#comment-16068830
]
Hadoop QA commented on HBASE-18175:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068789#comment-16068789
]
Mike Drob commented on HBASE-18175:
---
You're right, Sean. Adding to assembly descriptor was not enough,
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068779#comment-16068779
]
Sean Busbey commented on HBASE-18175:
-
Looks like we don't end up with anything in the binary
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068744#comment-16068744
]
Sean Busbey commented on HBASE-18175:
-
I would be very surprised if branch-2 has diverged enough from
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068687#comment-16068687
]
Yi Liang commented on HBASE-18175:
--
Thanks Sean, Do I also need to provide patch for branch 2 ?
> Add
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068644#comment-16068644
]
Sean Busbey commented on HBASE-18175:
-
I'm set to push this once my local test passes. I'm confident
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068617#comment-16068617
]
Mike Drob commented on HBASE-18175:
---
+1! Thanks for sticking with this, [~easyliangjob]
> Add
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068551#comment-16068551
]
Yi Liang commented on HBASE-18175:
--
change above to .equals(). Thanks for your review :), Mike
> Add
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16068466#comment-16068466
]
Mike Drob commented on HBASE-18175:
---
{noformat}
return this.getRk() == otherKey.getRk() &&
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067002#comment-16067002
]
Yi Liang commented on HBASE-18175:
--
Hi Mike,
The reason why the test fails is that I reuse the static
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066693#comment-16066693
]
Mike Drob commented on HBASE-18175:
---
QA Test failure is unrelated.
Verified IT locally with {{mvn
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065489#comment-16065489
]
Yi Liang commented on HBASE-18175:
--
Hi [~mdrob],
It finally pass the findbugs warnig, ;),
And in
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065467#comment-16065467
]
Hadoop QA commented on HBASE-18175:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064127#comment-16064127
]
Mike Drob commented on HBASE-18175:
---
You need to specify that the exclude file is two directories up,
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064045#comment-16064045
]
Yi Liang commented on HBASE-18175:
--
[~mdrob]
Just found the command mvn findbugs:findbugs, I also try
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063980#comment-16063980
]
Hadoop QA commented on HBASE-18175:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063954#comment-16063954
]
Yi Liang commented on HBASE-18175:
--
Hi Mike,
Do you know which command is used to generate the
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063810#comment-16063810
]
Mike Drob commented on HBASE-18175:
---
Do we know why findbugs isn't working? I couldn't get it to save
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063719#comment-16063719
]
Yi Liang commented on HBASE-18175:
--
new patch attached, carry Mike's comments.
> Add hbase-spark
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063670#comment-16063670
]
Hadoop QA commented on HBASE-18175:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063558#comment-16063558
]
Yi Liang commented on HBASE-18175:
--
Hi Mike,
Thanks for reviewing and testing.
{quote}but this
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063470#comment-16063470
]
Mike Drob commented on HBASE-18175:
---
Should add the hbase-spark-it to the hbase-assembly as well,
[
https://issues.apache.org/jira/browse/HBASE-18175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16061824#comment-16061824
]
Yi Liang commented on HBASE-18175:
--
Hi Mike and Sean
In the new patch, I add hbase-spark-it as top
47 matches
Mail list logo
