[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256605#comment-16256605
]
Hudson commented on HBASE-18911:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4066 (See
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256532#comment-16256532
]
Hudson commented on HBASE-18911:
FAILURE: Integrated in Jenkins build HBase-2.0 #865 (See
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255458#comment-16255458
]
Peter Somogyi commented on HBASE-18911:
---
+1 from my side, good patch!
> Unify Admin and
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255452#comment-16255452
]
Hadoop QA commented on HBASE-18911:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255342#comment-16255342
]
Hadoop QA commented on HBASE-18911:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255132#comment-16255132
]
Guanghao Zhang commented on HBASE-18911:
Add to review board: https://reviews.apache.org/r/63873/
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255101#comment-16255101
]
Peter Somogyi commented on HBASE-18911:
---
[~zghaobac], could you upload it to ReviewBoard?
> Unify
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255086#comment-16255086
]
Hadoop QA commented on HBASE-18911:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245663#comment-16245663
]
Peter Somogyi commented on HBASE-18911:
---
Javadoc for Admin#setSplitOrMergeEnabled links to
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245205#comment-16245205
]
stack commented on HBASE-18911:
---
What you think of this mighty [~psomogyi] sir?
> Unify Admin and
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204772#comment-16204772
]
Hadoop QA commented on HBASE-18911:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204678#comment-16204678
]
Guanghao Zhang commented on HBASE-18911:
Attach a 001 patch which unified the methods names by
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202254#comment-16202254
]
Chia-Ping Tsai commented on HBASE-18911:
How many deprecated APIs will be added in this issue?
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201615#comment-16201615
]
Guanghao Zhang commented on HBASE-18911:
Take a look about the methods names about
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196070#comment-16196070
]
Chia-Ping Tsai commented on HBASE-18911:
bq. Keep these methods in AsyncAdmin?
It is ok if these
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196025#comment-16196025
]
Guanghao Zhang commented on HBASE-18911:
For deleteTables/enableTables/disableTables methods, how
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195806#comment-16195806
]
stack commented on HBASE-18911:
---
This is a great issue [~zghaobac] Thanks for starting it.
Related, over
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195719#comment-16195719
]
Chia-Ping Tsai commented on HBASE-18911:
Let us carry over the discussion in HBASE-18914 now.
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194070#comment-16194070
]
Chia-Ping Tsai commented on HBASE-18911:
Personally, I prefer the get/set/is pattern.
> Unify
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191221#comment-16191221
]
Guanghao Zhang commented on HBASE-18911:
Seems the *Switch methods were introduced by
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187245#comment-16187245
]
Guanghao Zhang commented on HBASE-18911:
[~chia7712] Got it. Update the unified name to
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187092#comment-16187092
]
Chia-Ping Tsai commented on HBASE-18911:
bq. getTableDescriptor is better than getDescriptor?
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187080#comment-16187080
]
Guanghao Zhang commented on HBASE-18911:
bq. should we add the methods which only exist in
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187015#comment-16187015
]
Chia-Ping Tsai commented on HBASE-18911:
{{Admin#listTables}} and {{Admin#getTableDescriptor}}
[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187009#comment-16187009
]
Guanghao Zhang commented on HBASE-18911:
IMO I suggest to use the method names in AsyncAdmin. Any
25 matches
Mail list logo
