[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280846#comment-16280846 ] Hudson commented on HBASE-19417: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4180 (See

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279683#comment-16279683 ] Ted Yu commented on HBASE-19417: You can see the two test failures here:

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279680#comment-16279680 ] Ted Yu commented on HBASE-19417: There was no occurrence of LoadIncrementalHFiles test in the latest

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279676#comment-16279676 ] Appy commented on HBASE-19417: -- *LoadIncrementalHFiles (related to this change) are not in flaky list though

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279624#comment-16279624 ] Ted Yu commented on HBASE-19417: Ran failed tests locally which passed. > Remove boolean return value

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279617#comment-16279617 ] Hadoop QA commented on HBASE-19417: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279606#comment-16279606 ] Hadoop QA commented on HBASE-19417: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279468#comment-16279468 ] Appy commented on HBASE-19417: -- +1 Great stuff. bq. It turns out that SecureBulkLoadManager.java has the

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279422#comment-16279422 ] Ted Yu commented on HBASE-19417: It turns out that SecureBulkLoadManager.java has the calls to pre / post

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279398#comment-16279398 ] Appy commented on HBASE-19417: -- The reason it should be removed is: with current set of two params - map and

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279339#comment-16279339 ] Ted Yu commented on HBASE-19417: bq. You can change postBulkLoadHFile() to get rid of hasLoaded variable

[jira] [Commented] (HBASE-19417) Remove boolean return value from postBulkLoadHFile hook

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16279320#comment-16279320 ] Appy commented on HBASE-19417: -- You can change postBulkLoadHFile() to get rid of hasLoaded variable, since