[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-26 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376561#comment-16376561 ] Hudson commented on HBASE-20065: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4651 (See

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376326#comment-16376326 ] Duo Zhang commented on HBASE-20065: --- Pushed an addendum to master and branch-2 which removes the wrong

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-25 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376007#comment-16376007 ] Duo Zhang commented on HBASE-20065: --- I always wonder why we need to set timestamp explicitly when

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-25 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376004#comment-16376004 ] stack commented on HBASE-20065: --- Nice cleanup. Why not let the server set the time rather than do it in

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375989#comment-16375989 ] Hudson commented on HBASE-20065: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4645 (See

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375557#comment-16375557 ] Hadoop QA commented on HBASE-20065: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375469#comment-16375469 ] Duo Zhang commented on HBASE-20065: --- Address the review comments, and also the failed UTs. > Revisit

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375462#comment-16375462 ] Duo Zhang commented on HBASE-20065: --- Filed HBASE-20067 for the findbugs warnings. > Revisit the

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375452#comment-16375452 ] Hadoop QA commented on HBASE-20065: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375423#comment-16375423 ] Zheng Hu commented on HBASE-20065: -- No other concerns except the above two. > Revisit the timestamp

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375418#comment-16375418 ] Duo Zhang commented on HBASE-20065: --- Use HConstants.LATEST_TIMESTAMP is almost the same with current

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-24 Thread Zheng Hu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375411#comment-16375411 ] Zheng Hu commented on HBASE-20065: -- #1 {code} /** * @param t Table to use (will be closed when

[jira] [Commented] (HBASE-20065) Revisit the timestamp usage in MetaTableAccessor

2018-02-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375367#comment-16375367 ] Duo Zhang commented on HBASE-20065: --- Must provide a timestamp when constructing a Put or Delete, and