[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025941#comment-14025941
]
stack commented on HBASE-4199:
--
This was never hooked up unfortunately. Removed as part of H
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089229#comment-13089229
]
Hudson commented on HBASE-4199:
---
Integrated in HBase-TRUNK #2131 (See
[https://builds.apach
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089121#comment-13089121
]
Ted Yu commented on HBASE-4199:
---
Integrated to TRUNK.
Thanks for the patch Doug.
Thanks for
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089104#comment-13089104
]
Jean-Daniel Cryans commented on HBASE-4199:
---
Still +1, good work!
> blockCache
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088307#comment-13088307
]
Ted Yu commented on HBASE-4199:
---
Patch version 4 is in a commit-table state.
Minor comment
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087956#comment-13087956
]
Doug Meil commented on HBASE-4199:
--
Fair enough. In my defense, I did change writable me
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087948#comment-13087948
]
stack commented on HBASE-4199:
--
On 3., you can't use 'auto-gen' as excuse (smile). Fix your
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087923#comment-13087923
]
Doug Meil commented on HBASE-4199:
--
Also, RS interface changed to return List instead of
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087670#comment-13087670
]
Doug Meil commented on HBASE-4199:
--
Thanks Stack!
1. I'll change the class to BlockCach
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087475#comment-13087475
]
stack commented on HBASE-4199:
--
On 1., BlockCacheColumnFamilySummary? CF needs the table to
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087474#comment-13087474
]
stack commented on HBASE-4199:
--
On 1., BlockCacheColumnFamilySummary? CF needs the table to
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087469#comment-13087469
]
Doug Meil commented on HBASE-4199:
--
1. BlockCacheSummaryEntry name
I'm struggling
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087302#comment-13087302
]
stack commented on HBASE-4199:
--
Here's some feedback.
This is very nice funcionality. Thank
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087244#comment-13087244
]
Doug Meil commented on HBASE-4199:
--
Great! Do this need more +1's, or can it be committe
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087122#comment-13087122
]
Jean-Daniel Cryans commented on HBASE-4199:
---
+1 commit.
> blockCache summary -
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086421#comment-13086421
]
Ted Yu commented on HBASE-4199:
---
Please use curly braces for the code directive.
The advanta
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086405#comment-13086405
]
Doug Meil commented on HBASE-4199:
--
Thanks Ted.
I'll fix the Javadoc and the unit test t
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086317#comment-13086317
]
Ted Yu commented on HBASE-4199:
---
Please use better table names below:
{code}
+ private stat
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085464#comment-13085464
]
Doug Meil commented on HBASE-4199:
--
The unit test has been updated in this v2 patch and n
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085257#comment-13085257
]
Jean-Daniel Cryans commented on HBASE-4199:
---
bq. I'm just trying to create some
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085251#comment-13085251
]
Doug Meil commented on HBASE-4199:
--
Thanks!
re: "minicluster."
Doesn't need to be 3. I
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085207#comment-13085207
]
Jean-Daniel Cryans commented on HBASE-4199:
---
I'm sorta confused by TestBlockCach
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084881#comment-13084881
]
Ted Yu commented on HBASE-4199:
---
I was talking about the default ctor for BlockCacheSummaryE
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084864#comment-13084864
]
Doug Meil commented on HBASE-4199:
--
BlockCacheSummaryEntry can't be made package private
[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084856#comment-13084856
]
Ted Yu commented on HBASE-4199:
---
It would be easier for other developers to make review comm
25 matches
Mail list logo
