[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-24 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175695#comment-13175695 ] Hadoop QA commented on HBASE-5070: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-24 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175743#comment-13175743 ] Zhihong Yu commented on HBASE-5070: --- @Jesse: Are you Okay with the changes I proposed @

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-24 Thread Jesse Yates (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175755#comment-13175755 ] Jesse Yates commented on HBASE-5070: Yeah, those changes are fine - I totally missed

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-24 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175773#comment-13175773 ] Zhihong Yu commented on HBASE-5070: --- Integrated to TRUNK. Thanks for the patch Jesse.

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-24 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175785#comment-13175785 ] Hudson commented on HBASE-5070: --- Integrated in HBase-TRUNK #2574 (See

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-24 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175795#comment-13175795 ] Hudson commented on HBASE-5070: --- Integrated in HBase-TRUNK-security #47 (See

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-23 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175547#comment-13175547 ] Hadoop QA commented on HBASE-5070: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-22 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175016#comment-13175016 ] jirapos...@reviews.apache.org commented on HBASE-5070: --

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-22 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175024#comment-13175024 ] Zhihong Yu commented on HBASE-5070: --- For concern #1, how about creating helper method to

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-22 Thread Jesse Yates (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13175032#comment-13175032 ] Jesse Yates commented on HBASE-5070: bq. For concern #1, how about creating helper

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-21 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174339#comment-13174339 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- bq. On

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-21 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13174648#comment-13174648 ] jirapos...@reviews.apache.org commented on HBASE-5070: -- bq. On

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-20 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173439#comment-13173439 ] jirapos...@reviews.apache.org commented on HBASE-5070: --

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-20 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173466#comment-13173466 ] jirapos...@reviews.apache.org commented on HBASE-5070: --

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-20 Thread jirapos...@reviews.apache.org (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13173890#comment-13173890 ] jirapos...@reviews.apache.org commented on HBASE-5070: --

[jira] [Commented] (HBASE-5070) Constraints implementation and javadoc changes

2011-12-19 Thread Zhihong Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172788#comment-13172788 ] Zhihong Yu commented on HBASE-5070: --- w.r.t. whether HTableDescriptor is a good