[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632707#comment-13632707
]
Hudson commented on HBASE-7801:
---
Integrated in HBase-0.94-security #137 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631721#comment-13631721
]
Ted Yu commented on HBASE-7801:
---
We can either throw IOException at the server or, fall back
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631805#comment-13631805
]
Lars H commented on HBASE-7801:
---
Neither is ideal. Which would you prefer?
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631813#comment-13631813
]
Ted Yu commented on HBASE-7801:
---
bq. fall back to checking the value of writeToWAL.
Before
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631892#comment-13631892
]
Lars H commented on HBASE-7801:
---
Alright will have a new patch soon.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631982#comment-13631982
]
Ted Yu commented on HBASE-7801:
---
Looks good to me.
Thanks for the perseverance, Lars.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632515#comment-13632515
]
Hudson commented on HBASE-7801:
---
Integrated in HBase-0.94 #961 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631424#comment-13631424
]
Lars Hofhansl commented on HBASE-7801:
--
Going to commit to 0.94 today or tomorrow,
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631429#comment-13631429
]
Ted Yu commented on HBASE-7801:
---
{code}
+ public Durability getDurability() {
+byte[]
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631476#comment-13631476
]
Lars Hofhansl commented on HBASE-7801:
--
We have a silent agreement that attributes
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631482#comment-13631482
]
Ted Yu commented on HBASE-7801:
---
bq. I'd rather know in the client code if there's something
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631497#comment-13631497
]
Lars Hofhansl commented on HBASE-7801:
--
Hmm... So translate to a
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631042#comment-13631042
]
Ted Yu commented on HBASE-7801:
---
@Lars:
Can you update release notes for this JIRA ?
Thanks
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631108#comment-13631108
]
ramkrishna.s.vasudevan commented on HBASE-7801:
---
Patch looks good. The
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630507#comment-13630507
]
Lars Hofhansl commented on HBASE-7801:
--
Please have a look at the 0.94 patch
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630528#comment-13630528
]
Hudson commented on HBASE-7801:
---
Integrated in HBase-TRUNK #4058 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630621#comment-13630621
]
Ted Yu commented on HBASE-7801:
---
In
{code}
+ public static Durability valueOf(int ordinal)
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630645#comment-13630645
]
Hudson commented on HBASE-7801:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #495 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630648#comment-13630648
]
Ted Yu commented on HBASE-7801:
---
I ran 0.94 test suite with patch and all clear.
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630732#comment-13630732
]
Lars Hofhansl commented on HBASE-7801:
--
[~te...@apache.org] Thanks for looking.
bq.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630738#comment-13630738
]
Ted Yu commented on HBASE-7801:
---
bq. What Exception would be best here?
How about
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630787#comment-13630787
]
Lars Hofhansl commented on HBASE-7801:
--
Oops. Thanks Jeffrey, will commit addendum
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630790#comment-13630790
]
Lars Hofhansl commented on HBASE-7801:
--
Committed addendum. Thanks again Jeffrey.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630885#comment-13630885
]
Hudson commented on HBASE-7801:
---
Integrated in hbase-0.95-on-hadoop2 #67 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630910#comment-13630910
]
Hudson commented on HBASE-7801:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #496 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630930#comment-13630930
]
Lars Hofhansl commented on HBASE-7801:
--
bq. I think we should add to javadoc for
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630940#comment-13630940
]
Lars Hofhansl commented on HBASE-7801:
--
Here's a list of changes I deliberately
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630942#comment-13630942
]
Hudson commented on HBASE-7801:
---
Integrated in HBase-TRUNK #4060 (See
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629508#comment-13629508
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629586#comment-13629586
]
Lars Hofhansl commented on HBASE-7801:
--
Enis and Anoop +1'd already (and I have only
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628494#comment-13628494
]
Lars Hofhansl commented on HBASE-7801:
--
Expect a (hopefully) final patch soon.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628508#comment-13628508
]
Enis Soztutar commented on HBASE-7801:
--
bq. I'm thinking about how I could test this.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628631#comment-13628631
]
Lars Hofhansl commented on HBASE-7801:
--
Need to rebase the patch again. Grrr.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628633#comment-13628633
]
Lars Hofhansl commented on HBASE-7801:
--
I think I ran into the PB 2.5 vs 2.4.1 issue.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626882#comment-13626882
]
Enis Soztutar commented on HBASE-7801:
--
Thanks Lars, this looks better. Could you
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627046#comment-13627046
]
Lars Hofhansl commented on HBASE-7801:
--
I did add the InterfaceAudience... I must
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627169#comment-13627169
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627477#comment-13627477
]
Anoop Sam John commented on HBASE-7801:
---
1.{code}
- byte [] row =
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627502#comment-13627502
]
Lars Hofhansl commented on HBASE-7801:
--
Thanks Anoop.
#1 yes
#2 Oops, you're right.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627509#comment-13627509
]
Anoop Sam John commented on HBASE-7801:
---
#3 - Oh yes.. Sorry I missed that.. Ya
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625953#comment-13625953
]
Enis Soztutar commented on HBASE-7801:
--
API looks good. A couple of comments:
-
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626053#comment-13626053
]
Lars Hofhansl commented on HBASE-7801:
--
Thanks [~enis]. Expect a new patch today.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625133#comment-13625133
]
Lars Hofhansl commented on HBASE-7801:
--
Any comments on the latest patch? It should
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625134#comment-13625134
]
Anoop Sam John commented on HBASE-7801:
---
[~lhofhansl] I will see the patch today.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624505#comment-13624505
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624701#comment-13624701
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624315#comment-13624315
]
Lars Hofhansl commented on HBASE-7801:
--
[~enis] Anoop had the same question above. I
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607385#comment-13607385
]
ramkrishna.s.vasudevan commented on HBASE-7801:
---
Patch looks fine to me.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607558#comment-13607558
]
Anoop Sam John commented on HBASE-7801:
---
bq.If DefferedLogFlush is enabled in HTD
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608302#comment-13608302
]
Enis Soztutar commented on HBASE-7801:
--
Two more comments:
Should we rename
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606120#comment-13606120
]
Anoop Sam John commented on HBASE-7801:
---
Gone through the latest Trunk Patch. Seems
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606569#comment-13606569
]
Enis Soztutar commented on HBASE-7801:
--
bq. Are generated filed (like
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606581#comment-13606581
]
Enis Soztutar commented on HBASE-7801:
--
I think this is a good time to think about
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606602#comment-13606602
]
Lars Hofhansl commented on HBASE-7801:
--
Yeah I was wondering about this too. Not sure
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606615#comment-13606615
]
Enis Soztutar commented on HBASE-7801:
--
bq. Not sure we want to leak the Hadoop
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604139#comment-13604139
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604159#comment-13604159
]
Ted Yu commented on HBASE-7801:
---
Can you take a look at the java of warnings ?
Thanks,
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604297#comment-13604297
]
Lars Hofhansl commented on HBASE-7801:
--
Of course. Will also look at the long line
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604476#comment-13604476
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604493#comment-13604493
]
Lars Hofhansl commented on HBASE-7801:
--
Are generated filed (like ClientProtos.java)
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604496#comment-13604496
]
Ted Yu commented on HBASE-7801:
---
I don't think so:
{code}
ll=`cat $PATCH_DIR/patch | grep
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604498#comment-13604498
]
Lars Hofhansl commented on HBASE-7801:
--
Might be a good thing to add anyway.
The long
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604499#comment-13604499
]
Ted Yu commented on HBASE-7801:
---
I logged HBASE-8129 for making long line detection smarter
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599740#comment-13599740
]
Lars Hofhansl commented on HBASE-7801:
--
Any comments?
Allow a
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599768#comment-13599768
]
Anoop Sam John commented on HBASE-7801:
---
[~lhofhansl] I am going through the patch.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599864#comment-13599864
]
ramkrishna.s.vasudevan commented on HBASE-7801:
---
Will check this later today
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599933#comment-13599933
]
Anoop Sam John commented on HBASE-7801:
---
Gone through the changes in src code
1.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599976#comment-13599976
]
Anoop Sam John commented on HBASE-7801:
---
1. HBaseTestCase
{code}
-
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599973#comment-13599973
]
Anoop Sam John commented on HBASE-7801:
---
Change of writeToWAL - writeTwriteGuarantee
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599979#comment-13599979
]
Anoop Sam John commented on HBASE-7801:
---
If you are busy and need any help let me
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600338#comment-13600338
]
Lars Hofhansl commented on HBASE-7801:
--
Thanks Anoop.
New patch coming soon. Please
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600347#comment-13600347
]
Lars Hofhansl commented on HBASE-7801:
--
I think {{p.setWriteToWAL(true)}} in
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600378#comment-13600378
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591967#comment-13591967
]
Lars Hofhansl commented on HBASE-7801:
--
Sigh... I will try to have trunk patch
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588071#comment-13588071
]
Lars Hofhansl commented on HBASE-7801:
--
new trunk patch with PB coming tomorrow.
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583498#comment-13583498
]
Enis Soztutar commented on HBASE-7801:
--
bq. As far the Java API in concerned the fact
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583711#comment-13583711
]
Sergey Shelukhin commented on HBASE-7801:
-
{code}
+} else if
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583896#comment-13583896
]
Lars Hofhansl commented on HBASE-7801:
--
Yep that was an artifact of of my first
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582788#comment-13582788
]
Enis Soztutar commented on HBASE-7801:
--
For 0.94, it looks good, but for trunk I
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582810#comment-13582810
]
Lars Hofhansl commented on HBASE-7801:
--
Was trying to avoid a PB change, but there's
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582811#comment-13582811
]
Lars Hofhansl commented on HBASE-7801:
--
Oh another problem with PB is that we need to
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582854#comment-13582854
]
Enis Soztutar commented on HBASE-7801:
--
Makes sense. I think it is not a horrible
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582925#comment-13582925
]
Lars Hofhansl commented on HBASE-7801:
--
As far the Java API in concerned the fact
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580575#comment-13580575
]
Anoop Sam John commented on HBASE-7801:
---
+1
We can add in release notes about how to
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580390#comment-13580390
]
Ted Yu commented on HBASE-7801:
---
I looked at trunk patch. It looks good.
{code}
+ *
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580080#comment-13580080
]
Hadoop QA commented on HBASE-7801:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580120#comment-13580120
]
Lars Hofhansl commented on HBASE-7801:
--
Will fix the line length. As for this patch,
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13579705#comment-13579705
]
Lars Hofhansl commented on HBASE-7801:
--
Both #1 and #2 will be use cases, and both
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13579746#comment-13579746
]
ramkrishna.s.vasudevan commented on HBASE-7801:
---
@Lars
We need this. As far
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578215#comment-13578215
]
Anoop Sam John commented on HBASE-7801:
---
[~lhofhansl] What all use cases you see? I
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578216#comment-13578216
]
Anoop Sam John commented on HBASE-7801:
---
bq.Not running the LogSyncer thread at all
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578472#comment-13578472
]
Lars Hofhansl commented on HBASE-7801:
--
The use case that I see a lot at Saleforce is
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578926#comment-13578926
]
Anoop Sam John commented on HBASE-7801:
---
[~lhofhansl] Thanks for sharing the use
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578077#comment-13578077
]
Lars Hofhansl commented on HBASE-7801:
--
I testing the patch locally. Works fine.
Any
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578148#comment-13578148
]
Anoop Sam John commented on HBASE-7801:
---
{code}
+ if (walEdit.size() 0
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578154#comment-13578154
]
ramkrishna.s.vasudevan commented on HBASE-7801:
---
For Anoop's point on the
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578193#comment-13578193
]
Lars Hofhansl commented on HBASE-7801:
--
[~anoopsamjohn] I was thinking that if the
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578196#comment-13578196
]
Lars Hofhansl commented on HBASE-7801:
--
[~ram_krish] Not running the LogSyncer thread
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578205#comment-13578205
]
ramkrishna.s.vasudevan commented on HBASE-7801:
---
Yes right Lars.
If the
[
https://issues.apache.org/jira/browse/HBASE-7801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575697#comment-13575697
]
Anoop Sam John commented on HBASE-7801:
---
bq.For batch operation we'd take the safest
1 - 100 of 104 matches
Mail list logo
