[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13611698#comment-13611698
]
Liang Xie commented on HBASE-7845:
--
Is there any other blocking things for this jira need
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13611907#comment-13611907
]
Hudson commented on HBASE-7845:
---
Integrated in hbase-0.95-on-hadoop2 #39 (See
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609994#comment-13609994
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610021#comment-13610021
]
Liang Xie commented on HBASE-7845:
--
so weird, i ran mvn clean test -P localTests
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610969#comment-13610969
]
Ted Yu commented on HBASE-7845:
---
TestTableLockManager failure is tracked by HBASE-8164
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609093#comment-13609093
]
Jean-Marc Spaggiari commented on HBASE-7845:
[~xieliang007] I ran 10 times the
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609196#comment-13609196
]
Jean-Marc Spaggiari commented on HBASE-7845:
Here we go!
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609206#comment-13609206
]
Ted Yu commented on HBASE-7845:
---
Thanks Jean-Marc for doing the comparison.
Based on the
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609226#comment-13609226
]
ramkrishna.s.vasudevan commented on HBASE-7845:
---
JM , thanks for your work.
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609327#comment-13609327
]
stack commented on HBASE-7845:
--
[~jmspaggi] Nice. Thanks.
optimize hfile
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609345#comment-13609345
]
stack commented on HBASE-7845:
--
[~xieliang007] I don't think you answered all my review
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609852#comment-13609852
]
Ted Yu commented on HBASE-7845:
---
Liang:
I think you explained clearly.
There is no need to
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609893#comment-13609893
]
Liang Xie commented on HBASE-7845:
--
v9 renamed getFakedKey to getShortMidpointKey
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609959#comment-13609959
]
stack commented on HBASE-7845:
--
I'm +1 on this patch for trunk and 0.95 after looking at
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607423#comment-13607423
]
Liang Xie commented on HBASE-7845:
--
v7 introducd a constant to address
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607437#comment-13607437
]
Liang Xie commented on HBASE-7845:
--
{quote}
+ @Override
+ public byte[] getFakedKey(final
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607468#comment-13607468
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607488#comment-13607488
]
Liang Xie commented on HBASE-7845:
--
the rebased v8 should make TestEncodedSeekers pass,
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607534#comment-13607534
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607554#comment-13607554
]
Liang Xie commented on HBASE-7845:
--
TestJoinedScanners should be a false alarm, just
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607566#comment-13607566
]
Liang Xie commented on HBASE-7845:
--
About HFilePerformanceEvaluation, i ran three times
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607572#comment-13607572
]
Jean-Marc Spaggiari commented on HBASE-7845:
[~xieliang007] cna you share he
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608631#comment-13608631
]
Liang Xie commented on HBASE-7845:
--
[~jmspaggi], thanks for your help.
I just appended
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606471#comment-13606471
]
Ted Yu commented on HBASE-7845:
---
-2 is returned in several places.
How about introducing a
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606869#comment-13606869
]
stack commented on HBASE-7845:
--
Interesting optimization. I like it.
There is a
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13599955#comment-13599955
]
Liang Xie commented on HBASE-7845:
--
and fixed the above style problems per Ted's comments
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1367#comment-1367
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600138#comment-13600138
]
Ted Yu commented on HBASE-7845:
---
For HFileReaderV2.seekTo():
{code}
* @return -1 if
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600773#comment-13600773
]
Liang Xie commented on HBASE-7845:
--
bq. Is -1 no longer returned ?
it still returns. -2
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13598504#comment-13598504
]
Liang Xie commented on HBASE-7845:
--
just a quick update: i'll try to understand data
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13596947#comment-13596947
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597320#comment-13597320
]
Ted Yu commented on HBASE-7845:
---
I ran the failed tests and they passed locally.
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595733#comment-13595733
]
Hadoop QA commented on HBASE-7845:
--
{color:green}+1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595985#comment-13595985
]
Ted Yu commented on HBASE-7845:
---
{code}
return 0; // indicate exact match
-
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13594629#comment-13594629
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595445#comment-13595445
]
Liang Xie commented on HBASE-7845:
--
Please refer to TestBlocksRead case in v3, it's easy
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591646#comment-13591646
]
Liang Xie commented on HBASE-7845:
--
Diving into the failed cases, it somehow really funny
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591648#comment-13591648
]
Liang Xie commented on HBASE-7845:
--
seem i could not modify the old comments in place...
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591650#comment-13591650
]
Liang Xie commented on HBASE-7845:
--
And, one thing need to note is, it'll have a conflict
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591654#comment-13591654
]
Ted Yu commented on HBASE-7845:
---
@Liang:
Thanks for sharing your finding.
We can introduce
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591655#comment-13591655
]
Liang Xie commented on HBASE-7845:
--
yes, you are correct, per my current knowledge
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588111#comment-13588111
]
Enis Soztutar commented on HBASE-7845:
--
I like the approach, but wondering whether
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587031#comment-13587031
]
Liang Xie commented on HBASE-7845:
--
Here is a simple test result, loaded data with YCSB:
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587178#comment-13587178
]
Ted Yu commented on HBASE-7845:
---
@Liang:
Latest patch didn't get through hadoop QA.
Mind
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587331#comment-13587331
]
Ted Yu commented on HBASE-7845:
---
[~kannanm]:
What do you think of Liang's patch ?
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587953#comment-13587953
]
Ted Yu commented on HBASE-7845:
---
Took a brief look over the patch.
{code}
+
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587956#comment-13587956
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13587959#comment-13587959
]
Liang Xie commented on HBASE-7845:
--
There is no impact on existing read path at all, just
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588005#comment-13588005
]
ramkrishna.s.vasudevan commented on HBASE-7845:
---
Had a look at the patch.
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13588026#comment-13588026
]
Liang Xie commented on HBASE-7845:
--
Thanks:)
It's just a proto right now, i am looking
[
https://issues.apache.org/jira/browse/HBASE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585855#comment-13585855
]
Hadoop QA commented on HBASE-7845:
--
{color:red}-1 overall{color}. Here are the results
51 matches
Mail list logo
