[jira] [Commented] (HBASE-18708) Configure on-heap bucketCache size using percentage of heap size
[
https://issues.apache.org/jira/browse/HBASE-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144775#comment-16144775
]
Anoop Sam John commented on HBASE-18708:
For 2.0 whether we need the on heap mode of Bucket Cache really? Why should
one use this? Why not L1 LRU cache then which is any way on heap. Considering
the off heap mode improvement, I was thinking to propose the removal of on heap
mode of BC.
> Configure on-heap bucketCache size using percentage of heap size
>
>
> Key: HBASE-18708
> URL: https://issues.apache.org/jira/browse/HBASE-18708
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
>
> Currently heap allocations for RS memory structures like {{memstore}} and
> {{lruCache}} are configured as percentage of total RS heap size. Since
> on-heap bucketCache uses RS heap, configuring it as a percentage of heap size
> will improve usability. Currently this can be configured either as a
> percentage of heap or a memory size in MiB and we can remove the latter
> option which is applicable to external or off-heap bucketCache.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18698) MapreduceDependencyClasspathTool does not include hbase-server as a dependency
[ https://issues.apache.org/jira/browse/HBASE-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18698: -- Fix Version/s: (was: 3.0.0) Status: Patch Available (was: Open) > MapreduceDependencyClasspathTool does not include hbase-server as a dependency > -- > > Key: HBASE-18698 > URL: https://issues.apache.org/jira/browse/HBASE-18698 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18698.master.001.patch > > > This would introduce runtime errors when using snapshot input format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18698) MapreduceDependencyClasspathTool does not include hbase-server as a dependency
[ https://issues.apache.org/jira/browse/HBASE-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144764#comment-16144764 ] stack commented on HBASE-18698: --- .001 Move Driver to be the main-class in hbase-mapreduce jar rather than hbase-server jar. Reference the hbase-server and shaded protobuf so they get bundled when you do 'hbase mapredcp'. > MapreduceDependencyClasspathTool does not include hbase-server as a dependency > -- > > Key: HBASE-18698 > URL: https://issues.apache.org/jira/browse/HBASE-18698 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18698.master.001.patch > > > This would introduce runtime errors when using snapshot input format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18698) MapreduceDependencyClasspathTool does not include hbase-server as a dependency
[ https://issues.apache.org/jira/browse/HBASE-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18698: -- Attachment: HBASE-18698.master.001.patch > MapreduceDependencyClasspathTool does not include hbase-server as a dependency > -- > > Key: HBASE-18698 > URL: https://issues.apache.org/jira/browse/HBASE-18698 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18698.master.001.patch > > > This would introduce runtime errors when using snapshot input format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18700) Document the new changes on mapreduce stuffs
[ https://issues.apache.org/jira/browse/HBASE-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144763#comment-16144763 ] stack commented on HBASE-18700: --- Will push tomorrow unless objection. Adds section on Driver output and how to get it. I tested the instruction given here. > Document the new changes on mapreduce stuffs > > > Key: HBASE-18700 > URL: https://issues.apache.org/jira/browse/HBASE-18700 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18700.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18700) Document the new changes on mapreduce stuffs
[ https://issues.apache.org/jira/browse/HBASE-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18700: -- Attachment: HBASE-18700.master.001.patch > Document the new changes on mapreduce stuffs > > > Key: HBASE-18700 > URL: https://issues.apache.org/jira/browse/HBASE-18700 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 3.0.0, 2.0.0-alpha-3 > > Attachments: HBASE-18700.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-14166) Per-Region metrics can be stale
[ https://issues.apache.org/jira/browse/HBASE-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shibin Zhang updated HBASE-14166: - Description: # We're seeing some machines that are reporting only old region metrics. It seems like at some point the Hadoop metrics system decided which metrics to display and which not to. From then on it was not changing. (was: We're seeing some machines that are reporting only old region metrics. It seems like at some point the Hadoop metrics system decided which metrics to display and which not to. From then on it was not changing.) > Per-Region metrics can be stale > --- > > Key: HBASE-14166 > URL: https://issues.apache.org/jira/browse/HBASE-14166 > Project: HBase > Issue Type: Bug > Components: metrics >Affects Versions: 1.1.0.1 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-14166.patch, HBASE-14166-v1.patch, > HBASE-14166-v2.patch, HBASE-14166-v3.patch, HBASE-14166-v4.patch, > HBASE-14166-v5.patch > > > # We're seeing some machines that are reporting only old region metrics. It > seems like at some point the Hadoop metrics system decided which metrics to > display and which not to. From then on it was not changing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144758#comment-16144758 ] Hudson commented on HBASE-18710: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3616 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3616/]) HBASE-18710 Move on to hbase-thirdparty 1.0.1 (it was just released). (stack: rev ea1620ff4252b5d04782576ded7892d175804e9b) * (edit) pom.xml > Move on to hbase-thirdparty 1.0.1 (it was just released). > - > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18707.master.001 (1).patch, > HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144757#comment-16144757 ] Hudson commented on HBASE-18674: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3616 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3616/]) HBASE-18674 upgrading to commons-lang3 (stack: rev 5dacc85122ca67b0446bc79624d378824d2428eb) * (edit) hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/lib/MutableHistogram.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/monkies/PolicyBasedChaosMonkey.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/StripeCompactionsPerformanceEvaluation.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsMasterWrapperImpl.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java * (edit) hbase-rsgroup/pom.xml * (edit) hbase-server/src/main/resources/hbase-webapps/regionserver/region.jsp * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestBase.java * (edit) hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationSerDeHelper.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/EncodedDataBlock.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/SnapshotQuotaObserverChore.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/BackupInfo.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/util/ChaosMonkeyRunner.java * (edit) hbase-backup/pom.xml * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceRegionsAction.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java * (edit) hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTTestingUtility.java * (edit) hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestIncrementalBackupMergeWithFailures.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/policies/PeriodicPolicy.java * (edit) hbase-server/src/main/resources/hbase-webapps/regionserver/processRS.jsp * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * (edit) hbase-server/src/main/resources/hbase-webapps/master/zk.jsp * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/IncrementalTableBackupClient.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java * (edit) hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/metrics/impl/HBaseMetrics2HadoopMetricsAdapter.java * (edit) pom.xml * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupSet.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUser.java * (edit) hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java * (edit) hbase-common/pom.xml * (edit) hbase-server/src/main/resources/hbase-webapps/master/processMaster.jsp * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java * (edit) hbase-spark-it/pom.xml * (edit) hbase-server/src/main/resources/hbase-webapps/master/processRS.jsp * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/PreemptiveFastFailInterceptor.java * (edit)
[jira] [Commented] (HBASE-14498) Master stuck in infinite loop when all Zookeeper servers are unreachable
[
https://issues.apache.org/jira/browse/HBASE-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144752#comment-16144752
]
Pankaj Kumar commented on HBASE-14498:
--
No problem Stack Sir, this fix can wait :) will rebase the patch once test
failures are resolved.
> Master stuck in infinite loop when all Zookeeper servers are unreachable
>
>
> Key: HBASE-14498
> URL: https://issues.apache.org/jira/browse/HBASE-14498
> Project: HBase
> Issue Type: Bug
> Components: master
>Reporter: Y. SREENIVASULU REDDY
>Assignee: Pankaj Kumar
>Priority: Critical
> Fix For: 2.0.0, 1.3.2, 1.4.1, 1.5.0, 1.2.7
>
> Attachments: HBASE-14498-addendum.patch,
> HBASE-14498-branch-1.2.patch, HBASE-14498-branch-1.3.patch,
> HBASE-14498-branch-1.3-V2.patch, HBASE-14498-branch-1.4.patch,
> HBASE-14498-branch-1.patch, HBASE-14498.master.001.patch,
> HBASE-14498.master.002.patch, HBASE-14498.patch, HBASE-14498-V2.patch,
> HBASE-14498-V3.patch, HBASE-14498-V4.patch, HBASE-14498-V5.patch,
> HBASE-14498-V6.patch, HBASE-14498-V6.patch
>
>
> We met a weird scenario in our production environment.
> In a HA cluster,
> > Active Master (HM1) is not able to connect to any Zookeeper server (due to
> > N/w breakdown on master machine network with Zookeeper servers).
> {code}
> 2015-09-26 15:24:47,508 INFO
> [HM1-Host:16000.activeMasterManager-SendThread(ZK-Host:2181)]
> zookeeper.ClientCnxn: Client session timed out, have not heard from server in
> 33463ms for sessionid 0x104576b8dda0002, closing socket connection and
> attempting reconnect
> 2015-09-26 15:24:47,877 INFO
> [HM1-Host:16000.activeMasterManager-SendThread(ZK-Host1:2181)]
> client.FourLetterWordMain: connecting to ZK-Host1 2181
> 2015-09-26 15:24:48,236 INFO [main-SendThread(ZK-Host1:2181)]
> client.FourLetterWordMain: connecting to ZK-Host1 2181
> 2015-09-26 15:24:49,879 WARN
> [HM1-Host:16000.activeMasterManager-SendThread(ZK-Host1:2181)]
> zookeeper.ClientCnxn: Can not get the principle name from server ZK-Host1
> 2015-09-26 15:24:49,879 INFO
> [HM1-Host:16000.activeMasterManager-SendThread(ZK-Host1:2181)]
> zookeeper.ClientCnxn: Opening socket connection to server
> ZK-Host1/ZK-IP1:2181. Will not attempt to authenticate using SASL (unknown
> error)
> 2015-09-26 15:24:50,238 WARN [main-SendThread(ZK-Host1:2181)]
> zookeeper.ClientCnxn: Can not get the principle name from server ZK-Host1
> 2015-09-26 15:24:50,238 INFO [main-SendThread(ZK-Host1:2181)]
> zookeeper.ClientCnxn: Opening socket connection to server
> ZK-Host1/ZK-Host1:2181. Will not attempt to authenticate using SASL (unknown
> error)
> 2015-09-26 15:25:17,470 INFO [main-SendThread(ZK-Host1:2181)]
> zookeeper.ClientCnxn: Client session timed out, have not heard from server in
> 30023ms for sessionid 0x2045762cc710006, closing socket connection and
> attempting reconnect
> 2015-09-26 15:25:17,571 WARN [master/HM1-Host/HM1-IP:16000]
> zookeeper.RecoverableZooKeeper: Possibly transient ZooKeeper,
> quorum=ZK-Host:2181,ZK-Host1:2181,ZK-Host2:2181,
> exception=org.apache.zookeeper.KeeperException$ConnectionLossException:
> KeeperErrorCode = ConnectionLoss for /hbase/master
> 2015-09-26 15:25:17,872 INFO [main-SendThread(ZK-Host:2181)]
> client.FourLetterWordMain: connecting to ZK-Host 2181
> 2015-09-26 15:25:19,874 WARN [main-SendThread(ZK-Host:2181)]
> zookeeper.ClientCnxn: Can not get the principle name from server ZK-Host
> 2015-09-26 15:25:19,874 INFO [main-SendThread(ZK-Host:2181)]
> zookeeper.ClientCnxn: Opening socket connection to server ZK-Host/ZK-IP:2181.
> Will not attempt to authenticate using SASL (unknown error)
> {code}
> > Since HM1 was not able to connect to any ZK, so session timeout didnt
> > happen at Zookeeper server side and HM1 didnt abort.
> > On Zookeeper session timeout standby master (HM2) registered himself as an
> > active master.
> > HM2 is keep on waiting for region server to report him as part of active
> > master intialization.
> {noformat}
> 2015-09-26 15:24:44,928 | INFO | HM2-Host:21300.activeMasterManager | Waiting
> for region servers count to settle; currently checked in 0, slept for 0 ms,
> expecting minimum of 1, maximum of 2147483647, timeout of 4500 ms, interval
> of 1500 ms. |
> org.apache.hadoop.hbase.master.ServerManager.waitForRegionServers(ServerManager.java:1011)
> ---
> ---
> 2015-09-26 15:32:50,841 | INFO | HM2-Host:21300.activeMasterManager | Waiting
> for region servers count to settle; currently checked in 0, slept for 483913
> ms, expecting minimum of 1, maximum of 2147483647, timeout of 4500 ms,
> interval of 1500 ms. |
> org.apache.hadoop.hbase.master.ServerManager.waitForRegionServers(ServerManager.java:1011)
> {noformat}
> > At other end, region servers are
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144747#comment-16144747 ] stack commented on HBASE-18712: --- bq. I don't remember which branch #833 was for. precommit is master; i.e. jdk8 so permgen config does nothing. The post you cite for the UseLoopPredicate flag has zero upvotes. It is last in a long line of possible reasons for surefire timeout (i.e. anything that could crash a JVM). The post begins: "This *could* also happen due to a totally different issue.."... and continues " I found out that this *could* be happening because of a JDK bug which *could* have caused this regression" [emphasis mine]. The flag looks like a work around for a bug introduced long ago in early jdk7 long since solved. The bug report cited in the url you add is from 2015. I'm not against trying stuff but this seems like a long-shot w/ little by way of substantiation. We probably want to avoid adding odd-looking configs just getting our basic test suite passing. > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt, 18712.v2.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18682) TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
[
https://issues.apache.org/jira/browse/HBASE-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144744#comment-16144744
]
Chia-Ping Tsai commented on HBASE-18682:
bq. So which all tests fail in ur 32 bit env?
TestCompactingMemStore and TestHeapSize fails. I'm not sure whether there are
any more failed tests.
> TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
> ---
>
> Key: HBASE-18682
> URL: https://issues.apache.org/jira/browse/HBASE-18682
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0
>
>
> The UT works well on my centos(64-bits) but it always fails on my
> ubuntu(17.04 64-bits).
> {code}
> Running org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.998 sec <<<
> FAILURE! - in org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> testFlatteningToCellChunkMap(org.apache.hadoop.hbase.regionserver.TestCompactingMemStore)
> Time elapsed: 1.64 sec <<< FAILURE!
> java.lang.AssertionError: expected:<920> but was:<952>
> at
> org.apache.hadoop.hbase.regionserver.TestCompactingMemStore.testFlatteningToCellChunkMap(TestCompactingMemStore.java:609)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[ https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144746#comment-16144746 ] Chia-Ping Tsai commented on HBASE-3935: --- Will commit it later. > HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB > -- > > Key: HBASE-3935 > URL: https://issues.apache.org/jira/browse/HBASE-3935 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Andy Yang > Attachments: HBASE-3935.branch-2.v0.patch, > HBASE-3935.branch-2.v1.patch, HBASE-3935.branch-2.v2.patch, > HBASE-3935.branch-2.v3.patch, HBASE-3935.branch-2.v4.patch, > HBASE-3935.branch-2.v5.patch, HBASE-3935.branch-2.v6.patch, > HBASE-3935.master.v0.patch > > > Related to HBASE-3927, Matt proposed changing > HServerLoad.storefileIndexSizeMB to storefileIndexSizeKB so that user can see > the size of small store file index. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144740#comment-16144740
]
Hudson commented on HBASE-18568:
FAILURE: Integrated in Jenkins build HBase-1.5 #37 (See
[https://builds.apache.org/job/HBase-1.5/37/])
HBASE-18568 Correct metric of numRegions (tedyu: rev
31ba3cb6fc7936d61f1c1b0859726cb35bce87f2)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144739#comment-16144739
]
Hudson commented on HBASE-18568:
FAILURE: Integrated in Jenkins build HBase-1.4 #890 (See
[https://builds.apache.org/job/HBase-1.4/890/])
HBASE-18568 Correct metric of numRegions (tedyu: rev
f0b6b988b58ee8f50a8096a382f0594c912805af)
* (edit)
hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18682) TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
[
https://issues.apache.org/jira/browse/HBASE-18682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144737#comment-16144737
]
Anoop Sam John commented on HBASE-18682:
So which all tests fail in ur 32 bit env? Better we will have a look at them
and see the issue.
> TestCompactingMemStore#testFlatteningToCellChunkMap fails in master
> ---
>
> Key: HBASE-18682
> URL: https://issues.apache.org/jira/browse/HBASE-18682
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Fix For: 2.0.0
>
>
> The UT works well on my centos(64-bits) but it always fails on my
> ubuntu(17.04 64-bits).
> {code}
> Running org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.998 sec <<<
> FAILURE! - in org.apache.hadoop.hbase.regionserver.TestCompactingMemStore
> testFlatteningToCellChunkMap(org.apache.hadoop.hbase.regionserver.TestCompactingMemStore)
> Time elapsed: 1.64 sec <<< FAILURE!
> java.lang.AssertionError: expected:<920> but was:<952>
> at
> org.apache.hadoop.hbase.regionserver.TestCompactingMemStore.testFlatteningToCellChunkMap(TestCompactingMemStore.java:609)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144731#comment-16144731 ] Ted Yu commented on HBASE-18712: I don't remember which branch #833 was for. w.r.t. https://bugs.eclipse.org/bugs/show_bug.cgi?id=406419 , it was from 2013. The post from andreyro on https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi was for JDK 1.8.0_65 Not sure the relationship between bug 406419 and JDK-8081379 > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt, 18712.v2.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18448) EndPoint example for refreshing HFiles for stores
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144729#comment-16144729 ] Lars Hofhansl edited comment on HBASE-18448 at 8/29/17 4:41 AM: Thanks [~ajayjadhav], this make a lot of sense. I can see more use cases for this - such as quickly standing up an HBase cluster over existing data, etc. (And apologies that I missed the obvious parent jira) was (Author: lhofhansl): Thanks [~ajayjadhav], this make a lot of sense. I can see more use cases for this - such as quickly standing up an HBase cluster over existing data, etc. > EndPoint example for refreshing HFiles for stores > -- > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0, 2.0.0-alpha-3 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144730#comment-16144730 ] Hadoop QA commented on HBASE-18674: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/8381/console in case of problems. > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > hbase-18674.master.002.patch, hbase-18674.master.002.patch, > hbase-18674.master.003.patch, hbase-18674.master.004.patch, > hbase-18674.master.004.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18448) EndPoint example for refreshing HFiles for stores
[ https://issues.apache.org/jira/browse/HBASE-18448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144729#comment-16144729 ] Lars Hofhansl commented on HBASE-18448: --- Thanks [~ajayjadhav], this make a lot of sense. I can see more use cases for this - such as quickly standing up an HBase cluster over existing data, etc. > EndPoint example for refreshing HFiles for stores > -- > > Key: HBASE-18448 > URL: https://issues.apache.org/jira/browse/HBASE-18448 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Affects Versions: 2.0.0, 1.3.1 >Reporter: Ajay Jadhav >Assignee: Ajay Jadhav >Priority: Minor > Fix For: 1.4.0, 2.0.0-alpha-3 > > Attachments: HBASE-18448.branch-1.001.patch, > HBASE-18448.branch-1.002.patch, HBASE-18448.branch-1.003.patch, > HBASE-18448.branch-1.004.patch, HBASE-18448.branch-1.005.patch, > HBASE-18448.branch-1.006.patch, HBASE-18448.branch-1.007.patch, > HBASE-18448.master.001.patch, HBASE-18448.master.002.patch > > > In the case where multiple HBase clusters are sharing a common rootDir, even > after flushing the data from > one cluster doesn't mean that other clusters (replicas) will automatically > pick the new HFile. Through this patch, > we are exposing the refresh HFiles API which when issued from a replica will > update the in-memory file handle list > with the newly added file. > This allows replicas to be consistent with the data written through the > primary cluster. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144726#comment-16144726 ] stack commented on HBASE-18712: --- bq. https://builds.apache.org/job/PreCommit-HBASE-Build/833/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt The build is gone. Was it precommit for master branch? bq. For JDK 1.8, -XX:-UseLoopPredicate should be used, as indicated by the post in description. >From bug db, "Bug 406419 - Don't use -XX:-UseLoopPredicate"; says not needed >since the original prob was fixed. > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt, 18712.v2.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18674: - Attachment: hbase-18674.master.004.patch retry > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > hbase-18674.master.002.patch, hbase-18674.master.002.patch, > hbase-18674.master.003.patch, hbase-18674.master.004.patch, > hbase-18674.master.004.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18712: --- Attachment: 18712.v2.txt > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt, 18712.v2.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[
https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144724#comment-16144724
]
Hadoop QA commented on HBASE-18674:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 4m
34s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 51 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 5m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-spark-it hbase-shaded . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
14s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
9s{color} | {color:red} hbase-replication in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
25s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
14s{color} | {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 5m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
16s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-spark-it hbase-shaded . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
19s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
11s{color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} |
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144723#comment-16144723 ] Ted Yu commented on HBASE-18712: This past QA run: https://builds.apache.org/job/PreCommit-HBASE-Build/833/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt For JDK 1.8, -XX:-UseLoopPredicate should be used, as indicated by the post in description. > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[
https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144718#comment-16144718
]
Sean Busbey commented on HBASE-18712:
-
according to [this oracle
page|http://docs.oracle.com/javase/8/docs/technotes/tools/unix/java.html] in
jdk8 the replacement is {{-XX:MaxMetaspaceSize=size}}, but the default is
supposed to be unlimited.
> Specify MaxPermSize for surefire tests
> --
>
> Key: HBASE-18712
> URL: https://issues.apache.org/jira/browse/HBASE-18712
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 18712.v1.txt
>
>
> Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test
> run(s).
> This sometimes resulted in mvn build prematurely exiting, leaving some large
> tests behind.
> The tests would be deemed timed out.
> As indicated by the following post:
> https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi
> We should specify large enough MaxPermSize so that mvn build doesn't end
> prematurely.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18711) hbase shaded artifact for MR support utilities should have the mapreduce.Driver as its mainclass
[
https://issues.apache.org/jira/browse/HBASE-18711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144720#comment-16144720
]
stack commented on HBASE-18711:
---
I'm working on patches that move the Driver over the hbase-mapreduce. Also
adding description of Driver output to doc. FYI.
> hbase shaded artifact for MR support utilities should have the
> mapreduce.Driver as its mainclass
>
>
> Key: HBASE-18711
> URL: https://issues.apache.org/jira/browse/HBASE-18711
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 1.4.0, 1.3.1, 1.2.6, 2.0.0-alpha-2, 1.1.12
>Reporter: Sean Busbey
>
> to match the docs on using the non-shaded module for mapreduce support
> utilities, we should ensure the shaded version defines the same mainclass.
> (workaround, pass {{org.apache.hadoop.hbase.mapreduce.Driver}} as the class
> for {{hadoop jar}})
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144715#comment-16144715 ] stack commented on HBASE-18577: --- +1 > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.6.patch, HBASE-18577.7.patch, > HBASE-18577-branch-1.v6.patch, HBASE-18577-branch-1.v7.patch, > HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch, > HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch, > HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144712#comment-16144712 ] stack commented on HBASE-18712: --- There is no permgen in jdk8. bq. This sometimes resulted in mvn build prematurely exiting, leaving some large tests behind. Where you see this? > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18712) Specify MaxPermSize for surefire tests
[
https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144687#comment-16144687
]
Hadoop QA commented on HBASE-18712:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
3s{color} | {color:blue} The patch file was not named according to hbase's
naming conventions. Please see
https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
37m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}143m
9s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}207m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-18712 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884155/18712.v1.txt |
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux 80e67f85f134 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26
18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 47a5614 |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8377/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8377/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Specify MaxPermSize for surefire tests
> --
>
> Key: HBASE-18712
> URL: https://issues.apache.org/jira/browse/HBASE-18712
> Project: HBase
> Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: 18712.v1.txt
>
>
> Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test
> run(s).
> This sometimes resulted in mvn build prematurely exiting, leaving some large
> tests behind.
> The tests would be deemed timed out.
> As indicated by the following post:
>
[jira] [Updated] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18577: Attachment: HBASE-18577.7.patch HBASE-18577-branch-1.v7.patch -7 - rebases to latest master - adds requested description for the new module - adds requested description to the jar checker script - adds some more explanation in the pom of the invariant checker > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.6.patch, HBASE-18577.7.patch, > HBASE-18577-branch-1.v6.patch, HBASE-18577-branch-1.v7.patch, > HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch, > HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch, > HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144673#comment-16144673
]
Shibin Zhang commented on HBASE-18568:
--
thanks for the review ,[~tedyu] [~carp84]
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18568:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.0.0-alpha-3
1.5.0
1.4.0
3.0.0
Status: Resolved (was: Patch Available)
Thanks for the patch, Shibin.
Thanks for the review, Yu.
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144668#comment-16144668
]
Hadoop QA commented on HBASE-18568:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
38m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 46m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-18568 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12881402/HBASE-18568-V1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 471c51f78a0d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 47a5614 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8378/testReport/ |
| modules | C: hbase-hadoop2-compat U: hbase-hadoop2-compat |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8378/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144669#comment-16144669
]
Yu Li commented on HBASE-18568:
---
+1, patch LGTM. Let's see what HadoopQA says.
Checking commit log, should be some regression caused by HBASE-14278
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shibin Zhang updated HBASE-18568:
-
Description:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can not put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
was:
i found the value of metric numReigons in Regions is not correct.
the metric can not add or remove region correctly as region close or open.
the metric as follow:
"name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
"numRegions" : 2,
after trouble shooting ,i found the reason is in
MetricsRegionSourceImpl#MetricsRegionSourceImpl
{code:java}
agg.register(this);
...
hashCode = regionWrapper.getRegionHashCode();
{code}
when add the MetricsRegionSource to set ,but the hashCode has not yet
initialized.
So, the setFromMap can put or remove the object correctly.
it will be better like this :
{code:java}
hashCode = regionWrapper.getRegionHashCode();
agg.register(this);
{code}
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can not put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144658#comment-16144658
]
Shibin Zhang commented on HBASE-18568:
--
[~ted_yu] It looks like a concurrency problem.After the change,it works well
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18568:
---
Summary: Correct metric of numRegions (was: Correct Regions metric of
numRegions)
> Correct metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144654#comment-16144654
]
Ted Yu commented on HBASE-18568:
Does the change work for you, Shibin ?
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144643#comment-16144643 ] Hudson commented on HBASE-18710: FAILURE: Integrated in Jenkins build HBase-2.0 #415 (See [https://builds.apache.org/job/HBase-2.0/415/]) HBASE-18710 Move on to hbase-thirdparty 1.0.1 (it was just released). (stack: rev f06d62652b2fb36c968dd51aff68a7456abe56ab) * (edit) pom.xml > Move on to hbase-thirdparty 1.0.1 (it was just released). > - > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18707.master.001 (1).patch, > HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18568:
---
Status: Patch Available (was: Open)
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144629#comment-16144629
]
Shibin Zhang edited comment on HBASE-18568 at 8/29/17 1:25 AM:
---
[~tedyu] [~carp84] Is this a problem ?
was (Author: zhangshibin):
[~tedyu]Is this a problem ?
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18568) Correct Regions metric of numRegions
[
https://issues.apache.org/jira/browse/HBASE-18568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144629#comment-16144629
]
Shibin Zhang commented on HBASE-18568:
--
[~tedyu]Is this a problem ?
> Correct Regions metric of numRegions
> --
>
> Key: HBASE-18568
> URL: https://issues.apache.org/jira/browse/HBASE-18568
> Project: HBase
> Issue Type: Bug
> Components: metrics
>Affects Versions: 3.0.0
>Reporter: Shibin Zhang
>Assignee: Shibin Zhang
>Priority: Critical
> Attachments: HBASE-18568-V1.patch
>
>
> i found the value of metric numReigons in Regions is not correct.
> the metric can not add or remove region correctly as region close or open.
> the metric as follow:
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "numRegions" : 2,
> after trouble shooting ,i found the reason is in
> MetricsRegionSourceImpl#MetricsRegionSourceImpl
> {code:java}
> agg.register(this);
> ...
> hashCode = regionWrapper.getRegionHashCode();
> {code}
> when add the MetricsRegionSource to set ,but the hashCode has not yet
> initialized.
> So, the setFromMap can put or remove the object correctly.
> it will be better like this :
> {code:java}
> hashCode = regionWrapper.getRegionHashCode();
> agg.register(this);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[
https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144619#comment-16144619
]
Hadoop QA commented on HBASE-18577:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
27s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
15s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
24s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
15s{color} | {color:green} hbase-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
11s{color} | {color:green} hbase-shaded-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
10s{color} | {color:green} hbase-shaded-check-invariants in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}178m
24s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
45s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}247m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18577 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884122/HBASE-18577.6.patch |
| Optional Tests | asflicense javac javadoc unit xml compile shellcheck
shelldocs |
| uname | Linux e07616ab59aa 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a2b110e |
| Default Java | 1.8.0_144 |
| shellcheck | v0.4.6 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8373/testReport/ |
| modules | C: hbase-client hbase-shaded hbase-shaded/hbase-shaded-server
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[
https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144611#comment-16144611
]
Hadoop QA commented on HBASE-18577:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
54s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
53s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
45s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
44s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
45s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
19s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
34s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 58s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
16s{color} | {color:green} hbase-client-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 13 unchanged - 13 fixed = 13 total (was 26) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} hbase-shaded in the patch passed with JDK v1.8.0_144.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} hbase-shaded-client in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
8s{color} | {color:green} hbase-shaded-server in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
7s{color} | {color:green} hbase-shaded-check-invariants in the patch passed
with JDK v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} root in the patch passed with JDK v1.8.0_144.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} hbase-client-jdk1.7.0_131 with JDK v1.7.0_131
generated 0 new + 13 unchanged - 13 fixed = 13 total (was 26) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} |
[jira] [Commented] (HBASE-18699) Copy LoadIncrementalHFiles to another package and mark the old one as deprecated
[ https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144609#comment-16144609 ] Appy commented on HBASE-18699: -- (y) > Copy LoadIncrementalHFiles to another package and mark the old one as > deprecated > > > Key: HBASE-18699 > URL: https://issues.apache.org/jira/browse/HBASE-18699 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > > LoadIncrementalHFiles does not depend on map reduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18699) Copy LoadIncrementalHFiles to another package and mark the old one as deprecated
[ https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-18699: - Assignee: Duo Zhang > Copy LoadIncrementalHFiles to another package and mark the old one as > deprecated > > > Key: HBASE-18699 > URL: https://issues.apache.org/jira/browse/HBASE-18699 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > > LoadIncrementalHFiles does not depend on map reduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18699) Copy LoadIncrementalHFiles to another package and mark the old one as deprecated
[ https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-18699: -- Summary: Copy LoadIncrementalHFiles to another package and mark the old one as deprecated (was: Move LoadIncrementalHFiles to another package) > Copy LoadIncrementalHFiles to another package and mark the old one as > deprecated > > > Key: HBASE-18699 > URL: https://issues.apache.org/jira/browse/HBASE-18699 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > > LoadIncrementalHFiles does not depend on map reduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18699) Move LoadIncrementalHFiles to another package
[ https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144598#comment-16144598 ] Duo Zhang commented on HBASE-18699: --- You are right [~appy]. We copy the code to o.a.h.h.tools and mark the old one as deprecated. I can help doing this if you do not mind. Thanks. > Move LoadIncrementalHFiles to another package > - > > Key: HBASE-18699 > URL: https://issues.apache.org/jira/browse/HBASE-18699 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang > Fix For: 3.0.0, 2.0.0-alpha-3 > > > LoadIncrementalHFiles does not depend on map reduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18699) Move LoadIncrementalHFiles to another package
[
https://issues.apache.org/jira/browse/HBASE-18699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144584#comment-16144584
]
Appy commented on HBASE-18699:
--
I thought of doing that. But the problem is, it's marked IA.Public. I don't
think we can break that compat without marking it deprecated for at least a
major version.
So probably we should make this jira about ' deprecate LoadIncrementalHFiles
from o.a.h.h.mapreduce package'.
A simple way would be, move this class to {{o.a.h.h.tools}}, and make current
one deprecated and extend the one in tool. That should work, right?
> Move LoadIncrementalHFiles to another package
> -
>
> Key: HBASE-18699
> URL: https://issues.apache.org/jira/browse/HBASE-18699
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
>Reporter: Duo Zhang
> Fix For: 3.0.0, 2.0.0-alpha-3
>
>
> LoadIncrementalHFiles does not depend on map reduce.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18697) Need a shaded hbase-mapreduce module
[ https://issues.apache.org/jira/browse/HBASE-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy reassigned HBASE-18697: Assignee: Appy > Need a shaded hbase-mapreduce module > > > Key: HBASE-18697 > URL: https://issues.apache.org/jira/browse/HBASE-18697 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Appy > Fix For: 3.0.0, 2.0.0-alpha-3 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[
https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144564#comment-16144564
]
Sean Busbey commented on HBASE-18577:
-
{quote}
Why the sadness?
bq.
The parent pom can't do it for this sub pom?
Maybe take a look in modules. I think the additions to root pom have mentions
in modules. Could change these to make use of your new addtion?
Looks great.
{quote}
the sadness is because our root pom defines those dependencies for all child
poms, regardless of if we need them. the maven best practice would be to use a
{{dependencyManagement}} entry to do any project-wide configuration or version
setting and then only list the dependencies in modules that need them
specifically. It's a refactoring that probably will have a long tail of side
effects, so I don't want to tackle it yet.
> shaded client includes several non-relocated third party dependencies
> -
>
> Key: HBASE-18577
> URL: https://issues.apache.org/jira/browse/HBASE-18577
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13
>
> Attachments: HBASE-18577.6.patch, HBASE-18577-branch-1.v6.patch,
> HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch,
> HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch,
> HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch
>
>
> we have some unexpected unrelocated third party dependencies in our shaded
> artifacts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18700) Document the new changes on mapreduce stuffs
[ https://issues.apache.org/jira/browse/HBASE-18700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reassigned HBASE-18700: - Assignee: stack > Document the new changes on mapreduce stuffs > > > Key: HBASE-18700 > URL: https://issues.apache.org/jira/browse/HBASE-18700 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 3.0.0, 2.0.0-alpha-3 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-18698) MapreduceDependencyClasspathTool does not include hbase-server as a dependency
[ https://issues.apache.org/jira/browse/HBASE-18698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reassigned HBASE-18698: - Assignee: stack > MapreduceDependencyClasspathTool does not include hbase-server as a dependency > -- > > Key: HBASE-18698 > URL: https://issues.apache.org/jira/browse/HBASE-18698 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Duo Zhang >Assignee: stack > Fix For: 3.0.0, 2.0.0-alpha-3 > > > This would introduce runtime errors when using snapshot input format. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18696) Fix the problems when introducing the new hbase-mapreduce module
[ https://issues.apache.org/jira/browse/HBASE-18696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144556#comment-16144556 ] Appy commented on HBASE-18696: -- Pre discussions on this topic can be found in jira HBASE-18640 start with [this comment| https://issues.apache.org/jira/browse/HBASE-18640?focusedCommentId=16143234=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16143234] by [~busbey]. Also, thanks again [~Apache9] for starting this blocker. I'll start on these tasks right away. Let me arrange these tasks in the [priority] order i'll work on them . > Fix the problems when introducing the new hbase-mapreduce module > > > Key: HBASE-18696 > URL: https://issues.apache.org/jira/browse/HBASE-18696 > Project: HBase > Issue Type: Umbrella > Components: mapreduce >Affects Versions: 3.0.0, 2.0.0-alpha-2 >Reporter: Duo Zhang >Priority: Blocker > Fix For: 3.0.0, 2.0.0-alpha-3 > > > See the comment in HBASE-18640 > https://issues.apache.org/jira/browse/HBASE-18640?focusedCommentId=16143234=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16143234 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144553#comment-16144553 ] stack commented on HBASE-18640: --- @appy I am on the doc and basic CLASSPATH issues. I presume you'll work on the shading item. > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18712: --- Status: Patch Available (was: Open) > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18712) Specify MaxPermSize for surefire tests
[ https://issues.apache.org/jira/browse/HBASE-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-18712: --- Attachment: 18712.v1.txt With patch v1, I ran test suite several times where I haven't seen 'terminated without saying properly goodbye' error. > Specify MaxPermSize for surefire tests > -- > > Key: HBASE-18712 > URL: https://issues.apache.org/jira/browse/HBASE-18712 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 18712.v1.txt > > > Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test > run(s). > This sometimes resulted in mvn build prematurely exiting, leaving some large > tests behind. > The tests would be deemed timed out. > As indicated by the following post: > https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi > We should specify large enough MaxPermSize so that mvn build doesn't end > prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144548#comment-16144548 ] Appy commented on HBASE-18640: -- I'll work on these followup tasks. Thanks a lot [~busbey] for listing them and [~Apache9] for starting the blockers jira! Let's continue the discussion on HBASE-18696. > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18710: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: (was: 2.0.0) 2.0.0-alpha-3 Status: Resolved (was: Patch Available) Pushed to branch-2 and master. > Move on to hbase-thirdparty 1.0.1 (it was just released). > - > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18707.master.001 (1).patch, > HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18712) Specify MaxPermSize for surefire tests
Ted Yu created HBASE-18712: -- Summary: Specify MaxPermSize for surefire tests Key: HBASE-18712 URL: https://issues.apache.org/jira/browse/HBASE-18712 Project: HBase Issue Type: Bug Reporter: Ted Yu Assignee: Ted Yu Currently hbase-surefire.argLine doesn't specify MaxPermSize for the test run(s). This sometimes resulted in mvn build prematurely exiting, leaving some large tests behind. The tests would be deemed timed out. As indicated by the following post: https://stackoverflow.com/questions/23260057/the-forked-vm-terminated-without-saying-properly-goodbye-vm-crash-or-system-exi We should specify large enough MaxPermSize so that mvn build doesn't end prematurely. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[
https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144537#comment-16144537
]
Hadoop QA commented on HBASE-18710:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
43m 19s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
50s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 54m 26s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18710 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884144/HBASE-18707.master.001%20%281%29.patch
|
| Optional Tests | asflicense javac javadoc unit |
| uname | Linux 0cbe099f02bb 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / a2b110e |
| Default Java | 1.8.0_144 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/8375/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/8375/artifact/patchprocess/whitespace-tabs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8375/testReport/ |
| modules | C: hbase-rest U: hbase-rest |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8375/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move on to hbase-thirdparty 1.0.1 (it was just released).
> -
>
> Key: HBASE-18710
> URL: https://issues.apache.org/jira/browse/HBASE-18710
> Project: HBase
> Issue Type: Task
> Components: hbase-thirdparty
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0
>
> Attachments: HBASE-18707.master.001 (1).patch,
> HBASE-18710.branch-2.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144504#comment-16144504 ] Hadoop QA commented on HBASE-18674: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/8376/console in case of problems. > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > hbase-18674.master.002.patch, hbase-18674.master.002.patch, > hbase-18674.master.003.patch, hbase-18674.master.004.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144498#comment-16144498 ] Umesh Agashe commented on HBASE-18674: -- Thanks [~stack]! I have rebased to latest master. You can try patch 004 or we can wait for hadoopqa build to finish for latest patch. > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > hbase-18674.master.002.patch, hbase-18674.master.002.patch, > hbase-18674.master.003.patch, hbase-18674.master.004.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18674: - Attachment: hbase-18674.master.004.patch rebased on latest master > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > hbase-18674.master.002.patch, hbase-18674.master.002.patch, > hbase-18674.master.003.patch, hbase-18674.master.004.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144487#comment-16144487 ] stack commented on HBASE-18674: --- I tried before patch, a general build then builds in server and replication and these work. Patch doesn't apply any more for me [~uagashe] > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > hbase-18674.master.002.patch, hbase-18674.master.002.patch, > hbase-18674.master.003.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144484#comment-16144484 ] stack commented on HBASE-18577: --- On commit, could beef up description w/ examples of what invariants are being enforced (e.g. I didn't get it was maven enforcer until I read down -- even then, it seems like nice new enforcer tricks that are being deployed her relative to our other uses of enforcer). Enforces our invariants for our shaded artifacts. Related, add a 'what this script does' to your fancy ensure-jars-have-correct-contents.sh trick script: e.g. what it gets from pom on cmd-line? Why the sadness? The parent pom can't do it for this sub pom? Maybe take a look in modules. I think the additions to root pom have mentions in modules. Could change these to make use of your new addtion? Looks great. > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.6.patch, HBASE-18577-branch-1.v6.patch, > HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch, > HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch, > HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18710: -- Attachment: HBASE-18707.master.001 (1).patch Retry > Move on to hbase-thirdparty 1.0.1 (it was just released). > - > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18707.master.001 (1).patch, > HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[
https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144452#comment-16144452
]
Hadoop QA commented on HBASE-18710:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
43s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
9s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
19s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 74m 56s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
30s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}142m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.trace.TestHTraceHooks |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.TestFullLogReconstruction |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.apache.hadoop.hbase.security.access.TestAccessController3 |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.wal.TestWALFiltering |
| | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics |
| | org.apache.hadoop.hbase.security.access.TestAccessController2 |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncDrainAdminApi |
| | org.apache.hadoop.hbase.wal.TestWALSplitCompressed |
| | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| |
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[
https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144423#comment-16144423
]
Sean Busbey commented on HBASE-18674:
-
the log output is linked in the table at the end, e.g. [failure in
hbase-server|https://builds.apache.org/job/PreCommit-HBASE-Build/8311/artifact/patchprocess/patch-mvninstall-hbase-server.txt].
should start with a command you can use to replicate the problem locally
(after first doing a {{mvn install}} at the top level before the patch)
> upgrade hbase to commons-lang3
> --
>
> Key: HBASE-18674
> URL: https://issues.apache.org/jira/browse/HBASE-18674
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 2.0.0-alpha-2
>Reporter: Umesh Agashe
>Assignee: Umesh Agashe
> Fix For: 2.0.0
>
> Attachments: hbase-18674.master.001.patch,
> hbase-18674.master.002.patch, hbase-18674.master.002.patch,
> hbase-18674.master.003.patch
>
>
> upgrade hbase to use commons-lang 3.6
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18577: Attachment: HBASE-18577-branch-1.v6.patch attaching version for branch-1 and earlier - leave logger backed for slf4j as non-optional - keep some hadoop mr/yarn stuff in the shaded client, due to TokenUtil (leaves all of it in hbase-client, prunes web related stuff in shaded instances) - upgrade the enforcer plugin > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.6.patch, HBASE-18577-branch-1.v6.patch, > HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch, > HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch, > HBASE-18577.WIP.5.patch, HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work started] (HBASE-18708) Configure on-heap bucketCache size using percentage of heap size
[
https://issues.apache.org/jira/browse/HBASE-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-18708 started by Biju Nair.
-
> Configure on-heap bucketCache size using percentage of heap size
>
>
> Key: HBASE-18708
> URL: https://issues.apache.org/jira/browse/HBASE-18708
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
>
> Currently heap allocations for RS memory structures like {{memstore}} and
> {{lruCache}} are configured as percentage of total RS heap size. Since
> on-heap bucketCache uses RS heap, configuring it as a percentage of heap size
> will improve usability. Currently this can be configured either as a
> percentage of heap or a memory size in MiB and we can remove the latter
> option which is applicable to external or off-heap bucketCache.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (HBASE-18708) Configure on-heap bucketCache size using percentage of heap size
[
https://issues.apache.org/jira/browse/HBASE-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Biju Nair reassigned HBASE-18708:
-
Assignee: Biju Nair
> Configure on-heap bucketCache size using percentage of heap size
>
>
> Key: HBASE-18708
> URL: https://issues.apache.org/jira/browse/HBASE-18708
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Trivial
>
> Currently heap allocations for RS memory structures like {{memstore}} and
> {{lruCache}} are configured as percentage of total RS heap size. Since
> on-heap bucketCache uses RS heap, configuring it as a percentage of heap size
> will improve usability. Currently this can be configured either as a
> percentage of heap or a memory size in MiB and we can remove the latter
> option which is applicable to external or off-heap bucketCache.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[
https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144359#comment-16144359
]
Hadoop QA commented on HBASE-3935:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
20s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
1s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
41s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
32s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
34m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
27s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
19s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
33s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 95m
35s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
57s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
4s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}172m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:3c8b364 |
| JIRA Issue | HBASE-3935 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884092/HBASE-3935.branch-2.v6.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile cc hbaseprotoc |
[jira] [Updated] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18577: Attachment: HBASE-18577.6.patch -06 - no longer WIP. works based on testing branch-1.2 backport (see above) - log4j now marked as non-optional (needed for hadoop 2 installs) > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.6.patch, HBASE-18577.WIP.0.patch, > HBASE-18577.WIP.-1.patch, HBASE-18577.WIP.1.patch, HBASE-18577.WIP.2.patch, > HBASE-18577.WIP.3.patch, HBASE-18577.WIP.4.patch, HBASE-18577.WIP.5.patch, > HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144322#comment-16144322 ] Hudson commented on HBASE-18640: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3614 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3614/]) HBASE-18640 (Addendum) Remove the redundant dependency (chia7712: rev e219d34694783383f580067053614f6e6b227b03) * (edit) hbase-it/pom.xml > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144325#comment-16144325 ] Hudson commented on HBASE-18692: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3614 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3614/]) HBASE-18692 [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes (stack: rev a2b110e0fa82e98e100b70210101efc727f313ec) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java > [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int > - > > Key: HBASE-18692 > URL: https://issues.apache.org/jira/browse/HBASE-18692 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18692.master.001.patch > > > [~ram_krish] You need this change? BBUtils was public back in 1.0 and > ByteBufferUtils.copyFromBufferToBuffer > returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) > changed it to return an int. You think we need this? I can try undoing it. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18369) hbase thrift web-ui not available
[
https://issues.apache.org/jira/browse/HBASE-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144324#comment-16144324
]
Hudson commented on HBASE-18369:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3614 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3614/])
HBASE-18369 hbase thrift web-ui not available (tedyu: rev
bbf23d9627849c32ee6914c1350da02bceba5127)
* (delete) hbase-server/src/main/resources/hbase-webapps/thrift/index.html
* (edit) bin/hbase
* (delete) hbase-server/src/main/resources/hbase-webapps/thrift/thrift.jsp
> hbase thrift web-ui not available
> -
>
> Key: HBASE-18369
> URL: https://issues.apache.org/jira/browse/HBASE-18369
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 2.0.0
>Reporter: Peter Somogyi
>Assignee: Tamas Penzes
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18369.master.001.patch,
> HBASE-18369.master.002.patch
>
>
> In standalone mode hbase thrift web-ui is gives 404 error.
> {code}
> $ ./bin/start-hbase.sh
> running master, logging to
> /Users/peter.somogyi/hbase/bin/../logs/hbase-peter.somogyi-master-psomogyi-MBP.local.out
> $ ./bin/hbase thrift start
> ...
> Jul 12, 2017 12:32:03 PM org.apache.jasper.servlet.JspServlet serviceJspFile
> SEVERE: PWC6117: File
> "/Users/peter.somogyi/hbase/hbase-server/target/hbase-webapps/thrift/thrift.jsp"
> not found
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18701) Optimize reference guide to use cell acl conveniently
[ https://issues.apache.org/jira/browse/HBASE-18701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144323#comment-16144323 ] Hudson commented on HBASE-18701: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3614 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3614/]) HBASE-18701 Optimize reference guide to use cell acl conveniently (tedyu: rev f1b3528d791e01427c98d7209f266cfa2380778c) * (edit) src/main/asciidoc/_chapters/security.adoc > Optimize reference guide to use cell acl conveniently > - > > Key: HBASE-18701 > URL: https://issues.apache.org/jira/browse/HBASE-18701 > Project: HBase > Issue Type: Improvement >Reporter: Shibin Zhang >Assignee: Shibin Zhang >Priority: Trivial > Fix For: 3.0.0 > > Attachments: HBASE-18701.patch > > > When i use cell acl,i found it didn't work ,and without related settings > explain in hbase reference guide. After i read the code , i found we need to > change two option value in hbase-site.xml.It is user unfriendly to use cell > acl function.So, i think we need to explain how to enable this function in > reference guide. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just released).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18710: -- Summary: Move on to hbase-thirdparty 1.0.1 (it was just released). (was: Move on to hbase-thirdparty 1.0.1 (it was just release).) > Move on to hbase-thirdparty 1.0.1 (it was just released). > - > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[
https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144291#comment-16144291
]
Sean Busbey edited comment on HBASE-18577 at 8/28/17 8:26 PM:
--
all of below presumes you've set up any named tables, and the needed jars are
in the working directory.
Test of hbase-downstreamer:
{code}
$ /usr/java/jdk1.8.0_111/bin/java -cp
/etc/hbase/conf:hbase-downstreamer-api-1.y-2.0-SNAPSHOT-1.2.6_2.6.1.jar:hbase-shaded-client-1.2.7-SNAPSHOT.jar:commons-logging-1.2.jar:log4j-1.2.17.jar:slf4j-api-1.7.5.jar:htrace-core-3.2.0-incubating.jar
org.hbase.downstreamer.GetMetaContent cdh-57464-1.gce.cloudera.com:2181
2>/dev/null
{code}
Test of built in MR examples:
{code}
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
rowcounter 'test:exampe'
$ # After updating mapreduce.job.counters.max to be > 12,000
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
CellCounter "test:exampe" cellcounter-out :
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
export 'test:exampe' 'export-output'
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
import 'test:import_target' 'export-output'
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
rowcounter 'test:import_target'
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.HashTable 'test:exampe' 'hashtable-out'
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.SyncTable 'hashtable-out' 'test:exampe'
'test:import_target'
{code}
All of the above gave expected results.
I think this all works. I'll update the log4j as non-optional for
master/branch-2 and post here shortly
was (Author: busbey):
all of below presumes you've set up any named tables, and the needed jars are
in the working directory.
Test of hbase-downstreamer:
{code}
$ /usr/java/jdk1.8.0_111/bin/java -cp
/etc/hbase/conf:hbase-downstreamer-api-1.y-2.0-SNAPSHOT-1.2.6_2.6.1.jar:hbase-shaded-client-1.2.7-SNAPSHOT.jar:commons-logging-1.2.jar:log4j-1.2.17.jar:slf4j-api-1.7.5.jar:htrace-core-3.2.0-incubating.jar
org.hbase.downstreamer.GetMetaContent cdh-57464-1.gce.cloudera.com:2181
2>/dev/null
{code}
Test of built in MR examples:
{code}
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
rowcounter 'test:exampe'
$ # After updating mapreduce.job.counters.max to be > 12,000
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver CellCounter "test:exampe"
cellcounter-out :
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver export 'test:exampe' 'export-output'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver import 'test:import_target'
'export-output'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver rowcounter 'test:import_target'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.HashTable 'test:exampe' 'hashtable-out'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.SyncTable 'hashtable-out' 'test:exampe'
'test:import_target'
{code}
All of the above gave expected results.
I think this all works. I'll update the log4j as non-optional for
master/branch-2 and post here shortly
> shaded client includes several non-relocated third party dependencies
> -
>
> Key: HBASE-18577
> URL:
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[
https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144291#comment-16144291
]
Sean Busbey commented on HBASE-18577:
-
all of below presumes you've set up any named tables, and the needed jars are
in the working directory.
Test of hbase-downstreamer:
{code}
$ /usr/java/jdk1.8.0_111/bin/java -cp
/etc/hbase/conf:hbase-downstreamer-api-1.y-2.0-SNAPSHOT-1.2.6_2.6.1.jar:hbase-shaded-client-1.2.7-SNAPSHOT.jar:commons-logging-1.2.jar:log4j-1.2.17.jar:slf4j-api-1.7.5.jar:htrace-core-3.2.0-incubating.jar
org.hbase.downstreamer.GetMetaContent cdh-57464-1.gce.cloudera.com:2181
2>/dev/null
{code}
Test of built in MR examples:
{code}
$ HADOOP_CLASSPATH=/etc/hbase/conf:htrace-core-3.2.0-incubating.jar hadoop jar
hbase-shaded-server-1.2.7-SNAPSHOT.jar org.apache.hadoop.hbase.mapreduce.Driver
rowcounter 'test:exampe'
$ # After updating mapreduce.job.counters.max to be > 12,000
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver CellCounter "test:exampe"
cellcounter-out :
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver export 'test:exampe' 'export-output'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver import 'test:import_target'
'export-output'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.Driver rowcounter 'test:import_target'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.HashTable 'test:exampe' 'hashtable-out'
$
HADOOP_CLASSPATH=/etc/hbase/conf:/opt/cloudera/parcels/CDH/jars/htrace-core-3.2.0-incubating.jar
hadoop jar hbase-shaded-server-1.2.7-SNAPSHOT.jar
org.apache.hadoop.hbase.mapreduce.SyncTable 'hashtable-out' 'test:exampe'
'test:import_target'
{code}
All of the above gave expected results.
I think this all works. I'll update the log4j as non-optional for
master/branch-2 and post here shortly
> shaded client includes several non-relocated third party dependencies
> -
>
> Key: HBASE-18577
> URL: https://issues.apache.org/jira/browse/HBASE-18577
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13
>
> Attachments: HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch,
> HBASE-18577.WIP.1.patch, HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch,
> HBASE-18577.WIP.4.patch, HBASE-18577.WIP.5.patch,
> HBASE-18577.WIP-branch-1.2.v5.patch
>
>
> we have some unexpected unrelocated third party dependencies in our shaded
> artifacts.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18369) hbase thrift web-ui not available
[
https://issues.apache.org/jira/browse/HBASE-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144280#comment-16144280
]
Hadoop QA commented on HBASE-18369:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
4s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
59s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 89m
4s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}142m
45s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
46s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}284m 13s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884064/HBASE-18369.master.002.patch
|
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit |
| uname | Linux c66af2d55cd3 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f1b3528 |
| Default Java | 1.8.0_144 |
| shellcheck | v0.4.6 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8368/testReport/ |
| modules | C: hbase-server . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8368/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> hbase thrift web-ui not available
> -
>
> Key: HBASE-18369
> URL: https://issues.apache.org/jira/browse/HBASE-18369
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 2.0.0
>Reporter: Peter Somogyi
>Assignee: Tamas Penzes
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18369.master.001.patch,
> HBASE-18369.master.002.patch
>
>
> In standalone mode hbase thrift web-ui is gives 404 error.
> {code}
> $ ./bin/start-hbase.sh
> running master, logging to
> /Users/peter.somogyi/hbase/bin/../logs/hbase-peter.somogyi-master-psomogyi-MBP.local.out
> $ ./bin/hbase thrift
[jira] [Assigned] (HBASE-18652) Expose individual cache stats in a CombinedCache through JMX
[ https://issues.apache.org/jira/browse/HBASE-18652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biju Nair reassigned HBASE-18652: - Assignee: Biju Nair > Expose individual cache stats in a CombinedCache through JMX > > > Key: HBASE-18652 > URL: https://issues.apache.org/jira/browse/HBASE-18652 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Biju Nair >Assignee: Biju Nair > > With offHeap cache being used to store data blocks and on-heap for index and > bloom filters, exposing the stats from the individual caches through JMX will > help understand the cache usage trend. Currently the combined cache stats is > available through JMX which may not provide insight into the individual cache > usage. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-3935) HServerLoad.storefileIndexSizeMB should be changed to storefileIndexSizeKB
[
https://issues.apache.org/jira/browse/HBASE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144267#comment-16144267
]
Hadoop QA commented on HBASE-3935:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
19s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
48s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
32s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
30s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
38s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
53s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 18s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
1m 28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
19s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
22s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}113m
27s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
21s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}199m 21s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:3c8b364 |
| JIRA Issue | HBASE-3935 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12884082/HBASE-3935.branch-2.v5.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile cc
[jira] [Commented] (HBASE-18665) ReversedScannerCallable invokes getRegionLocations incorrectly
[ https://issues.apache.org/jira/browse/HBASE-18665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144265#comment-16144265 ] Ted Yu commented on HBASE-18665: Tests passed. If there is no more review comment, I plan to integrate tomorrow morning. > ReversedScannerCallable invokes getRegionLocations incorrectly > -- > > Key: HBASE-18665 > URL: https://issues.apache.org/jira/browse/HBASE-18665 > Project: HBase > Issue Type: Bug >Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 >Reporter: Peter Somogyi >Assignee: Peter Somogyi > Attachments: 18665.master.003.patch, HBASE-18665.branch-1.003.patch, > HBASE-18665.branch-1.003.patch, HBASE-18665.master.001.patch, > HBASE-18665.master.002.patch, HBASE-18665.master.003.patch, > HBASE-18665.master.003.patch > > > The behavior of ReversedScannerCallable#prepare [1] and > ScannerCallable#prepare [2] methods differ how they call > RpcRetryingCallerWithReadReplicas.getRegionLocations method. > The reversed scanner uses the 'reload' parameter directly as the first > argument - RpcRetryingCallerWithReadReplicas.getRegionLocations(reload, id, > getConnection(), getTableName(), getRow()) - however, the forward scanner > passes '!reload'. The getRegionLocations first parameter is 'useCache', the > way we use it in ScannerCallable is the correct one. > The same call can be found in ReversedScannerCallable#locateRegionsInRange > [3] also without negating its value. > [1] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L89-L90 > [2] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java#L139-L140 > [3] > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedScannerCallable.java#L143-L144 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144249#comment-16144249 ] Sean Busbey commented on HBASE-18577: - file HBASE-18711 based on not being able to swap in the shaded-server jar for the instructions in the ref guide > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, > HBASE-18577.WIP.1.patch, HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, > HBASE-18577.WIP.4.patch, HBASE-18577.WIP.5.patch, > HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18711) hbase shaded artifact for MR support utilities should have the mapreduce.Driver as its mainclass
Sean Busbey created HBASE-18711:
---
Summary: hbase shaded artifact for MR support utilities should
have the mapreduce.Driver as its mainclass
Key: HBASE-18711
URL: https://issues.apache.org/jira/browse/HBASE-18711
Project: HBase
Issue Type: Improvement
Components: mapreduce
Affects Versions: 1.1.12, 2.0.0-alpha-2, 1.2.6, 1.3.1, 1.4.0
Reporter: Sean Busbey
to match the docs on using the non-shaded module for mapreduce support
utilities, we should ensure the shaded version defines the same mainclass.
(workaround, pass {{org.apache.hadoop.hbase.mapreduce.Driver}} as the class for
{{hadoop jar}})
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just release).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18710: -- Status: Patch Available (was: Open) > Move on to hbase-thirdparty 1.0.1 (it was just release). > > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144247#comment-16144247 ] stack commented on HBASE-18640: --- Thanks for clarification. Makes more sense now. > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144244#comment-16144244
]
Sean Busbey commented on HBASE-18640:
-
the {{git reset}} line in my examples is going back to the commit before this
fix went in. Probably should have annotated that. :X
> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> ---
>
> Key: HBASE-18640
> URL: https://issues.apache.org/jira/browse/HBASE-18640
> Project: HBase
> Issue Type: Bug
>Reporter: Appy
>Assignee: Appy
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18640.branch-2.001.patch,
> HBASE-18640.master.001.patch, HBASE-18640.master.002.patch,
> HBASE-18640.master.003.patch, HBASE-18640.master.003.patch,
> HBASE-18640.master.004.patch, HBASE-18640.master.004.patch,
> HBASE-18640.master.005.patch, HBASE-18640.master.006.patch,
> HBASE-18640.master.007.patch, HBASE-18640.master.008.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively
> coupled with visibility labels/wal/filesystem/hfile. These can not be
> migrated to new module until corresponding subcomponents are untangled out of
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to
> hbase-mapreduce module. Given these dependency constraints, one way would be
> having a separate module for tests:
> hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144242#comment-16144242 ] Sean Busbey commented on HBASE-18640: - sorry boss on the lack of clarity. the contents is the opposite of what you say above. Previously it had all the MR classes and now it has just the load tool. I don't think we've ever gotten a ref guide entry for the shaded artifacts put together. there was some talk of pushing folks towards them more for 2.0, but I dont' think we ever got boots on the ground for either a docs update nor an artifact refactoring (I'd favor the former, personally). > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just release).
[ https://issues.apache.org/jira/browse/HBASE-18710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18710: -- Attachment: HBASE-18710.branch-2.001.patch > Move on to hbase-thirdparty 1.0.1 (it was just release). > > > Key: HBASE-18710 > URL: https://issues.apache.org/jira/browse/HBASE-18710 > Project: HBase > Issue Type: Task > Components: hbase-thirdparty >Reporter: stack >Assignee: stack > Fix For: 2.0.0 > > Attachments: HBASE-18710.branch-2.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18710) Move on to hbase-thirdparty 1.0.1 (it was just release).
stack created HBASE-18710: - Summary: Move on to hbase-thirdparty 1.0.1 (it was just release). Key: HBASE-18710 URL: https://issues.apache.org/jira/browse/HBASE-18710 Project: HBase Issue Type: Task Components: hbase-thirdparty Reporter: stack Assignee: stack Fix For: 2.0.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18577) shaded client includes several non-relocated third party dependencies
[ https://issues.apache.org/jira/browse/HBASE-18577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144240#comment-16144240 ] Sean Busbey commented on HBASE-18577: - okay, finished testing updating YCSB. on the maintenance release branches, we need to not change any of the logging stuff to optional because it's definitely surprising. :/ > shaded client includes several non-relocated third party dependencies > - > > Key: HBASE-18577 > URL: https://issues.apache.org/jira/browse/HBASE-18577 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.2.0, 1.1.2, 1.3.0, 2.0.0-alpha-1 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Critical > Fix For: 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3, 1.1.13 > > Attachments: HBASE-18577.WIP.0.patch, HBASE-18577.WIP.-1.patch, > HBASE-18577.WIP.1.patch, HBASE-18577.WIP.2.patch, HBASE-18577.WIP.3.patch, > HBASE-18577.WIP.4.patch, HBASE-18577.WIP.5.patch, > HBASE-18577.WIP-branch-1.2.v5.patch > > > we have some unexpected unrelocated third party dependencies in our shaded > artifacts. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18692) [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int
[ https://issues.apache.org/jira/browse/HBASE-18692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144232#comment-16144232 ] Hudson commented on HBASE-18692: FAILURE: Integrated in Jenkins build HBase-2.0 #413 (See [https://builds.apache.org/job/HBase-2.0/413/]) HBASE-18692 [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes (stack: rev 5053ed954506f2d5d4ed3f13153ef32472617771) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java > [compat 1-2] ByteBufferUtils.copyFromBufferToBuffer goes from void to int > - > > Key: HBASE-18692 > URL: https://issues.apache.org/jira/browse/HBASE-18692 > Project: HBase > Issue Type: Sub-task > Components: API >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18692.master.001.patch > > > [~ram_krish] You need this change? BBUtils was public back in 1.0 and > ByteBufferUtils.copyFromBufferToBuffer > returned a void. HBASE-12213 HFileBlock backed by Array of ByteBuffers (Ram) > changed it to return an int. You think we need this? I can try undoing it. > Thanks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18640) Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
[ https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144230#comment-16144230 ] Hudson commented on HBASE-18640: FAILURE: Integrated in Jenkins build HBase-2.0 #413 (See [https://builds.apache.org/job/HBase-2.0/413/]) HBASE-18640 (Addendum) Remove the redundant dependency (chia7712: rev 152ad3025b47cc5026c960b4672f54ccf3db0675) * (edit) hbase-it/pom.xml > Move mapreduce out of hbase-server into separate hbase-mapreduce moduel > --- > > Key: HBASE-18640 > URL: https://issues.apache.org/jira/browse/HBASE-18640 > Project: HBase > Issue Type: Bug >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18640.branch-2.001.patch, > HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, > HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, > HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, > HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, > HBASE-18640.master.007.patch, HBASE-18640.master.008.patch > > > (Couldn't find another dedicated jira, so creating new one). > Uploaded patch which is moving ~60 files to the new module. Few notes: > - The classes remaining in hbase-server are the ones which are intensively > coupled with visibility labels/wal/filesystem/hfile. These can not be > migrated to new module until corresponding subcomponents are untangled out of > hbase-server into their own separate modules. > - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to > hbase-mapreduce module. Given these dependency constraints, one way would be > having a separate module for tests: > hbase-mapreduce < hbase-server <--- hbase-mapreduce-tests > Imo, this makes sense and looks fine. > The only issue is - yetus' pre-commit. It won't run tests in > hbase-mapreduce-tests module if something changed in just hbase-mapreduce. > However, yetus' limitation shouldn't warrant against the idea. > So i'd say that we should go that way, unless there are better suggestions. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18369) hbase thrift web-ui not available
[
https://issues.apache.org/jira/browse/HBASE-18369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144231#comment-16144231
]
Hudson commented on HBASE-18369:
FAILURE: Integrated in Jenkins build HBase-2.0 #413 (See
[https://builds.apache.org/job/HBase-2.0/413/])
HBASE-18369 hbase thrift web-ui not available (tedyu: rev
5531be160b2dc5136309163d52f4a0cd1ae1dcd3)
* (edit) bin/hbase
* (delete) hbase-server/src/main/resources/hbase-webapps/thrift/index.html
* (delete) hbase-server/src/main/resources/hbase-webapps/thrift/thrift.jsp
> hbase thrift web-ui not available
> -
>
> Key: HBASE-18369
> URL: https://issues.apache.org/jira/browse/HBASE-18369
> Project: HBase
> Issue Type: Bug
> Components: Thrift
>Affects Versions: 2.0.0
>Reporter: Peter Somogyi
>Assignee: Tamas Penzes
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18369.master.001.patch,
> HBASE-18369.master.002.patch
>
>
> In standalone mode hbase thrift web-ui is gives 404 error.
> {code}
> $ ./bin/start-hbase.sh
> running master, logging to
> /Users/peter.somogyi/hbase/bin/../logs/hbase-peter.somogyi-master-psomogyi-MBP.local.out
> $ ./bin/hbase thrift start
> ...
> Jul 12, 2017 12:32:03 PM org.apache.jasper.servlet.JspServlet serviceJspFile
> SEVERE: PWC6117: File
> "/Users/peter.somogyi/hbase/hbase-server/target/hbase-webapps/thrift/thrift.jsp"
> not found
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18709) [hbase-thirdparty] Clean out bundled proto files
[
https://issues.apache.org/jira/browse/HBASE-18709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144200#comment-16144200
]
stack commented on HBASE-18709:
---
Also fix this reported by [~carp84]
{code}2. Noticed patches-applied.txt in hbase-shaded-protobuf/target after
build,
maybe we could put the contents into CHANGES.txt?
{code}
> [hbase-thirdparty] Clean out bundled proto files
>
>
> Key: HBASE-18709
> URL: https://issues.apache.org/jira/browse/HBASE-18709
> Project: HBase
> Issue Type: Bug
> Components: hbase-thirdparty
>Reporter: stack
>
> From the 1.0.1 vote thread from [~Apache9]
> {code}
> There are some proto files which are still under the 'google' directory and
> the package in the proto files is not relocated, like this:
> option csharp_namespace = "Google.Protobuf.WellKnownTypes";
> option go_package = "github.com/golang/protobuf/ptypes/any";
> option java_package = "com.google.protobuf"; // < here
> option java_outer_classname = "AnyProto";
> option java_multiple_files = true;
> option objc_class_prefix = "GPB";
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (HBASE-18709) [hbase-thirdparty] Clean out bundled proto files
stack created HBASE-18709:
-
Summary: [hbase-thirdparty] Clean out bundled proto files
Key: HBASE-18709
URL: https://issues.apache.org/jira/browse/HBASE-18709
Project: HBase
Issue Type: Bug
Components: hbase-thirdparty
Reporter: stack
>From the 1.0.1 vote thread from [~Apache9]
{code}
There are some proto files which are still under the 'google' directory and
the package in the proto files is not relocated, like this:
option csharp_namespace = "Google.Protobuf.WellKnownTypes";
option go_package = "github.com/golang/protobuf/ptypes/any";
option java_package = "com.google.protobuf"; // < here
option java_outer_classname = "AnyProto";
option java_multiple_files = true;
option objc_class_prefix = "GPB";
...
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
