[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811481#comment-16811481
]
Hadoop QA commented on HBASE-22020:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 14m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/5/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22020 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965083/HBASE-22020-branch-1.v1.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 249001720ad1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1 / 3702e7f |
| maven | version: Apache Maven 3.0.5 |
| shellcheck | v0.4.7 |
| Max. process+thread count | 36 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/5/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811495#comment-16811495
]
Hudson commented on HBASE-20912:
Results for branch branch-1.2
[build #724 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/724/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/724//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/724//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.2/724//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811512#comment-16811512
]
Hudson commented on HBASE-20912:
Results for branch branch-1
[build #756 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/756/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/756//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/755//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/755//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811511#comment-16811511
]
Hudson commented on HBASE-20912:
Results for branch branch-1.3
[build #713 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/713/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/713//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/713//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/713//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[
https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811471#comment-16811471
]
Hadoop QA commented on HBASE-22174:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-22174 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965084/HBASE-22174.patch |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 89c9d6d3bf55 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul
13 08:53:17 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 6abf408f33 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| shellcheck | v0.4.4 |
| Max. process+thread count | 43 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Remove error prone from our precommit javac check
> -
>
> Key: HBASE-22174
> URL: https://issues.apache.org/jira/browse/HBASE-22174
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22174.patch
>
>
> As the result is not stable. Can add it back as a separated check later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[ https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811468#comment-16811468 ] Duo Zhang commented on HBASE-22174: --- Let me push to branch HBASE-22174, and see whether it works. > Remove error prone from our precommit javac check > - > > Key: HBASE-22174 > URL: https://issues.apache.org/jira/browse/HBASE-22174 > Project: HBase > Issue Type: Task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-22174.patch > > > As the result is not stable. Can add it back as a separated check later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[ https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811470#comment-16811470 ] Hadoop QA commented on HBASE-22174: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/3/console in case of problems. > Remove error prone from our precommit javac check > - > > Key: HBASE-22174 > URL: https://issues.apache.org/jira/browse/HBASE-22174 > Project: HBase > Issue Type: Task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-22174.patch > > > As the result is not stable. Can add it back as a separated check later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[ https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811479#comment-16811479 ] Sean Busbey commented on HBASE-22020: - build #5 looks to be going, but docker image building is taking a really long time. I gotta sign-off for the night. if it breaks folks should happily roll back my change without concern. > upgrade to yetus 0.9.0 > -- > > Key: HBASE-22020 > URL: https://issues.apache.org/jira/browse/HBASE-22020 > Project: HBase > Issue Type: Task > Components: build, community >Reporter: stack >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch, > HBASE-22020.1.patch > > > branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language > js can not be found" > See parent for some context. Checkstyle references dtds that were hosted on > puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing > for among other reasons, complaint that there is bad xml in the build... > notably, the unresolvable DTDs. > I'd just update the DTDs but there is a need for a js engine some where and > openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and > then we can backport the parent issue... > See > https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt > ... which in case its rolled away, is filled with this message: > "script engine for language js can not be found" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811477#comment-16811477
]
Hadoop QA commented on HBASE-22020:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 24m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 4s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:61288f8 |
| JIRA Issue | HBASE-22020 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965083/HBASE-22020-branch-1.v1.patch
|
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux 50fbc06d0b79 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | branch-1 / 3702e7f |
| maven | version: Apache Maven 3.0.5 |
| shellcheck | v0.4.7 |
| Max. process+thread count | 38 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[ https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811475#comment-16811475 ] Sean Busbey commented on HBASE-22020: - checked in with Duo on HBASE-22175 after he hit a speed bump and am now updating the old-style precommit job to use 0.9.0 > upgrade to yetus 0.9.0 > -- > > Key: HBASE-22020 > URL: https://issues.apache.org/jira/browse/HBASE-22020 > Project: HBase > Issue Type: Task > Components: build, community >Reporter: stack >Assignee: Sean Busbey >Priority: Major > Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch, > HBASE-22020.1.patch > > > branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language > js can not be found" > See parent for some context. Checkstyle references dtds that were hosted on > puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing > for among other reasons, complaint that there is bad xml in the build... > notably, the unresolvable DTDs. > I'd just update the DTDs but there is a need for a js engine some where and > openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and > then we can backport the parent issue... > See > https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt > ... which in case its rolled away, is filled with this message: > "script engine for language js can not be found" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-22174) Remove error prone from our precommit javac check
[ https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-22174: -- Attachment: HBASE-22174-HBASE-22174.patch > Remove error prone from our precommit javac check > - > > Key: HBASE-22174 > URL: https://issues.apache.org/jira/browse/HBASE-22174 > Project: HBase > Issue Type: Task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-22174-HBASE-22174.patch, HBASE-22174.patch > > > As the result is not stable. Can add it back as a separated check later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #114: for testing whether we skip the error prone check
Apache-HBase commented on issue #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114#issuecomment-480479908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 70 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ HBASE-22174 Compile Tests _ | | +1 | mvninstall | 314 | HBASE-22174 passed | | +1 | compile | 31 | HBASE-22174 passed | | +1 | checkstyle | 41 | HBASE-22174 passed | | +1 | shadedjars | 340 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 80 | HBASE-22174 passed | | +1 | javadoc | 28 | HBASE-22174 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 313 | the patch passed | | +1 | compile | 32 | the patch passed | | +1 | javac | 32 | the patch passed | | +1 | checkstyle | 39 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 330 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 644 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 87 | the patch passed | | +1 | javadoc | 27 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 237 | hbase-client in the patch passed. | | +1 | asflicense | 15 | The patch does not generate ASF License warnings. | | | | 2706 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-114/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/114 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux bdfecbd1ac96 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-22174 / 86f9443eeb | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-114/1/testReport/ | | Max. process+thread count | 293 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-114/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[ https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811473#comment-16811473 ] Duo Zhang commented on HBASE-22174: --- Ah, a bit strange. Why we do not have the "Re-executing" message on github... > Remove error prone from our precommit javac check > - > > Key: HBASE-22174 > URL: https://issues.apache.org/jira/browse/HBASE-22174 > Project: HBase > Issue Type: Task > Components: build >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-22174.patch > > > As the result is not stable. Can add it back as a separated check later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #114: for testing whether we skip the error prone check
Apache9 opened a new pull request #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[
https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811485#comment-16811485
]
Hadoop QA commented on HBASE-22174:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-22174 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} HBASE-22174 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} HBASE-22174 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} HBASE-22174 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
0s{color} | {color:green} HBASE-22174 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} HBASE-22174 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 48s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
9s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m 33s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/6/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22174 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12965085/HBASE-22174-HBASE-22174.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 670f79cd8fc5 4.4.0-131-generic #157~14.04.1-Ubuntu SMP Fri Jul
13 08:53:17 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | HBASE-22174 / 86f9443eeb |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/6/testReport/ |
| Max. process+thread count | 257 (vs. ulimit of 1) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811494#comment-16811494
]
Hudson commented on HBASE-20912:
Results for branch branch-2.1
[build #1026 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1026/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1026//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1026//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1026//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811502#comment-16811502
]
Hudson commented on HBASE-20912:
Results for branch branch-1.4
[build #733 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/733/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/733//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/733//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/733//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] hadoop-yetus commented on issue #115: test merge
hadoop-yetus commented on issue #115: test merge URL: https://github.com/apache/hbase/pull/115#issuecomment-480521154 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 268 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ HBASE-21512 Compile Tests _ | | +1 | mvninstall | 263 | HBASE-21512 passed | | +1 | compile | 633 | HBASE-21512 passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 154 | HBASE-21512 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 235 | the patch passed | | +1 | compile | 640 | the patch passed | | +1 | javac | 640 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 1 | The patch has no ill-formed XML file. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 524 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | javadoc | 160 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16775 | root in the patch failed. | | +1 | asflicense | 39 | The patch does not generate ASF License warnings. | | | | 20282 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSideWithCoprocessor | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestFromClientSide3 | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-115/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/115 | | Optional Tests | dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile | | uname | Linux ab3f547ed164 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | HBASE-21512 / dd2ca837d3 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-115/1/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-115/1/testReport/ | | Max. process+thread count | 4943 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-115/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21718) Implement Admin based on AsyncAdmin
[
https://issues.apache.org/jira/browse/HBASE-21718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811653#comment-16811653
]
Hadoop QA commented on HBASE-21718:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 40 new or modified test
files. {color} |
|| || || || {color:brown} HBASE-21512 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
35s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
54s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
30s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
12s{color} | {color:green} HBASE-21512 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
50s{color} | {color:green} HBASE-21512 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
27s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
22s{color} | {color:red} hbase-server: The patch generated 1 new + 416
unchanged - 4 fixed = 417 total (was 420) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
34s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
9s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 16s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 30s{color}
| {color:red} hbase-mapreduce in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
21s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 41s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}228m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestEndToEndSplitTransaction |
| | hadoop.hbase.snapshot.TestExportSnapshotNoCluster |
| | hadoop.hbase.backup.TestBackupDeleteWithFailures |
| | hadoop.hbase.backup.TestIncrementalBackupWithFailures |
| |
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[
https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811665#comment-16811665
]
Hudson commented on HBASE-22174:
Results for branch branch-2.0
[build #1496 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1496/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1496//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1496//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1496//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove error prone from our precommit javac check
> -
>
> Key: HBASE-22174
> URL: https://issues.apache.org/jira/browse/HBASE-22174
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22174-HBASE-22174.patch, HBASE-22174.patch
>
>
> As the result is not stable. Can add it back as a separated check later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 closed pull request #114: for testing whether we skip the error prone check
Apache9 closed pull request #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #114: for testing whether we skip the error prone check
Apache9 commented on issue #114: for testing whether we skip the error prone check URL: https://github.com/apache/hbase/pull/114#issuecomment-480494900 Seems worked. There is no '-PerrorProne' https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-114/1/artifact/out/branch-compile-hbase-client.txt cd /testptch/hbase/hbase-client /usr/share/maven/bin/mvn --batch-mode -DHBasePatchProcess clean test-compile -DskipTests=true This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check
Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480495438 Oh a bit strange, the merge operation will generate a merge commit... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check
Apache9 commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480504849 Yes, the default action is create a merge commit... I just clicked the button and then clicked confirm merge... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] petersomogyi commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check
petersomogyi commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480505793 If I remember correctly on hbase-connectors after I submitted a PR with "Squash and merge" the next time that became the default action for me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22175) Unify the old PreCommit-HBase-Build and the new GitHub PR based PreCommit
[
https://issues.apache.org/jira/browse/HBASE-22175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811549#comment-16811549
]
Hudson commented on HBASE-22175:
Results for branch HBASE-22175
[build #1 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22175/1/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22175/1//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22175/1//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22175/1//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Unify the old PreCommit-HBase-Build and the new GitHub PR based PreCommit
> -
>
> Key: HBASE-22175
> URL: https://issues.apache.org/jira/browse/HBASE-22175
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22175-HBASE-22175.patch
>
>
> We should do this to keep the pre commit behavior the same between GitHub PR
> and the old Patch Available on jira.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 merged pull request #113: HBASE-22174 Remove error prone from our precommit javac check
Apache9 merged pull request #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[
https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811554#comment-16811554
]
Duo Zhang commented on HBASE-22174:
---
{noformat}
cd /testptch/hbase/hbase-client
/usr/share/maven/bin/mvn --batch-mode
-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/yetus-m2/hbase-HBASE-22174-patch-1
-DHBasePatchProcess clean test-compile -DskipTests=true
{noformat}
No '-PerrorProne' which is good.
> Remove error prone from our precommit javac check
> -
>
> Key: HBASE-22174
> URL: https://issues.apache.org/jira/browse/HBASE-22174
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22174-HBASE-22174.patch, HBASE-22174.patch
>
>
> As the result is not stable. Can add it back as a separated check later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811562#comment-16811562
]
Hudson commented on HBASE-20912:
Results for branch branch-2
[build #1800 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1800/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1800//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1800//console].
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1800//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811563#comment-16811563
]
Hudson commented on HBASE-20912:
Results for branch branch-2.2
[build #157 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/157/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/157//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/149//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/149//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20912) Add import order config in dev support for eclipse
[
https://issues.apache.org/jira/browse/HBASE-20912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811561#comment-16811561
]
Hudson commented on HBASE-20912:
Results for branch master
[build #910 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/910/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/910//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/master/910//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/910//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add import order config in dev support for eclipse
> --
>
> Key: HBASE-20912
> URL: https://issues.apache.org/jira/browse/HBASE-20912
> Project: HBase
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 3.0.0, 1.4.10, 1.3.4, 2.3.0, 1.5.1, 1.2.12, 2.1.5, 2.2.1
>
> Attachments: eclipse.importorder
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 closed pull request #115: test merge
Apache9 closed pull request #115: test merge URL: https://github.com/apache/hbase/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22176) Document how to make use of GitHub PR in HBase
Duo Zhang created HBASE-22176: - Summary: Document how to make use of GitHub PR in HBase Key: HBASE-22176 URL: https://issues.apache.org/jira/browse/HBASE-22176 Project: HBase Issue Type: Task Components: documentation Reporter: Duo Zhang At least we need some guidelines for committers, so they do not click the 'Merge Pull Request' button directly and mess up the commits, like me... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check
busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480504730 Looks like we'll need to ask infra to change it; I don't see repo settings. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-19229) Nightly script to check source artifact should not do a destructive git operation without opt-in
[
https://issues.apache.org/jira/browse/HBASE-19229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811596#comment-16811596
]
Hudson commented on HBASE-19229:
Results for branch branch-1
[build #757 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/757/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/757//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/750//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/750//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Nightly script to check source artifact should not do a destructive git
> operation without opt-in
>
>
> Key: HBASE-19229
> URL: https://issues.apache.org/jira/browse/HBASE-19229
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Sean Busbey
>Assignee: Sean Busbey
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 2.0.0-beta-1, 1.1.13, 2.0.0, 1.2.7
>
> Attachments: HBASE-19229.0.patch
>
>
> right now we have a "git please destroy all this stuff" command in the check
> of the source artifact. we shouldn't do this unless the person invoking the
> script has indicated that's okay (e..g through a cli flag).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #115: test merge
Apache9 opened a new pull request #115: test merge URL: https://github.com/apache/hbase/pull/115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred]
Apache9 commented on issue #91: HBASE-21257 misspelled words.[occured -> occurred] URL: https://github.com/apache/hbase/pull/91#issuecomment-480498626 @gangxueZhang Please combine your commits into one commit? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21512) Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
[
https://issues.apache.org/jira/browse/HBASE-21512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811581#comment-16811581
]
Hudson commented on HBASE-21512:
Results for branch HBASE-21512
[build #165 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/165/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/165//console].
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/165//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21512/165//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Introduce an AsyncClusterConnection and replace the usage of ClusterConnection
> --
>
> Key: HBASE-21512
> URL: https://issues.apache.org/jira/browse/HBASE-21512
> Project: HBase
> Issue Type: Umbrella
>Reporter: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
> At least for the RSProcedureDispatcher, with CompletableFuture we do not need
> to set a delay and use a thread pool any more, which could reduce the
> resource usage and also the latency.
> Once this is done, I think we can remove the ClusterConnection completely,
> and start to rewrite the old sync client based on the async client, which
> could reduce the code base a lot for our client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check
busbey commented on issue #113: HBASE-22174 Remove error prone from our precommit javac check URL: https://github.com/apache/hbase/pull/113#issuecomment-480504547 There's a different option when accepting a PR that avoids the merge commit. I guess we didn't make it the default for the repo after all? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22177) Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
Duo Zhang created HBASE-22177: - Summary: Do not recreate IOException in RawAsyncHBaseAdmin.adminCall Key: HBASE-22177 URL: https://issues.apache.org/jira/browse/HBASE-22177 Project: HBase Issue Type: Bug Components: Admin Reporter: Duo Zhang Assignee: Duo Zhang Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5 This should be a typo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
Duo Zhang created HBASE-22179:
-
Summary: Fix RawAsyncHBaseAdmin.getCompactionState
Key: HBASE-22179
URL: https://issues.apache.org/jira/browse/HBASE-22179
Project: HBase
Issue Type: Bug
Components: Admin
Reporter: Duo Zhang
Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
{code}
if (!future.isDone()) {
future.complete(state);
}
{code}
This piece of code should be placed outside the for loop, it should be a typo.
And we should use a thread safe collection to collect the region state instead
of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22070: -- Priority: Minor (was: Major) > Checking restoreDir in RestoreSnapshotHelper > - > > Key: HBASE-22070 > URL: https://issues.apache.org/jira/browse/HBASE-22070 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Vincent Choi >Assignee: Vincent Choi >Priority: Minor > Attachments: > 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, > HBASE-22070-master-001.patch, HBASE-22070.patch > > > The restoreDir shouldn't be a sub directory of rootDir. The code check it > with a prefix check > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it > goes error in some reasonable cases. > eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I > think it's more reasonable to chang the code to > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
Apache9 opened a new pull request #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall URL: https://github.com/apache/hbase/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22179) Fix RawAsyncHBaseAdmin.getCompactionState
[
https://issues.apache.org/jira/browse/HBASE-22179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-22179:
-
Assignee: Duo Zhang
> Fix RawAsyncHBaseAdmin.getCompactionState
> -
>
> Key: HBASE-22179
> URL: https://issues.apache.org/jira/browse/HBASE-22179
> Project: HBase
> Issue Type: Bug
> Components: Admin
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.3.0, 2.1.5
>
>
> {code}
> if (!future.isDone()) {
> future.complete(state);
> }
> {code}
> This piece of code should be placed outside the for loop, it should be a
> typo. And we should use a thread safe collection to collect the region state
> instead of using an ArrayList.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState
Apache9 opened a new pull request #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState URL: https://github.com/apache/hbase/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-22070: -- Resolution: Fixed Fix Version/s: 2.1.5 1.5.1 2.0.6 2.3.0 1.3.4 1.4.10 2.2.0 3.0.0 Status: Resolved (was: Patch Available) Pushed the commit to branch-1.3 and up. Skipped branch-1.2 because an RC is in progress and this fix in not critical that needs to land there. Thanks [~VincentChoiCN] for contributing! > Checking restoreDir in RestoreSnapshotHelper > - > > Key: HBASE-22070 > URL: https://issues.apache.org/jira/browse/HBASE-22070 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Vincent Choi >Assignee: Vincent Choi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5 > > Attachments: > 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, > HBASE-22070-master-001.patch, HBASE-22070.patch > > > The restoreDir shouldn't be a sub directory of rootDir. The code check it > with a prefix check > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it > goes error in some reasonable cases. > eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I > think it's more reasonable to chang the code to > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
Duo Zhang created HBASE-22180:
-
Summary: Make
TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
Key: HBASE-22180
URL: https://issues.apache.org/jira/browse/HBASE-22180
Project: HBase
Issue Type: Bug
Components: test
Reporter: Duo Zhang
{code}
List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
while (onlineRegions.size() != 2) {
onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
Thread.sleep(100);
LOG.info("Waiting on SPLIT to complete...");
}
{code}
Actually this piece of code is not correct. We only have one region server in
this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811605#comment-16811605
]
Hudson commented on HBASE-22020:
Results for branch HBASE-22020
[build #3 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/3/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/3//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/3//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/3//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] petersomogyi commented on issue #109: a bug of checking if restoreDir is subDir of rootDir
petersomogyi commented on issue #109: a bug of checking if restoreDir is subDir of rootDir URL: https://github.com/apache/hbase/pull/109#issuecomment-480508548 Merged patch from Jira. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[
https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811604#comment-16811604
]
Peter Somogyi commented on HBASE-22070:
---
[~VincentChoiCN], please note that I modified the commit message to match with
the requirement: HBASE-X .
In this case it is {{HBASE-22070 Checking restoreDir in RestoreSnapshotHelper}}
> Checking restoreDir in RestoreSnapshotHelper
> -
>
> Key: HBASE-22070
> URL: https://issues.apache.org/jira/browse/HBASE-22070
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Affects Versions: 2.0.0
>Reporter: Vincent Choi
>Assignee: Vincent Choi
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5
>
> Attachments:
> 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch,
> HBASE-22070-master-001.patch, HBASE-22070.patch
>
>
> The restoreDir shouldn't be a sub directory of rootDir. The code check it
> with a prefix check
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it
> goes error in some reasonable cases.
> eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I
> think it's more reasonable to chang the code to
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] petersomogyi closed pull request #109: a bug of checking if restoreDir is subDir of rootDir
petersomogyi closed pull request #109: a bug of checking if restoreDir is subDir of rootDir URL: https://github.com/apache/hbase/pull/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811606#comment-16811606 ] Vincent Choi commented on HBASE-22070: -- OK, I will obey the requirement next time. :) > Checking restoreDir in RestoreSnapshotHelper > - > > Key: HBASE-22070 > URL: https://issues.apache.org/jira/browse/HBASE-22070 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Vincent Choi >Assignee: Vincent Choi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5 > > Attachments: > 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, > HBASE-22070-master-001.patch, HBASE-22070.patch > > > The restoreDir shouldn't be a sub directory of rootDir. The code check it > with a prefix check > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it > goes error in some reasonable cases. > eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I > think it's more reasonable to chang the code to > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall
Apache-HBase commented on issue #116: HBASE-22177 Do not recreate IOException in RawAsyncHBaseAdmin.adminCall URL: https://github.com/apache/hbase/pull/116#issuecomment-480510674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 48 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 309 | master passed | | +1 | compile | 31 | master passed | | +1 | checkstyle | 40 | master passed | | +1 | shadedjars | 322 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 76 | master passed | | +1 | javadoc | 28 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 317 | the patch passed | | +1 | compile | 31 | the patch passed | | +1 | javac | 31 | the patch passed | | +1 | checkstyle | 40 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 328 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 666 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 89 | the patch passed | | +1 | javadoc | 28 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 236 | hbase-client in the patch passed. | | +1 | asflicense | 13 | The patch does not generate ASF License warnings. | | | | 2680 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-116/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/116 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 5fd6c5ff52c5 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b1525ed85e | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-116/1/testReport/ | | Max. process+thread count | 293 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-116/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811626#comment-16811626
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #52 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/52/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/52//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/52//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/52//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22173) Update doc on integration tests
[
https://issues.apache.org/jira/browse/HBASE-22173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811636#comment-16811636
]
Wei-Chiu Chuang commented on HBASE-22173:
-
Thanks for the review!
Updated the patch. A screenshot is attached: !HBASE-22173 doc.png!
> Update doc on integration tests
> ---
>
> Key: HBASE-22173
> URL: https://issues.apache.org/jira/browse/HBASE-22173
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HBASE-22173 doc.png, HBASE-22173.master.001.patch,
> HBASE-22173.master.002.patch
>
>
> Followed the doc to run integration tests but maven failed to run. Turns out
> an additional parameter {{-DfailIfNoTests=false}} is required, so file this
> jira to get that updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22173) Update doc on integration tests
[
https://issues.apache.org/jira/browse/HBASE-22173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-22173:
Attachment: HBASE-22173 doc.png
> Update doc on integration tests
> ---
>
> Key: HBASE-22173
> URL: https://issues.apache.org/jira/browse/HBASE-22173
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HBASE-22173 doc.png, HBASE-22173.master.001.patch,
> HBASE-22173.master.002.patch
>
>
> Followed the doc to run integration tests but maven failed to run. Turns out
> an additional parameter {{-DfailIfNoTests=false}} is required, so file this
> jira to get that updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22173) Update doc on integration tests
[
https://issues.apache.org/jira/browse/HBASE-22173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-22173:
Attachment: HBASE-22173.master.002.patch
> Update doc on integration tests
> ---
>
> Key: HBASE-22173
> URL: https://issues.apache.org/jira/browse/HBASE-22173
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HBASE-22173.master.001.patch,
> HBASE-22173.master.002.patch
>
>
> Followed the doc to run integration tests but maven failed to run. Turns out
> an additional parameter {{-DfailIfNoTests=false}} is required, so file this
> jira to get that updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-21718) Implement Admin based on AsyncAdmin
[ https://issues.apache.org/jira/browse/HBASE-21718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-21718: -- Attachment: HBASE-21718-HBASE-21512-v5.patch > Implement Admin based on AsyncAdmin > --- > > Key: HBASE-21718 > URL: https://issues.apache.org/jira/browse/HBASE-21718 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-21718-HBASE-21512-v1.patch, > HBASE-21718-HBASE-21512-v2.patch, HBASE-21718-HBASE-21512-v3.patch, > HBASE-21718-HBASE-21512-v4.patch, HBASE-21718-HBASE-21512-v5.patch, > HBASE-21718-HBASE-21512.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
Duo Zhang created HBASE-22178: - Summary: Introduce a createTableAsync with TableDescriptor method in Admin Key: HBASE-22178 URL: https://issues.apache.org/jira/browse/HBASE-22178 Project: HBase Issue Type: Bug Components: Admin Reporter: Duo Zhang So we do not need to pass null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HBASE-22178) Introduce a createTableAsync with TableDescriptor method in Admin
[ https://issues.apache.org/jira/browse/HBASE-22178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-22178: - Assignee: Duo Zhang > Introduce a createTableAsync with TableDescriptor method in Admin > - > > Key: HBASE-22178 > URL: https://issues.apache.org/jira/browse/HBASE-22178 > Project: HBase > Issue Type: Bug > Components: Admin >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > So we do not need to pass null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache9 opened a new pull request #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method …
Apache9 opened a new pull request #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method … URL: https://github.com/apache/hbase/pull/117 …in Admin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache9 opened a new pull request #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp…
Apache9 opened a new pull request #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp… URL: https://github.com/apache/hbase/pull/119 …lits more stable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Assigned] (HBASE-22180) Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
[
https://issues.apache.org/jira/browse/HBASE-22180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-22180:
-
Assignee: Duo Zhang
> Make TestBlockEvictionFromClient.testBlockRefCountAfterSplits more stable
> -
>
> Key: HBASE-22180
> URL: https://issues.apache.org/jira/browse/HBASE-22180
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> {code}
> List onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> while (onlineRegions.size() != 2) {
> onlineRegions = TEST_UTIL.getAdmin().getRegions(rs);
> Thread.sleep(100);
> LOG.info("Waiting on SPLIT to complete...");
> }
> {code}
> Actually this piece of code is not correct. We only have one region server in
> this test so the region server will also carry meta region.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22020) upgrade to yetus 0.9.0
[
https://issues.apache.org/jira/browse/HBASE-22020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811601#comment-16811601
]
Hudson commented on HBASE-22020:
Results for branch HBASE-22020
[build #2 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/2/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22020/2//General_Nightly_Build_Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> upgrade to yetus 0.9.0
> --
>
> Key: HBASE-22020
> URL: https://issues.apache.org/jira/browse/HBASE-22020
> Project: HBase
> Issue Type: Task
> Components: build, community
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Attachments: HBASE-22020-branch-1.v1.patch, HBASE-22020.0.patch,
> HBASE-22020.1.patch
>
>
> branch-1/jdk7 checkstyle dtd xml parse complaint; "script engine for language
> js can not be found"
> See parent for some context. Checkstyle references dtds that were hosted on
> puppycrawl, then on sourceforge up until ten days ago. Nightlies are failing
> for among other reasons, complaint that there is bad xml in the build...
> notably, the unresolvable DTDs.
> I'd just update the DTDs but there is a need for a js engine some where and
> openjdk7 doesn't ship with one (openjdk8 does). That needs addressing and
> then we can backport the parent issue...
> See
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-1/710/artifact/output-general/xml.txt
> ... which in case its rolled away, is filled with this message:
> "script engine for language js can not be found"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811602#comment-16811602 ] Vincent Choi commented on HBASE-22070: -- [~psomogyi], you are so nice. It's my pleasure. > Checking restoreDir in RestoreSnapshotHelper > - > > Key: HBASE-22070 > URL: https://issues.apache.org/jira/browse/HBASE-22070 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Vincent Choi >Assignee: Vincent Choi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5 > > Attachments: > 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, > HBASE-22070-master-001.patch, HBASE-22070.patch > > > The restoreDir shouldn't be a sub directory of rootDir. The code check it > with a prefix check > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it > goes error in some reasonable cases. > eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I > think it's more reasonable to chang the code to > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState
Apache-HBase commented on issue #118: HBASE-22179 Fix RawAsyncHBaseAdmin.getCompactionState URL: https://github.com/apache/hbase/pull/118#issuecomment-480510428 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 245 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 30 | master passed | | +1 | shadedjars | 256 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 65 | master passed | | +1 | javadoc | 25 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 242 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | +1 | checkstyle | 29 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 517 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 65 | the patch passed | | +1 | javadoc | 23 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 194 | hbase-client in the patch passed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2133 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-118/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/118 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b93c80a0db4f 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b1525ed85e | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-118/1/testReport/ | | Max. process+thread count | 310 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-118/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method …
Apache-HBase commented on issue #117: HBASE-22178 Introduce a createTableAsync with TableDescriptor method … URL: https://github.com/apache/hbase/pull/117#issuecomment-480511228 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 25 | Maven dependency ordering for branch | | +1 | mvninstall | 272 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 60 | master passed | | +1 | shadedjars | 257 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 144 | master passed | | +1 | javadoc | 53 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 13 | Maven dependency ordering for patch | | +1 | mvninstall | 256 | the patch passed | | +1 | compile | 56 | the patch passed | | +1 | javac | 56 | the patch passed | | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113) | | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-thrift | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 264 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 495 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 155 | the patch passed | | +1 | javadoc | 56 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 200 | hbase-client in the patch passed. | | +1 | unit | 278 | hbase-thrift in the patch passed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 2850 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-117/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/117 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 70ae8192bbd3 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b1525ed85e | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-117/1/testReport/ | | Max. process+thread count | 1840 (vs. ulimit of 1) | | modules | C: hbase-client hbase-thrift U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-117/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22173) Update doc on integration tests
[
https://issues.apache.org/jira/browse/HBASE-22173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811616#comment-16811616
]
Peter Somogyi commented on HBASE-22173:
---
Thanks for the cleanup [~jojochuang]!
-DfailIfNoTests=false argument is repeated in this command: {{mvn
failsafe:integration-test -Dit.test=\*ClassX\* -DfailIfNoTests=false
-DfailIfNoTests=false}}
> Update doc on integration tests
> ---
>
> Key: HBASE-22173
> URL: https://issues.apache.org/jira/browse/HBASE-22173
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Minor
> Attachments: HBASE-22173.master.001.patch
>
>
> Followed the doc to run integration tests but maven failed to run. Turns out
> an additional parameter {{-DfailIfNoTests=false}} is required, so file this
> jira to get that updated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22151) hbase-backup should specify hadoop-hdfs-client version for Hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-22151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-22151:
Attachment: (was: HBASE-22151.master.002.patch)
> hbase-backup should specify hadoop-hdfs-client version for Hadoop 3
> ---
>
> Key: HBASE-22151
> URL: https://issues.apache.org/jira/browse/HBASE-22151
> Project: HBase
> Issue Type: Bug
> Components: backuprestore
>Affects Versions: 2.0.0
> Environment: Hadoop 3.2.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-22151.master.001.patch
>
>
> {code}
> mvn test -P runAllTests -fn -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.0
> -Dtest=TestIncrementalBackupWithBulkLoad
> {code}
>
> Despite hadoop 3 version is specified, the test always use hadoop-hdfs-client
> 3.0.3, and will fail on Hadoop 3.2.0 because it can't find a new class.
>
> {noformat}
> Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 709.323 s <<<
> FAILURE! - in org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad
> TestIncBackupDeleteTable(org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad)
> Time elapsed: 1.907 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-22151) hbase-backup should specify hadoop-hdfs-client version for Hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-22151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HBASE-22151:
Attachment: HBASE-22151.master.002.patch
> hbase-backup should specify hadoop-hdfs-client version for Hadoop 3
> ---
>
> Key: HBASE-22151
> URL: https://issues.apache.org/jira/browse/HBASE-22151
> Project: HBase
> Issue Type: Bug
> Components: backuprestore
>Affects Versions: 2.0.0
> Environment: Hadoop 3.2.0
>Reporter: Wei-Chiu Chuang
>Assignee: Wei-Chiu Chuang
>Priority: Major
> Attachments: HBASE-22151.master.001.patch
>
>
> {code}
> mvn test -P runAllTests -fn -Dhadoop.profile=3.0 -Dhadoop-three.version=3.2.0
> -Dtest=TestIncrementalBackupWithBulkLoad
> {code}
>
> Despite hadoop 3 version is specified, the test always use hadoop-hdfs-client
> 3.0.3, and will fail on Hadoop 3.2.0 because it can't find a new class.
>
> {noformat}
> Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 709.323 s <<<
> FAILURE! - in org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad
> TestIncBackupDeleteTable(org.apache.hadoop.hbase.backup.TestIncrementalBackupWithBulkLoad)
> Time elapsed: 1.907 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> org/apache/hadoop/hdfs/protocol/HdfsConstants$StoragePolicySatisfierMode
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hdfs.protocol.HdfsConstants$StoragePolicySatisfierMode{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[ https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811639#comment-16811639 ] Hudson commented on HBASE-22070: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #539 (See [https://builds.apache.org/job/HBase-1.3-IT/539/]) HBASE-22070 Checking restoreDir in RestoreSnapshotHelper (psomogyi: [https://github.com/apache/hbase/commit/953537b97263edbb64d489b3d29ade11f5ea57e2]) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java > Checking restoreDir in RestoreSnapshotHelper > - > > Key: HBASE-22070 > URL: https://issues.apache.org/jira/browse/HBASE-22070 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.0.0 >Reporter: Vincent Choi >Assignee: Vincent Choi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5 > > Attachments: > 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch, > HBASE-22070-master-001.patch, HBASE-22070.patch > > > The restoreDir shouldn't be a sub directory of rootDir. The code check it > with a prefix check > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it > goes error in some reasonable cases. > eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I > think it's more reasonable to chang the code to > "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-22174) Remove error prone from our precommit javac check
[
https://issues.apache.org/jira/browse/HBASE-22174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811670#comment-16811670
]
Hudson commented on HBASE-22174:
Results for branch branch-2.1
[build #1028 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1028/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1028//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1028//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1028//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Remove error prone from our precommit javac check
> -
>
> Key: HBASE-22174
> URL: https://issues.apache.org/jira/browse/HBASE-22174
> Project: HBase
> Issue Type: Task
> Components: build
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22174-HBASE-22174.patch, HBASE-22174.patch
>
>
> As the result is not stable. Can add it back as a separated check later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [hbase] Apache-HBase commented on issue #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp…
Apache-HBase commented on issue #119: HBASE-22180 Make TestBlockEvictionFromClient.testBlockRefCountAfterSp… URL: https://github.com/apache/hbase/pull/119#issuecomment-480531788 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 43 | Docker mode activated. | ||| _ Prechecks _ | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 308 | master passed | | +1 | compile | 65 | master passed | | +1 | checkstyle | 84 | master passed | | +1 | shadedjars | 322 | branch has no errors when building our shaded downstream artifacts. | | +1 | findbugs | 184 | master passed | | +1 | javadoc | 39 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 314 | the patch passed | | +1 | compile | 68 | the patch passed | | +1 | javac | 68 | the patch passed | | +1 | checkstyle | 79 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 335 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 645 | Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. | | +1 | findbugs | 192 | the patch passed | | +1 | javadoc | 40 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 15912 | hbase-server in the patch failed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 18739 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas | | | hadoop.hbase.client.TestAdmin1 | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.client.TestFromClientSide3 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-119/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/119 | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9d4797a466c1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | master / b1525ed85e | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | findbugs | v3.1.11 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-119/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-119/1/testReport/ | | Max. process+thread count | 5062 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-119/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22070) Checking restoreDir in RestoreSnapshotHelper
[
https://issues.apache.org/jira/browse/HBASE-22070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811684#comment-16811684
]
Hudson commented on HBASE-22070:
Results for branch branch-1.4
[build #734 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/734//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Checking restoreDir in RestoreSnapshotHelper
> -
>
> Key: HBASE-22070
> URL: https://issues.apache.org/jira/browse/HBASE-22070
> Project: HBase
> Issue Type: Bug
> Components: snapshots
>Affects Versions: 2.0.0
>Reporter: Vincent Choi
>Assignee: Vincent Choi
>Priority: Minor
> Fix For: 3.0.0, 2.2.0, 1.4.10, 1.3.4, 2.3.0, 2.0.6, 1.5.1, 2.1.5
>
> Attachments:
> 0001-fixed-a-bug-of-checking-if-restoreDir-is-subDir-of-r.patch,
> HBASE-22070-master-001.patch, HBASE-22070.patch
>
>
> The restoreDir shouldn't be a sub directory of rootDir. The code check it
> with a prefix check
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath())". But it
> goes error in some reasonable cases.
> eg: rootDir = hdfs://user/hbase restoreDir = hdfs://user/hbase_restore. So I
> think it's more reasonable to chang the code to
> "restoreDir.toUri().getPath().startsWith(rootDir.toUri().getPath() + "/" )".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
