[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Attachment: HBASE-24976_1.patch
Status: Patch Available (was: Open)
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> Rest server doesn't start successfully, but it was bad that I can't find any
> error message indicating that server fails to start and why failure happens.
> Afer debuging, I found that loginServerPrincipal can throw exception, like:
> {code:java}
> java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
> security is enabled
> at
> org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
> at
> org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
> at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
> at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
> {code}
> But these exceptions are caught without any messages printed.
> {code:java}
> org.apache.hadoop.hbase.rest.RESTServer.main
> 423 try {
> 424server.run();
> 425server.join();
> 426 } catch (Exception e) {
> 427 System.exit(1);
> 428 }
> {code}
> We need print the failure message to help user config the system.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages printed.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
We need print the failure message to help user config the system.
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages printed.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages printed.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages printed.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo:
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages printed.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
But these exceptions are caught without any messages.
{code:java}
org.apache.hadoop.hbase.rest.RESTServer.main
423 try {
424server.run();
425server.join();
426 } catch (Exception e) {
427 System.exit(1);
428 }
{code}
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
Afer debuging, I found that loginServerPrincipal can throw exception, like:
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> Rest server doesn't start successfully, but it was bad that I can't find any
> error message indicating that server fails to start and why failure happens.
>
> Afer debuging, I found that loginServerPrincipal can throw exception, like:
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
Rest server doesn't start successfully, but it was bad that I can't find any
error message indicating that server fails to start and why failure happens.
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
use jps and find that rest server does't start successfully, but it was bad
that I can't find any error message indicating that server fails to start and
what failure happens.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> Rest server doesn't start successfully, but it was bad that I can't find any
> error message indicating that server fails to start and why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Attachment: (was: HBASE-24976_1.patch)
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> what failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Comment: was deleted
(was: Appending the patch, move the error message from 'run' to 'main', hence
we can catch all exception and print it.)
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> what failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Comment: was deleted
(was: After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all exception without any message. If we log the
exception before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424){code}
We need to log the exception to help user configure their system.
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
)
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> what failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase-thirdparty] Apache-HBase commented on pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
Apache-HBase commented on pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36#issuecomment-686268055 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 56s | master passed | | +1 :green_heart: | compile | 0m 17s | master passed | | +1 :green_heart: | checkstyle | 0m 51s | master passed | | +1 :green_heart: | javadoc | 0m 9s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 0m 47s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | -1 :x: | checkstyle | 0m 15s | hbase-noop-htrace: The patch generated 334 new + 0 unchanged - 0 fixed = 334 total (was 0) | | -1 :x: | checkstyle | 0m 57s | root: The patch generated 334 new + 0 unchanged - 0 fixed = 334 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 42s | hbase-noop-htrace in the patch passed. | | +1 :green_heart: | unit | 0m 52s | root in the patch passed. | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 8m 18s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/1/artifact/yetus-precommit-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase-thirdparty/pull/36 | | Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle | | uname | Linux a8a88620766b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | git revision | master / b47d4cd | | Default Java | Oracle Corporation-1.8.0_265-b01 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/1/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-noop-htrace.txt | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/1/artifact/yetus-precommit-check/output/diff-checkstyle-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/1/testReport/ | | Max. process+thread count | 418 (vs. ulimit of 1000) | | modules | C: hbase-noop-htrace . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-36/1/console | | versions | git=2.20.1 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase-thirdparty] busbey opened a new pull request #36: HBASE-24802 make a drop-in compatible impl of htrace APIs that does not do anything
busbey opened a new pull request #36: URL: https://github.com/apache/hbase-thirdparty/pull/36 first pass. works for `mvn test` against the shaded testing utility in HBase 2.2.5. need some more hbase/hadoop version combos. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
Apache-HBase commented on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686265169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | checkstyle | 1m 2s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 47s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2345/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2345 | | JIRA Issue | HBASE-24974 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 181e421761d7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2345/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (HBASE-24977) [Alter hbase:meta]: Making meta read only should not be be allowed
Ajeet Rai created HBASE-24977:
-
Summary: [Alter hbase:meta]: Making meta read only should not be
be allowed
Key: HBASE-24977
URL: https://issues.apache.org/jira/browse/HBASE-24977
Project: HBase
Issue Type: Bug
Components: meta
Affects Versions: 2.2.3
Reporter: Ajeet Rai
After HBASE-23055, Alter of Meta schema is allowed.
After this change meta table can be made Read only table which is not correct
as per my view,because it will impact majority of the functionality of HBase.
alter 'hbase:meta',\{METHOD=>'table_att', READONLY=>true}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2344: HBASE-24857:Fix several problems when starting webUI
Apache-HBase commented on pull request #2344: URL: https://github.com/apache/hbase/pull/2344#issuecomment-686264073 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 31s | branch-2.3 passed | | +1 :green_heart: | compile | 2m 6s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 4m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 50s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 13s | the patch passed | | +1 :green_heart: | compile | 2m 12s | the patch passed | | +1 :green_heart: | javac | 2m 12s | the patch passed | | +1 :green_heart: | shadedjars | 5m 4s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 45s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 313m 19s | root in the patch passed. | | | | 344m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2344 | | JIRA Issue | HBASE-24857 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 30eb1401d182 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / b7c99fbaf8 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/testReport/ | | Max. process+thread count | 4639 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-686256392 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 27s | master passed | | +1 :green_heart: | compile | 2m 17s | master passed | | +1 :green_heart: | shadedjars | 6m 34s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 17s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | shadedjars | 6m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 13s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 331m 36s | root in the patch failed. | | | | 367m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2320 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8104596c0355 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/testReport/ | | Max. process+thread count | 6226 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sandeepvinayak commented on pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
sandeepvinayak commented on pull request #2345: URL: https://github.com/apache/hbase/pull/2345#issuecomment-686255221 @bharathv can you review this since you last touched this file? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] sandeepvinayak opened a new pull request #2345: HBASE-24974: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
sandeepvinayak opened a new pull request #2345: URL: https://github.com/apache/hbase/pull/2345 Provide flexibility to print only row key from WALPrettyPrinter and filter for multiple tables in the WALPrettyPrinter This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189792#comment-17189792
]
lujie edited comment on HBASE-24976 at 9/3/20, 5:00 AM:
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all exception without any message. If we log the
exception before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424){code}
We need to log the exception to help user configure their system.
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
was (Author: xiaoheipangzi):
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we log the
excaption before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424){code}
We need to log the exception to help user configure their system.
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> what failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
use jps and find that rest server does't start successfully, but it was bad
that I can't find any error message indicating that server fails to start and
what failure happens.
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
use jps and find that rest server does't start successfully, but it was bad
that I can't find any error message indicating that server fails to start and
why failure happens.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> what failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
virajjasani commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r482700776
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -2472,4 +2482,13 @@ boolean snapshotCleanupSwitch(final boolean on, final
boolean synchronous)
*/
void updateRSGroupConfig(String groupName, Map
configuration) throws IOException;
+ /**
+ * Retrieve recent online records from HMaster / RegionServers.
+ * Examples include slow/large RPC logs, balancer decisions by master.
+ *
+ * @param logRequest request payload with possible filters
+ * @return Log entries representing online records from servers
+ * @throws IOException if a remote or network exception occurs
+ */
+ List getLogEntries(LogRequest logRequest) throws IOException;
Review comment:
This is our Admin endpoint:
```
List getLogEntries(LogRequest logRequest) throws IOException;
```
Now when client uses this to get slowLog response, they can provide `limit`
in specific payload which extends `LogRequest` and send it over, similarly they
can provide `limit` in BalancerDecisionRequest which extends `LogRequest` and
get the response accordingly, both request payloads that extend `LogRequest`
are anyways public interfaces for clients. Now, client would rather provide
`limit` in request payload than as separate argument on this Admin endpoint
(method signature). Does that sound good?
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerDecisionRequest.java
##
@@ -0,0 +1,64 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Balancer decision request payload with filter attributes
+ */
+@InterfaceAudience.Private
+public class BalancerDecisionRequest extends LogRequest {
+
+ private int limit = 250;
+
+ public int getLimit() {
Review comment:
This is public non-RPC class. It extends `LogRequest` and public Admin
API endpoint is:
```
List getLogEntries(LogRequest logRequest) throws IOException;
```
And hence, this class goes as request param to this API by extending
`LogRequest`, so we anyways have this `limit` on public class for imposing all
limits and filters (BalancerDecision so far doesn't have filters though, so
just limit).
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/LogQueryFilter.java
##
@@ -22,22 +22,27 @@
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.hadoop.hbase.ServerName;
import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import java.util.Collections;
+import java.util.Set;
/**
* Slow/Large Log Query Filter with all filter and limit parameters
* Used by Admin API: getSlowLogResponses
*/
-@InterfaceAudience.Private
-public class LogQueryFilter {
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public class LogQueryFilter extends LogRequest {
private String regionName;
private String clientAddress;
private String tableName;
private String userName;
- private int limit = 10;
Review comment:
> Limits by way of filter will be fine if you want to do it this way.
This is exactly what I am trying to do:
1. For SlowLog use-case, this class exposes `limit`:
`public class LogQueryFilter extends LogRequest`
2. For BalancerDecision use-case, this class exposes `limit`:
`public class BalancerDecisionRequest extends LogRequest`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
[jira] [Assigned] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie reassigned HBASE-24976:
-
Assignee: lujie
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189792#comment-17189792
]
lujie edited comment on HBASE-24976 at 9/3/20, 4:12 AM:
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we log the
excaption before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)被掠that{code}
We need to log the exception to help user configure their system.
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
was (Author: xiaoheipangzi):
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we log the
excaption before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)被掠that{code}
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189792#comment-17189792
]
lujie edited comment on HBASE-24976 at 9/3/20, 4:12 AM:
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we log the
excaption before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424){code}
We need to log the exception to help user configure their system.
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
was (Author: xiaoheipangzi):
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we log the
excaption before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)被掠that{code}
We need to log the exception to help user configure their system.
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189792#comment-17189792
]
lujie edited comment on HBASE-24976 at 9/3/20, 4:11 AM:
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we log the
excaption before line 427, we can get the error message:
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)被掠that{code}
I find this issue in version 2.2.1, I check the master code and beleve it
also have same problem
was (Author: xiaoheipangzi):
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we insertlog the
excaption before line 427, we can get :
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
So i got the error message indicating thay why server fails to start.
I debug the error at versiob 2.2.1, I check the master code and beleve it also
have same problem
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189811#comment-17189811
]
lujie edited comment on HBASE-24976 at 9/3/20, 4:09 AM:
Appending the patch, move the error message from 'run' to 'main', hence we can
catch all exception and print it.
was (Author: xiaoheipangzi):
Appending the patch, move the error message in 'run' to 'main', hence we can
catch all exception and print it.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24974) Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter
[ https://issues.apache.org/jira/browse/HBASE-24974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Pal updated HBASE-24974: Description: Currently, [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java] provides an option to ignore the values in the output, but it prints the whole cell and has no option to ignore some information from the cell. Sometimes, the user may only need the row keys from WAL and it may reduce the size of output from WALPrettyPrinter significantly. We should provide flexibility to output only rowkey from the cell. In addition we should increase the flexibility for providing multiple tables in the table filter. was: Currently, [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java] provides an option to ignore the values in the output, but it prints the whole cell and has no option to ignore some information from the cell. Sometimes, the user may only need the row keys from WAL and it may reduce the size of output from WALPrettyPrinter significantly. We should provide flexibility to output only rowkey from the cell. Summary: Provide a flexibility to print only row key and filter for multiple tables in the WALPrettyPrinter (was: Provide a flexibility to print only row key in the WALPrettyPrinter) > Provide a flexibility to print only row key and filter for multiple tables in > the WALPrettyPrinter > -- > > Key: HBASE-24974 > URL: https://issues.apache.org/jira/browse/HBASE-24974 > Project: HBase > Issue Type: Improvement > Components: wal >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Minor > > Currently, > [WALPrettyPrinter|https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java] > provides an option to ignore the values in the output, but it prints the > whole cell and has no option to ignore some information from the cell. > Sometimes, the user may only need the row keys from WAL and it may reduce the > size of output from WALPrettyPrinter significantly. > We should provide flexibility to output only rowkey from the cell. > In addition we should increase the flexibility for providing multiple tables > in the table filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-686230915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 26s | master passed | | +1 :green_heart: | compile | 3m 2s | master passed | | +1 :green_heart: | shadedjars | 7m 20s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-asyncfs in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 14s | root in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 3m 4s | the patch passed | | +1 :green_heart: | javac | 3m 4s | the patch passed | | +1 :green_heart: | shadedjars | 7m 16s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 13s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 237m 26s | root in the patch passed. | | | | 273m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2320 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4d3a631189f5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/testReport/ | | Max. process+thread count | 4893 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,
[jira] [Commented] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189811#comment-17189811
]
lujie commented on HBASE-24976:
---
Appending the patch, move the error message in 'run' to 'main', hence we can
catch all exception and print it.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Attachment: HBASE-24976_1.patch
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
> Attachments: HBASE-24976_1.patch
>
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2344: HBASE-24857:Fix several problems when starting webUI
Apache-HBase commented on pull request #2344: URL: https://github.com/apache/hbase/pull/2344#issuecomment-686223206 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 6s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 19s | branch-2.3 passed | | +1 :green_heart: | compile | 2m 50s | branch-2.3 passed | | +1 :green_heart: | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | root in branch-2.3 failed. | | -0 :warning: | javadoc | 0m 44s | hbase-server in branch-2.3 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 57s | the patch passed | | +1 :green_heart: | compile | 2m 43s | the patch passed | | +1 :green_heart: | javac | 2m 43s | the patch passed | | +1 :green_heart: | shadedjars | 5m 53s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 15s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 168m 6s | root in the patch passed. | | | | 200m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2344 | | JIRA Issue | HBASE-24857 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d1d7df459984 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / b7c99fbaf8 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/testReport/ | | Max. process+thread count | 5665 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-686207562 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +0 :ok: | prototool | 0m 1s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 49s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 7m 49s | branch-1 passed | | +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | compile | 1m 46s | branch-1 passed with JDK v1.7.0_272 | | +1 :green_heart: | checkstyle | 12m 13s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 29s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 5m 17s | branch-1 passed with JDK v1.7.0_272 | | +0 :ok: | spotbugs | 2m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 17m 14s | branch-1 passed | | -0 :warning: | patch | 3m 24s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 54s | the patch passed | | +1 :green_heart: | compile | 1m 38s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | cc | 1m 38s | the patch passed | | +1 :green_heart: | javac | 1m 39s | the patch passed | | +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | cc | 1m 41s | the patch passed | | +1 :green_heart: | javac | 1m 41s | the patch passed | | -1 :x: | checkstyle | 0m 52s | hbase-client: The patch generated 12 new + 682 unchanged - 32 fixed = 694 total (was 714) | | -1 :x: | checkstyle | 2m 22s | hbase-server: The patch generated 97 new + 1860 unchanged - 49 fixed = 1957 total (was 1909) | | -1 :x: | checkstyle | 6m 8s | root: The patch generated 105 new + 2548 unchanged - 77 fixed = 2653 total (was 2625) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 42s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | hbaseprotoc | 3m 51s | the patch passed | | +1 :green_heart: | javadoc | 3m 22s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 5m 17s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | findbugs | 18m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 154m 25s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 20s | The patch does not generate ASF License warnings. | | | | 276m 12s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | pom.xml | | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/13/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2280 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux 84af55fcad48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh | | git revision | branch-1 / 1dc75e7 | | Default Java | 1.7.0_272 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 | | checkstyle
[jira] [Comment Edited] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189792#comment-17189792
]
lujie edited comment on HBASE-24976 at 9/3/20, 2:25 AM:
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we insertlog the
excaption before line 427, we can get :
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
So i got the error message indicating thay why server fails to start.
I debug the error at versiob 2.2.1, I check the master code and beleve it also
have same problem
was (Author: xiaoheipangzi):
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we insertlog the
excaption before line 427, we can get :
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
So i got the error message indicating thay why server fails to start.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189792#comment-17189792
]
lujie commented on HBASE-24976:
---
After debug the system, i found that the error is in RESTServer#445:
{code:java}
423try {
424 server.run();
425 server.join();
426} catch (Exception e) {
427 System.exit(1);
428}
{code}
the catch block devours all excaption without any message. If we insertlog the
excaption before line 427, we can get :
{code:java}
java.lang.IllegalArgumentException: hbase.rest.keytab.file should be set if
security is enabled
at
org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:142)
at
org.apache.hadoop.hbase.rest.RESTServer.loginServerPrincipal(RESTServer.java:149)
at org.apache.hadoop.hbase.rest.RESTServer.run(RESTServer.java:237)
at org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:424)
{code}
So i got the error message indicating thay why server fails to start.
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Issue Type: Improvement (was: Bug)
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Improvement
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
use jps and find that rest server does't start successfully, but it was bad
that I can't find any error message indicating that server fails to start and
why failure happens.
was:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
it was bad that I can;;
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> use jps and find that rest server does't start successfully, but it was bad
> that I can't find any error message indicating that server fails to start and
> why failure happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Attachment: (was: image-2020-09-03-10-12-36-230.png)
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> it was bad that I can;;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[
https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated HBASE-24976:
--
Description:
When I enable security and start rest server, i see the messages like these:
{code:java}
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
'RESTServer' *
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
git://hao-OptiPlex-7050/home/hao/open_source/hbase
revision=f93aaf770cce81caacbf22174dfee2860dbb4810
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on 2019年
09月 10日 星期二 14:28:27 CST
2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
checksum c0f358e344b10713f61037e16fd39f8euse{code}
it was bad that I can;;
> REST Server failes to start without any error message
> -
>
> Key: HBASE-24976
> URL: https://issues.apache.org/jira/browse/HBASE-24976
> Project: HBase
> Issue Type: Bug
> Components: REST
>Affects Versions: 2.2.1
>Reporter: lujie
>Priority: Major
>
> When I enable security and start rest server, i see the messages like these:
> {code:java}
> SLF4J: Class path contains multiple SLF4J bindings.
> SLF4J: Found binding in
> [jar:file:/usr/local/hadoop-2.8.5/share/hadoop/common/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: Found binding in
> [jar:file:/usr/local/hbase-2.2.1/lib/client-facing-thirdparty/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
> SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
> explanation.
> SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
> 2020-09-03 02:10:57,995 INFO [main] RESTServer: * STARTING service
> 'RESTServer' *
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: HBase 2.2.1
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Source code repository
> git://hao-OptiPlex-7050/home/hao/open_source/hbase
> revision=f93aaf770cce81caacbf22174dfee2860dbb4810
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: Compiled by hao on
> 2019年 09月 10日 星期二 14:28:27 CST
> 2020-09-03 02:10:57,998 INFO [main] util.VersionInfo: From source with
> checksum c0f358e344b10713f61037e16fd39f8euse{code}
> it was bad that I can;;
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24976) REST Server failes to start without any error message
[ https://issues.apache.org/jira/browse/HBASE-24976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-24976: -- Attachment: image-2020-09-03-10-12-36-230.png > REST Server failes to start without any error message > - > > Key: HBASE-24976 > URL: https://issues.apache.org/jira/browse/HBASE-24976 > Project: HBase > Issue Type: Bug > Components: REST >Affects Versions: 2.2.1 >Reporter: lujie >Priority: Major > Attachments: image-2020-09-03-10-12-36-230.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24976) REST Server failes to start without any error message
lujie created HBASE-24976: - Summary: REST Server failes to start without any error message Key: HBASE-24976 URL: https://issues.apache.org/jira/browse/HBASE-24976 Project: HBase Issue Type: Bug Components: REST Affects Versions: 2.2.1 Reporter: lujie -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] brfrn169 commented on pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate
brfrn169 commented on pull request #2228: URL: https://github.com/apache/hbase/pull/2228#issuecomment-686173812 @Apache9 @joshelser Can you please review this? I think no behavior change other than what I commented as follows after this change: https://github.com/apache/hbase/pull/2228#issue-465416205 Thank you in advance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2344: HBASE-24857:Fix several problems when starting webUI
Apache-HBase commented on pull request #2344: URL: https://github.com/apache/hbase/pull/2344#issuecomment-686165699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | shelldocs | 0m 0s | Shelldocs was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2.3 Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 52s | branch-2.3 passed | | +1 :green_heart: | checkstyle | 2m 25s | branch-2.3 passed | | +1 :green_heart: | spotbugs | 11m 17s | branch-2.3 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 19s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 33s | the patch passed | | +1 :green_heart: | checkstyle | 2m 23s | the patch passed | | +1 :green_heart: | shellcheck | 0m 2s | There were no new shellcheck issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 41s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 11m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 64m 7s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2344 | | JIRA Issue | HBASE-24857 | | Optional Tests | dupname asflicense shellcheck shelldocs spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux c558c6bd2007 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2.3 / b7c99fbaf8 | | Max. process+thread count | 122 (vs. ulimit of 12500) | | modules | C: hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2344/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat
[
https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189772#comment-17189772
]
Hudson commented on HBASE-24831:
Results for branch master
[build #33 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33//console].
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Avoid invoke Counter using reflection in SnapshotInputFormat
> -
>
> Key: HBASE-24831
> URL: https://issues.apache.org/jira/browse/HBASE-24831
> Project: HBase
> Issue Type: Improvement
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Labels: Performance, mapreduce, snapshot
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> In TableRecordReaderImpl we invoke Counter increment by reflection
> This will be called nextKeyValue() in TableSnapshotInputFormat
> reflection invoke is very slower than normal method call
> we can avoid these to improve the read performance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24973) Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner
[
https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189773#comment-17189773
]
Hudson commented on HBASE-24973:
Results for branch master
[build #33 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33//console].
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/33//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Remove read point parameter in method StoreFlush#performFlush and
> StoreFlush#createScanner
> --
>
> Key: HBASE-24973
> URL: https://issues.apache.org/jira/browse/HBASE-24973
> Project: HBase
> Issue Type: Improvement
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Currently, read point parameter in method StoreFlush#performFlush is useless
> and can be safely removed.
> and then method StoreFlush#createScanner can also remove this parameter
> See below
> {code:java}
> // Some comments here
> /**
>* Performs memstore flush, writing data from scanner into sink.
>* @param scanner Scanner to get data from.
>* @param sink Sink to write data to. Could be StoreFile.Writer.
>* @param smallestReadPoint Smallest read point used for the flush.
>* @param throughputController A controller to avoid flush too fast
>*/
> protected void performFlush(InternalScanner scanner, CellSink sink,
> long smallestReadPoint, ThroughputController throughputController)
> throws IOException
> {code}
> Parameter smallestReadPoint is not used in this method. When
> `smallestReadPoint` is removed, inner method `createScanner` can remove this
> necessary parameter too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-686154935 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | checkstyle | 2m 7s | master passed | | +0 :ok: | refguide | 5m 31s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 14m 24s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | -0 :warning: | checkstyle | 2m 8s | root: The patch generated 2 new + 7 unchanged - 0 fixed = 9 total (was 7) | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +0 :ok: | refguide | 5m 45s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 12m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 15m 16s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. | | | | 77m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2320 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide | | uname | Linux 90b4cdd09986 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-general-check/output/branch-site/book.html | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] GeorryHuang opened a new pull request #2344: HBASE-24857:Fix several problems when starting webUI
GeorryHuang opened a new pull request #2344: URL: https://github.com/apache/hbase/pull/2344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r482602787
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerDecisionRequest.java
##
@@ -0,0 +1,64 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Balancer decision request payload with filter attributes
+ */
+@InterfaceAudience.Private
+public class BalancerDecisionRequest extends LogRequest {
+
+ private int limit = 250;
+
+ public int getLimit() {
Review comment:
-1 on limits in non public RPC classes. The Admin API is the public
interface here. These RPC FooRequest and FooResponse classes are implementation
detail and not the place to be doing this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r482602133
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/LogQueryFilter.java
##
@@ -22,22 +22,27 @@
import org.apache.commons.lang3.builder.EqualsBuilder;
import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.hadoop.hbase.ServerName;
import org.apache.yetus.audience.InterfaceAudience;
+import org.apache.yetus.audience.InterfaceStability;
+import java.util.Collections;
+import java.util.Set;
/**
* Slow/Large Log Query Filter with all filter and limit parameters
* Used by Admin API: getSlowLogResponses
*/
-@InterfaceAudience.Private
-public class LogQueryFilter {
+@InterfaceAudience.Public
+@InterfaceStability.Evolving
+public class LogQueryFilter extends LogRequest {
private String regionName;
private String clientAddress;
private String tableName;
private String userName;
- private int limit = 10;
Review comment:
Limits by way of filter will be fine if you want to do it this way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
apurtell commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r482601358 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java ## @@ -2472,4 +2482,13 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous) */ void updateRSGroupConfig(String groupName, Map configuration) throws IOException; + /** + * Retrieve recent online records from HMaster / RegionServers. + * Examples include slow/large RPC logs, balancer decisions by master. + * + * @param logRequest request payload with possible filters + * @return Log entries representing online records from servers + * @throws IOException if a remote or network exception occurs + */ + List getLogEntries(LogRequest logRequest) throws IOException; Review comment: Please define a limit parameter for the Admin API. I'm open to other suggestions, but by "individual use cases" I believe you mean the RPC message classes, and those are not the user facing API, they are an implementation detail. As an alternative you can do the same thing as you did for the SlowLog API where a filter can be supplied, and one thing the filter interface lets you do is specify a limit. I won't approve this without a limit option of some kind in the public user facing admin API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
apurtell commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r482600399 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java ## @@ -1673,4 +1682,13 @@ * @throws IOException if a remote or network exception occurs */ CompletableFuture updateRSGroupConfig(String groupName, Map configuration); + + /** + * Retrieve recent online records from HMaster / RegionServers. + * Examples include slow/large RPC logs, balancer decisions by master. + * + * @param logRequest request payload with possible filters + * @return Log entries representing online records from servers + */ + CompletableFuture> getLogEntries(LogRequest logRequest); Review comment: Please define a limit parameter for the Admin API. I'm open to other suggestions, but by "individual use cases" I believe you mean the RPC message classes, and those are not user facing public API. The user facing API here is the Admin API. This is the place to do this. As an alternative you can do the same thing as you did for the SlowLog API where a filter can be supplied, and one thing the filter interface lets you do is specify a limit. I won't approve this without a limit option of some kind in the public user facing admin API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API
apurtell commented on a change in pull request #2261:
URL: https://github.com/apache/hbase/pull/2261#discussion_r482600399
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##
@@ -1673,4 +1682,13 @@
* @throws IOException if a remote or network exception occurs
*/
CompletableFuture updateRSGroupConfig(String groupName, Map configuration);
+
+ /**
+ * Retrieve recent online records from HMaster / RegionServers.
+ * Examples include slow/large RPC logs, balancer decisions by master.
+ *
+ * @param logRequest request payload with possible filters
+ * @return Log entries representing online records from servers
+ */
+ CompletableFuture> getLogEntries(LogRequest logRequest);
Review comment:
Please define a limit parameter for the Admin API. I'm open to other
suggestions, but by "individual use cases" I believe you mean the RPC message
classes, and those are not public API.
As an alternative you can do the same thing as you did for the SlowLog API
where a filter can be supplied, and one thing the filter interface lets you do
is specify a limit.
I won't approve this without a limit option of some kind in the public user
facing admin API.
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/BalancerDecisionRequest.java
##
@@ -0,0 +1,64 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase.client;
+
+import org.apache.commons.lang3.builder.EqualsBuilder;
+import org.apache.commons.lang3.builder.HashCodeBuilder;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Balancer decision request payload with filter attributes
+ */
+@InterfaceAudience.Private
+public class BalancerDecisionRequest extends LogRequest {
+
+ private int limit = 250;
+
+ public int getLimit() {
Review comment:
-1 on limits in non public RPC classes. The Admin API is the public
interface here. These RPC classes are implementation detail and not the place
to be doing this.
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##
@@ -1673,4 +1682,13 @@
* @throws IOException if a remote or network exception occurs
*/
CompletableFuture updateRSGroupConfig(String groupName, Map configuration);
+
+ /**
+ * Retrieve recent online records from HMaster / RegionServers.
+ * Examples include slow/large RPC logs, balancer decisions by master.
+ *
+ * @param logRequest request payload with possible filters
+ * @return Log entries representing online records from servers
+ */
+ CompletableFuture> getLogEntries(LogRequest logRequest);
Review comment:
In the future please do not mark conversations that are not resolved as
resolved.
##
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##
@@ -2472,4 +2482,13 @@ boolean snapshotCleanupSwitch(final boolean on, final
boolean synchronous)
*/
void updateRSGroupConfig(String groupName, Map
configuration) throws IOException;
+ /**
+ * Retrieve recent online records from HMaster / RegionServers.
+ * Examples include slow/large RPC logs, balancer decisions by master.
+ *
+ * @param logRequest request payload with possible filters
+ * @return Log entries representing online records from servers
+ * @throws IOException if a remote or network exception occurs
+ */
+ List getLogEntries(LogRequest logRequest) throws IOException;
Review comment:
Please define a limit parameter for the Admin API. I'm open to other
suggestions, but by "individual use cases" I believe you mean the RPC message
classes, and those are not public API.
As an alternative you can do the same thing as you did for the SlowLog API
where a filter can be supplied, and one thing the filter interface lets you do
is specify a limit.
I won't approve this without a limit option of some kind in the public user
facing admin API.
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/LogQueryFilter.java
##
@@ -22,22
[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-686074169 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | compile | 2m 35s | master passed | | +1 :green_heart: | shadedjars | 7m 28s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 26s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 53s | the patch passed | | +1 :green_heart: | compile | 2m 37s | the patch passed | | +1 :green_heart: | javac | 2m 37s | the patch passed | | +1 :green_heart: | shadedjars | 7m 37s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 327m 21s | root in the patch failed. | | | | 366m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2320 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 82c9c9b89445 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/testReport/ | | Max. process+thread count | 3128 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2280: HBASE-18095 branch-1 backport (WIP)
Apache-HBase commented on pull request #2280: URL: https://github.com/apache/hbase/pull/2280#issuecomment-686039122 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. | | +0 :ok: | prototool | 0m 0s | prototool was not available. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 31 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 55s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 40s | branch-1 passed | | +1 :green_heart: | compile | 1m 39s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | compile | 1m 44s | branch-1 passed with JDK v1.7.0_272 | | +1 :green_heart: | checkstyle | 12m 23s | branch-1 passed | | +1 :green_heart: | shadedjars | 2m 58s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 3m 32s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 5m 18s | branch-1 passed with JDK v1.7.0_272 | | +0 :ok: | spotbugs | 2m 41s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 17m 10s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 1m 56s | the patch passed | | +1 :green_heart: | compile | 1m 41s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | cc | 1m 41s | the patch passed | | +1 :green_heart: | javac | 1m 41s | the patch passed | | +1 :green_heart: | compile | 1m 42s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | cc | 1m 42s | the patch passed | | +1 :green_heart: | javac | 1m 42s | the patch passed | | -1 :x: | checkstyle | 0m 52s | hbase-client: The patch generated 1 new + 691 unchanged - 21 fixed = 692 total (was 712) | | -1 :x: | checkstyle | 2m 23s | hbase-server: The patch generated 95 new + 1861 unchanged - 48 fixed = 1956 total (was 1909) | | -1 :x: | checkstyle | 6m 11s | root: The patch generated 100 new + 2550 unchanged - 73 fixed = 2650 total (was 2623) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | xml | 0m 0s | The patch has 1 ill-formed XML file(s). | | +1 :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 4m 48s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | hbaseprotoc | 3m 51s | the patch passed | | +1 :green_heart: | javadoc | 3m 19s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 5m 11s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | findbugs | 18m 23s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 154m 31s | root in the patch failed. | | +1 :green_heart: | asflicense | 2m 19s | The patch does not generate ASF License warnings. | | | | 277m 28s | | | Reason | Tests | |---:|:--| | XML | Parsing Error(s): | | | pom.xml | | Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshotWithTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2280 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool xml | | uname | Linux d2fd6e0c523a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-2280/out/precommit/personality/provided.sh | | git revision | branch-1 / 1dc75e7 | | Default Java | 1.7.0_272 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2280/12/artifact/out/diff-checkstyle-hbase-client.txt | | checkstyle |
[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-686035370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 3m 11s | master passed | | +1 :green_heart: | shadedjars | 7m 24s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 15s | root in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-asyncfs in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 30s | the patch passed | | +1 :green_heart: | compile | 3m 6s | the patch passed | | +1 :green_heart: | javac | 3m 6s | the patch passed | | +1 :green_heart: | shadedjars | 7m 19s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 15s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 240m 22s | root in the patch passed. | | | | 277m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2320 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d6665859c218 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-asyncfs.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-asyncfs.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/testReport/ | | Max. process+thread count | 4546 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,
[GitHub] [hbase-filesystem] wchevreuil commented on pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.
wchevreuil commented on pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15#issuecomment-685954468 Had pushed a new commit, with a change to EmbeddedZK to make sure it works with hbase versions including HBASE-23993 (like 2.3.1), for example. As mentioned on my previous comments, testing against hbase 2.3.1 works as long as ZK version specified is 3.5.7: `mvn clean install -Dhadoop.profile=3 -Dhadoop3.version=3.3.0 -Dhbase.profile=2 -Dhbase2.version=2.3.1 -Dzookeeper.version=3.5.7` @apurtell @joshelser , mind give it another try? I was thinking maybe worth raise these dependency versions on another jira? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat
[
https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189630#comment-17189630
]
Hudson commented on HBASE-24831:
Results for branch branch-2.3
[build #27 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/27/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/27/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/27//console].
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/27//console].
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/27//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Avoid invoke Counter using reflection in SnapshotInputFormat
> -
>
> Key: HBASE-24831
> URL: https://issues.apache.org/jira/browse/HBASE-24831
> Project: HBase
> Issue Type: Improvement
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Labels: Performance, mapreduce, snapshot
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> In TableRecordReaderImpl we invoke Counter increment by reflection
> This will be called nextKeyValue() in TableSnapshotInputFormat
> reflection invoke is very slower than normal method call
> we can avoid these to improve the read performance
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-685912320 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 38s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | checkstyle | 2m 10s | master passed | | +0 :ok: | refguide | 6m 1s | branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | spotbugs | 16m 1s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | -0 :warning: | checkstyle | 2m 16s | root: The patch generated 4 new + 7 unchanged - 0 fixed = 11 total (was 7) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +0 :ok: | refguide | 6m 12s | patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect. | | +1 :green_heart: | hadoopcheck | 13m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 17m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 59s | The patch does not generate ASF License warnings. | | | | 84m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2320 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle refguide | | uname | Linux fe1334aefcf7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-general-check/output/branch-site/book.html | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | refguide | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/artifact/yetus-general-check/output/patch-site/book.html | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-asyncfs hbase-server . U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2320/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24975) HBASE shell update_config doesn't work for master node
[ https://issues.apache.org/jira/browse/HBASE-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189609#comment-17189609 ] Clara Xiong commented on HBASE-24975: - We ran into the issue with these configs: hbase.master.balancer.stochastic.runMaxSteps hbase.master.balancer.stochastic.stepsPerRegion hbase.master.balancer.stochastic.maxRunningTime > HBASE shell update_config doesn't work for master node > -- > > Key: HBASE-24975 > URL: https://issues.apache.org/jira/browse/HBASE-24975 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.3.1 >Reporter: Clara Xiong >Priority: Critical > > The helper message says: > Reload a subset of configuration on server 'servername' where servername is > host, port plus startcode. For example: > host187.example.com,60020,1289493121758 > See http://hbase.apache.org/book.html#dyn_config for more details. Here is how > you would run the command in the hbase shell: > hbase> update_config 'servername' > > But the command doesn't update config on master. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-filesystem] wchevreuil commented on pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.
wchevreuil commented on pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15#issuecomment-685894894 Right, so here some findings: 1) Setting hbase version to 2.3.1 requires updating ZK version in hboss to 3.5.7, otherwise, we get the NCDFE already mentioned above. 2) Additional adjustment is required in EmbeddedZK class to use loopback address, instead of localhost, per the changes in MiniZooKeeperCluster by HBASE-23993. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-685854991 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 7m 10s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 7m 5s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 206m 15s | hbase-server in the patch failed. | | | | 234m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2342 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3127437cd769 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/testReport/ | | Max. process+thread count | 2852 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell reopened HBASE-24893:
-
> TestLogLevel failing on hadoop-ci (branch-1)
>
>
> Key: HBASE-24893
> URL: https://issues.apache.org/jira/browse/HBASE-24893
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Andrew Kyle Purtell
>Assignee: Abhey Rana
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> TestLogLevel is failing the branch-1 builds on hadoop-ci.
> The test needs some improvement. The code seems to be doing the right thing
> but the error condition the test is expecting varies by JVM or JVM version:
> {noformat}
> Expected to find 'Unrecognized SSL message' but got unexpected exception:
> javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-685850008 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 47s | master passed | | +1 :green_heart: | compile | 1m 11s | master passed | | +1 :green_heart: | shadedjars | 7m 18s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 43s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 7m 25s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 195m 58s | hbase-server in the patch passed. | | | | 226m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2342 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3e244cb72d25 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/testReport/ | | Max. process+thread count | 3275 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.
virajjasani commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r482199372
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
I just had an offline chat with @shahrs87 and I am +1 with keeping
scanner timeout as config for Lock, the intention is to:
1. not introduce more timeout configs and worsen timeout burden.
2. use the one which can help with multiple retries (if allowed within SLA)
rather than timeout which is available at entire operation level (rpc call +
lock + locate region by scan + retry if required + and so on...).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24957) ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.
[
https://issues.apache.org/jira/browse/HBASE-24957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189343#comment-17189343
]
Rushabh Shah commented on HBASE-24957:
--
Thank you [~vjasani] for review and commit, [~bharathv] for the review.
> ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or
> not.
> --
>
> Key: HBASE-24957
> URL: https://issues.apache.org/jira/browse/HBASE-24957
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 1.6.0, 1.3.6, 1.7.0
>Reporter: Rushabh Shah
>Assignee: Rushabh Shah
>Priority: Major
> Fix For: 1.7.0
>
>
> The following bug exists only in branch-1 and below.
> ZKTableStateClientSideReader#isDisabledTable returns false even if table
> doesn't exists.
> Below is the code snippet:
> {code:title=ZKTableStateClientSideReader.java|borderStyle=solid}
> public static boolean isDisabledTable(final ZooKeeperWatcher zkw,
> final TableName tableName)
> throws KeeperException, InterruptedException {
> ZooKeeperProtos.Table.State state = getTableState(zkw, tableName);
> ---> We should check here if state is null or not.
> return isTableState(ZooKeeperProtos.Table.State.DISABLED, state);
> }
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] mnpoonia commented on pull request #2334: HBASE-24970 Backport HBASE-20985 to branch-1
mnpoonia commented on pull request #2334: URL: https://github.com/apache/hbase/pull/2334#issuecomment-685827328 The test failure is in TestLoadIncrementalHFiles.testRegionCrossingHFileSplit which is unrelated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.
shahrs87 commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r482175115
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
Let me explain my POV with one of our client example.
We have an internal customer who wants a strict 15 seconds SLA for every
operation. Since operation timeout is end to end timeout which includes all the
retries, sleep within retries so we suggested them to use operation timeout as
15 seconds.
Also we recommended them to set scanner timeout period to 7 seconds with
retries config (hbase.client.retries.number) set to 2 . There is some sleep
interval between each attempt and we expect the call to complete within 15
seconds and if it doesn't then operation timeout will kick in and fail the call.
But we found out that getRegionLocations call is not bounded by operation
timeout.
Now if we set the lock timeout to same as operation timeout, then in worst
case scenario call will fail in 15 (lock timeout) + 15 (lock timeout 2nd try) +
1 (assuming sleep of 1 second) = 31 seconds
If we set the lock timeout to same as scanner timeout, then in worst case
scenario the call will fail in 7 (scanner timeout) + 7 (scanner timeout) + 1
(sleep between tries) = 16 seconds which is closer to SLA that we promised.
Hope this makes sense. If still the community wants to go forward with
operation timeout, I will change it to operation timeout.
@infraio @bharathv @virajjasani @saintstack @apurtell
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.
shahrs87 commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r482175115
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
We have an internal customer who wants a strict 15 seconds SLA for every
operation. Since operation timeout is end to end timeout which includes all the
retries, sleep within retries so we suggested them to use operation timeout as
15 seconds.
Also we recommended them to set scanner timeout period to 7 seconds with
retries config (hbase.client.retries.number) set to 2 . There is some sleep
interval between each attempt and we expect the call to complete within 15
seconds and if it doesn't then operation timeout will kick in and fail the call.
But we found out that getRegionLocations call is not bounded by operation
timeout.
Now if we set the lock timeout to same as operation timeout, then in worst
case scenario call will fail in 15 (lock timeout) + 15 (lock timeout 2nd try) +
1 (assuming sleep of 1 second) = 31 seconds
If we set the lock timeout to same as scanner timeout, then in worst case
scenario the call will fail in 7 (scanner timeout) + 7 (scanner timeout) + 1
(sleep between tries) = 16 seconds which is closer to SLA that we promised.
Hope this makes sense. If still the community wants to go forward with
operation timeout, I will change it to operation timeout.
@infraio @bharathv @virajjasani @saintstack @apurtell
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24569) Get hostAndWeights in addition using localhost if it is null in local mode
[
https://issues.apache.org/jira/browse/HBASE-24569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189322#comment-17189322
]
Hudson commented on HBASE-24569:
Results for branch branch-2
[build #30 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/30/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/30/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/30/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/30/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/30/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/30//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Get hostAndWeights in addition using localhost if it is null in local mode
> --
>
> Key: HBASE-24569
> URL: https://issues.apache.org/jira/browse/HBASE-24569
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.3.2
>
>
> In local mode, regionserver use pcname as hostname, but the blockLocation
> returned by filesystem use localhost as hostname, it cause mismatch when we
> get hostAndWeight from hostAndWeights.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24971) Upgrade JQuery to 3.5.1
[
https://issues.apache.org/jira/browse/HBASE-24971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189296#comment-17189296
]
Hudson commented on HBASE-24971:
Results for branch branch-2.3
[build #26 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/26/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/26/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/26/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/26/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/26/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Upgrade JQuery to 3.5.1
> ---
>
> Key: HBASE-24971
> URL: https://issues.apache.org/jira/browse/HBASE-24971
> Project: HBase
> Issue Type: Bug
> Components: security, UI
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7
>
>
> JQuery <= 3.5.0 is subject to a known cross site scripting vulnerability.
> Upgrade our embedded minimized jquery library to 3.5.1.
> Upgrade embedded jquery-tablesorter while at it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-685729480 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | checkstyle | 1m 12s | master passed | | +1 :green_heart: | spotbugs | 2m 6s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | -0 :warning: | checkstyle | 1m 9s | hbase-server: The patch generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 19s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | -1 :x: | spotbugs | 2m 18s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 35m 46s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Null pointer dereference of involvedRegions in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) Dereferenced at RegionServerFlushTableProcedureManager.java:in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) Dereferenced at RegionServerFlushTableProcedureManager.java:[line 153] | | | Load of known null value in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) At RegionServerFlushTableProcedureManager.java:in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) At RegionServerFlushTableProcedureManager.java:[line 153] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2342 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux a366063b2996 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24964) Remove MetaTableAccessor.tableExists
[
https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189217#comment-17189217
]
Hudson commented on HBASE-24964:
Results for branch master
[build #32 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Remove MetaTableAccessor.tableExists
>
>
> Key: HBASE-24964
> URL: https://issues.apache.org/jira/browse/HBASE-24964
> Project: HBase
> Issue Type: Sub-task
> Components: meta
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> At master side, we could make use of TableDescriptors to determine whether a
> table exists, as it caches all the table descriptors.
> For other places, we could just make use Admin.tableExists, which is exactly
> the same with calling MetaTableAccessor.tableExists but avoid exposing meta
> directly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24971) Upgrade JQuery to 3.5.1
[
https://issues.apache.org/jira/browse/HBASE-24971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189216#comment-17189216
]
Hudson commented on HBASE-24971:
Results for branch master
[build #32 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/32//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> Upgrade JQuery to 3.5.1
> ---
>
> Key: HBASE-24971
> URL: https://issues.apache.org/jira/browse/HBASE-24971
> Project: HBase
> Issue Type: Bug
> Components: security, UI
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7
>
>
> JQuery <= 3.5.0 is subject to a known cross site scripting vulnerability.
> Upgrade our embedded minimized jquery library to 3.5.1.
> Upgrade embedded jquery-tablesorter while at it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2341: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2341: URL: https://github.com/apache/hbase/pull/2341#issuecomment-685708252 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 7m 14s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 46s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 7m 7s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 203m 47s | hbase-server in the patch failed. | | | | 237m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2341 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a87bd134dba3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | Default Java | 1.8.0_232 | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/testReport/ | | Max. process+thread count | 3730 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-685706645 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 14s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 5s | master passed | | +1 :green_heart: | compile | 1m 16s | master passed | | +1 :green_heart: | shadedjars | 7m 39s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 44s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 7m 35s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 199m 21s | hbase-server in the patch passed. | | | | 232m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2342 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux abac8c443fd4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/testReport/ | | Max. process+thread count | 3196 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-685704944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | shadedjars | 7m 8s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 50s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 7m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 201m 27s | hbase-server in the patch passed. | | | | 229m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2342 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c5c2f546e399 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/testReport/ | | Max. process+thread count | 3451 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2341: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2341: URL: https://github.com/apache/hbase/pull/2341#issuecomment-685697040 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 23s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 1m 10s | master passed | | +1 :green_heart: | shadedjars | 7m 20s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 24s | the patch passed | | +1 :green_heart: | compile | 1m 11s | the patch passed | | +1 :green_heart: | javac | 1m 11s | the patch passed | | +1 :green_heart: | shadedjars | 7m 16s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 188m 37s | hbase-server in the patch passed. | | | | 218m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2341 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 12706bbb3355 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/testReport/ | | Max. process+thread count | 3337 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24971) Upgrade JQuery to 3.5.1
[
https://issues.apache.org/jira/browse/HBASE-24971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189182#comment-17189182
]
Hudson commented on HBASE-24971:
Results for branch branch-1
[build #17 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> Upgrade JQuery to 3.5.1
> ---
>
> Key: HBASE-24971
> URL: https://issues.apache.org/jira/browse/HBASE-24971
> Project: HBase
> Issue Type: Bug
> Components: security, UI
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.3, 1.7.0, 2.4.0, 2.2.7
>
>
> JQuery <= 3.5.0 is subject to a known cross site scripting vulnerability.
> Upgrade our embedded minimized jquery library to 3.5.1.
> Upgrade embedded jquery-tablesorter while at it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189183#comment-17189183
]
Hudson commented on HBASE-24893:
Results for branch branch-1
[build #17 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> TestLogLevel failing on hadoop-ci (branch-1)
>
>
> Key: HBASE-24893
> URL: https://issues.apache.org/jira/browse/HBASE-24893
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Andrew Kyle Purtell
>Assignee: Abhey Rana
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> TestLogLevel is failing the branch-1 builds on hadoop-ci.
> The test needs some improvement. The code seems to be doing the right thing
> but the error condition the test is expecting varies by JVM or JVM version:
> {noformat}
> Expected to find 'Unrecognized SSL message' but got unexpected exception:
> javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2334: HBASE-24970 Backport HBASE-20985 to branch-1
Apache-HBase commented on pull request #2334: URL: https://github.com/apache/hbase/pull/2334#issuecomment-685673615 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 16s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +0 :ok: | mvndep | 2m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 8m 10s | branch-1 passed | | +1 :green_heart: | compile | 1m 20s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | compile | 1m 35s | branch-1 passed with JDK v1.7.0_272 | | +1 :green_heart: | checkstyle | 2m 45s | branch-1 passed | | +1 :green_heart: | shadedjars | 3m 16s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 10s | branch-1 passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 1m 22s | branch-1 passed with JDK v1.7.0_272 | | +0 :ok: | spotbugs | 2m 55s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 4m 35s | branch-1 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 2m 7s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | compile | 1m 35s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | javac | 1m 35s | the patch passed | | +1 :green_heart: | checkstyle | 0m 37s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 46s | hbase-server: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4) | | +1 :green_heart: | checkstyle | 0m 14s | The patch passed checkstyle in hbase-shell | | -1 :x: | rubocop | 0m 16s | The patch generated 9 new + 1031 unchanged - 6 fixed = 1040 total (was 1037) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedjars | 3m 6s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | hadoopcheck | 5m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 :green_heart: | javadoc | 1m 2s | the patch passed with JDK v1.8.0_262 | | +1 :green_heart: | javadoc | 1m 22s | the patch passed with JDK v1.7.0_272 | | +1 :green_heart: | findbugs | 4m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 50s | hbase-client in the patch passed. | | -1 :x: | unit | 154m 43s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 11m 2s | hbase-shell in the patch passed. | | +1 :green_heart: | asflicense | 1m 6s | The patch does not generate ASF License warnings. | | | | 225m 24s | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2334/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2334 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile rubocop | | uname | Linux 8112dd85a9d3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-2334/out/precommit/personality/provided.sh | | git revision | branch-1 / 1dc75e7 | | Default Java | 1.7.0_272 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_262 /usr/lib/jvm/zulu-7-amd64:1.7.0_272 | | rubocop | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2334/4/artifact/out/diff-patch-rubocop.txt | | unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2334/4/artifact/out/patch-unit-hbase-server.txt | | Test Results |
[jira] [Assigned] (HBASE-24966) The methods in AsyncTableRegionLocator should not throw IOException directly
[ https://issues.apache.org/jira/browse/HBASE-24966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wenfeiyi666 reassigned HBASE-24966: --- Assignee: wenfeiyi666 > The methods in AsyncTableRegionLocator should not throw IOException directly > > > Key: HBASE-24966 > URL: https://issues.apache.org/jira/browse/HBASE-24966 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Assignee: wenfeiyi666 >Priority: Major > > This is an incompatible change as we changed the method signature. > But anyway this is a mistake so we should fix it... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2343: HBASE-24962 Optimize BufferNode Lock
Apache-HBase commented on pull request #2343: URL: https://github.com/apache/hbase/pull/2343#issuecomment-685599756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 14s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | checkstyle | 0m 15s | master passed | | +1 :green_heart: | spotbugs | 0m 36s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | -0 :warning: | checkstyle | 0m 15s | hbase-procedure: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 14m 18s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 36m 57s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2343 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 9be20097b1a0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2343: HBASE-24962 Optimize BufferNode Lock
Apache-HBase commented on pull request #2343: URL: https://github.com/apache/hbase/pull/2343#issuecomment-685594036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 7s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 8m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 17s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 7m 31s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 15s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 10s | hbase-procedure in the patch passed. | | | | 32m 54s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2343 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 0d6642aadeb3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/testReport/ | | Max. process+thread count | 245 (vs. ulimit of 12500) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2343: HBASE-24962 Optimize BufferNode Lock
Apache-HBase commented on pull request #2343: URL: https://github.com/apache/hbase/pull/2343#issuecomment-685589107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 34s | master passed | | +1 :green_heart: | compile | 0m 22s | master passed | | +1 :green_heart: | shadedjars | 7m 35s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 19s | hbase-procedure in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 36s | the patch passed | | +1 :green_heart: | compile | 0m 21s | the patch passed | | +1 :green_heart: | javac | 0m 21s | the patch passed | | +1 :green_heart: | shadedjars | 7m 31s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-procedure in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 50s | hbase-procedure in the patch passed. | | | | 29m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2343 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2b0a59f5629d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 4dc08144f3 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/testReport/ | | Max. process+thread count | 229 (vs. ulimit of 12500) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24975) HBASE shell update_config doesn't work for master node
[ https://issues.apache.org/jira/browse/HBASE-24975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189133#comment-17189133 ] Viraj Jasani commented on HBASE-24975: -- [~clarax98007] could you please provide the detail of config for which update_config didn't update the value dynamically? Thanks > HBASE shell update_config doesn't work for master node > -- > > Key: HBASE-24975 > URL: https://issues.apache.org/jira/browse/HBASE-24975 > Project: HBase > Issue Type: Bug > Components: shell >Affects Versions: 2.3.1 >Reporter: Clara Xiong >Priority: Critical > > The helper message says: > Reload a subset of configuration on server 'servername' where servername is > host, port plus startcode. For example: > host187.example.com,60020,1289493121758 > See http://hbase.apache.org/book.html#dyn_config for more details. Here is how > you would run the command in the hbase shell: > hbase> update_config 'servername' > > But the command doesn't update config on master. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24893) TestLogLevel failing on hadoop-ci (branch-1)
[
https://issues.apache.org/jira/browse/HBASE-24893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189131#comment-17189131
]
Viraj Jasani commented on HBASE-24893:
--
Thanks [~UselessCoder]!
I triggered nightly today, http tests are resolved and https related are
failing:
1.
[https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17/testReport/junit/org.apache.hadoop.hbase.http.log/TestLogLevel/testLogLevelByHttps/]
2.
[https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/17/testReport/junit/org.apache.hadoop.hbase.http.log/TestLogLevel/testLogLevelByHttpsWithSpnego/]
> TestLogLevel failing on hadoop-ci (branch-1)
>
>
> Key: HBASE-24893
> URL: https://issues.apache.org/jira/browse/HBASE-24893
> Project: HBase
> Issue Type: Bug
> Components: test
>Reporter: Andrew Kyle Purtell
>Assignee: Abhey Rana
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> TestLogLevel is failing the branch-1 builds on hadoop-ci.
> The test needs some improvement. The code seems to be doing the right thing
> but the error condition the test is expecting varies by JVM or JVM version:
> {noformat}
> Expected to find 'Unrecognized SSL message' but got unexpected exception:
> javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24973) Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner
[
https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang resolved HBASE-24973.
Fix Version/s: 2.4.0
3.0.0-alpha-1
Resolution: Fixed
Pushed to branch-2+. Thanks [~yuqi] for contributing.
> Remove read point parameter in method StoreFlush#performFlush and
> StoreFlush#createScanner
> --
>
> Key: HBASE-24973
> URL: https://issues.apache.org/jira/browse/HBASE-24973
> Project: HBase
> Issue Type: Improvement
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Currently, read point parameter in method StoreFlush#performFlush is useless
> and can be safely removed.
> and then method StoreFlush#createScanner can also remove this parameter
> See below
> {code:java}
> // Some comments here
> /**
>* Performs memstore flush, writing data from scanner into sink.
>* @param scanner Scanner to get data from.
>* @param sink Sink to write data to. Could be StoreFile.Writer.
>* @param smallestReadPoint Smallest read point used for the flush.
>* @param throughputController A controller to avoid flush too fast
>*/
> protected void performFlush(InternalScanner scanner, CellSink sink,
> long smallestReadPoint, ThroughputController throughputController)
> throws IOException
> {code}
> Parameter smallestReadPoint is not used in this method. When
> `smallestReadPoint` is removed, inner method `createScanner` can remove this
> necessary parameter too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24973) Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner
[
https://issues.apache.org/jira/browse/HBASE-24973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang reassigned HBASE-24973:
--
Assignee: yuqi
> Remove read point parameter in method StoreFlush#performFlush and
> StoreFlush#createScanner
> --
>
> Key: HBASE-24973
> URL: https://issues.apache.org/jira/browse/HBASE-24973
> Project: HBase
> Issue Type: Improvement
>Reporter: yuqi
>Assignee: yuqi
>Priority: Minor
>
> Currently, read point parameter in method StoreFlush#performFlush is useless
> and can be safely removed.
> and then method StoreFlush#createScanner can also remove this parameter
> See below
> {code:java}
> // Some comments here
> /**
>* Performs memstore flush, writing data from scanner into sink.
>* @param scanner Scanner to get data from.
>* @param sink Sink to write data to. Could be StoreFile.Writer.
>* @param smallestReadPoint Smallest read point used for the flush.
>* @param throughputController A controller to avoid flush too fast
>*/
> protected void performFlush(InternalScanner scanner, CellSink sink,
> long smallestReadPoint, ThroughputController throughputController)
> throws IOException
> {code}
> Parameter smallestReadPoint is not used in this method. When
> `smallestReadPoint` is removed, inner method `createScanner` can remove this
> necessary parameter too
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2343: HBASE-24962 Optimize BufferNode Lock
Apache-HBase commented on pull request #2343: URL: https://github.com/apache/hbase/pull/2343#issuecomment-685545934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 45s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 19s | master passed | | +1 :green_heart: | checkstyle | 0m 17s | master passed | | +1 :green_heart: | spotbugs | 0m 41s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 38s | the patch passed | | -0 :warning: | checkstyle | 0m 17s | hbase-procedure: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 39s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 55s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 38m 38s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2343 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 52763e6e3a5a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-procedure.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2343: HBASE-24962 Optimize BufferNode Lock
Apache-HBase commented on pull request #2343: URL: https://github.com/apache/hbase/pull/2343#issuecomment-685539551 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 4s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 7s | master passed | | +1 :green_heart: | compile | 0m 23s | master passed | | +1 :green_heart: | shadedjars | 8m 39s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 56s | the patch passed | | +1 :green_heart: | compile | 0m 24s | the patch passed | | +1 :green_heart: | javac | 0m 24s | the patch passed | | +1 :green_heart: | shadedjars | 8m 25s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 29s | hbase-procedure in the patch passed. | | | | 34m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2343 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 390d7659b2c5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | Default Java | 1.8.0_232 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/testReport/ | | Max. process+thread count | 250 (vs. ulimit of 12500) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2343: HBASE-24962 Optimize BufferNode Lock
Apache-HBase commented on pull request #2343: URL: https://github.com/apache/hbase/pull/2343#issuecomment-685532581 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 52s | master passed | | +1 :green_heart: | compile | 0m 25s | master passed | | +1 :green_heart: | shadedjars | 7m 29s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-procedure in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 29s | the patch passed | | +1 :green_heart: | compile | 0m 20s | the patch passed | | +1 :green_heart: | javac | 0m 20s | the patch passed | | +1 :green_heart: | shadedjars | 7m 18s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-procedure in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 51s | hbase-procedure in the patch passed. | | | | 29m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2343 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 53d18e4ac92d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | Default Java | 2020-01-14 | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-procedure.txt | | javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-procedure.txt | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/testReport/ | | Max. process+thread count | 218 (vs. ulimit of 12500) | | modules | C: hbase-procedure U: hbase-procedure | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2343/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio merged pull request #2337: HBASE-24973 Remove read point parameter in method StoreFlush#performFlush and StoreFlush#createScanner
infraio merged pull request #2337: URL: https://github.com/apache/hbase/pull/2337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-24962) Optimize BufferNode Lock
[ https://issues.apache.org/jira/browse/HBASE-24962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24962: --- Status: Patch Available (was: Open) > Optimize BufferNode Lock > > > Key: HBASE-24962 > URL: https://issues.apache.org/jira/browse/HBASE-24962 > Project: HBase > Issue Type: Bug > Components: MTTR >Affects Versions: 2.2.3, 3.0.0-alpha-1 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > > [https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L373] > during startup, a large number of OpenRegionProcedures are generated, which > are added to the BufferNode. However, the BufferNode has some "synchronized" > methods, These methods may affect MTTR -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-24962) Optimize BufferNode Lock
[ https://issues.apache.org/jira/browse/HBASE-24962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui reassigned HBASE-24962: -- Assignee: Bo Cui > Optimize BufferNode Lock > > > Key: HBASE-24962 > URL: https://issues.apache.org/jira/browse/HBASE-24962 > Project: HBase > Issue Type: Bug > Components: MTTR >Affects Versions: 3.0.0-alpha-1, 2.2.3 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > > [https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java#L373] > during startup, a large number of OpenRegionProcedures are generated, which > are added to the BufferNode. However, the BufferNode has some "synchronized" > methods, These methods may affect MTTR -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] cuibo01 opened a new pull request #2343: HBASE-24962 Optimize BufferNode Lock
cuibo01 opened a new pull request #2343: URL: https://github.com/apache/hbase/pull/2343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24831. Fix Version/s: 2.3.2 2.4.0 3.0.0-alpha-1 Resolution: Fixed Pushed to branch-2.3+. Thanks [~chenyechao] for contributing. > Avoid invoke Counter using reflection in SnapshotInputFormat > - > > Key: HBASE-24831 > URL: https://issues.apache.org/jira/browse/HBASE-24831 > Project: HBase > Issue Type: Improvement >Reporter: Yechao Chen >Assignee: Yechao Chen >Priority: Major > Labels: Performance, mapreduce, snapshot > Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2 > > > In TableRecordReaderImpl we invoke Counter increment by reflection > This will be called nextKeyValue() in TableSnapshotInputFormat > reflection invoke is very slower than normal method call > we can avoid these to improve the read performance -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2342: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2342: URL: https://github.com/apache/hbase/pull/2342#issuecomment-685484425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 15s | master passed | | +1 :green_heart: | spotbugs | 2m 15s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 37s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | -1 :x: | spotbugs | 2m 25s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 36m 56s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Null pointer dereference of involvedRegions in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) Dereferenced at RegionServerFlushTableProcedureManager.java:in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) Dereferenced at RegionServerFlushTableProcedureManager.java:[line 153] | | | Load of known null value in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) At RegionServerFlushTableProcedureManager.java:in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) At RegionServerFlushTableProcedureManager.java:[line 153] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2342 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 5e73cd0a15fc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2342/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2341: HBASE-24960 reduce invalid subprocedure task
Apache-HBase commented on pull request #2341: URL: https://github.com/apache/hbase/pull/2341#issuecomment-685484723 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 51s | master passed | | +1 :green_heart: | checkstyle | 1m 11s | master passed | | +1 :green_heart: | spotbugs | 2m 19s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | the patch passed | | -0 :warning: | checkstyle | 1m 11s | hbase-server: The patch generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 48s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | -1 :x: | spotbugs | 3m 3s | hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 39m 17s | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-server | | | Null pointer dereference of involvedRegions in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) Dereferenced at RegionServerFlushTableProcedureManager.java:in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) Dereferenced at RegionServerFlushTableProcedureManager.java:[line 153] | | | Load of known null value in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) At RegionServerFlushTableProcedureManager.java:in org.apache.hadoop.hbase.procedure.flush.RegionServerFlushTableProcedureManager.buildSubprocedure(String, String) At RegionServerFlushTableProcedureManager.java:[line 153] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2341 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux bec0ecdb4eb7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 04de594138 | | checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2341/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24792) LogRoller.walRollFinished fix
[ https://issues.apache.org/jira/browse/HBASE-24792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189095#comment-17189095 ] wenfeiyi666 commented on HBASE-24792: - ping [~anoop.hbase] and [~zhangduo] > LogRoller.walRollFinished fix > - > > Key: HBASE-24792 > URL: https://issues.apache.org/jira/browse/HBASE-24792 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.3.1, 2.2.6 >Reporter: wenfeiyi666 >Assignee: wenfeiyi666 >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24849) Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when one of the WAL needs a roll
[ https://issues.apache.org/jira/browse/HBASE-24849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17189092#comment-17189092 ] wenfeiyi666 commented on HBASE-24849: - ping [~anoop.hbase] > Branch-1 Backport : HBASE-24665 MultiWAL : Avoid rolling of ALL WALs when > one of the WAL needs a roll > -- > > Key: HBASE-24849 > URL: https://issues.apache.org/jira/browse/HBASE-24849 > Project: HBase > Issue Type: Bug >Reporter: Anoop Sam John >Assignee: wenfeiyi666 >Priority: Major > Fix For: 1.7.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24960) reduce invalid subprocedure task
[ https://issues.apache.org/jira/browse/HBASE-24960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24960: --- Status: Patch Available (was: Open) > reduce invalid subprocedure task > > > Key: HBASE-24960 > URL: https://issues.apache.org/jira/browse/HBASE-24960 > Project: HBase > Issue Type: Bug > Components: snapshots >Affects Versions: 2.2.3, 3.0.0-alpha-1 >Reporter: Bo Cui >Assignee: Bo Cui >Priority: Major > > [https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/snapshot/RegionServerSnapshotManager.java#L165] > [https://github.com/apache/hbase/blob/047e0618d290a09a4a269b00548fe17691e31787/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/flush/RegionServerFlushTableProcedureManager.java#L146] > > if involvedRegions is null or empty, rs should skip subprocedure. -- This message was sent by Atlassian Jira (v8.3.4#803005)
