[
https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25439.
---
Fix Version/s: 3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Merged to
saintstack commented on pull request #2821:
URL: https://github.com/apache/hbase/pull/2821#issuecomment-753649734
Merged. Test failure unrelated to doc changes.
This is an automated message from the Apache Git Service.
To
saintstack merged pull request #2821:
URL: https://github.com/apache/hbase/pull/2821
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
saintstack merged pull request #2812:
URL: https://github.com/apache/hbase/pull/2812
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25450.
---
Fix Version/s: 2.5.0
3.0.0-alpha-1
Hadoop Flags: Reviewed
[
https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257820#comment-17257820
]
Michael Stack commented on HBASE-25450:
---
Merged to branch-2 and master.
> The parameter
saintstack commented on a change in pull request #2801:
URL: https://github.com/apache/hbase/pull/2801#discussion_r551034111
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
##
@@ -242,6 +255,9 @@ public static void isLegalNamespaceName(final
[
https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257823#comment-17257823
]
Hudson commented on HBASE-24751:
Results for branch branch-2
[build #145 on
[
https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257796#comment-17257796
]
Michael Stack commented on HBASE-25453:
---
Can you enforce a limit? Span count? On each #next?
>
leyangyueshan commented on pull request #2822:
URL: https://github.com/apache/hbase/pull/2822#issuecomment-753730948
> @leyangyueshan there is a conflict still? See above.
sorry,rebase now
This is an automated message
leyangyueshan opened a new pull request #2837:
URL: https://github.com/apache/hbase/pull/2837
… & updatePut
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Apache-HBase commented on pull request #2837:
URL: https://github.com/apache/hbase/pull/2837#issuecomment-753749742
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257953#comment-17257953
]
Anjan Das commented on HBASE-25445:
---
[~mokai87] Yes, I have started working on the fix and I'm testing
Apache9 opened a new pull request #2839:
URL: https://github.com/apache/hbase/pull/2839
…ice and close
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Apache-HBase commented on pull request #2839:
URL: https://github.com/apache/hbase/pull/2839#issuecomment-753815181
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
cuibo01 commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-753792850
thank all for reviewing the code
This is an automated message from the Apache Git Service.
To respond to the
Apache9 commented on pull request #2714:
URL: https://github.com/apache/hbase/pull/2714#issuecomment-753720995
> How about we add our own annotation to mark things visible for testing
into the `hbase-annotations` module?
I‘m OK with this approach but what's the difference with
[
https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257913#comment-17257913
]
Baiqiang Zhao commented on HBASE-25439:
---
Thanks for review [~stack]. Will give a PR for branch-2.
Apache-HBase commented on pull request #2839:
URL: https://github.com/apache/hbase/pull/2839#issuecomment-753820098
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 commented on pull request #2714:
URL: https://github.com/apache/hbase/pull/2714#issuecomment-753726484
Oh, it is used to address the concern that guava may remove it in the
future? Sounds good to me.
This is an
[
https://issues.apache.org/jira/browse/HBASE-25431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257906#comment-17257906
]
Baiqiang Zhao commented on HBASE-25431:
---
Yes, the original logic is use maxFileSizeLowerLimit
[
https://issues.apache.org/jira/browse/HBASE-25431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Baiqiang Zhao updated HBASE-25431:
--
Description:
Before create or alter table, we will do sanityCheck in TableDescriptorChecker.
[
https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257925#comment-17257925
]
mokai commented on HBASE-25445:
---
[~dasanjan1296] Have you started the fix? I'm testing the fix on my
leyangyueshan commented on pull request #2837:
URL: https://github.com/apache/hbase/pull/2837#issuecomment-753742620
#2822 closed unexpected,so i open a new pr #2837
This is an automated message from the Apache Git
Apache9 opened a new pull request #2838:
URL: https://github.com/apache/hbase/pull/2838
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Apache-HBase commented on pull request #2838:
URL: https://github.com/apache/hbase/pull/2838#issuecomment-753800310
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m
leyangyueshan closed pull request #2822:
URL: https://github.com/apache/hbase/pull/2822
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25458:
--
Environment: (was: HRegi)
> HRegion methods cleanup
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25457 started by Duo Zhang.
-
> Possible race in AsyncConnectionImpl between getChoreService and close
>
[
https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25458:
-
Assignee: Duo Zhang
> HRegion methods cleanup
> ---
>
>
[
https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25457:
-
Assignee: Duo Zhang
> Possible race in AsyncConnectionImpl between getChoreService and close
>
[
https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25458 started by Duo Zhang.
-
> HRegion methods cleanup
> ---
>
> Key:
Apache-HBase commented on pull request #2837:
URL: https://github.com/apache/hbase/pull/2837#issuecomment-753783380
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
[
https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25457:
--
Component/s: Client
> Possible race in AsyncConnectionImpl between getChoreService and close
>
Apache-HBase commented on pull request #2839:
URL: https://github.com/apache/hbase/pull/2839#issuecomment-753816050
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257897#comment-17257897
]
Duo Zhang commented on HBASE-25453:
---
For ResultScanner, on master branch, it is something like the
[
https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257966#comment-17257966
]
Zheng Wang commented on HBASE-25435:
Backported to branch2.3+, with a bit conflict fixing.
> Slow
Apache-HBase commented on pull request #2837:
URL: https://github.com/apache/hbase/pull/2837#issuecomment-753812742
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
[
https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257899#comment-17257899
]
shenshengli commented on HBASE-25449:
-
{quote}Do you mean, users could forget to set it in hbase and
Apache-HBase commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-753584020
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #2824:
URL: https://github.com/apache/hbase/pull/2824#issuecomment-753584637
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache9 commented on pull request #2714:
URL: https://github.com/apache/hbase/pull/2714#issuecomment-753617483
Any other concerns here @apurtell ?
When implementing HBASE-25458, I found that it is a pain that we do not have
VisibleForTesting annotation.
For example, this
[
https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257754#comment-17257754
]
Hudson commented on HBASE-24751:
Results for branch master
[build #173 on
[
https://issues.apache.org/jira/browse/HBASE-25438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257755#comment-17257755
]
Hudson commented on HBASE-25438:
Results for branch master
[build #173 on
[
https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257731#comment-17257731
]
Duo Zhang commented on HBASE-25453:
---
Was thinking of add a span in AsyncClientScanner to be used as
[
https://issues.apache.org/jira/browse/HBASE-25437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257756#comment-17257756
]
Hudson commented on HBASE-25437:
Results for branch master
[build #173 on
busbey commented on pull request #2714:
URL: https://github.com/apache/hbase/pull/2714#issuecomment-753636244
How about we add our own annotation to mark things visible for testing into
the `hbase-annotations` module?
This
47 matches
Mail list logo