[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-753820098 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 55s | master passed | | +1 :green_heart: | checkstyle | 0m 28s | master passed | | +1 :green_heart: | spotbugs | 1m 5s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | checkstyle | 0m 27s | hbase-client: The patch generated 0 new + 0 unchanged - 3 fixed = 0 total (was 3) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 17m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 1m 8s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 37m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2839 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 13fbf30bfa33 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-753816050 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 24s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 28s | master passed | | +1 :green_heart: | compile | 0m 31s | master passed | | +1 :green_heart: | shadedjars | 6m 49s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 26s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 0m 30s | the patch passed | | +1 :green_heart: | javac | 0m 30s | the patch passed | | +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 8s | hbase-client in the patch passed. | | | | 27m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2839 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cdce7fc77715 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache-HBase commented on pull request #2839: URL: https://github.com/apache/hbase/pull/2839#issuecomment-753815181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 2s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 49s | master passed | | +1 :green_heart: | compile | 0m 26s | master passed | | +1 :green_heart: | shadedjars | 6m 42s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 35s | the patch passed | | +1 :green_heart: | compile | 0m 26s | the patch passed | | +1 :green_heart: | javac | 0m 26s | the patch passed | | +1 :green_heart: | shadedjars | 6m 38s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 6s | hbase-client in the patch passed. | | | | 25m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2839 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6c86fee7111d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/testReport/ | | Max. process+thread count | 346 (vs. ulimit of 3) | | modules | C: hbase-client U: hbase-client | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2839/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
Apache-HBase commented on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-753812742 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 48s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 7m 12s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 54s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | +1 :green_heart: | shadedjars | 7m 17s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 205m 40s | hbase-server in the patch passed. | | | | 236m 9s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2837 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 8a5312971715 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/testReport/ | | Max. process+thread count | 3891 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 opened a new pull request #2839: HBASE-25457 Possible race in AsyncConnectionImpl between getChoreServ…
Apache9 opened a new pull request #2839: URL: https://github.com/apache/hbase/pull/2839 …ice and close This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2838: HBASE-25458 HRegion methods cleanup
Apache-HBase commented on pull request #2838: URL: https://github.com/apache/hbase/pull/2838#issuecomment-753800310 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 54s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 58s | master passed | | +1 :green_heart: | checkstyle | 1m 10s | master passed | | +1 :green_heart: | spotbugs | 2m 2s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 1m 14s | hbase-server: The patch generated 0 new + 272 unchanged - 10 fixed = 272 total (was 282) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 19m 14s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 47s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. | | | | 48m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2838 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 5cfd9fafaba6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2838/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] cuibo01 commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR
cuibo01 commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-753792850 thank all for reviewing the code This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close
[ https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25457: -- Component/s: Client > Possible race in AsyncConnectionImpl between getChoreService and close > -- > > Key: HBASE-25457 > URL: https://issues.apache.org/jira/browse/HBASE-25457 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > On branch HBASE-22120, spotbugs reported a high priority error about this > problem, but the problem also exists on master. > Let's fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
Apache-HBase commented on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-753783380 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 31s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 7m 4s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 43s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 8s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 6m 46s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 40s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 131m 32s | hbase-server in the patch passed. | | | | 160m 28s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2837 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c05aaf4a4c4f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/testReport/ | | Max. process+thread count | 4097 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work started] (HBASE-25458) HRegion methods cleanup
[ https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25458 started by Duo Zhang. - > HRegion methods cleanup > --- > > Key: HBASE-25458 > URL: https://issues.apache.org/jira/browse/HBASE-25458 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Narrow down the public interface to make easier for tracing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close
[ https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25457: - Assignee: Duo Zhang > Possible race in AsyncConnectionImpl between getChoreService and close > -- > > Key: HBASE-25457 > URL: https://issues.apache.org/jira/browse/HBASE-25457 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > On branch HBASE-22120, spotbugs reported a high priority error about this > problem, but the problem also exists on master. > Let's fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (HBASE-25458) HRegion methods cleanup
[ https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25458: - Assignee: Duo Zhang > HRegion methods cleanup > --- > > Key: HBASE-25458 > URL: https://issues.apache.org/jira/browse/HBASE-25458 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Narrow down the public interface to make easier for tracing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-25457) Possible race in AsyncConnectionImpl between getChoreService and close
[ https://issues.apache.org/jira/browse/HBASE-25457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25457 started by Duo Zhang. - > Possible race in AsyncConnectionImpl between getChoreService and close > -- > > Key: HBASE-25457 > URL: https://issues.apache.org/jira/browse/HBASE-25457 > Project: HBase > Issue Type: Bug >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > On branch HBASE-22120, spotbugs reported a high priority error about this > problem, but the problem also exists on master. > Let's fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #2838: HBASE-25458 HRegion methods cleanup
Apache9 opened a new pull request #2838: URL: https://github.com/apache/hbase/pull/2838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25458) HRegion methods cleanup
[ https://issues.apache.org/jira/browse/HBASE-25458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25458: -- Environment: (was: HRegi) > HRegion methods cleanup > --- > > Key: HBASE-25458 > URL: https://issues.apache.org/jira/browse/HBASE-25458 > Project: HBase > Issue Type: Improvement > Components: regionserver >Reporter: Duo Zhang >Priority: Major > > Narrow down the public interface to make easier for tracing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25435) Slow metric value can be configured
[ https://issues.apache.org/jira/browse/HBASE-25435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257966#comment-17257966 ] Zheng Wang commented on HBASE-25435: Backported to branch2.3+, with a bit conflict fixing. > Slow metric value can be configured > --- > > Key: HBASE-25435 > URL: https://issues.apache.org/jira/browse/HBASE-25435 > Project: HBase > Issue Type: Improvement > Components: metrics >Reporter: xijiawen >Assignee: xijiawen >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.4, 2.5.0, 2.4.1 > > > The slow time in MetricsRegionServer is hard code (value :1000) > it's should be configured when some cluster is sensitived -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257953#comment-17257953 ] Anjan Das commented on HBASE-25445: --- [~mokai87] Yes, I have started working on the fix and I'm testing it out. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to diffrent filesystem, > SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using > wrong fs instance. SplitWALManager should use WAL corresponding fs instance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
Apache-HBase commented on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-753749742 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 53s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 27s | the patch passed | | +1 :green_heart: | checkstyle | 1m 6s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 18m 42s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0. | | +1 :green_heart: | spotbugs | 2m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 17s | The patch does not generate ASF License warnings. | | | | 43m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2837 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux c6686cca191f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8ecfcede96 | | Max. process+thread count | 94 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2837/1/console | | versions | git=2.17.1 maven=3.6.3 spotbugs=3.1.12 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan commented on pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
leyangyueshan commented on pull request #2837: URL: https://github.com/apache/hbase/pull/2837#issuecomment-753742620 #2822 closed unexpected，so i open a new pr #2837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] leyangyueshan opened a new pull request #2837: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
leyangyueshan opened a new pull request #2837: URL: https://github.com/apache/hbase/pull/2837 … & updatePut This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25445) SplitWALRemoteProcedure failed to archive split WAL
[ https://issues.apache.org/jira/browse/HBASE-25445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257925#comment-17257925 ] mokai commented on HBASE-25445: --- [~dasanjan1296] Have you started the fix? I'm testing the fix on my cluster and will raise PR soon. > SplitWALRemoteProcedure failed to archive split WAL > --- > > Key: HBASE-25445 > URL: https://issues.apache.org/jira/browse/HBASE-25445 > Project: HBase > Issue Type: Bug > Components: wal >Affects Versions: 3.0.0-alpha-1, 2.2.3, 2.4.1 >Reporter: mokai >Assignee: Anjan Das >Priority: Critical > > If 'hbase.wal.dir' and 'hbase.rootdir' are configured to diffrent filesystem, > SplitWALRemoteProcedure archived split WAL failed since SplitWALManager using > wrong fs instance. SplitWALManager should use WAL corresponding fs instance. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] leyangyueshan closed pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
leyangyueshan closed pull request #2822: URL: https://github.com/apache/hbase/pull/2822 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit
[ https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257913#comment-17257913 ] Baiqiang Zhao commented on HBASE-25439: --- Thanks for review [~stack]. Will give a PR for branch-2. And create a new issue for pretty print BlockSize > Add BYTE unit in PrettyPrinter.Unit > > > Key: HBASE-25439 > URL: https://issues.apache.org/jira/browse/HBASE-25439 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: image-2020-12-23-16-12-42-210.png > > > Currently only TTL supports PrettyPrinter, and MAX_FILESIZE is not human > readable： > !image-2020-12-23-16-12-42-210.png! > This issue add a new unit 'BYTE' to pretty print value of size, such as > MAX_FILESIZE, MEMSTORE_FLUSHSIZE. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] leyangyueshan commented on pull request #2822: HBASE-25434 SlowDelete & SlowPut metric value should use updateDelete…
leyangyueshan commented on pull request #2822: URL: https://github.com/apache/hbase/pull/2822#issuecomment-753730948 > @leyangyueshan there is a conflict still? See above. sorry，rebase now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-25431) MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number
[ https://issues.apache.org/jira/browse/HBASE-25431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Baiqiang Zhao updated HBASE-25431: -- Description: Before create or alter table, we will do sanityCheck in TableDescriptorChecker. If MAX_FILESIZE or MEMSTORE_FLUSHSIZE < 0, use maxFileSizeLowerLimit or flushSizeLowerLimit instead to pass check. But the real value in TableDescriptor is still < 0, and we can see negative values on the UI. However in flush and split logic, MAX_FILESIZE and MEMSTORE_FLUSHSIZE will judge whether it's value <= 0 , if true, change to default value. This does not affect flush and split. !image-2020-12-22-11-46-38-967.png! was: MAX_FILESIZE and MEMSTORE_FLUSHSIZE will judge whether it's value <= 0 in flush and split logic, if true, change to default value. We should check this in TableDescriptorChecker !image-2020-12-22-11-46-38-967.png! > MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number > - > > Key: HBASE-25431 > URL: https://issues.apache.org/jira/browse/HBASE-25431 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.4.0 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > Attachments: image-2020-12-22-11-46-38-967.png > > > Before create or alter table, we will do sanityCheck in > TableDescriptorChecker. If MAX_FILESIZE or MEMSTORE_FLUSHSIZE < 0, use > maxFileSizeLowerLimit or flushSizeLowerLimit instead to pass check. But the > real value in TableDescriptor is still < 0, and we can see negative values > on the UI. > However in flush and split logic, MAX_FILESIZE and MEMSTORE_FLUSHSIZE will > judge whether it's value <= 0 , if true, change to default value. This does > not affect flush and split. > !image-2020-12-22-11-46-38-967.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-25431) MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number
[ https://issues.apache.org/jira/browse/HBASE-25431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257906#comment-17257906 ] Baiqiang Zhao commented on HBASE-25431: --- Yes, the original logic is use maxFileSizeLowerLimit (2MB) instead if < 0. But the real value in TableDescriptor is still < 0, and we can see negative values on the UI. > MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number > - > > Key: HBASE-25431 > URL: https://issues.apache.org/jira/browse/HBASE-25431 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1, 2.4.0 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > Attachments: image-2020-12-22-11-46-38-967.png > > > Before create or alter table, we will do sanityCheck in > TableDescriptorChecker. If MAX_FILESIZE or MEMSTORE_FLUSHSIZE < 0, use > maxFileSizeLowerLimit or flushSizeLowerLimit instead to pass check. But the > real value in TableDescriptor is still < 0, and we can see negative values > on the UI. > However in flush and split logic, MAX_FILESIZE and MEMSTORE_FLUSHSIZE will > judge whether it's value <= 0 , if true, change to default value. This does > not affect flush and split. > !image-2020-12-22-11-46-38-967.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…
Apache9 commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-753726484 Oh, it is used to address the concern that guava may remove it in the future? Sounds good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
[
https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257899#comment-17257899
]
shenshengli commented on HBASE-25449:
-
{quote}Do you mean, users could forget to set it in hbase and in hdfs?
{quote}
Yes.I just left the default value of this configuration empty so that I could
use the HDFS configuration directly.
{quote}I don't follow why this hbase-default configuration does not prevail
over the hdfs default? Is it that the hdfs jar with hdfs-default it in comes
before hbase-default in the classpath?
{quote}
This hbase-default configuration does prevail over the hdfs default,and prevail
over the hdfs-site.
{quote}Is it that you observe in operation that the default
dfs.client.read.shortcircuit=true in hbase-default is not happening?
{quote}
I find the default dfs.client.read.shortcircuit=false in hbase-default.So, even
if this value is true in my HDFs-site.xml, I still need to explicitly set it in
hbase-site.xml.
> 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
> -
>
> Key: HBASE-25449
> URL: https://issues.apache.org/jira/browse/HBASE-25449
> Project: HBase
> Issue Type: Improvement
> Components: conf
>Affects Versions: 2.0.1
>Reporter: shenshengli
>Assignee: shenshengli
>Priority: Major
>
> I think this parameter is not suitable for in hbase-default.xml, because in
> this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase
> rely on HDFS configuration, the parameters in hbase service still is
> false.Must be explicitly in hbase-site.xml is set to
> "dfs.client.read.shortcircuit=true" to take effect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25453) Add trace support for scan operation
[ https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257897#comment-17257897 ] Duo Zhang commented on HBASE-25453: --- For ResultScanner, on master branch, it is something like the AsyncPrefetchScanner, so at the foreground, you just get everything from the cache, and all the actual rpc request is done in background thread... And there is no 1v1 mapping on the scanner.next call and the fetching rpc call... > Add trace support for scan operation > > > Key: HBASE-25453 > URL: https://issues.apache.org/jira/browse/HBASE-25453 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…
Apache9 commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-753720995 > How about we add our own annotation to mark things visible for testing into the `hbase-annotations` module? I‘m OK with this approach but what's the difference with guava's VisibleForTesting annotation? We still should not use it in public API? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24751) Display Task completion time and/or processing duration on Web UI
[
https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257823#comment-17257823
]
Hudson commented on HBASE-24751:
Results for branch branch-2
[build #145 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/145/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/145/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/145/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/145/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/145/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Display Task completion time and/or processing duration on Web UI
> -
>
> Key: HBASE-24751
> URL: https://issues.apache.org/jira/browse/HBASE-24751
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Zhuoyue Huang
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image-2020-12-27-13-38-45-744.png,
> image-2020-12-27-13-40-33-490.png
>
>
> Our web UI's list "Tasks", some of which are really important things an
> operator wants to know about. We have columns Start Time, Description, State,
> and Status (which looks more or less identical to Description). We don't have
> Completion Time or Duration columns. I think it would be nice to see at a
> glance how long various Tasks are taking.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on a change in pull request #2801: HBASE-25433 There is no limit on the table name length when creating a table
saintstack commented on a change in pull request #2801:
URL: https://github.com/apache/hbase/pull/2801#discussion_r551034111
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
##
@@ -242,6 +255,9 @@ public static void isLegalNamespaceName(final byte[]
namespaceName,
// A znode named "zookeeper" is disallowed by zookeeper.
throw new IllegalArgumentException("Tables may not be named '" +
DISALLOWED_TABLE_NAME + "'");
}
+if(namespaceName.length > MAX_NAMESPACE_LENGTH){
Review comment:
See background code. It has a space after the 'if' and before the '('.
Ditto on end.
Can you add a test for this nice addition? Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (HBASE-25439) Add BYTE unit in PrettyPrinter.Unit
[ https://issues.apache.org/jira/browse/HBASE-25439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25439. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to master. I tried to backport but conflicts. Thanks for the nice PR [~DeanZ] > Add BYTE unit in PrettyPrinter.Unit > > > Key: HBASE-25439 > URL: https://issues.apache.org/jira/browse/HBASE-25439 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0-alpha-1 >Reporter: Baiqiang Zhao >Assignee: Baiqiang Zhao >Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: image-2020-12-23-16-12-42-210.png > > > Currently only TTL supports PrettyPrinter, and MAX_FILESIZE is not human > readable： > !image-2020-12-23-16-12-42-210.png! > This issue add a new unit 'BYTE' to pretty print value of size, such as > MAX_FILESIZE, MEMSTORE_FLUSHSIZE. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack merged pull request #2812: HBASE-25439 Add BYTE unit in PrettyPrinter.Unit
saintstack merged pull request #2812: URL: https://github.com/apache/hbase/pull/2812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25450) The parameter "hbase.bucketcache.size" is misdescribed
[
https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257820#comment-17257820
]
Michael Stack commented on HBASE-25450:
---
Merged to branch-2 and master.
> The parameter "hbase.bucketcache.size" is misdescribed
> --
>
> Key: HBASE-25450
> URL: https://issues.apache.org/jira/browse/HBASE-25450
> Project: HBase
> Issue Type: Improvement
> Components: conf
>Affects Versions: 2.0.0
>Reporter: shenshengli
>Assignee: shenshengli
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image-2020-12-28-17-53-32-575.png
>
>
> You can see that the description of this configuration is outdated
> {quote}
> hbase.bucketcache.size
>
> A float that EITHER represents a percentage of total heap memory
> size to give to the cache (if < 1.0) OR, it is the total capacity in
> megabytes of BucketCache. Default: 0.0
>
> {quote}
> !image-2020-12-28-17-53-32-575.png!
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-25450) The parameter "hbase.bucketcache.size" is misdescribed
[
https://issues.apache.org/jira/browse/HBASE-25450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-25450.
---
Fix Version/s: 2.5.0
3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Merged. Thanks for the PR [~shenshengli]
> The parameter "hbase.bucketcache.size" is misdescribed
> --
>
> Key: HBASE-25450
> URL: https://issues.apache.org/jira/browse/HBASE-25450
> Project: HBase
> Issue Type: Improvement
> Components: conf
>Affects Versions: 2.0.0
>Reporter: shenshengli
>Assignee: shenshengli
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image-2020-12-28-17-53-32-575.png
>
>
> You can see that the description of this configuration is outdated
> {quote}
> hbase.bucketcache.size
>
> A float that EITHER represents a percentage of total heap memory
> size to give to the cache (if < 1.0) OR, it is the total capacity in
> megabytes of BucketCache. Default: 0.0
>
> {quote}
> !image-2020-12-28-17-53-32-575.png!
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack commented on pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed
saintstack commented on pull request #2821: URL: https://github.com/apache/hbase/pull/2821#issuecomment-753649734 Merged. Test failure unrelated to doc changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack merged pull request #2821: Shenshengli hbase-25450 The parameter "hbase.bucketcache.size" is misdescribed
saintstack merged pull request #2821: URL: https://github.com/apache/hbase/pull/2821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25453) Add trace support for scan operation
[ https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257796#comment-17257796 ] Michael Stack commented on HBASE-25453: --- Can you enforce a limit? Span count? On each #next? > Add trace support for scan operation > > > Key: HBASE-25453 > URL: https://issues.apache.org/jira/browse/HBASE-25453 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] busbey commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…
busbey commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-753636244 How about we add our own annotation to mark things visible for testing into the `hbase-annotations` module? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #2714: HBASE-25333 Add a yetus check to disable usage of VisibleForTesting a…
Apache9 commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-753617483 Any other concerns here @apurtell ? When implementing HBASE-25458, I found that it is a pain that we do not have VisibleForTesting annotation. For example, this method in HRegion `OperationStatus[] batchMutate(BatchOperation batchOp) throws IOException` is declared as package private, the javadoc is very long and after reading it, there is no information about why it is marked as package private, after reference searching, it is referenced in a test. So if we have a VisibleForTesting annotation on this method, I could know that this method is exposed for testing. So I do not think we should reject VisibleForTesting annotation in all classes. With the check proposed in this PR, we have the ability to only avoid the annotation in public and limited private classes, so I think our concerns on messing up the API could be resolved. What do you think? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-25437) Update refguide RC section; point at the dev-tools/create-releases/README.txt rather than repeat its content
[
https://issues.apache.org/jira/browse/HBASE-25437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257756#comment-17257756
]
Hudson commented on HBASE-25437:
Results for branch master
[build #173 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update refguide RC section; point at the dev-tools/create-releases/README.txt
> rather than repeat its content
>
>
> Key: HBASE-25437
> URL: https://issues.apache.org/jira/browse/HBASE-25437
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> Edit of the RC-making section of the refguide.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24751) Display Task completion time and/or processing duration on Web UI
[
https://issues.apache.org/jira/browse/HBASE-24751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257754#comment-17257754
]
Hudson commented on HBASE-24751:
Results for branch master
[build #173 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Display Task completion time and/or processing duration on Web UI
> -
>
> Key: HBASE-24751
> URL: https://issues.apache.org/jira/browse/HBASE-24751
> Project: HBase
> Issue Type: Improvement
> Components: UI
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Zhuoyue Huang
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0
>
> Attachments: image-2020-12-27-13-38-45-744.png,
> image-2020-12-27-13-40-33-490.png
>
>
> Our web UI's list "Tasks", some of which are really important things an
> operator wants to know about. We have columns Start Time, Description, State,
> and Status (which looks more or less identical to Description). We don't have
> Completion Time or Duration columns. I think it would be nice to see at a
> glance how long various Tasks are taking.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25438) Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3
[
https://issues.apache.org/jira/browse/HBASE-25438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257755#comment-17257755
]
Hudson commented on HBASE-25438:
Results for branch master
[build #173 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/173/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Update create-release mvn in Dockerfile; its 3.6.0; make it 3.6.3
> -
>
> Key: HBASE-25438
> URL: https://issues.apache.org/jira/browse/HBASE-25438
> Project: HBase
> Issue Type: Improvement
> Components: create-release
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> Having trouble running RM builds from gcp. Downloads of artifacts are having
> connection reset. Apparently mvn 3.6.1 gets a better http wagon downloader.
> Doesn't seem to help in this particular case but let me get this in anyways.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-25453) Add trace support for scan operation
[ https://issues.apache.org/jira/browse/HBASE-25453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257731#comment-17257731 ] Duo Zhang commented on HBASE-25453: --- Was thinking of add a span in AsyncClientScanner to be used as the parent span for all scan related operations, but if this is a long scan operation, for example, in a map reduce job where we will scan the whole table, the span will have thousands of sub spans, which is not a good idea... Any other ideas? [~zghao] [~stack] Thanks. > Add trace support for scan operation > > > Key: HBASE-25453 > URL: https://issues.apache.org/jira/browse/HBASE-25453 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR
Apache-HBase commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-753584637 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 1m 17s | master passed | | +1 :green_heart: | shadedjars | 6m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 1m 17s | the patch passed | | +1 :green_heart: | javac | 1m 17s | the patch passed | | +1 :green_heart: | shadedjars | 6m 35s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 49s | hbase-procedure in the patch passed. | | +1 :green_heart: | unit | 138m 44s | hbase-server in the patch passed. | | | | 168m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2824 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3c3e065def05 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e21da7597 | | Default Java | AdoptOpenJDK-1.8.0_232-b09 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/testReport/ | | Max. process+thread count | 4599 (vs. ulimit of 3) | | modules | C: hbase-procedure hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #2824: HBASE-25447 remoteProc is suspended due to OOM ERROR
Apache-HBase commented on pull request #2824: URL: https://github.com/apache/hbase/pull/2824#issuecomment-753584020 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 3s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 58s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 43s | hbase-procedure in the patch passed. | | +1 :green_heart: | unit | 130m 42s | hbase-server in the patch passed. | | | | 162m 2s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/2824 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eea1d7f9dab5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2e21da7597 | | Default Java | AdoptOpenJDK-11.0.6+10 | | Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/testReport/ | | Max. process+thread count | 4078 (vs. ulimit of 3) | | modules | C: hbase-procedure hbase-server U: . | | Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2824/4/console | | versions | git=2.17.1 maven=3.6.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
