[GitHub] [hbase] Apache-HBase commented on pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3437: URL: https://github.com/apache/hbase/pull/3437#issuecomment-870461872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3440: HBASE-26039 TestReplicationKillRS is useless after HBASE-23956

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3440: URL: https://github.com/apache/hbase/pull/3440#issuecomment-870560755 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] saintstack commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
saintstack commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660162631 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1047,6 +1074,29 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3435: URL: https://github.com/apache/hbase/pull/3435#issuecomment-870411644 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-870606945 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-29 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-26031. - Resolution: Later After chatting with Stack about donation internals, these hosts are getting

[GitHub] [hbase] Apache-HBase commented on pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3434: URL: https://github.com/apache/hbase/pull/3434#issuecomment-870201695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3433: HBASE-26035 Redundant null check in the compareTo function

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3433: URL: https://github.com/apache/hbase/pull/3433#issuecomment-870121257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] ddupg commented on a change in pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-29 Thread GitBox
ddupg commented on a change in pull request #3430: URL: https://github.com/apache/hbase/pull/3430#discussion_r660247427 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java ## @@ -838,185 +795,116 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-870713341 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] jojochuang merged pull request #3427: HBASE-23817 The message "Please make sure that backup is enabled on the cluster." is shown even when the backup feature is enabled

2021-06-29 Thread GitBox
jojochuang merged pull request #3427: URL: https://github.com/apache/hbase/pull/3427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] saintstack commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
saintstack commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r660744043 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CSRpcServices.java ## @@ -19,11 +19,15 @@ Review comment:

[GitHub] [hbase] Apache-HBase commented on pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3430: URL: https://github.com/apache/hbase/pull/3430#issuecomment-870748067 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] anoopsjohn commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
anoopsjohn commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660539542 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -139,6 +140,31 @@ public static TableDescriptor

[GitHub] [hbase] Apache9 commented on a change in pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-29 Thread GitBox
Apache9 commented on a change in pull request #3430: URL: https://github.com/apache/hbase/pull/3430#discussion_r660286508 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ClaimReplicationQueuesProcedure.java ## @@ -0,0 +1,140 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 ByteBuff released too early and dirty data for checkAndMu…

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-870436602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r660495018 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CSRpcServices.java ## @@ -88,8 +93,18 @@ void start() { public

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 ByteBuff released too early and dirty data for checkAndMu…

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-870643454 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-870708724 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-26036) DBB released too early and dirty data for checkAndMutate

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371519#comment-17371519 ] Michael Stack edited comment on HBASE-26036 at 6/29/21, 4:34 PM: -

[GitHub] [hbase] bharathv commented on pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-29 Thread GitBox
bharathv commented on pull request #3435: URL: https://github.com/apache/hbase/pull/3435#issuecomment-870760205 > Is it possible to provide 2 commits in this PR: I clubbed them into a single commit unfortunately but would've been better if I did them as separate commits for reviews.

[jira] [Commented] (HBASE-25990) Add donated buildbots for jenkins

2021-06-29 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371542#comment-17371542 ] Sean Busbey commented on HBASE-25990: - also filed INFRA-22057 to have them removed from the

[GitHub] [hbase] jojochuang commented on a change in pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-29 Thread GitBox
jojochuang commented on a change in pull request #3434: URL: https://github.com/apache/hbase/pull/3434#discussion_r660361583 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java ## @@ -207,6 +234,17 @@ public static boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3439: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3439: URL: https://github.com/apache/hbase/pull/3439#issuecomment-870506544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3438: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3438: URL: https://github.com/apache/hbase/pull/3438#issuecomment-870622358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 11m

[GitHub] [hbase] Apache-HBase commented on pull request #3440: HBASE-26039 TestReplicationKillRS is useless after HBASE-23956

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3440: URL: https://github.com/apache/hbase/pull/3440#issuecomment-870696058 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
saintstack commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r660745257 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionServerStorage.java ## @@ -0,0 +1,139 @@ +/** + * Licensed

[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for checkAndMutate

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371519#comment-17371519 ] Michael Stack commented on HBASE-26036: --- Excellent. How did you debug and find the skipped close

[GitHub] [hbase] Apache-HBase commented on pull request #3440: HBASE-26039 TestReplicationKillRS is useless after HBASE-23956

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3440: URL: https://github.com/apache/hbase/pull/3440#issuecomment-870714561 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371512#comment-17371512 ] Hudson commented on HBASE-26031: Results for branch HBASE-26031 [build #7 on

[jira] [Commented] (HBASE-25990) Add donated buildbots for jenkins

2021-06-29 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371526#comment-17371526 ] Sean Busbey commented on HBASE-25990: - to remove these hosts from ci-hadoop workload * moved all to

[GitHub] [hbase] saintstack commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

2021-06-29 Thread GitBox
saintstack commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r660167381 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] Apache9 commented on a change in pull request #3434: HBASE-21946 Use ByteBuffer pread instead of byte[] pread in HFileBlock when applicable

2021-06-29 Thread GitBox
Apache9 commented on a change in pull request #3434: URL: https://github.com/apache/hbase/pull/3434#discussion_r660287517 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java ## @@ -207,6 +234,17 @@ public static boolean

[GitHub] [hbase] Apache9 commented on pull request #3421: HBASE-26026 HBase Write may be stuck forever when using CompactingMem…

2021-06-29 Thread GitBox
Apache9 commented on pull request #3421: URL: https://github.com/apache/hbase/pull/3421#issuecomment-870441222 I need sometime to understand the code better... A bit busy recently, sorry... -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-29 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371472#comment-17371472 ] Sean Busbey commented on HBASE-26031: - I am of two minds. On the one hand, checking on how builds

[GitHub] [hbase] virajjasani opened a new pull request #3441: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
virajjasani opened a new pull request #3441: URL: https://github.com/apache/hbase/pull/3441 Signed-off-by: Michael Stack Forward-port PR: #3417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] comnetwork commented on pull request #3421: HBASE-26026 HBase Write may be stuck forever when using CompactingMem…

2021-06-29 Thread GitBox
comnetwork commented on pull request #3421: URL: https://github.com/apache/hbase/pull/3421#issuecomment-870262769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [hbase] Apache-HBase commented on pull request #3439: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3439: URL: https://github.com/apache/hbase/pull/3439#issuecomment-870633281 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25130) [branch-1] Masters in-memory serverHoldings map is not cleared during hbck repair

2021-06-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371488#comment-17371488 ] Hudson commented on HBASE-25130: Results for branch branch-1 [build #140 on

[GitHub] [hbase] saintstack commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

2021-06-29 Thread GitBox
saintstack commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r660746321 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionTask.java ## @@ -0,0 +1,173 @@ +/** + * Licensed to the

[GitHub] [hbase] Apache-HBase commented on pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3417: URL: https://github.com/apache/hbase/pull/3417#issuecomment-870753280 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25990) Add donated buildbots for jenkins

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25990. --- Resolution: Incomplete Closing. I was unable to hook up billing. Might be back but this

[GitHub] [hbase] Apache-HBase commented on pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3430: URL: https://github.com/apache/hbase/pull/3430#issuecomment-870860962 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
virajjasani commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660847616 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -1047,6 +1077,29 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3435: URL: https://github.com/apache/hbase/pull/3435#issuecomment-870857224 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
virajjasani commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660849609 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java ## @@ -139,6 +140,31 @@ public static TableDescriptor

[GitHub] [hbase] Apache-HBase commented on pull request #3441: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3441: URL: https://github.com/apache/hbase/pull/3441#issuecomment-870798309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3417: URL: https://github.com/apache/hbase/pull/3417#issuecomment-870867614 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
virajjasani commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660846981 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -953,9 +956,26 @@ private void

[jira] [Commented] (HBASE-26031) Validate nightly builds run on new ci workers hbase11-hbase15

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371570#comment-17371570 ] Michael Stack commented on HBASE-26031: --- Thanks for the help [~busbey]   > Validate nightly

[GitHub] [hbase] Apache-HBase commented on pull request #3441: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3441: URL: https://github.com/apache/hbase/pull/3441#issuecomment-870863841 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3417: URL: https://github.com/apache/hbase/pull/3417#issuecomment-870875203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache-HBase commented on pull request #3441: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3441: URL: https://github.com/apache/hbase/pull/3441#issuecomment-870910968 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3430: URL: https://github.com/apache/hbase/pull/3430#issuecomment-870849409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv commented on pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-29 Thread GitBox
bharathv commented on pull request #3435: URL: https://github.com/apache/hbase/pull/3435#issuecomment-870935942 Most checkstyle issues are from the original implementation, too many to even fix. Leaving them as-is. Will wait for one final jenkins run before merging. -- This is an

[GitHub] [hbase] apurtell commented on a change in pull request #3438: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
apurtell commented on a change in pull request #3438: URL: https://github.com/apache/hbase/pull/3438#discussion_r660994432 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -253,6 +253,28 @@ // are persisted in meta with a

[GitHub] [hbase] bharathv commented on a change in pull request #3438: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
bharathv commented on a change in pull request #3438: URL: https://github.com/apache/hbase/pull/3438#discussion_r661023484 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -2564,6 +2588,45 @@ public int compare(Pair o1,

[GitHub] [hbase] saintstack commented on a change in pull request #3417: HBASE-25902 Add missing CFs in meta during HBase 1 to 2 Upgrade

2021-06-29 Thread GitBox
saintstack commented on a change in pull request #3417: URL: https://github.com/apache/hbase/pull/3417#discussion_r660901446 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java ## @@ -953,9 +956,26 @@ private void

[GitHub] [hbase] bharathv edited a comment on pull request #3438: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
bharathv edited a comment on pull request #3438: URL: https://github.com/apache/hbase/pull/3438#issuecomment-870979844 Also, the "localhost" part is suspicious, why does AM look for a localhost address? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] bharathv commented on pull request #3438: HBASE-22923 min version of RegionServer to move system table regions

2021-06-29 Thread GitBox
bharathv commented on pull request #3438: URL: https://github.com/apache/hbase/pull/3438#issuecomment-870979844 Also, the "localhost" part is suspcicious, why does AM look for a localhost address? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] Apache9 merged pull request #3430: HBASE-26029 It is not reliable to use nodeDeleted event to track regi…

2021-06-29 Thread GitBox
Apache9 merged pull request #3430: URL: https://github.com/apache/hbase/pull/3430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HBASE-26029) It is not reliable to use nodeDeleted event to track region server's death

2021-06-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26029. --- Fix Version/s: 2.5.0 3.0.0-alpha-1 Hadoop Flags: Reviewed Release Note:

[jira] [Commented] (HBASE-26042) WAL lockup on 'sync failed' org.apache.hbase.thirdparty.io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: Connection reset by peer

2021-06-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371814#comment-17371814 ] Duo Zhang commented on HBASE-26042: --- {quote} Interesting is how more than one thread is able to be

[jira] [Created] (HBASE-26045) Master control the global throughtput of all compaction servers

2021-06-29 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-26045: - Summary: Master control the global throughtput of all compaction servers Key: HBASE-26045 URL: https://issues.apache.org/jira/browse/HBASE-26045 Project: HBase

[jira] [Created] (HBASE-26041) Replace PrintThreadInfoLazyHolder's reflection usage

2021-06-29 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-26041: --- Summary: Replace PrintThreadInfoLazyHolder's reflection usage Key: HBASE-26041 URL: https://issues.apache.org/jira/browse/HBASE-26041 Project: HBase

[jira] [Assigned] (HBASE-26041) Replace PrintThreadInfoLazyHolder's reflection usage

2021-06-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HBASE-26041: --- Assignee: Wei-Chiu Chuang > Replace PrintThreadInfoLazyHolder's reflection usage >

[jira] [Resolved] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25960. --- Fix Version/s: thirdparty-4.0.0 thirdparty-3.5.2 Assignee:

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early and dirty data for checkAndMu…

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-871117922 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Assigned] (HBASE-26040) Replace reflections that are redundant

2021-06-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HBASE-26040: --- Assignee: Wei-Chiu Chuang > Replace reflections that are redundant >

[GitHub] [hbase] Apache-HBase commented on pull request #3442: HBASE-26041 Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3442: URL: https://github.com/apache/hbase/pull/3442#issuecomment-871076440 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3442: HBASE-26041 Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3442: URL: https://github.com/apache/hbase/pull/3442#issuecomment-871078621 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 merged pull request #3440: HBASE-26039 TestReplicationKillRS is useless after HBASE-23956

2021-06-29 Thread GitBox
Apache9 merged pull request #3440: URL: https://github.com/apache/hbase/pull/3440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HBASE-25960) Build includes unshaded netty .so; clashes w/ downstreamers who would use a different version of netty

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371746#comment-17371746 ] Michael Stack commented on HBASE-25960: --- I build a snapshot of hbase-.2.4.4 with thirdparty 3.5.1

[jira] [Resolved] (HBASE-26039) TestReplicationKillRS is useless after HBASE-23956

2021-06-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26039. --- Fix Version/s: 2.4.5 2.3.6 2.5.0

[GitHub] [hbase] Apache9 commented on pull request #3436: HBASE-26036 ByteBuff released too early and dirty data for checkAndMu…

2021-06-29 Thread GitBox
Apache9 commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-871045818 Sorry, I do not fully understand the problem here. Skimmed the code, the change is to use RegionScanner directly instead of the get method. Does this mean the get method is

[jira] [Resolved] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-29 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada resolved HBASE-26021. -- Fix Version/s: 1.7.1 Resolution: Fixed Merged the change, thanks for

[GitHub] [hbase] jojochuang opened a new pull request #3442: HBASE-26041 Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-06-29 Thread GitBox
jojochuang opened a new pull request #3442: URL: https://github.com/apache/hbase/pull/3442 HBASE-13710 copied ReflectionUtils utility class from Hadoop, so we no longer need to use reflection to access the Hadoop's one. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #3437: HBASE-26037 Implement namespace and table level access control for thrift & thrift2

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3437: URL: https://github.com/apache/hbase/pull/3437#issuecomment-871072528 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-26011) Introduce a new API to sync the live region server list more effectively

2021-06-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26011. --- Resolution: Invalid > Introduce a new API to sync the live region server list more effectively >

[jira] [Updated] (HBASE-26042) WAL lockup on 'sync failed' org.apache.hbase.thirdparty.io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: Connection reset by peer

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-26042: -- Summary: WAL lockup on 'sync failed'

[jira] [Created] (HBASE-26042) WAL lockup on 'sync failed'

2021-06-29 Thread Michael Stack (Jira)
Michael Stack created HBASE-26042: - Summary: WAL lockup on 'sync failed' Key: HBASE-26042 URL: https://issues.apache.org/jira/browse/HBASE-26042 Project: HBase Issue Type: Bug Affects

[jira] [Commented] (HBASE-26042) WAL lockup on 'sync failed' org.apache.hbase.thirdparty.io.netty.channel.unix.Errors$NativeIoException: readAddress(..) failed: Connection reset by peer

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371796#comment-17371796 ] Michael Stack commented on HBASE-26042: --- Here is what it looked like when I tried to repro the

[jira] [Created] (HBASE-26043) CompactionServer support compact TTL data

2021-06-29 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-26043: - Summary: CompactionServer support compact TTL data Key: HBASE-26043 URL: https://issues.apache.org/jira/browse/HBASE-26043 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3435: URL: https://github.com/apache/hbase/pull/3435#issuecomment-871030080 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bsglz merged pull request #3420: HBASE-26028 The view as json page shows exception when using TinyLfuB…

2021-06-29 Thread GitBox
bsglz merged pull request #3420: URL: https://github.com/apache/hbase/pull/3420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 closed pull request #3405: HBASE-26011 Introduce a new API to sync the live region server list m…

2021-06-29 Thread GitBox
Apache9 closed pull request #3405: URL: https://github.com/apache/hbase/pull/3405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache-HBase commented on pull request #3442: HBASE-26041 Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-06-29 Thread GitBox
Apache-HBase commented on pull request #3442: URL: https://github.com/apache/hbase/pull/3442#issuecomment-871077131 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] jojochuang opened a new pull request #3443: HBASE-25516 jdk11 reflective access Field.class.getDeclaredField("modifiers") not supported

2021-06-29 Thread GitBox
jojochuang opened a new pull request #3443: URL: https://github.com/apache/hbase/pull/3443 The patch is inspired by powermock: https://github.com/powermock/powermock/pull/1010/files to work around the forbidden access to the modifiers field. -- This is an automated message from the

[jira] [Created] (HBASE-26044) Add CompactionServer Web UI

2021-06-29 Thread Yulin Niu (Jira)
Yulin Niu created HBASE-26044: - Summary: Add CompactionServer Web UI Key: HBASE-26044 URL: https://issues.apache.org/jira/browse/HBASE-26044 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] dingwei-2017 commented on pull request #3423: HBASE-26017 fix pe tool totalRows exceed maximum of int

2021-06-29 Thread GitBox
dingwei-2017 commented on pull request #3423: URL: https://github.com/apache/hbase/pull/3423#issuecomment-871079941 @Apache9 sure. when i run the following command: bin/hbase org.apache.hadoop.hbase.PerformanceEvaluation --size=2048 --nomapred --table=TestTable --presplit=100

[GitHub] [hbase] sunhelly commented on pull request #3436: HBASE-26036 DBB released too early and dirty data for checkAndMu…

2021-06-29 Thread GitBox
sunhelly commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-871113549 > Sorry, I do not fully understand the problem here. > > Skimmed the code, the change is to use RegionScanner directly instead of the get method. Does this mean the get

[jira] [Created] (HBASE-26040) Replace reflections that are redundant

2021-06-29 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HBASE-26040: --- Summary: Replace reflections that are redundant Key: HBASE-26040 URL: https://issues.apache.org/jira/browse/HBASE-26040 Project: HBase Issue Type:

[GitHub] [hbase] bharathv merged pull request #3435: HBASE-26021: Undo the incompatible serialization change in HBASE-7767

2021-06-29 Thread GitBox
bharathv merged pull request #3435: URL: https://github.com/apache/hbase/pull/3435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-29 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-26021: - Labels: compatibility incompatibility serialization upgrade (was: ) > HBase

[jira] [Updated] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-29 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-26021: - Component/s: master > HBase 1.7 to 2.4 upgrade issue due to incompatible

[jira] [Updated] (HBASE-26041) Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

2021-06-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HBASE-26041: Summary: Replace PrintThreadInfoHelper with HBase's own ReflectionUtils.printThreadInfo()

[jira] [Commented] (HBASE-25729) Upgrade to latest hbase-thirdparty

2021-06-29 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371813#comment-17371813 ] Michael Stack commented on HBASE-25729: --- Thanks [~pankajkumar] ... Then lets leave thirdparty

[jira] [Commented] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371125#comment-17371125 ] Viraj Jasani commented on HBASE-26021: -- Thank you [~bharathv]! > HBase 1.7 to 2.4 upgrade issue

[jira] [Assigned] (HBASE-26021) HBase 1.7 to 2.4 upgrade issue due to incompatible deserialization

2021-06-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-26021: Assignee: Bharath Vissapragada > HBase 1.7 to 2.4 upgrade issue due to incompatible

[GitHub] [hbase] comnetwork commented on pull request #3421: HBASE-26026 HBase Write may be stuck forever when using CompactingMem…

2021-06-29 Thread GitBox
comnetwork commented on pull request #3421: URL: https://github.com/apache/hbase/pull/3421#issuecomment-870262769 @Apache9 , please continue help me have a view at your convenience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >