[jira] [Updated] (HBASE-27020) Fix spotless warn for master branch

2022-05-10 Thread Tao Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Li updated HBASE-27020: --- Description: Fix spotless warn for master branch. We can see the spotless warn at

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1122118753 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122238376 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s |

[GitHub] [hbase] frostruan commented on pull request #4335: HBASE-26942 cache region locations when getAllRegionLocations

2022-05-10 Thread GitBox
frostruan commented on PR #4335: URL: https://github.com/apache/hbase/pull/4335#issuecomment-1122686601 Thanks for the reply. @bbeaudreault hi @xiaowangzhixiao would you mind opening a new jira to provide your solution ? If there is any conflict, please just overwrite mine. --

[jira] [Commented] (HBASE-27015) Fix log format for ServerManager

2022-05-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534535#comment-17534535 ] Hudson commented on HBASE-27015: Results for branch master [build #583 on

[jira] [Commented] (HBASE-26999) HStore should try write WAL compaction marker before replacing compacted files in StoreEngine

2022-05-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534536#comment-17534536 ] Hudson commented on HBASE-26999: Results for branch master [build #583 on

[GitHub] [hbase] elliottneilclark commented on pull request #4406: HBASE-27000 Block cache stats (Misses Caching) display error in RS web UI

2022-05-10 Thread GitBox
elliottneilclark commented on PR #4406: URL: https://github.com/apache/hbase/pull/4406#issuecomment-1122764517 Nice catch. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (HBASE-26999) HStore should try write WAL compaction marker before replacing compacted files in StoreEngine

2022-05-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534566#comment-17534566 ] Hudson commented on HBASE-26999: Results for branch branch-2.5 [build #115 on

[GitHub] [hbase] bbeaudreault commented on pull request #4335: HBASE-26942 cache region locations when getAllRegionLocations

2022-05-10 Thread GitBox
bbeaudreault commented on PR #4335: URL: https://github.com/apache/hbase/pull/4335#issuecomment-1122661351 I think it's an honest mistake. I did not see any other jira or PR related to this. Since this one has already been merged to all branches, and the jira resolved, I think the best

[jira] [Commented] (HBASE-26960) Another case for unnecessary replication suspending in RegionReplicationSink

2022-05-10 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534488#comment-17534488 ] Huaxiang Sun commented on HBASE-26960: -- Does this issue exist in branch-2? If so, can we backport

[jira] [Assigned] (HBASE-18678) Add more metrics to the Procedure MBean; currently one metric only for a loci of macro churn

2022-05-10 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-18678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-18678: Assignee: Anwesha Banerjee > Add more metrics to the Procedure MBean; currently one

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122719519 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

[jira] [Commented] (HBASE-26994) MasterFileSystem create directory without permission check

2022-05-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534534#comment-17534534 ] Hudson commented on HBASE-26994: Results for branch master [build #583 on

[jira] [Updated] (HBASE-26999) HStore should try write WAL compaction marker before replacing compacted files in StoreEngine

2022-05-10 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-26999: - Resolution: Fixed Status: Resolved (was: Patch Available) Original

[GitHub] [hbase] Apache-HBase commented on pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4419: URL: https://github.com/apache/hbase/pull/4419#issuecomment-1122660067 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 56s |

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122736170 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 52s |

[jira] [Updated] (HBASE-27022) SFT seems to apparently tracking invalid/malformed store files

2022-05-10 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-27022: - Summary: SFT seems to apparently tracking invalid/malformed store files (was:

[jira] [Created] (HBASE-27022) SFT seems apparently tracking invalid/malformed store files

2022-05-10 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-27022: Summary: SFT seems apparently tracking invalid/malformed store files Key: HBASE-27022 URL: https://issues.apache.org/jira/browse/HBASE-27022 Project:

[GitHub] [hbase] Apache-HBase commented on pull request #4382: HBASE-26925 Create WAL event tracker table to track all the WAL events.

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4382: URL: https://github.com/apache/hbase/pull/4382#issuecomment-1122872126 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 20s |

[jira] [Commented] (HBASE-26953) CallDroppedException message says "server 0.0.0.0 is overloaded"

2022-05-10 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534283#comment-17534283 ] Bryan Beaudreault commented on HBASE-26953: --- [~ayeshasilvia]  sorry for the confusion. Yes,

[GitHub] [hbase] BukrosSzabolcs opened a new pull request, #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled

2022-05-10 Thread GitBox
BukrosSzabolcs opened a new pull request, #4418: URL: https://github.com/apache/hbase/pull/4418 Get rid of renames in the MOB compaction and flush. Also refactor the MOB cleaner to be compatible with FileBased StoreFileTracker -- This is an automated message from the Apache Git

[GitHub] [hbase] tomscut commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
tomscut commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122086831 After `mvn spotless:apply`, I run `mvn spotless:check` locally, and `build success`. But failed here. I feel a little confused. -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4418: URL: https://github.com/apache/hbase/pull/4418#issuecomment-1122400802 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s |

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-118200 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122267825 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1122286080 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1122314449 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

[GitHub] [hbase] Apache-HBase commented on pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4419: URL: https://github.com/apache/hbase/pull/4419#issuecomment-1122654753 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[jira] [Commented] (HBASE-26969) Eliminate MOB renames when SFT is enabled

2022-05-10 Thread Szabolcs Bukros (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534360#comment-17534360 ] Szabolcs Bukros commented on HBASE-26969: - I would like to start by stating that this issue grow

[jira] [Commented] (HBASE-26999) HStore should try write WAL compaction marker before replacing compacted files in StoreEngine

2022-05-10 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534364#comment-17534364 ] Wellington Chevreuil commented on HBASE-26999: -- Hi [~apurtell] , since your reported issue

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122562919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 57s |

[GitHub] [hbase] Apache-HBase commented on pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4419: URL: https://github.com/apache/hbase/pull/4419#issuecomment-1122657764 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s |

[GitHub] [hbase] Apache-HBase commented on pull request #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4418: URL: https://github.com/apache/hbase/pull/4418#issuecomment-1122647466 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 58s |

[jira] [Commented] (HBASE-26999) HStore should try write WAL compaction marker before replacing compacted files in StoreEngine

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534427#comment-17534427 ] Andrew Kyle Purtell commented on HBASE-26999: - Yes, of course. > HStore should try write

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122460217 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122470490 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s |

[GitHub] [hbase] xiaowangzhixiao commented on pull request #4335: HBASE-26942 cache region locations when getAllRegionLocations

2022-05-10 Thread GitBox
xiaowangzhixiao commented on PR #4335: URL: https://github.com/apache/hbase/pull/4335#issuecomment-1122586497 The question you came up 20 days ago is the question I point out in the internal HBase repository of our company 30 days ago, which I had offered a solution at the same time. You

[jira] [Created] (HBASE-27021) StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-27021: Summary: StoreFileInfo should set its initialPath in a consistent way Key: HBASE-27021 URL: https://issues.apache.org/jira/browse/HBASE-27021

[GitHub] [hbase] Apache-HBase commented on pull request #4418: HBASE-26969:Eliminate MOB renames when SFT is enabled

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4418: URL: https://github.com/apache/hbase/pull/4418#issuecomment-1122617643 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

[GitHub] [hbase] frostruan commented on pull request #4335: HBASE-26942 cache region locations when getAllRegionLocations

2022-05-10 Thread GitBox
frostruan commented on PR #4335: URL: https://github.com/apache/hbase/pull/4335#issuecomment-1122656925 I am sorry for that. Didn't know you were also interested in contributing to the community. Anyway, I think finding the problem is more important than the solution. So Let's revert this

[jira] [Updated] (HBASE-27019) Minor compression performance improvements

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27019: Description: TRACE level logging is expensive enough to warrant removal. They

[jira] [Updated] (HBASE-27019) Minor compression performance improvements

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27019: Summary: Minor compression performance improvements (was: Remove TRACE level

[GitHub] [hbase] 2005hithlj closed pull request #4412: HBASE-26977 Fix branch-2 spotless check error

2022-05-10 Thread GitBox
2005hithlj closed pull request #4412: HBASE-26977 Fix branch-2 spotless check error URL: https://github.com/apache/hbase/pull/4412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123137144 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] xiaowangzhixiao commented on pull request #4335: HBASE-26942 cache region locations when getAllRegionLocations

2022-05-10 Thread GitBox
xiaowangzhixiao commented on PR #4335: URL: https://github.com/apache/hbase/pull/4335#issuecomment-1123189429 @frostruan Thanks for your honest. I will try to submit a new issue to add a function with a cacheAll argument on top of your implementation. Thanks for your suggestion.

[jira] [Resolved] (HBASE-27003) Optimize log format for PerformanceEvaluation

2022-05-10 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-27003. -- Fix Version/s: 2.5.0 3.0.0-alpha-3 2.4.13 Hadoop

[GitHub] [hbase] virajjasani commented on pull request #4411: HBASE-27003 Optimize log format for PerformanceEvaluation

2022-05-10 Thread GitBox
virajjasani commented on PR #4411: URL: https://github.com/apache/hbase/pull/4411#issuecomment-1123204339 Thanks for the contribution @tomscut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #4410: HBASE-27002 Config BucketCache as victim handler of LRUCache

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4410: URL: https://github.com/apache/hbase/pull/4410#issuecomment-1123182190 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123182035 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

[GitHub] [hbase] virajjasani merged pull request #4411: HBASE-27003 Optimize log format for PerformanceEvaluation

2022-05-10 Thread GitBox
virajjasani merged PR #4411: URL: https://github.com/apache/hbase/pull/4411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HBASE-27022) SFT seems to apparently tracking invalid/malformed store files

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-27022: Fix Version/s: 2.5.0 3.0.0-alpha-3 > SFT seems to apparently

[jira] [Updated] (HBASE-20430) Improve store file management for non-HDFS filesystems

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-20430: Parent: (was: HBASE-20429) Issue Type: New Feature (was: Sub-task) >

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123087304 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

[GitHub] [hbase] Apache-HBase commented on pull request #4420: HBASE-27019 Minor compression performance improvements

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4420: URL: https://github.com/apache/hbase/pull/4420#issuecomment-1123094567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1123116750 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

[GitHub] [hbase] Apache9 commented on pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
Apache9 commented on PR #4419: URL: https://github.com/apache/hbase/pull/4419#issuecomment-1123126805 I think the key problem here is we use StoreFileInfo as the key of a hash map. In general, within a typical store, we just need to use the storefile's name to decide whether they

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1122988690 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[GitHub] [hbase] joshelser commented on a diff in pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
joshelser commented on code in PR #4414: URL: https://github.com/apache/hbase/pull/4414#discussion_r869794629 ## hbase-common/src/main/java/org/apache/hadoop/hbase/io/util/BlockIOUtils.java: ## @@ -284,6 +311,10 @@ private static boolean preadWithExtraDirectly(ByteBuff buff,

[jira] [Commented] (HBASE-27013) Introduce read all bytes when using pread for prefetch

2022-05-10 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534638#comment-17534638 ] Josh Elser commented on HBASE-27013: {quote}In the case of the input stream read short and when the

[jira] [Comment Edited] (HBASE-27013) Introduce read all bytes when using pread for prefetch

2022-05-10 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534638#comment-17534638 ] Josh Elser edited comment on HBASE-27013 at 5/11/22 1:46 AM: - {quote}In the

[GitHub] [hbase] joshelser commented on a diff in pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
joshelser commented on code in PR #4419: URL: https://github.com/apache/hbase/pull/4419#discussion_r869802361 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -119,18 +119,18 @@ public class StoreFileInfo implements Configurable {

[GitHub] [hbase] Apache-HBase commented on pull request #4420: HBASE-27019 Minor compression performance improvements

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4420: URL: https://github.com/apache/hbase/pull/4420#issuecomment-1123093620 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s |

[GitHub] [hbase] Apache9 commented on pull request #4407: HBASE-26999 HStore should try write WAL compaction marker before repl…

2022-05-10 Thread GitBox
Apache9 commented on PR #4407: URL: https://github.com/apache/hbase/pull/4407#issuecomment-1123114603 Please do not ignore the spotless error before merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hbase] Apache9 commented on a diff in pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
Apache9 commented on code in PR #4419: URL: https://github.com/apache/hbase/pull/4419#discussion_r869823745 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -119,18 +119,18 @@ public class StoreFileInfo implements Configurable {

[GitHub] [hbase] tomscut commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
tomscut commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123164939 Thanks @Apache9 for your review and suggestion. I ran `mvn spotless:apply` and `mvn spotless:check`, build success locally. -- This is an automated message from the Apache Git

[GitHub] [hbase] tomscut commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
tomscut commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123024227 Thanks @shahrs87 for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] apurtell opened a new pull request, #4420: HBASE-27019 Minor compression performance improvements

2022-05-10 Thread GitBox
apurtell opened a new pull request, #4420: URL: https://github.com/apache/hbase/pull/4420 TRACE level logging is expensive enough to warrant removal. They were useful during development but are now just overhead. Also we unnecessarily create new compressor and decompressor instances

[GitHub] [hbase] Apache-HBase commented on pull request #4382: HBASE-26925 Create WAL event tracker table to track all the WAL events.

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4382: URL: https://github.com/apache/hbase/pull/4382#issuecomment-1123077071 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 22s |

[GitHub] [hbase] tomscut commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
tomscut commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123096530 Hi @Apache9 @apurtell I found some spotless warn on another PR at

[GitHub] [hbase] Apache-HBase commented on pull request #4420: HBASE-27019 Minor compression performance improvements

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4420: URL: https://github.com/apache/hbase/pull/4420#issuecomment-1123098880 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s |

[GitHub] [hbase] Apache9 commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache9 commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1123118328 Please just run spotless:apply to fix the spotless errors? Will check the checkstyle configurations later to align them. Thanks. -- This is an automated message from the Apache

[GitHub] [hbase] Apache9 commented on pull request #4419: HBASE-27021 StoreFileInfo should set its initialPath in a consistent way

2022-05-10 Thread GitBox
Apache9 commented on PR #4419: URL: https://github.com/apache/hbase/pull/4419#issuecomment-1123127903 OK, there is a FileSystem instance in the StoreFileInfo, so I think we just need to make a makeQualified to normalize the initial path? -- This is an automated message from the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #4382: HBASE-26925 Create WAL event tracker table to track all the WAL events.

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4382: URL: https://github.com/apache/hbase/pull/4382#issuecomment-1123036372 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 41s |

[jira] [Commented] (HBASE-26905) ReplicationPeerManager#checkPeerExists should throw ReplicationPeerNotFoundException if peer doesn't exists

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534635#comment-17534635 ] Andrew Kyle Purtell commented on HBASE-26905: - Apologies for the long delayed response. This

[jira] [Assigned] (HBASE-20430) Improve store file management for non-HDFS filesystems

2022-05-10 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-20430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-20430: --- Assignee: (was: Mingliang Liu) > Improve store file management for

[jira] [Work started] (HBASE-26953) CallDroppedException message says "server 0.0.0.0 is overloaded"

2022-05-10 Thread Ayesha Mosaddeque (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-26953 started by Ayesha Mosaddeque. - > CallDroppedException message says "server 0.0.0.0 is overloaded" >

[jira] [Commented] (HBASE-26999) HStore should try write WAL compaction marker before replacing compacted files in StoreEngine

2022-05-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534189#comment-17534189 ] Hudson commented on HBASE-26999: Results for branch branch-2 [build #537 on

[jira] [Commented] (HBASE-26994) MasterFileSystem create directory without permission check

2022-05-10 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534188#comment-17534188 ] Hudson commented on HBASE-26994: Results for branch branch-2 [build #537 on

[jira] [Created] (HBASE-27020) Fix spotless warn for master branch

2022-05-10 Thread Tao Li (Jira)
Tao Li created HBASE-27020: -- Summary: Fix spotless warn for master branch Key: HBASE-27020 URL: https://issues.apache.org/jira/browse/HBASE-27020 Project: HBase Issue Type: Bug

[jira] [Commented] (HBASE-26953) CallDroppedException message says "server 0.0.0.0 is overloaded"

2022-05-10 Thread Ayesha Mosaddeque (Jira)
[ https://issues.apache.org/jira/browse/HBASE-26953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534196#comment-17534196 ] Ayesha Mosaddeque commented on HBASE-26953: --- Hi [~bbeaudreault],  Can you please let me know

[GitHub] [hbase] tomscut opened a new pull request, #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
tomscut opened a new pull request, #4417: URL: https://github.com/apache/hbase/pull/4417 JIRA: HBASE-27020. Fix spotless warn for master branch. We can see the spotless warn at

[GitHub] [hbase] Apache-HBase commented on pull request #4411: HBASE-27003 Optimize log format for PerformanceEvaluation

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4411: URL: https://github.com/apache/hbase/pull/4411#issuecomment-1122039734 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s |

[GitHub] [hbase] Apache-HBase commented on pull request #4411: HBASE-27003 Optimize log format for PerformanceEvaluation

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4411: URL: https://github.com/apache/hbase/pull/4411#issuecomment-1122043540 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[GitHub] [hbase] Apache-HBase commented on pull request #4411: HBASE-27003 Optimize log format for PerformanceEvaluation

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4411: URL: https://github.com/apache/hbase/pull/4411#issuecomment-1122043990 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s |

[jira] [Updated] (HBASE-27020) Fix spotless warn for master branch

2022-05-10 Thread Tao Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Li updated HBASE-27020: --- Description: Fix spotless warn for master branch. We can see the spotless warn at

[GitHub] [hbase] Apache-HBase commented on pull request #4417: HBASE-27020 Fix spotless warn for master branch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4417: URL: https://github.com/apache/hbase/pull/4417#issuecomment-1122049555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[GitHub] [hbase] Apache-HBase commented on pull request #4416: HBASE-27018 Add a tool command list_liveservers

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4416: URL: https://github.com/apache/hbase/pull/4416#issuecomment-1122050915 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1122054142 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 46s |

[GitHub] [hbase] Apache-HBase commented on pull request #4416: HBASE-27018 Add a tool command list_liveservers

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4416: URL: https://github.com/apache/hbase/pull/4416#issuecomment-1122058718 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 50s |

[GitHub] [hbase] Apache-HBase commented on pull request #4414: HBASE-27013 Introduce read all bytes when using pread for prefetch

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4414: URL: https://github.com/apache/hbase/pull/4414#issuecomment-1122061206 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

[GitHub] [hbase] Apache-HBase commented on pull request #4416: HBASE-27018 Add a tool command list_liveservers

2022-05-10 Thread GitBox
Apache-HBase commented on PR #4416: URL: https://github.com/apache/hbase/pull/4416#issuecomment-1122061904 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |