Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020327457 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020352997 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539191315 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -165,7 +165,7 @@ protected static byte[]

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020417661 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020425262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539139640 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539147304 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
ndimiduk commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539165446 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -423,6 +424,54 @@ public String toString() { + (isReference() ? "->"

[jira] [Updated] (HBASE-27315) Add timeout to JavaRegexEngine

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-27315: --- Labels: pull-request-available (was: ) > Add timeout to JavaRegexEngine >

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020447314 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 1s |

[jira] [Commented] (HBASE-28420) Aborting Active HMaster is not rejecting remote Procedure Reports

2024-03-26 Thread Aman Poonia (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830899#comment-17830899 ] Aman Poonia commented on HBASE-28420: - Summarising the offfline discussion with [~umesh9414]  Most

[jira] [Commented] (HBASE-28420) Aborting Active HMaster is not rejecting remote Procedure Reports

2024-03-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830902#comment-17830902 ] Duo Zhang commented on HBASE-28420: --- A nasty problem here is that, ServerRemoteProcedure does not has

[jira] [Updated] (HBASE-28412) Restoring incremental backups to mapped table requires existence of original table

2024-03-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28412: --- Labels: pull-request-available (was: ) > Restoring incremental backups to mapped table

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539170198 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -423,6 +424,54 @@ public String toString() { + (isReference() ?

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020355217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5776: URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020368143 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 41s |

Re: [PR] HBASE-27315 Add timeout to JavaRegexEngine [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #4720: URL: https://github.com/apache/hbase/pull/4720#issuecomment-2020434957 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
wchevreuil commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2020453022 The UT flakeyness is actually a bug in the BucketCache.notifyFileCachingCompleted logic. The UT needs to be changed as well to consistently reproduce the issue, so I will address it in

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
ndimiduk commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539260241 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java: ## @@ -165,7 +165,7 @@ protected static byte[] combineTableNameSuffix(byte[]

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5775: URL: https://github.com/apache/hbase/pull/5775#issuecomment-2020514083 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28450 BuckeCache.evictBlocksByHfileName won't work after a cache recovery from file [hbase]

2024-03-26 Thread via GitHub
Apache-HBase commented on PR #5769: URL: https://github.com/apache/hbase/pull/5769#issuecomment-2020592593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 53s |

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault merged PR #5775: URL: https://github.com/apache/hbase/pull/5775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539449576 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28443 Return too slow when scanning a table with non-existing REGION_REPLICA_ID [hbase]

2024-03-26 Thread via GitHub
guluo2016 commented on PR #5767: URL: https://github.com/apache/hbase/pull/5767#issuecomment-2020729857 > I think we should try to check the replica id when we hit the RegionOfflineException, like what we have done in AsyncRpcRetryingCaller. Thanks for your good suggestion， the

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
Apache9 commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539339492 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,262 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28456 HBase Restore restores old data if data for the same timestamp is in different hfiles [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5775: URL: https://github.com/apache/hbase/pull/5775#discussion_r1539365245 ## hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileInputFormat.java: ## @@ -109,6 +114,9 @@ public boolean nextKeyValue() throws IOException,

[jira] [Created] (HBASE-28457) Introduce a version field in file based tracker record

2024-03-26 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28457: - Summary: Introduce a version field in file based tracker record Key: HBASE-28457 URL: https://issues.apache.org/jira/browse/HBASE-28457 Project: HBase Issue Type:

[jira] [Updated] (HBASE-28457) Introduce a version field in file based tracker record

2024-03-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28457: -- Component/s: HFile > Introduce a version field in file based tracker record >

[jira] [Commented] (HBASE-27826) Region split and merge time while offline is O(n) with respect to number of store files

2024-03-26 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-27826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830966#comment-17830966 ] Duo Zhang commented on HBASE-27826: --- Filed HBASE-28457, for adding the version field. > Region split

[jira] [Updated] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault updated HBASE-28456: -- Affects Version/s: (was: 2.6.0) (was: 3.0.0) > HBase

[jira] [Resolved] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Beaudreault resolved HBASE-28456. --- Fix Version/s: 2.6.0 3.0.0-beta-2 Resolution: Fixed >

[jira] [Commented] (HBASE-28456) HBase Restore restores old data if data for the same timestamp is in different hfiles

2024-03-26 Thread Bryan Beaudreault (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830972#comment-17830972 ] Bryan Beaudreault commented on HBASE-28456: --- Pushed to branch-2.6+. Thanks [~rubenvw] for

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539447876 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539470479 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (HBASE-28458) BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached

2024-03-26 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-28458: Summary: BucketCache.notifyFileCachingCompleted may incorrectly consider a file fully cached Key: HBASE-28458 URL:

Re: [PR] HBASE-28412 Select correct target table for incremental backup [hbase]

2024-03-26 Thread via GitHub
rubenvw-ngdata commented on code in PR #5776: URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695 ## hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java: ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

<    1   2