Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2066932836 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5808: URL: https://github.com/apache/hbase/pull/5808#issuecomment-2067095217 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28512 Update error prone to 2.26.1 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5838: URL: https://github.com/apache/hbase/pull/5838#issuecomment-2067325340 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28512 Update error prone to 2.26.1 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5838: URL: https://github.com/apache/hbase/pull/5838#issuecomment-2067060993 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2066961197 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-28512 Update error prone to 2.26.1 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5838: URL: https://github.com/apache/hbase/pull/5838#issuecomment-2067160216 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2067266398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 40s |

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2067299438 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 45s |

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2067316001 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s |

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5808: URL: https://github.com/apache/hbase/pull/5808#issuecomment-2067005824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2067146240 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2067289117 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

[jira] [Commented] (HBASE-28298) HFilePrettyPrinter thrown NoSuchMethodError about MetricRegistry

2024-04-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839127#comment-17839127 ] Hudson commented on HBASE-28298: Results for branch branch-2.5 [build #514 on

[jira] [Commented] (HBASE-28470) Fix Typo in Java Method Comment

2024-04-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839128#comment-17839128 ] Hudson commented on HBASE-28470: Results for branch branch-2.5 [build #514 on

Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2067301860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2067133871 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2067143741 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

[jira] [Commented] (HBASE-28470) Fix Typo in Java Method Comment

2024-04-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839114#comment-17839114 ] Hudson commented on HBASE-28470: Results for branch master [build #1055 on

[jira] [Created] (HBASE-28538) BackupHFileCleaner.loadHFileRefs is very expensive

2024-04-19 Thread Bryan Beaudreault (Jira)
Bryan Beaudreault created HBASE-28538: - Summary: BackupHFileCleaner.loadHFileRefs is very expensive Key: HBASE-28538 URL: https://issues.apache.org/jira/browse/HBASE-28538 Project: HBase

[jira] [Commented] (HBASE-28470) Fix Typo in Java Method Comment

2024-04-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839138#comment-17839138 ] Hudson commented on HBASE-28470: Results for branch branch-3 [build #188 on

Re: [PR] HBASE-28509 ScanResumer.resume would perform unnecessary scan when cl… [hbase]

2024-04-19 Thread via GitHub
comnetwork merged PR #5817: URL: https://github.com/apache/hbase/pull/5817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2067385726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2067347040 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 51s |

[jira] [Resolved] (HBASE-28510) Put up hbase-thirdparty-4.1.7RC0

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28510. --- Resolution: Fixed Will release RC0 as 4.1.7. > Put up hbase-thirdparty-4.1.7RC0 >

[jira] [Updated] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28537: -- Summary: [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release (was: Finish hbase-thirdparty

[jira] [Updated] (HBASE-28510) [hbase-thirdparty] Put up hbase-thirdparty-4.1.7RC0

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28510: -- Summary: [hbase-thirdparty] Put up hbase-thirdparty-4.1.7RC0 (was: Put up hbase-thirdparty-4.1.7RC0)

[jira] [Commented] (HBASE-28534) Authentication failure when running hbase-spark in local mode

2024-04-19 Thread Nikita Pande (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838889#comment-17838889 ] Nikita Pande commented on HBASE-28534: -- [~junegunn] I validated your patch and it works. >>>That

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
kabhishek4 commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2066138757 Hi @Apache9 Can you please review this one and let me know your comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache9 commented on code in PR #5823: URL: https://github.com/apache/hbase/pull/5823#discussion_r1572091361 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java: ## @@ -2187,6 +2187,10 @@ public void onConfigurationChange(Configuration conf) {

[jira] [Commented] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838935#comment-17838935 ] Duo Zhang commented on HBASE-28537: --- # Release the artifacts on repository.apache.org (/) # Move the

[jira] [Updated] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28537: -- Description: # Release the artifacts on repository.apache.org # Move the binaries from dist-dev to

[jira] [Updated] (HBASE-28474) Finish 2.4.18 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28474: -- Component/s: community > Finish 2.4.18 release > - > > Key:

[jira] [Created] (HBASE-28537) Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-28537: - Summary: Finish hbase-thirdparty 4.1.7 release Key: HBASE-28537 URL: https://issues.apache.org/jira/browse/HBASE-28537 Project: HBase Issue Type: Sub-task

[jira] [Comment Edited] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838935#comment-17838935 ] Duo Zhang edited comment on HBASE-28537 at 4/19/24 11:55 AM: - # Release the

[jira] [Updated] (HBASE-28510) [hbase-thirdparty] Put up hbase-thirdparty-4.1.7RC0

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28510: -- Component/s: thirdparty > [hbase-thirdparty] Put up hbase-thirdparty-4.1.7RC0 >

[jira] [Resolved] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28537. --- Resolution: Fixed Done. > [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release >

[jira] [Assigned] (HBASE-28490) [hbase-thirdparty] Release hbase-thirdparty 4.1.7

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28490: - Assignee: Duo Zhang > [hbase-thirdparty] Release hbase-thirdparty 4.1.7 >

[jira] [Resolved] (HBASE-28490) [hbase-thirdparty] Release hbase-thirdparty 4.1.7

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-28490. --- Resolution: Fixed Done. > [hbase-thirdparty] Release hbase-thirdparty 4.1.7 >

[jira] [Updated] (HBASE-28495) [hbase-thirdparty] Fix pre commit build

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28495: -- Component/s: thirdparty > [hbase-thirdparty] Fix pre commit build >

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-19 Thread via GitHub
vinayakphegde commented on code in PR #5808: URL: https://github.com/apache/hbase/pull/5808#discussion_r1572267502 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java: ## @@ -37,10 +37,15 @@ public class HFilePreadReader extends HFileReaderImpl

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572310939 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -218,6 +225,65 @@ public void testColdDataFiles() { } }

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572311160 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -218,6 +225,65 @@ public void testColdDataFiles() { } }

Re: [PR] HBASE-28428 : ConnectionRegistry APIs should have timeout [hbase]

2024-04-19 Thread via GitHub
Apache9 commented on code in PR #5837: URL: https://github.com/apache/hbase/pull/5837#discussion_r1572305997 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java: ## @@ -326,15 +328,17 @@ CompletableFuture getMasterStub() { }

Re: [PR] HBASE-28511 Update hbase-thirdparty to 4.1.7 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5818: URL: https://github.com/apache/hbase/pull/5818#issuecomment-2066545654 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5808: URL: https://github.com/apache/hbase/pull/5808#issuecomment-2066548499 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

[jira] [Updated] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-28537: -- Component/s: thirdparty > [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release >

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
wchevreuil commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572259557 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -999,6 +1019,12 @@ void freeSpace(final String why) { }

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572313499 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -999,6 +1019,12 @@ void freeSpace(final String why) { } }

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572161825 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -980,9 +991,18 @@ void freeSpace(final String why) {

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572161068 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -980,9 +991,18 @@ void freeSpace(final String why) {

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2066366267 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

[jira] [Comment Edited] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838935#comment-17838935 ] Duo Zhang edited comment on HBASE-28537 at 4/19/24 11:48 AM: - # Release the

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
wchevreuil commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572252207 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDataTieringManager.java: ## @@ -218,6 +225,65 @@ public void testColdDataFiles() { } }

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572253832 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -983,6 +994,15 @@ void freeSpace(final String why) { // Scan entire

[jira] [Comment Edited] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838935#comment-17838935 ] Duo Zhang edited comment on HBASE-28537 at 4/19/24 10:18 AM: - # Release the

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
petersomogyi commented on code in PR #5823: URL: https://github.com/apache/hbase/pull/5823#discussion_r1567441400 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java: ## @@ -464,4 +465,18 @@ public String toString() { + shouldEvictOnClose() +

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2066379398 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28466 Integration of time-based priority logic of bucket cache in prefetch functionality of HBase [hbase]

2024-04-19 Thread via GitHub
wchevreuil commented on code in PR #5808: URL: https://github.com/apache/hbase/pull/5808#discussion_r1572232953 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePreadReader.java: ## @@ -37,10 +37,15 @@ public class HFilePreadReader extends HFileReaderImpl {

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
wchevreuil commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572237627 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -983,6 +994,15 @@ void freeSpace(final String why) { // Scan

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572253085 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -999,6 +1019,12 @@ void freeSpace(final String why) { } }

[jira] [Comment Edited] (HBASE-28537) [hbase-thirdparty] Finish hbase-thirdparty 4.1.7 release

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838935#comment-17838935 ] Duo Zhang edited comment on HBASE-28537 at 4/19/24 10:07 AM: - # Release the

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
jhungund commented on code in PR #5829: URL: https://github.com/apache/hbase/pull/5829#discussion_r1572155034 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java: ## @@ -980,9 +991,18 @@ void freeSpace(final String why) {

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
petersomogyi commented on code in PR #5823: URL: https://github.com/apache/hbase/pull/5823#discussion_r1567441400 ## hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java: ## @@ -464,4 +465,18 @@ public String toString() { + shouldEvictOnClose() +

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2066771567 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 25s |

Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2066808565 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2066842002 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

[PR] HBASE-28512 Update error prone to 2.26.1 [hbase]

2024-04-19 Thread via GitHub
Apache9 opened a new pull request, #5838: URL: https://github.com/apache/hbase/pull/5838 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Updated] (HBASE-28512) Update error prone to 2.26.1

2024-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HBASE-28512: --- Labels: pull-request-available (was: ) > Update error prone to 2.26.1 >

Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2066644425 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 11s |

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2066755670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |

[jira] [Assigned] (HBASE-28512) Update error prone to 2.26.1

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-28512: - Assignee: Duo Zhang > Update error prone to 2.26.1 > > >

[jira] [Work started] (HBASE-28512) Update error prone to 2.26.1

2024-04-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-28512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-28512 started by Duo Zhang. - > Update error prone to 2.26.1 > > >

Re: [PR] HBASE-28529 Use ZKClientConfig instead of system properties when sett… [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5835: URL: https://github.com/apache/hbase/pull/5835#issuecomment-2066607259 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28512 Update error prone to 2.26.1 [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5838: URL: https://github.com/apache/hbase/pull/5838#issuecomment-2066725157 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2066884942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 42s |

Re: [PR] HBASE-28517 Make properties dynamically configured [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5823: URL: https://github.com/apache/hbase/pull/5823#issuecomment-2066919527 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 18s |

Re: [PR] HBASE-28468: Integrate the data-tiering logic into cache evictions. [hbase]

2024-04-19 Thread via GitHub
Apache-HBase commented on PR #5829: URL: https://github.com/apache/hbase/pull/5829#issuecomment-2066926092 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 16s |