[jira] [Commented] (HBASE-12606) Sanity check encryption configuration before opening WAL or onlining regions
[ https://issues.apache.org/jira/browse/HBASE-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237094#comment-14237094 ] Hudson commented on HBASE-12606: SUCCESS: Integrated in HBase-1.0 #549 (See [https://builds.apache.org/job/HBase-1.0/549/]) HBASE-12606 Sanity check encryption configuration before opening WAL or onlining regions (apurtell: rev 7b7b39805620aa74839cf42f711f6e9fe92f873f) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/EncryptionTest.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEncryptionTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java Sanity check encryption configuration before opening WAL or onlining regions Key: HBASE-12606 URL: https://issues.apache.org/jira/browse/HBASE-12606 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12606-0.98.patch, HBASE-12606-branch-1.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12606) Sanity check encryption configuration before opening WAL or onlining regions
[ https://issues.apache.org/jira/browse/HBASE-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237096#comment-14237096 ] Hudson commented on HBASE-12606: FAILURE: Integrated in HBase-0.98 #724 (See [https://builds.apache.org/job/HBase-0.98/724/]) HBASE-12606 Sanity check encryption configuration before opening WAL or onlining regions (apurtell: rev 6d24a3b67ae2bb71095fd1ada84d458c97ac3473) * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEncryptionTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/EncryptionTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java Sanity check encryption configuration before opening WAL or onlining regions Key: HBASE-12606 URL: https://issues.apache.org/jira/browse/HBASE-12606 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12606-0.98.patch, HBASE-12606-branch-1.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12606) Sanity check encryption configuration before opening WAL or onlining regions
[ https://issues.apache.org/jira/browse/HBASE-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237097#comment-14237097 ] Hudson commented on HBASE-12606: SUCCESS: Integrated in HBase-TRUNK #5882 (See [https://builds.apache.org/job/HBase-TRUNK/5882/]) HBASE-12606 Sanity check encryption configuration before opening WAL or onlining regions (apurtell: rev bb15fd5fe0a89e647cd9cefa0ceae342578f0833) * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEncryptionTest.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/EncryptionTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java Sanity check encryption configuration before opening WAL or onlining regions Key: HBASE-12606 URL: https://issues.apache.org/jira/browse/HBASE-12606 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12606-0.98.patch, HBASE-12606-branch-1.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-11903) Directly invoking split merge of replica regions should be disallowed
[ https://issues.apache.org/jira/browse/HBASE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-11903: Attachment: 11903-2-for-master-4.txt Fixes the unit test.. Directly invoking split merge of replica regions should be disallowed --- Key: HBASE-11903 URL: https://issues.apache.org/jira/browse/HBASE-11903 Project: HBase Issue Type: Sub-task Reporter: Devaraj Das Assignee: Devaraj Das Attachments: 11903-1-for-98.txt, 11903-1.txt, 11903-2-for-master-2.txt, 11903-2-for-master-4.txt, 11903-2-for-master.txt When the primary is split/merged the secondaries follow suit. We should disallow calling split/merge on the secondaries directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12606) Sanity check encryption configuration before opening WAL or onlining regions
[ https://issues.apache.org/jira/browse/HBASE-12606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237103#comment-14237103 ] Hudson commented on HBASE-12606: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #691 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/691/]) HBASE-12606 Sanity check encryption configuration before opening WAL or onlining regions (apurtell: rev 6d24a3b67ae2bb71095fd1ada84d458c97ac3473) * hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogReader.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureProtobufLogWriter.java * hbase-it/src/test/java/org/apache/hadoop/hbase/IntegrationTestIngestWithEncryption.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEncryptionTest.java * hbase-server/src/main/java/org/apache/hadoop/hbase/util/EncryptionTest.java Sanity check encryption configuration before opening WAL or onlining regions Key: HBASE-12606 URL: https://issues.apache.org/jira/browse/HBASE-12606 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12606-0.98.patch, HBASE-12606-branch-1.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch, HBASE-12606.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-11903) Directly invoking split merge of replica regions should be disallowed
[
https://issues.apache.org/jira/browse/HBASE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237112#comment-14237112
]
Hadoop QA commented on HBASE-11903:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685601/11903-2-for-master-4.txt
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685601
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11980//console
This message is automatically generated.
Directly invoking split merge of replica regions should be disallowed
---
Key: HBASE-11903
URL: https://issues.apache.org/jira/browse/HBASE-11903
Project: HBase
Issue Type: Sub-task
Reporter: Devaraj Das
Assignee: Devaraj Das
Attachments: 11903-1-for-98.txt, 11903-1.txt,
11903-2-for-master-2.txt, 11903-2-for-master-4.txt, 11903-2-for-master.txt
When the primary is split/merged the secondaries follow suit. We should
disallow calling split/merge on the secondaries directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir
[
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Saxena updated HBASE-12645:
-
Assignee: Varun Saxena
Status: Patch Available (was: Open)
HBaseTestingUtility is using ${$HOME} for rootDir
-
Key: HBASE-12645
URL: https://issues.apache.org/jira/browse/HBASE-12645
Project: HBase
Issue Type: Test
Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12645.patch
I noticed this while running tests on branch-1
{noformat}
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec
FAILURE! - in
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits Time
elapsed: 0.009 sec ERROR!
java.io.FileNotFoundException: Destination exists and is not a directory:
/homes/hortonnd/hbase
at
org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
at
org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
at
org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
at
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
{noformat}
Either the testing utility has a regression or there's a config regression in
this test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir
[
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.patch
HBaseTestingUtility is using ${$HOME} for rootDir
-
Key: HBASE-12645
URL: https://issues.apache.org/jira/browse/HBASE-12645
Project: HBase
Issue Type: Test
Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Priority: Critical
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12645.patch
I noticed this while running tests on branch-1
{noformat}
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec
FAILURE! - in
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits Time
elapsed: 0.009 sec ERROR!
java.io.FileNotFoundException: Destination exists and is not a directory:
/homes/hortonnd/hbase
at
org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
at
org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
at
org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
at
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
{noformat}
Either the testing utility has a regression or there's a config regression in
this test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11903) Directly invoking split merge of replica regions should be disallowed
[ https://issues.apache.org/jira/browse/HBASE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237147#comment-14237147 ] Ted Yu commented on HBASE-11903: +1 on patch v4 Directly invoking split merge of replica regions should be disallowed --- Key: HBASE-11903 URL: https://issues.apache.org/jira/browse/HBASE-11903 Project: HBase Issue Type: Sub-task Reporter: Devaraj Das Assignee: Devaraj Das Attachments: 11903-1-for-98.txt, 11903-1.txt, 11903-2-for-master-2.txt, 11903-2-for-master-4.txt, 11903-2-for-master.txt When the primary is split/merged the secondaries follow suit. We should disallow calling split/merge on the secondaries directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12644) Visibility Labels: issue with storing super users in labels table
[ https://issues.apache.org/jira/browse/HBASE-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237161#comment-14237161 ] Anoop Sam John commented on HBASE-12644: bq.But the concept of super users should probably means 'automatic' privilege without explicit 'set' or 'clear'. Since we use a hbase-site.xml property to determine super users at startup time, presence or absence in the property will determine the privilege without a need of any explicit action. +1 for doing this way. I was thinking the 1st patch going this way around and saw it was not. That is why asked abt 2nd issue in the desc. Visibility Labels: issue with storing super users in labels table - Key: HBASE-12644 URL: https://issues.apache.org/jira/browse/HBASE-12644 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.98.8, 0.99.2 Reporter: Jerry He Assignee: Jerry He Fix For: 1.0.0, 0.98.9 Attachments: HBASE-12644-master.patch Super users have all the permissions for ACL and Visibility labels. They are defined in hbase-site.xml. Currently in VisibilityController, we persist super user with their system permission in hbase:labels. This makes change in super user difficult. There are two issues: In the current DefaultVisibilityLabelServiceImpl.addSystemLabel, we only add super user when we initially create the 'system' label. No additional update after that even if super user changed. See code for details. Additionally, there is no mechanism to remove any super user from the labels table. We probably should not persist super users in the labels table. They are in hbase-site.xml and can just stay in labelsCache and used from labelsCache after retrieval by Visibility Controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir
[
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237164#comment-14237164
]
Hadoop QA commented on HBASE-12645:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685606/HBASE-12645.patch
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685606
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//console
This message is automatically generated.
HBaseTestingUtility is using ${$HOME} for rootDir
-
Key: HBASE-12645
URL: https://issues.apache.org/jira/browse/HBASE-12645
Project: HBase
Issue Type: Test
Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12645.patch
I noticed this while running tests on branch-1
{noformat}
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec
FAILURE! - in
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits Time
elapsed: 0.009 sec ERROR!
java.io.FileNotFoundException: Destination exists and is not a directory:
/homes/hortonnd/hbase
at
org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
at
org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
at
org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
at
org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
{noformat}
Either the testing utility has a regression or there's a config
[jira] [Updated] (HBASE-12510) Remove the dependency on HRegionInfo from 0.89-fb
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Menghani updated HBASE-12510: Summary: Remove the dependency on HRegionInfo from 0.89-fb (was: Remove the dependency on 0.89-fb branch for HydraBase) Remove the dependency on HRegionInfo from 0.89-fb - Key: HBASE-12510 URL: https://issues.apache.org/jira/browse/HBASE-12510 Project: HBase Issue Type: Sub-task Components: wal Reporter: Rishit Shroff Assignee: Gaurav Menghani Priority: Minor Attachments: 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch The current RAFT protocol implementation depends on few classes (8) which were present in 0.89-fb branch. The latest HBase branch may have other equivalents of it and we need to cleanup/refactor to code to use them. Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (HBASE-12510) Remove the dependency on HRegionInfo from 0.89-fb
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Menghani resolved HBASE-12510. - Resolution: Fixed Remove the dependency on HRegionInfo from 0.89-fb - Key: HBASE-12510 URL: https://issues.apache.org/jira/browse/HBASE-12510 Project: HBase Issue Type: Sub-task Components: wal Reporter: Rishit Shroff Assignee: Gaurav Menghani Priority: Minor Attachments: 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch The current RAFT protocol implementation depends on few classes (8) which were present in 0.89-fb branch. The latest HBase branch may have other equivalents of it and we need to cleanup/refactor to code to use them. Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12510) Remove the dependency on 0.89-fb branch for HydraBase
[ https://issues.apache.org/jira/browse/HBASE-12510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237166#comment-14237166 ] Gaurav Menghani commented on HBASE-12510: - Ok, so I am going to rename this JIRA to indicate that this was only for HRegionInfo. We will file separate JIRAs for the remaining work. Remove the dependency on 0.89-fb branch for HydraBase - Key: HBASE-12510 URL: https://issues.apache.org/jira/browse/HBASE-12510 Project: HBase Issue Type: Sub-task Components: wal Reporter: Rishit Shroff Assignee: Gaurav Menghani Priority: Minor Attachments: 0001-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch, 0002-HBASE-12510-Make-hbase-consensus-independent-of-HReg.patch The current RAFT protocol implementation depends on few classes (8) which were present in 0.89-fb branch. The latest HBase branch may have other equivalents of it and we need to cleanup/refactor to code to use them. Filing this JIRA to track this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12511) namespace permissions - add support from table creation privilege in a namespace 'C'
[ https://issues.apache.org/jira/browse/HBASE-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237177#comment-14237177 ] Ashish Singhi commented on HBASE-12511: --- bq. which requirePermission API did you suggest? This one requireGlobalPermission(String request, Action perm, String namespace) If required you can change the log message here, AFAIK it is used only for NS check. namespace permissions - add support from table creation privilege in a namespace 'C' Key: HBASE-12511 URL: https://issues.apache.org/jira/browse/HBASE-12511 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Huaiyu Zhu Attachments: HBASE-12511.patch, HBASE-12511.patch As discussed in namespace permission Jira. A user granted a 'C' on a namespace enables a user to create tables within the namespace. 'C' on a namespace does not enable a user to create/drop the namespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangduo updated HBASE-10201: - Attachment: (was: HBASE-10201_14.patch) Port 'Make flush decisions per column family' to trunk -- Key: HBASE-10201 URL: https://issues.apache.org/jira/browse/HBASE-10201 Project: HBase Issue Type: Improvement Components: wal Reporter: Ted Yu Assignee: zhangduo Priority: Critical Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch, HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch, HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch, HBASE-10201_13.patch, HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch, HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch, HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png, memstore.png Currently the flush decision is made using the aggregate size of all column families. When large and small column families co-exist, this causes many small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangduo updated HBASE-10201: - Attachment: HBASE-10201_14.patch Seems previous hadoop QA run was exited abnormally. Rebase and retry. Port 'Make flush decisions per column family' to trunk -- Key: HBASE-10201 URL: https://issues.apache.org/jira/browse/HBASE-10201 Project: HBase Issue Type: Improvement Components: wal Reporter: Ted Yu Assignee: zhangduo Priority: Critical Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch, HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch, HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch, HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch, HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch, HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png, memstore.png Currently the flush decision is made using the aggregate size of all column families. When large and small column families co-exist, this causes many small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12511) namespace permissions - add support from table creation privilege in a namespace 'C'
[ https://issues.apache.org/jira/browse/HBASE-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237186#comment-14237186 ] Ashish Singhi commented on HBASE-12511: --- [~huaiyu] One doubt here. A user with 'C' permission on a NS can create a table in it. Can't the same user delete the table from there ? namespace permissions - add support from table creation privilege in a namespace 'C' Key: HBASE-12511 URL: https://issues.apache.org/jira/browse/HBASE-12511 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Huaiyu Zhu Attachments: HBASE-12511.patch, HBASE-12511.patch As discussed in namespace permission Jira. A user granted a 'C' on a namespace enables a user to create tables within the namespace. 'C' on a namespace does not enable a user to create/drop the namespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangduo updated HBASE-10201: - Attachment: HBASE-10201_15.patch fix a javadoc issue. Port 'Make flush decisions per column family' to trunk -- Key: HBASE-10201 URL: https://issues.apache.org/jira/browse/HBASE-10201 Project: HBase Issue Type: Improvement Components: wal Reporter: Ted Yu Assignee: zhangduo Priority: Critical Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch, HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch, HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch, HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch, HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch, HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch, HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png, memstore.png Currently the flush decision is made using the aggregate size of all column families. When large and small column families co-exist, this causes many small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
Ted Yu created HBASE-12651: -- Summary: Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1 Key: HBASE-12651 URL: https://issues.apache.org/jira/browse/HBASE-12651 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Fix For: 1.0.0 HBASE-12559 added support for online configuration update of load balancer. This JIRA backports this to branch-1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
[ https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12651: --- Attachment: 12651-1.0.txt Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1 Key: HBASE-12651 URL: https://issues.apache.org/jira/browse/HBASE-12651 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Fix For: 1.0.0 Attachments: 12651-1.0.txt HBASE-12559 added support for online configuration update of load balancer. This JIRA backports this to branch-1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
[ https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12651: --- Status: Patch Available (was: Open) TestUpdateConfiguration passed locally. Running test suite now. Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1 Key: HBASE-12651 URL: https://issues.apache.org/jira/browse/HBASE-12651 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Fix For: 1.0.0 Attachments: 12651-1.0.txt HBASE-12559 added support for online configuration update of load balancer. This JIRA backports this to branch-1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
[
https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237207#comment-14237207
]
Hadoop QA commented on HBASE-12651:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685617/12651-1.0.txt
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685617
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11984//console
This message is automatically generated.
Backport HBASE-12559 'Provide LoadBalancer with online configuration
capability' to branch-1
Key: HBASE-12651
URL: https://issues.apache.org/jira/browse/HBASE-12651
Project: HBase
Issue Type: Improvement
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 1.0.0
Attachments: 12651-1.0.txt
HBASE-12559 added support for online configuration update of load balancer.
This JIRA backports this to branch-1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[
https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237213#comment-14237213
]
Hadoop QA commented on HBASE-10201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685611/HBASE-10201_14.patch
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685611
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 32 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11982//console
This message is automatically generated.
Port 'Make flush decisions per column family' to trunk
--
Key: HBASE-10201
URL: https://issues.apache.org/jira/browse/HBASE-10201
Project: HBase
Issue Type: Improvement
Components: wal
Reporter: Ted Yu
Assignee: zhangduo
Priority: Critical
Fix For: 1.0.0, 2.0.0, 0.98.9
Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch,
HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch,
HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch,
HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch,
HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch,
HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch,
HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch,
HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png,
memstore.png
Currently the flush decision is made using the aggregate size of all column
families. When large and small column families co-exist, this causes many
small flushes of the smaller CF. We need to make per-CF flush decisions.
--
This message was sent by Atlassian JIRA
[jira] [Commented] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[
https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237214#comment-14237214
]
Hadoop QA commented on HBASE-10201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685612/HBASE-10201_15.patch
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685612
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 32 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 6
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11983//console
This message is automatically generated.
Port 'Make flush decisions per column family' to trunk
--
Key: HBASE-10201
URL: https://issues.apache.org/jira/browse/HBASE-10201
Project: HBase
Issue Type: Improvement
Components: wal
Reporter: Ted Yu
Assignee: zhangduo
Priority: Critical
Fix For: 1.0.0, 2.0.0, 0.98.9
Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch,
HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch,
HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch,
HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch,
HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch,
HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch,
HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch,
HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png,
memstore.png
Currently the flush decision is made using the aggregate size of all column
families. When large and small column families co-exist, this causes many
small flushes of the smaller CF. We need to make per-CF flush decisions.
--
This message was sent by Atlassian JIRA
[jira] [Updated] (HBASE-12485) Maintain SeqId monotonically increasing
[ https://issues.apache.org/jira/browse/HBASE-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12485: -- Attachment: HBASE-12485-v2.patch Retry. I like what Elliott said. Maintain SeqId monotonically increasing --- Key: HBASE-12485 URL: https://issues.apache.org/jira/browse/HBASE-12485 Project: HBase Issue Type: Sub-task Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12485-v2.patch, HBASE-12485-v2.patch, HBASE-12485.patch We added FLUSH, REGION CLOSE events into WAL, for each those events the region SeqId is bumped. The issue comes from region close operation. Because when opening a region, we use flushed SeqId from store files while after store flush during region close we still write COMMIT_FLUSH, REGION_CLOSE events etc which respectively bump up SeqId. Therefore, the region opening SeqId is lower than it should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12485) Maintain SeqId monotonically increasing
[
https://issues.apache.org/jira/browse/HBASE-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237219#comment-14237219
]
stack commented on HBASE-12485:
---
[~jeffreyz] Thanks for making the change (and for doing old and new style
handling). +1
We only parse with the new style file name ending in below
698 Long tmpSeqId = Long.parseLong(fileName.substring(0,
fileName.length()
688 - SEQUENCE_ID_FILE_SUFFIX.length())); 699
- SEQUENCE_ID_FILE_SUFFIX_LENGTH));
That is because if old style, its stale... not pertinent to this recovery?
Previous, we just added 1 always when we did this:
long nextSeqid = maxSeqId;
But you don't do it when you add the safety margin any more because why add 1
when we just added 10? -- that is the reasoning?
Next time
688 if (isSequenceIdFile(p)) {
689 return true;
690 }
691 return false;
should be just 'return isSequenceIdFile(p);'
Nice patch and fix [~jeffreyz] -- +1
Maintain SeqId monotonically increasing
---
Key: HBASE-12485
URL: https://issues.apache.org/jira/browse/HBASE-12485
Project: HBase
Issue Type: Sub-task
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12485-v2.patch, HBASE-12485-v2.patch,
HBASE-12485.patch
We added FLUSH, REGION CLOSE events into WAL, for each those events the
region SeqId is bumped.
The issue comes from region close operation. Because when opening a region,
we use flushed SeqId from store files while after store flush during region
close we still write COMMIT_FLUSH, REGION_CLOSE events etc which respectively
bump up SeqId. Therefore, the region opening SeqId is lower than it should
be.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reassigned HBASE-12650: -- Assignee: Ted Yu (was: Gaurav Menghani) Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Ted Yu Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12650) Move ServerName to hbase-common module
[ https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12650: --- Attachment: 12650-v4.txt Move ServerName to hbase-common module -- Key: HBASE-12650 URL: https://issues.apache.org/jira/browse/HBASE-12650 Project: HBase Issue Type: Improvement Affects Versions: 2.0.0 Reporter: Gaurav Menghani Assignee: Ted Yu Priority: Blocker Fix For: 2.0.0 Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt The idea is to move ServerName to hbase-common, so that other modules like hbase-consensus which (would) depend on ServerName, but can't depend on hbase-client, since hbase-client would depend on them. Moreover, it looks logical that ServerName not be a part of the client module. It is a shared class between multiple modules, so it should be in hbase-common. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
[ https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12651: --- Attachment: (was: 12651-1.0.txt) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1 Key: HBASE-12651 URL: https://issues.apache.org/jira/browse/HBASE-12651 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Fix For: 1.0.0 HBASE-12559 added support for online configuration update of load balancer. This JIRA backports this to branch-1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
[ https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-12651: --- Attachment: 12651-1.0.txt Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1 Key: HBASE-12651 URL: https://issues.apache.org/jira/browse/HBASE-12651 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ted Yu Fix For: 1.0.0 Attachments: 12651-1.0.txt HBASE-12559 added support for online configuration update of load balancer. This JIRA backports this to branch-1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12651) Backport HBASE-12559 'Provide LoadBalancer with online configuration capability' to branch-1
[
https://issues.apache.org/jira/browse/HBASE-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237234#comment-14237234
]
Hadoop QA commented on HBASE-12651:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685625/12651-1.0.txt
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685625
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11987//console
This message is automatically generated.
Backport HBASE-12559 'Provide LoadBalancer with online configuration
capability' to branch-1
Key: HBASE-12651
URL: https://issues.apache.org/jira/browse/HBASE-12651
Project: HBase
Issue Type: Improvement
Reporter: Ted Yu
Assignee: Ted Yu
Fix For: 1.0.0
Attachments: 12651-1.0.txt
HBASE-12559 added support for online configuration update of load balancer.
This JIRA backports this to branch-1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12485) Maintain SeqId monotonically increasing
[
https://issues.apache.org/jira/browse/HBASE-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237253#comment-14237253
]
Hadoop QA commented on HBASE-12485:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685620/HBASE-12485-v2.patch
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685620
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 15 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2091 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11985//console
This message is automatically generated.
Maintain SeqId monotonically increasing
---
Key: HBASE-12485
URL: https://issues.apache.org/jira/browse/HBASE-12485
Project: HBase
Issue Type: Sub-task
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12485-v2.patch, HBASE-12485-v2.patch,
HBASE-12485.patch
We added FLUSH, REGION CLOSE events into WAL, for each those events the
region SeqId is bumped.
The issue comes from region close operation. Because when opening a region,
we use flushed SeqId from store files while after store flush during region
close we still write COMMIT_FLUSH, REGION_CLOSE events etc which respectively
bump up SeqId. Therefore, the region opening SeqId is lower than it should
be.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12548) Improve debuggability of IntegrationTestTimeBoundedRequestsWithRegionReplicas
[ https://issues.apache.org/jira/browse/HBASE-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-12548: Resolution: Fixed Status: Resolved (was: Patch Available) Improve debuggability of IntegrationTestTimeBoundedRequestsWithRegionReplicas - Key: HBASE-12548 URL: https://issues.apache.org/jira/browse/HBASE-12548 Project: HBase Issue Type: Bug Reporter: Devaraj Das Assignee: Devaraj Das Priority: Minor Fix For: 2.0.0 Attachments: 12548-0.98.zip, 12548-1.txt -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-11903) Directly invoking split merge of replica regions should be disallowed
[ https://issues.apache.org/jira/browse/HBASE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj Das updated HBASE-11903: Resolution: Fixed Fix Version/s: 2.0.0 Status: Resolved (was: Patch Available) Committed. Directly invoking split merge of replica regions should be disallowed --- Key: HBASE-11903 URL: https://issues.apache.org/jira/browse/HBASE-11903 Project: HBase Issue Type: Sub-task Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 2.0.0 Attachments: 11903-1-for-98.txt, 11903-1.txt, 11903-2-for-master-2.txt, 11903-2-for-master-4.txt, 11903-2-for-master.txt When the primary is split/merged the secondaries follow suit. We should disallow calling split/merge on the secondaries directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12650) Move ServerName to hbase-common module
[
https://issues.apache.org/jira/browse/HBASE-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237260#comment-14237260
]
Hadoop QA commented on HBASE-12650:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685623/12650-v4.txt
against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
ATTACHMENT ID: 12685623
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2092 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * codelt;hostname '{@link #SERVERNAME_SEPARATOR}' lt;port '{@link
#SERVERNAME_SEPARATOR}' lt;startcode/code.
+@edu.umd.cs.findbugs.annotations.SuppressWarnings(value=DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11986//console
This message is automatically generated.
Move ServerName to hbase-common module
--
Key: HBASE-12650
URL: https://issues.apache.org/jira/browse/HBASE-12650
Project: HBase
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Gaurav Menghani
Assignee: Ted Yu
Priority: Blocker
Fix For: 2.0.0
Attachments: 12650-v1.txt, 12650-v2.txt, 12650-v3.txt, 12650-v4.txt
The idea is to move ServerName to hbase-common, so that other modules like
hbase-consensus which (would) depend on ServerName, but can't depend on
hbase-client, since hbase-client would depend on them. Moreover, it looks
logical that ServerName not be a part of the client module. It is a shared
class between multiple modules, so it should be in hbase-common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-11903) Directly invoking split merge of replica regions should be disallowed
[ https://issues.apache.org/jira/browse/HBASE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237278#comment-14237278 ] Hudson commented on HBASE-11903: SUCCESS: Integrated in HBase-TRUNK #5883 (See [https://builds.apache.org/job/HBase-TRUNK/5883/]) HBASE-11903. Directly invoking split merge of replica regions should be disallowed (ddas: rev 9fd6db3703d3e7ec50b32b1e96c65ed9f2b1456d) * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java Directly invoking split merge of replica regions should be disallowed --- Key: HBASE-11903 URL: https://issues.apache.org/jira/browse/HBASE-11903 Project: HBase Issue Type: Sub-task Reporter: Devaraj Das Assignee: Devaraj Das Fix For: 2.0.0 Attachments: 11903-1-for-98.txt, 11903-1.txt, 11903-2-for-master-2.txt, 11903-2-for-master-4.txt, 11903-2-for-master.txt When the primary is split/merged the secondaries follow suit. We should disallow calling split/merge on the secondaries directly. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12575) Sanity check table coprocessor classes are loadable
[ https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12575: --- Summary: Sanity check table coprocessor classes are loadable (was: Sanity check coprocessor classes and other classes from configuration are loadable) Sanity check table coprocessor classes are loadable --- Key: HBASE-12575 URL: https://issues.apache.org/jira/browse/HBASE-12575 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch We load coprocessors and other classes from configuration. In case of a typo in the class name (or deployment problem) a create table / alter table with wrong class name brings down the whole cluster. Master already does sanity check for compression and region split policy classes introduced in HBASE-10591. We should extend that to check some other common cases as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12575) Sanity check table coprocessor classes are loadable
[ https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12575: --- Status: Patch Available (was: Open) Sanity check table coprocessor classes are loadable --- Key: HBASE-12575 URL: https://issues.apache.org/jira/browse/HBASE-12575 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch We load coprocessors and other classes from configuration. In case of a typo in the class name (or deployment problem) a create table / alter table with wrong class name brings down the whole cluster. Master already does sanity check for compression and region split policy classes introduced in HBASE-10591. We should extend that to check some other common cases as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12575) Sanity check table coprocessor classes are loadable
[ https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12575: --- Attachment: HBASE-12575.patch Ok, this is ready. Let's just check table coprocessor class availability and call it a day as this is the reported problem. We could do just a bit more and check if the store engine class is loadable, but that isn't very useful. A store engine implementation determines what flusher, compactor, or compaction policy class to use. The choices are unknowable without an instance. We _could_ create a test StoreEngine instance in the master, but we'd need to create a real test Store first - components like the compactor want to look at a Store object for configuration in their constructor - and so I think that gets out of hand. Sanity check table coprocessor classes are loadable --- Key: HBASE-12575 URL: https://issues.apache.org/jira/browse/HBASE-12575 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch We load coprocessors and other classes from configuration. In case of a typo in the class name (or deployment problem) a create table / alter table with wrong class name brings down the whole cluster. Master already does sanity check for compression and region split policy classes introduced in HBASE-10591. We should extend that to check some other common cases as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12028) Abort the RegionServer, when one of it's handler threads die
[ https://issues.apache.org/jira/browse/HBASE-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alicia Ying Shu updated HBASE-12028: Attachment: Hbase-12028.patch Abort the RegionServer, when one of it's handler threads die Key: HBASE-12028 URL: https://issues.apache.org/jira/browse/HBASE-12028 Project: HBase Issue Type: Bug Components: regionserver Reporter: Sudarshan Kadambi Assignee: Alicia Ying Shu Attachments: Hbase-12028.patch Over in HBase-11813, a user identified an issue where in all the RPC handler threads would exit with StackOverflow errors due to an unchecked recursion-terminating condition. Our clusters demonstrated the same trace. While the patch posted for HBASE-11813 got our clusters to be merry again, the breakdown surfaced some larger issues. When the RegionServer had all it's RPC handler threads dead, it continued to have regions assigned it. Clearly, it wouldn't be able to serve reads and writes on those regions. A second issue was that when a user tried to disable or drop a table, the master would try to communicate to the regionserver for region unassignment. Since the same handler threads seem to be used for master - RS communication as well, the master ended up hanging on the RS indefinitely. Eventually, the master stopped responding to all table meta-operations. A handler thread should never exit, and if it does, it seems like the more prudent thing to do would be for the RS to abort. This way, at least recovery can be undertaken and the regions could be reassigned elsewhere. I also think that the master-RS communication should get its own exclusive threadpool, but I'll wait until this issue has been sufficiently discussed before opening an issue ticket for that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12028) Abort the RegionServer, when one of it's handler threads die
[ https://issues.apache.org/jira/browse/HBASE-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alicia Ying Shu updated HBASE-12028: Attachment: (was: Hbase-12028.patch) Abort the RegionServer, when one of it's handler threads die Key: HBASE-12028 URL: https://issues.apache.org/jira/browse/HBASE-12028 Project: HBase Issue Type: Bug Components: regionserver Reporter: Sudarshan Kadambi Assignee: Alicia Ying Shu Over in HBase-11813, a user identified an issue where in all the RPC handler threads would exit with StackOverflow errors due to an unchecked recursion-terminating condition. Our clusters demonstrated the same trace. While the patch posted for HBASE-11813 got our clusters to be merry again, the breakdown surfaced some larger issues. When the RegionServer had all it's RPC handler threads dead, it continued to have regions assigned it. Clearly, it wouldn't be able to serve reads and writes on those regions. A second issue was that when a user tried to disable or drop a table, the master would try to communicate to the regionserver for region unassignment. Since the same handler threads seem to be used for master - RS communication as well, the master ended up hanging on the RS indefinitely. Eventually, the master stopped responding to all table meta-operations. A handler thread should never exit, and if it does, it seems like the more prudent thing to do would be for the RS to abort. This way, at least recovery can be undertaken and the regions could be reassigned elsewhere. I also think that the master-RS communication should get its own exclusive threadpool, but I'll wait until this issue has been sufficiently discussed before opening an issue ticket for that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12028) Abort the RegionServer, when one of it's handler threads die
[ https://issues.apache.org/jira/browse/HBASE-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237313#comment-14237313 ] Alicia Ying Shu commented on HBASE-12028: - Modified the patch a little bit. Set the default for whether to abort region server when handlers die to be false. User can configure it to be true. Keep existing behavior not closing client connection when Rpc handler thread dies since client can close the connection when needed. Otherwise, we may run into race condition that both client and server want to close the connection at the same time. Abort the RegionServer, when one of it's handler threads die Key: HBASE-12028 URL: https://issues.apache.org/jira/browse/HBASE-12028 Project: HBase Issue Type: Bug Components: regionserver Reporter: Sudarshan Kadambi Assignee: Alicia Ying Shu Attachments: Hbase-12028.patch Over in HBase-11813, a user identified an issue where in all the RPC handler threads would exit with StackOverflow errors due to an unchecked recursion-terminating condition. Our clusters demonstrated the same trace. While the patch posted for HBASE-11813 got our clusters to be merry again, the breakdown surfaced some larger issues. When the RegionServer had all it's RPC handler threads dead, it continued to have regions assigned it. Clearly, it wouldn't be able to serve reads and writes on those regions. A second issue was that when a user tried to disable or drop a table, the master would try to communicate to the regionserver for region unassignment. Since the same handler threads seem to be used for master - RS communication as well, the master ended up hanging on the RS indefinitely. Eventually, the master stopped responding to all table meta-operations. A handler thread should never exit, and if it does, it seems like the more prudent thing to do would be for the RS to abort. This way, at least recovery can be undertaken and the regions could be reassigned elsewhere. I also think that the master-RS communication should get its own exclusive threadpool, but I'll wait until this issue has been sufficiently discussed before opening an issue ticket for that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangduo updated HBASE-10201: - Attachment: HBASE-10201_16.patch trivial change to remove javadoc warnings Port 'Make flush decisions per column family' to trunk -- Key: HBASE-10201 URL: https://issues.apache.org/jira/browse/HBASE-10201 Project: HBase Issue Type: Improvement Components: wal Reporter: Ted Yu Assignee: zhangduo Priority: Critical Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch, HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch, HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch, HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch, HBASE-10201_16.patch, HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch, HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch, HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png, memstore.png Currently the flush decision is made using the aggregate size of all column families. When large and small column families co-exist, this causes many small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12575) Sanity check table coprocessor classes are loadable
[
https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237333#comment-14237333
]
Hadoop QA commented on HBASE-12575:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685638/HBASE-12575.patch
against master branch at commit 9fd6db3703d3e7ec50b32b1e96c65ed9f2b1456d.
ATTACHMENT ID: 12685638
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2091 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+public TableCoprocessorAttribute(Path path, String className, int
priority, Configuration conf) {
+ LOG.error(Malformed table coprocessor specification: key= +
key + , spec: + spec);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at org.apache.hadoop.hbase.client.TestShell.testRunShellTests(TestShell.java:81)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11988//console
This message is automatically generated.
Sanity check table coprocessor classes are loadable
---
Key: HBASE-12575
URL: https://issues.apache.org/jira/browse/HBASE-12575
Project: HBase
Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Andrew Purtell
Fix For: 1.0.0, 2.0.0, 0.98.9
Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch,
HBASE-12575.patch
We load coprocessors and other classes from configuration. In case of a typo
in the class name (or deployment problem) a create table / alter table with
wrong class name brings down the whole cluster.
Master already does sanity check for compression and region split policy
classes introduced in HBASE-10591.
[jira] [Updated] (HBASE-12575) Sanity check table coprocessor classes are loadable
[ https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12575: --- Status: Open (was: Patch Available) Sanity check table coprocessor classes are loadable --- Key: HBASE-12575 URL: https://issues.apache.org/jira/browse/HBASE-12575 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch We load coprocessors and other classes from configuration. In case of a typo in the class name (or deployment problem) a create table / alter table with wrong class name brings down the whole cluster. Master already does sanity check for compression and region split policy classes introduced in HBASE-10591. We should extend that to check some other common cases as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12575) Sanity check table coprocessor classes are loadable
[
https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237335#comment-14237335
]
Andrew Purtell commented on HBASE-12575:
One of the shell tests fails a sanity check:
{noformat}
java.io.FileNotFoundException: File does not exist: hdfs:/foo.jar
at
org.apache.hadoop.hbase.master.HMaster.sanityCheckTableDescriptor(HMaster.java:1232)
{noformat}
So the test will need updating.
Sanity check table coprocessor classes are loadable
---
Key: HBASE-12575
URL: https://issues.apache.org/jira/browse/HBASE-12575
Project: HBase
Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Andrew Purtell
Fix For: 1.0.0, 2.0.0, 0.98.9
Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch,
HBASE-12575.patch
We load coprocessors and other classes from configuration. In case of a typo
in the class name (or deployment problem) a create table / alter table with
wrong class name brings down the whole cluster.
Master already does sanity check for compression and region split policy
classes introduced in HBASE-10591. We should extend that to check some other
common cases as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (HBASE-12652) Allow unmanaged connections in MetaTableAccessor
Solomon Duskis created HBASE-12652: -- Summary: Allow unmanaged connections in MetaTableAccessor Key: HBASE-12652 URL: https://issues.apache.org/jira/browse/HBASE-12652 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 2.0.0 Reporter: Solomon Duskis Assignee: Solomon Duskis Passing in an unmanaged connnection to MetaTableAccessor causes an exception. MetaTableAccessor should be able to use both unmanaged and managed connections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12644) Visibility Labels: issue with storing super users in labels table
[ https://issues.apache.org/jira/browse/HBASE-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237350#comment-14237350 ] Jerry He commented on HBASE-12644: -- Hi, [~anoop.hbase] Thanks. I will provide an updated patch. Visibility Labels: issue with storing super users in labels table - Key: HBASE-12644 URL: https://issues.apache.org/jira/browse/HBASE-12644 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.98.8, 0.99.2 Reporter: Jerry He Assignee: Jerry He Fix For: 1.0.0, 0.98.9 Attachments: HBASE-12644-master.patch Super users have all the permissions for ACL and Visibility labels. They are defined in hbase-site.xml. Currently in VisibilityController, we persist super user with their system permission in hbase:labels. This makes change in super user difficult. There are two issues: In the current DefaultVisibilityLabelServiceImpl.addSystemLabel, we only add super user when we initially create the 'system' label. No additional update after that even if super user changed. See code for details. Additionally, there is no mechanism to remove any super user from the labels table. We probably should not persist super users in the labels table. They are in hbase-site.xml and can just stay in labelsCache and used from labelsCache after retrieval by Visibility Controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12028) Abort the RegionServer, when one of it's handler threads die
[
https://issues.apache.org/jira/browse/HBASE-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237353#comment-14237353
]
Hadoop QA commented on HBASE-12028:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685642/Hbase-12028.patch
against master branch at commit 9fd6db3703d3e7ec50b32b1e96c65ed9f2b1456d.
ATTACHMENT ID: 12685642
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2103 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static final String REGION_SERVER_HANDLERFAILURE_PERCENT =
hbase.regionserver.handlerfailure.percent;
+ final float readShare, final int maxQueueLength, final Configuration
conf, final Abortable abortable) {
+this(name, handlerCount, numQueues, readShare, maxQueueLength, 0, conf,
abortable, LinkedBlockingQueue.class);
+ final float readShare, final float scanShare, final int maxQueueLength,
final Configuration conf, final Abortable abortable) {
+ final float readShare, final int maxQueueLength, final Configuration
conf, final Abortable abortable,
+ final float readShare, final float scanShare, final int maxQueueLength,
final Configuration conf, final Abortable abortable,
+ String message = RpcServer handler thread encountered an
exception, close client connection;
+callExecutor = new RWQueueRpcExecutor(RW.default, handlerCount,
numCallQueues, callqReadShare, callqScanShare, maxQueueLength, conf, abortable);
+callExecutor = new BalancedQueueRpcExecutor(B.default, handlerCount,
numCallQueues, conf, abortable,
+ this(conf, handlerCount, priorityHandlerCount,
replicationHandlerCount, priority, null, highPriorityLevel);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMaster
org.apache.hadoop.hbase.master.TestTableLockManager
org.apache.hadoop.hbase.master.TestMasterShutdown
org.apache.hadoop.hbase.client.TestReplicaWithCluster
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.client.TestHCM
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.master.handler.TestCreateTableHandler
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.client.TestScannersFromClientSide
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
{color:red}-1 core zombie tests{color}. There are 16 zombie test(s):
at
org.apache.hadoop.hbase.client.TestMetaScanner.testMetaScanner(TestMetaScanner.java:74)
at
org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat.testInitTableSnapshotMapperJobConfig(TestTableSnapshotInputFormat.java:157)
at
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat.testMRIncrementalLoad(TestHFileOutputFormat.java:360)
at
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignDisabledRegion(TestAssignmentManagerOnCluster.java:931)
at
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testMoveRegion(TestAssignmentManagerOnCluster.java:353)
at
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testReportRegionStateTransition(TestAssignmentManagerOnCluster.java:1121)
at
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignOfflinedRegionBySSH(TestAssignmentManagerOnCluster.java:946)
at
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testAssignWhileClosing(TestAssignmentManagerOnCluster.java:437)
at
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster.testOfflineRegion(TestAssignmentManagerOnCluster.java:303)
at
[jira] [Commented] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[
https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237370#comment-14237370
]
Hadoop QA commented on HBASE-10201:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685645/HBASE-10201_16.patch
against master branch at commit 9fd6db3703d3e7ec50b32b1e96c65ed9f2b1456d.
ATTACHMENT ID: 12685645
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 32 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ private static final Class? extends FlushPolicy
DEFAULT_FLUSH_POLICY_CLASS = FlushLargeStoresPolicy.class;
+new WALKey(info.getEncodedNameAsBytes(), htd.getTableName(),
System.currentTimeMillis()),
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11990//console
This message is automatically generated.
Port 'Make flush decisions per column family' to trunk
--
Key: HBASE-10201
URL: https://issues.apache.org/jira/browse/HBASE-10201
Project: HBase
Issue Type: Improvement
Components: wal
Reporter: Ted Yu
Assignee: zhangduo
Priority: Critical
Fix For: 1.0.0, 2.0.0, 0.98.9
Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch,
HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch,
HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch,
HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch,
HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch,
HBASE-10201_16.patch, HBASE-10201_2.patch, HBASE-10201_3.patch,
HBASE-10201_4.patch, HBASE-10201_5.patch, HBASE-10201_6.patch,
HBASE-10201_7.patch, HBASE-10201_8.patch, HBASE-10201_9.patch,
compactions.png, count.png, io.png, memstore.png
Currently the flush decision is made using the aggregate size of all column
families. When large and small column families co-exist, this causes many
small
[jira] [Updated] (HBASE-12652) Allow unmanaged connections in MetaTableAccessor
[ https://issues.apache.org/jira/browse/HBASE-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12652: --- Status: Patch Available (was: Open) Allow unmanaged connections in MetaTableAccessor Key: HBASE-12652 URL: https://issues.apache.org/jira/browse/HBASE-12652 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 2.0.0 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12652.patch Passing in an unmanaged connnection to MetaTableAccessor causes an exception. MetaTableAccessor should be able to use both unmanaged and managed connections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12652) Allow unmanaged connections in MetaTableAccessor
[ https://issues.apache.org/jira/browse/HBASE-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Solomon Duskis updated HBASE-12652: --- Attachment: HBASE-12652.patch Allow unmanaged connections in MetaTableAccessor Key: HBASE-12652 URL: https://issues.apache.org/jira/browse/HBASE-12652 Project: HBase Issue Type: Bug Affects Versions: 1.0.0, 2.0.0 Reporter: Solomon Duskis Assignee: Solomon Duskis Attachments: HBASE-12652.patch Passing in an unmanaged connnection to MetaTableAccessor causes an exception. MetaTableAccessor should be able to use both unmanaged and managed connections. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12644) Visibility Labels: issue with storing super users in labels table
[ https://issues.apache.org/jira/browse/HBASE-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237426#comment-14237426 ] ramkrishna.s.vasudevan commented on HBASE-12644: [~jerryhe] Thanks for the patch. So for the automatic way of updation to happen can we now change this addition of super users to the start() of VC as part of RegionServerObserver itself then? I think that would make sense rather than calling every time during region open intialization? But even if it is part of region we could still have a contains check before adding, but what would make more sense? Visibility Labels: issue with storing super users in labels table - Key: HBASE-12644 URL: https://issues.apache.org/jira/browse/HBASE-12644 Project: HBase Issue Type: Bug Components: security Affects Versions: 0.98.8, 0.99.2 Reporter: Jerry He Assignee: Jerry He Fix For: 1.0.0, 0.98.9 Attachments: HBASE-12644-master.patch Super users have all the permissions for ACL and Visibility labels. They are defined in hbase-site.xml. Currently in VisibilityController, we persist super user with their system permission in hbase:labels. This makes change in super user difficult. There are two issues: In the current DefaultVisibilityLabelServiceImpl.addSystemLabel, we only add super user when we initially create the 'system' label. No additional update after that even if super user changed. See code for details. Additionally, there is no mechanism to remove any super user from the labels table. We probably should not persist super users in the labels table. They are in hbase-site.xml and can just stay in labelsCache and used from labelsCache after retrieval by Visibility Controller. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12652) Allow unmanaged connections in MetaTableAccessor
[
https://issues.apache.org/jira/browse/HBASE-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237439#comment-14237439
]
Hadoop QA commented on HBASE-12652:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685654/HBASE-12652.patch
against master branch at commit 9fd6db3703d3e7ec50b32b1e96c65ed9f2b1456d.
ATTACHMENT ID: 12685654
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2091 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.master.TestMasterNoCluster.testNotPullingDeadRegionServerFromZK(TestMasterNoCluster.java:306)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11991//console
This message is automatically generated.
Allow unmanaged connections in MetaTableAccessor
Key: HBASE-12652
URL: https://issues.apache.org/jira/browse/HBASE-12652
Project: HBase
Issue Type: Bug
Affects Versions: 1.0.0, 2.0.0
Reporter: Solomon Duskis
Assignee: Solomon Duskis
Attachments: HBASE-12652.patch
Passing in an unmanaged connnection to MetaTableAccessor causes an exception.
MetaTableAccessor should be able to use both unmanaged and managed
connections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HBASE-12647) Truncate table should work with C as well
[ https://issues.apache.org/jira/browse/HBASE-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-12647: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to 0.98+. Thanks for review. Truncate table should work with C as well - Key: HBASE-12647 URL: https://issues.apache.org/jira/browse/HBASE-12647 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: hbase-12647_v1.patch, hbase-12647_v2.patch https://hbase.apache.org/book/appendix_acl_matrix.html indicates that truncateTable works with A or C (similar to createTable, deleteTable,modifyTable), but it is actually only A. Seems logical to require A or C. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12575) Sanity check table coprocessor classes are loadable
[ https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12575: --- Attachment: HBASE-12575.patch Fix two cases in admin_test.rb Sanity check table coprocessor classes are loadable --- Key: HBASE-12575 URL: https://issues.apache.org/jira/browse/HBASE-12575 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch We load coprocessors and other classes from configuration. In case of a typo in the class name (or deployment problem) a create table / alter table with wrong class name brings down the whole cluster. Master already does sanity check for compression and region split policy classes introduced in HBASE-10591. We should extend that to check some other common cases as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-12575) Sanity check table coprocessor classes are loadable
[ https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12575: --- Status: Patch Available (was: Open) Sanity check table coprocessor classes are loadable --- Key: HBASE-12575 URL: https://issues.apache.org/jira/browse/HBASE-12575 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Andrew Purtell Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch We load coprocessors and other classes from configuration. In case of a typo in the class name (or deployment problem) a create table / alter table with wrong class name brings down the whole cluster. Master already does sanity check for compression and region split policy classes introduced in HBASE-10591. We should extend that to check some other common cases as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12511) namespace permissions - add support from table creation privilege in a namespace 'C'
[ https://issues.apache.org/jira/browse/HBASE-12511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237451#comment-14237451 ] Enis Soztutar commented on HBASE-12511: --- Agreed with deleteTable, and possibly others (modify table) etc which should be fixed together with createTable. One problem with the patch is that, it relies on exception catching for the regular code path, which is quite costly. The exception should not be raised in the global check. If at the end of global + NS check it fails, only then the exception should be thrown. namespace permissions - add support from table creation privilege in a namespace 'C' Key: HBASE-12511 URL: https://issues.apache.org/jira/browse/HBASE-12511 Project: HBase Issue Type: Sub-task Reporter: Francis Liu Assignee: Huaiyu Zhu Attachments: HBASE-12511.patch, HBASE-12511.patch As discussed in namespace permission Jira. A user granted a 'C' on a namespace enables a user to create tables within the namespace. 'C' on a namespace does not enable a user to create/drop the namespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12485) Maintain SeqId monotonically increasing
[
https://issues.apache.org/jira/browse/HBASE-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237468#comment-14237468
]
Jeffrey Zhong commented on HBASE-12485:
---
Thanks [~saint@gmail.com] for the comments!
{quote}
should be just 'return isSequenceIdFile(p);'
{quote}
That's a good point. I'll change the part when committing the patch.
{quote}
That is because if old style, its stale... not pertinent to this recovery?
{quote}
Yes.
{quote}
that is the reasoning?
{quote}
Yes.
Maintain SeqId monotonically increasing
---
Key: HBASE-12485
URL: https://issues.apache.org/jira/browse/HBASE-12485
Project: HBase
Issue Type: Sub-task
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
Fix For: 1.0.0, 2.0.0
Attachments: HBASE-12485-v2.patch, HBASE-12485-v2.patch,
HBASE-12485.patch
We added FLUSH, REGION CLOSE events into WAL, for each those events the
region SeqId is bumped.
The issue comes from region close operation. Because when opening a region,
we use flushed SeqId from store files while after store flush during region
close we still write COMMIT_FLUSH, REGION_CLOSE events etc which respectively
bump up SeqId. Therefore, the region opening SeqId is lower than it should
be.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12485) Maintain SeqId monotonically increasing
[ https://issues.apache.org/jira/browse/HBASE-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237487#comment-14237487 ] stack commented on HBASE-12485: --- +1 Maintain SeqId monotonically increasing --- Key: HBASE-12485 URL: https://issues.apache.org/jira/browse/HBASE-12485 Project: HBase Issue Type: Sub-task Reporter: Jeffrey Zhong Assignee: Jeffrey Zhong Fix For: 1.0.0, 2.0.0 Attachments: HBASE-12485-v2.patch, HBASE-12485-v2.patch, HBASE-12485.patch We added FLUSH, REGION CLOSE events into WAL, for each those events the region SeqId is bumped. The issue comes from region close operation. Because when opening a region, we use flushed SeqId from store files while after store flush during region close we still write COMMIT_FLUSH, REGION_CLOSE events etc which respectively bump up SeqId. Therefore, the region opening SeqId is lower than it should be. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12647) Truncate table should work with C as well
[ https://issues.apache.org/jira/browse/HBASE-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237499#comment-14237499 ] Hudson commented on HBASE-12647: SUCCESS: Integrated in HBase-TRUNK #5884 (See [https://builds.apache.org/job/HBase-TRUNK/5884/]) HBASE-12647 Truncate table should work with C as well (enis: rev 87e44140040ab9a864e592c13f164dcde6ed6c03) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Truncate table should work with C as well - Key: HBASE-12647 URL: https://issues.apache.org/jira/browse/HBASE-12647 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: hbase-12647_v1.patch, hbase-12647_v2.patch https://hbase.apache.org/book/appendix_acl_matrix.html indicates that truncateTable works with A or C (similar to createTable, deleteTable,modifyTable), but it is actually only A. Seems logical to require A or C. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-10201) Port 'Make flush decisions per column family' to trunk
[ https://issues.apache.org/jira/browse/HBASE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangduo updated HBASE-10201: - Attachment: HBASE-10201_17.patch line length Port 'Make flush decisions per column family' to trunk -- Key: HBASE-10201 URL: https://issues.apache.org/jira/browse/HBASE-10201 Project: HBase Issue Type: Improvement Components: wal Reporter: Ted Yu Assignee: zhangduo Priority: Critical Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: 3149-trunk-v1.txt, HBASE-10201-0.98.patch, HBASE-10201-0.98_1.patch, HBASE-10201-0.98_2.patch, HBASE-10201-0.99.patch, HBASE-10201.patch, HBASE-10201_1.patch, HBASE-10201_10.patch, HBASE-10201_11.patch, HBASE-10201_12.patch, HBASE-10201_13.patch, HBASE-10201_13.patch, HBASE-10201_14.patch, HBASE-10201_15.patch, HBASE-10201_16.patch, HBASE-10201_17.patch, HBASE-10201_2.patch, HBASE-10201_3.patch, HBASE-10201_4.patch, HBASE-10201_5.patch, HBASE-10201_6.patch, HBASE-10201_7.patch, HBASE-10201_8.patch, HBASE-10201_9.patch, compactions.png, count.png, io.png, memstore.png Currently the flush decision is made using the aggregate size of all column families. When large and small column families co-exist, this causes many small flushes of the smaller CF. We need to make per-CF flush decisions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-8275) Tool to test binary compatibility
[
https://issues.apache.org/jira/browse/HBASE-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237502#comment-14237502
]
Dima Spivak commented on HBASE-8275:
I think we have a pretty decent solution to address this that we're using at
Cloudera, and which I'd love to push upstream. The workflow looks like this:
- Store pre-created Docker images in a common registry containing the various
releases of HBase servers we want to test against. This would just be an
extension of the functionality we already have under /dev-support/hbase_docker.
(Also, the gents at Apache Infra are working on the registry aspect at
INFRA-8441.)
- Also store images of HBase clients (again, for each version we want to test).
These images contain basic dependencies (e.g. Java, Maven) and some client code
to exercise as much of the API as possible. At Cloudera, what I've found has
worked very well for this is TestFromClientSide, so I extend this into another
class (TestJavaClient) and override the unit test-specific aspects of it in the
derived class (e.g. prevent starting a minicluster, and skipping a few tests
that touch HBase internals). {{mvn compile}} is used to pre-compile the source
code for the original version and then the whole deal is committed into a
Docker image. The client image also has POM files for any other version of
HBase for which we want to test binary compatibility.
- With the images precreated, running a test of compatibility is done by
standing up an HBase cluster (again, using the Docker images), and then using
the HBase client image and a simple script to test either wire or binary
compatibility. For wire compatibility, we use {{mvn verify}}, which takes the
already-compiled source code alongside the original version of JARs and points
it at the HBase server. For binary compatibility, the script handles pointing
Maven at the pom.xml referencing the JARs I care to validate against, and then
a simple {{mvn failsafe:integration-test failsafe:verify}} doesn't recompile
the code, but puts the new binaries on the classpath and tries running against
the server.
Tool to test binary compatibility
-
Key: HBASE-8275
URL: https://issues.apache.org/jira/browse/HBASE-8275
Project: HBase
Issue Type: New Feature
Reporter: Jean-Daniel Cryans
Stack and I were discussing of ways to make binary compatibility easier to
test than doing it completely by hand.
One idea would be to have a tool that uses reflection to generate code that
calls all the public methods from a list of classes. You would then compile
this code against the current version you are on, then try it out with
different HBase jars without recompiling.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-8275) Tool to test binary compatibility
[ https://issues.apache.org/jira/browse/HBASE-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237504#comment-14237504 ] Dima Spivak commented on HBASE-8275: Oh, and one other thing I forgot to mention: the other advantage of using something like TestFromClientSide is that we also get semantic compatibility testing for free, which we wouldn't get if we just validated that compilation and running with different binaries works. Tool to test binary compatibility - Key: HBASE-8275 URL: https://issues.apache.org/jira/browse/HBASE-8275 Project: HBase Issue Type: New Feature Reporter: Jean-Daniel Cryans Stack and I were discussing of ways to make binary compatibility easier to test than doing it completely by hand. One idea would be to have a tool that uses reflection to generate code that calls all the public methods from a list of classes. You would then compile this code against the current version you are on, then try it out with different HBase jars without recompiling. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12630) Provide capability for dropping malfunctioning ConfigurationObserver automatically
[ https://issues.apache.org/jira/browse/HBASE-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237521#comment-14237521 ] Ashish Singhi commented on HBASE-12630: --- Hi [~tedyu] bq. We can handle such ConfigurationObserver by sidelining it after configurable number of exceptions seen from the ConfigurationObserver. By sidelining you mean deregister it from ConfigurationObserver ? Provide capability for dropping malfunctioning ConfigurationObserver automatically -- Key: HBASE-12630 URL: https://issues.apache.org/jira/browse/HBASE-12630 Project: HBase Issue Type: Improvement Reporter: Ted Yu Chatting with Manukranth, online config update feature should handle the case where certain ConfigurationObserver(s) constantly produce exception when notified of config update. We can handle such ConfigurationObserver by sidelining it after configurable number of exceptions seen from the ConfigurationObserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (HBASE-12630) Provide capability for dropping malfunctioning ConfigurationObserver automatically
[ https://issues.apache.org/jira/browse/HBASE-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Singhi reassigned HBASE-12630: - Assignee: Ashish Singhi Provide capability for dropping malfunctioning ConfigurationObserver automatically -- Key: HBASE-12630 URL: https://issues.apache.org/jira/browse/HBASE-12630 Project: HBase Issue Type: Improvement Reporter: Ted Yu Assignee: Ashish Singhi Chatting with Manukranth, online config update feature should handle the case where certain ConfigurationObserver(s) constantly produce exception when notified of config update. We can handle such ConfigurationObserver by sidelining it after configurable number of exceptions seen from the ConfigurationObserver. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12556) Create a golden file for testing client API source/binary compatibility
[ https://issues.apache.org/jira/browse/HBASE-12556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237522#comment-14237522 ] Dima Spivak commented on HBASE-12556: - I detailed how we might want to actually run binary compatibility tests in another JIRA (HBASE-8275), but some of the discussion might belong here, too. I think if we want to really ensure compatibility across versions, we should have functional tests for every public API in one place that can feed into a framework for doing all the necessary compilation and binary-versions-on-the-classpath permutations we care about. Having them as actual tests (and not just making sure things compile and seem to work) means we'd also be looking out for semantic compatibility as described in the [Apache Hadoop compatibility guide|http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html]. Create a golden file for testing client API source/binary compatibility --- Key: HBASE-12556 URL: https://issues.apache.org/jira/browse/HBASE-12556 Project: HBase Issue Type: Sub-task Components: Client Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 1.0.0, 2.0.0 Attachments: hbase-12556-wip.patch [~lhofhansl] had a suggestion (in some other jira I forgot) for doing a golden file for the HBase API so that we can compare between releases to ensure that we are keeping source and binary compatibility as defined in this document : https://docs.google.com/document/d/1p5pP7v2OuzSSaomK2S2v7sfKky1Hex6OqwsJO0sZTUY/edit I think we can generate a file, commit it to the repo, and create a unit test to check whether any API's are broken. Adding new InterfaceAudience.Public interfaces has to modify this file so that it becomes an explicit decision. The downside is that we have to modify the file every time we add a new API, but it should be fine since it will force us to think more before committing to supporting new interfaces within the same major versions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12647) Truncate table should work with C as well
[ https://issues.apache.org/jira/browse/HBASE-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237533#comment-14237533 ] Hudson commented on HBASE-12647: SUCCESS: Integrated in HBase-1.0 #550 (See [https://builds.apache.org/job/HBase-1.0/550/]) HBASE-12647 Truncate table should work with C as well (enis: rev 9ee9a4bd200a56d83f74a9ce12b86c1da615698f) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Truncate table should work with C as well - Key: HBASE-12647 URL: https://issues.apache.org/jira/browse/HBASE-12647 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: hbase-12647_v1.patch, hbase-12647_v2.patch https://hbase.apache.org/book/appendix_acl_matrix.html indicates that truncateTable works with A or C (similar to createTable, deleteTable,modifyTable), but it is actually only A. Seems logical to require A or C. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12575) Sanity check table coprocessor classes are loadable
[
https://issues.apache.org/jira/browse/HBASE-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237536#comment-14237536
]
Hadoop QA commented on HBASE-12575:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12685664/HBASE-12575.patch
against master branch at commit 87e44140040ab9a864e592c13f164dcde6ed6c03.
ATTACHMENT ID: 12685664
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
2091 checkstyle errors (more than the master's current 2089 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+public TableCoprocessorAttribute(Path path, String className, int
priority, Configuration conf) {
+ LOG.error(Malformed table coprocessor specification: key= +
key + , spec: + spec);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11992//console
This message is automatically generated.
Sanity check table coprocessor classes are loadable
---
Key: HBASE-12575
URL: https://issues.apache.org/jira/browse/HBASE-12575
Project: HBase
Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Andrew Purtell
Fix For: 1.0.0, 2.0.0, 0.98.9
Attachments: HBASE-12575.patch, HBASE-12575.patch, HBASE-12575.patch,
HBASE-12575.patch, HBASE-12575.patch
We load coprocessors and other classes from configuration. In case of a typo
in the class name (or deployment problem) a create table / alter table with
wrong class name brings down the whole cluster.
Master already does sanity check for compression and region split policy
classes introduced in HBASE-10591. We should extend that to check some other
common cases as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-12647) Truncate table should work with C as well
[ https://issues.apache.org/jira/browse/HBASE-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237537#comment-14237537 ] Hudson commented on HBASE-12647: FAILURE: Integrated in HBase-0.98 #725 (See [https://builds.apache.org/job/HBase-0.98/725/]) HBASE-12647 Truncate table should work with C as well (enis: rev 6b9f597d5f9a218751a82b807619f2af4fa4a7d3) * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Truncate table should work with C as well - Key: HBASE-12647 URL: https://issues.apache.org/jira/browse/HBASE-12647 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: hbase-12647_v1.patch, hbase-12647_v2.patch https://hbase.apache.org/book/appendix_acl_matrix.html indicates that truncateTable works with A or C (similar to createTable, deleteTable,modifyTable), but it is actually only A. Seems logical to require A or C. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12647) Truncate table should work with C as well
[ https://issues.apache.org/jira/browse/HBASE-12647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237566#comment-14237566 ] Hudson commented on HBASE-12647: SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #692 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/692/]) HBASE-12647 Truncate table should work with C as well (enis: rev 6b9f597d5f9a218751a82b807619f2af4fa4a7d3) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java Truncate table should work with C as well - Key: HBASE-12647 URL: https://issues.apache.org/jira/browse/HBASE-12647 Project: HBase Issue Type: Bug Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 1.0.0, 2.0.0, 0.98.9 Attachments: hbase-12647_v1.patch, hbase-12647_v2.patch https://hbase.apache.org/book/appendix_acl_matrix.html indicates that truncateTable works with A or C (similar to createTable, deleteTable,modifyTable), but it is actually only A. Seems logical to require A or C. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
