[jira] [Commented] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153122#comment-16153122 ] Hudson commented on HBASE-18723: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3660 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3660/]) HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove (stack: rev 52d4b25754a227983170bdbadc477756a639ea8e) * (edit) pom.xml * (edit) hbase-rest/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-it/pom.xml > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, HBASE-18723.master.005.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153121#comment-16153121 ] Hudson commented on HBASE-18736: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3660 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3660/]) HBASE-18736 Cleanup the HTD/HCD for Admin; ADDENDUM (stack: rev 8ec5d59a081a6bc70692241b373cbbf2aacaf1f5) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153108#comment-16153108 ] stack commented on HBASE-18736: --- No problem [~chia7712] > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153106#comment-16153106 ] stack commented on HBASE-15607: --- bq. But regarding the depreciation patch except for the missing for SnapshotInfo. Rest is taken care of already right? You mean it already applied? If so, yes. Sorry for confusion. Just giving the go-ahead. > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-15607) Remove PB references from Admin for 2.0
[ https://issues.apache.org/jira/browse/HBASE-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-15607: --- Hadoop Flags: Incompatible change,Reviewed (was: Reviewed) Release Note: All the references to Protos in Admin.java have been removed and replaced with respective POJO classes. The references to Protos that were removed are AdminProtos.GetRegionInfoResponse, HBaseProtos.SnapshotDescription, HBaseProtos.SnapshotDescription.Type, MasterProtos.SnapshotResponse. CompactionType, CompactionState and MasterSwitchType Enums have been moved out of Admin.java to standalone Enums. > Remove PB references from Admin for 2.0 > --- > > Key: HBASE-15607 > URL: https://issues.apache.org/jira/browse/HBASE-15607 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Blocker > Fix For: 2.0.0, 1.3.0, 2.0.0-alpha-3 > > Attachments: HBASE-15607_1.patch, HBASE-15607_2.patch, > HBASE-15607_3.patch, HBASE-15607_3.patch, HBASE-15607_4.patch, > HBASE-15607_4.patch, HBASE-15607_branch-1.patch, HBASE-15607.patch > > > This is a sub-task for HBASE-15174. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153094#comment-16153094 ] Chia-Ping Tsai commented on HBASE-18736: My bad. Thanks for the addendum. [~stack] > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153095#comment-16153095 ] Hadoop QA commented on HBASE-18674: --- (!) A patch to the testing environment has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HBASE-Build/8464/console in case of problems. > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > HBASE-18674.master.001.patch, hbase-18674.master.002.patch, > hbase-18674.master.002.patch, HBASE-18674.master.002.patch, > HBASE-18674.master.002.patch, hbase-18674.master.003.patch, > hbase-18674.master.004.patch, hbase-18674.master.004.patch, > hbase-18674.master.005.patch, hbase-18674.master.006.patch, > hbase-18674.master.007.patch, hbase-18674.master.008.patch, > hbase-18674.master.008.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18674) upgrade hbase to commons-lang3
[ https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18674: -- Attachment: HBASE-18674.master.002.patch Retry now pushed addendum on "HBASE-18723 [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit; ADDENDUM2" to address jspc being missing. Patch still applies. > upgrade hbase to commons-lang3 > -- > > Key: HBASE-18674 > URL: https://issues.apache.org/jira/browse/HBASE-18674 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.0.0-alpha-2 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0 > > Attachments: hbase-18674.master.001.patch, > HBASE-18674.master.001.patch, hbase-18674.master.002.patch, > hbase-18674.master.002.patch, HBASE-18674.master.002.patch, > HBASE-18674.master.002.patch, hbase-18674.master.003.patch, > hbase-18674.master.004.patch, hbase-18674.master.004.patch, > hbase-18674.master.005.patch, hbase-18674.master.006.patch, > hbase-18674.master.007.patch, hbase-18674.master.008.patch, > hbase-18674.master.008.patch > > > upgrade hbase to use commons-lang 3.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18723: -- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed addendum 2 to master and branch-2 (addendum 2 == .005 patch). > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, HBASE-18723.master.005.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153091#comment-16153091 ] stack commented on HBASE-18723: --- The TestCanaryTool was because of HBASE-18736; an addendum just applied should fix it. Going to push this second addendum. > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, HBASE-18723.master.005.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (HBASE-18736) Cleanup the HTD/HCD for Admin
[
https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack resolved HBASE-18736.
---
Resolution: Fixed
Re-resolving. I pushed the above addendum on master and branch-2:
{code}
commit e778fbc059fbe99222aef8e578090c8092fa1bda
Author: Michael Stack
Date: Mon Sep 4 21:09:04 2017 -0700
HBASE-18736 Cleanup the HTD/HCD for Admin; ADDENDUM
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java
index 8c07a54c91..bf2064671c 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/tool/TestCanaryTool.java
@@ -19,6 +19,7 @@
package org.apache.hadoop.hbase.tool;
import org.apache.hadoop.hbase.*;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
import org.apache.hadoop.hbase.client.Put;
import org.apache.hadoop.hbase.client.Table;
import org.apache.hadoop.hbase.testclassification.MediumTests;
@@ -113,7 +114,8 @@ public class TestCanaryTool {
ToolRunner.run(testingUtility.getConfiguration(), canary, args);
assertEquals("verify no read error count", 0,
canary.getReadFailures().size());
assertEquals("verify no write error count", 0,
canary.getWriteFailures().size());
-verify(sink, atLeastOnce()).publishReadTiming(isA(ServerName.class),
isA(HRegionInfo.class), isA(HColumnDescriptor.class), anyLong());
+verify(sink, atLeastOnce()).publishReadTiming(isA(ServerName.class),
isA(HRegionInfo.class),
+ isA(ColumnFamilyDescriptor.class), anyLong());
}
@Test
@@ -217,11 +219,13 @@ public class TestCanaryTool {
Canary.RegionStdOutSink sink = spy(new Canary.RegionStdOutSink());
Canary canary = new Canary(executor, sink);
String[] args = { "-t", "1", name.getMethodName() };
-org.apache.hadoop.conf.Configuration conf = new
org.apache.hadoop.conf.Configuration(testingUtility.getConfiguration());
+org.apache.hadoop.conf.Configuration conf =
+ new
org.apache.hadoop.conf.Configuration(testingUtility.getConfiguration());
conf.setBoolean(HConstants.HBASE_CANARY_READ_RAW_SCAN_KEY, true);
ToolRunner.run(conf, canary, args);
verify(sink, atLeastOnce())
-.publishReadTiming(isA(ServerName.class), isA(HRegionInfo.class),
isA(HColumnDescriptor.class), anyLong());
+.publishReadTiming(isA(ServerName.class), isA(HRegionInfo.class),
+isA(ColumnFamilyDescriptor.class), anyLong());
assertEquals("verify no read error count", 0,
canary.getReadFailures().size());
}
{code}
> Cleanup the HTD/HCD for Admin
> -
>
> Key: HBASE-18736
> URL: https://issues.apache.org/jira/browse/HBASE-18736
> Project: HBase
> Issue Type: Sub-task
>Reporter: Chia-Ping Tsai
>Assignee: Chia-Ping Tsai
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18736.v0.patch
>
>
> see the
> [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675]
> in HBASE-18729.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Reopened] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-18736: --- Reopen to apply ADDENDUM. The TestCatalogTool failure seems legit (I get it local). Let me apply a patch. > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18755) Set Increment getReturnResults to false will cause batch failed by using BufferedMutator
Xudong Zheng created HBASE-18755:
Summary: Set Increment getReturnResults to false will cause batch
failed by using BufferedMutator
Key: HBASE-18755
URL: https://issues.apache.org/jira/browse/HBASE-18755
Project: HBase
Issue Type: Bug
Components: Client
Affects Versions: 1.2.0
Reporter: Xudong Zheng
I try to do batch of increment in Spark rdd like this:
{code:scala}
var connection: Connection = null
var bufferdMutator: BufferedMutator = null
try {
connection = getConnection
bufferdMutator = getBufferedMutator(connection)
dataItr.foreach(row => try {
val rowKey = toRowKey(row)
val increment = new Increment(rowKey)
increment.setDurability(Durability.SKIP_WAL)
increment.setReturnResults(false)
meas.foreach(columnName => {
increment.addColumn("cf".getBytes, Bytes.toBytes(columnName),
row.getAs[Long](columnName))
})
bufferdMutator.mutate(increment)
} catch {
case t: Throwable => logger.error(t.getMessage, t)
})
bufferdMutator.flush()
} catch {
case t: Throwable => logger.error(t.getMessage, t)
} finally {
IOUtils.closeQuietly(bufferdMutator)
}
{code}
Because I do not need the return result, thus I use
increment.setReturnResults(false) . When flush to Hbase, I got the flowing
exception. When I change increment.setReturnResults(true) everything is OK
17/09/04 17:55:39 ERROR client.AsyncProcess: #32, Caught throwable while
calling. This is unexpected. Retrying. Server is hadoop02,60020,1502272041150,
tableName=push:msgHourInfo
java.lang.RuntimeException: java.lang.IllegalStateException:
actions.getActionCount=1, actionResult.getResultOrExceptionCount=0 for region
type: REGION_NAME
value: "msgHourInfo,,1504318878177.1edc4215ef0853432b1598a0b1965519."
at
org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:208)
at
org.apache.hadoop.hbase.client.AsyncProcess$AsyncRequestFutureImpl$SingleServerRequestRunnable.run(AsyncProcess.java:733)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalStateException: actions.getActionCount=1,
actionResult.getResultOrExceptionCount=0 for region type: REGION_NAME
value: "push:msgHourInfo,,1504318878177.1edc4215ef0853432b1598a0b1965519."
at
org.apache.hadoop.hbase.protobuf.ResponseConverter.getResults(ResponseConverter.java:117)
at
org.apache.hadoop.hbase.client.MultiServerCallable.call(MultiServerCallable.java:133)
at
org.apache.hadoop.hbase.client.MultiServerCallable.call(MultiServerCallable.java:53)
at
org.apache.hadoop.hbase.client.RpcRetryingCaller.callWithoutRetries(RpcRetryingCaller.java:200)
... 6 more
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[
https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152998#comment-16152998
]
Hadoop QA commented on HBASE-18723:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
38s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 38s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
54s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 90m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
49s{color} | {color:green} hbase-thrift in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
25s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
46s{color} | {color:green} hbase-rest in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}100m 43s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}265m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.tool.TestCanaryTool |
| | hadoop.hbase.tool.TestCanaryTool |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-18723 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12885281/HBASE-18723.master.005.patch
|
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux 725601bc1aa5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / bea5de0 |
| Default Java | 1.8.0_144 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8463/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8463/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152993#comment-16152993
]
Hudson commented on HBASE-18746:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #280 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/280/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev e43857d87752a683ba94a9bbcac5b548053c6070)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152979#comment-16152979
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-2.0 #456 (See
[https://builds.apache.org/job/HBase-2.0/456/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev 27db1298f740b5efedf2d9a4fe5c6d4a648187f7)
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152975#comment-16152975
]
Hudson commented on HBASE-18746:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #214 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/214/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev 11c17597801435840a4097d5ab0ed4de617b52dc)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-14093) deduplicate copies of bootstrap files
[ https://issues.apache.org/jira/browse/HBASE-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152956#comment-16152956 ] Tamas Penzes commented on HBASE-14093: -- [~busbey], it is possible, I try to implement it. With any JEE container or standalone Jetty it would be simple, with embedded Jetty it's a bit more challenging, but I'll find a way. :-) > deduplicate copies of bootstrap files > - > > Key: HBASE-14093 > URL: https://issues.apache.org/jira/browse/HBASE-14093 > Project: HBase > Issue Type: Improvement > Components: build >Reporter: Sean Busbey >Assignee: Tamas Penzes > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-14093.master.001.patch > > > right now we have a couple of different copies of the bootstrap js and css > files. It'll be easier to maintain them later if we can centralize. > Move them to a common location and use maven to populate them as needed in > various component build directories. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152951#comment-16152951
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3658 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3658/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev bea5de02b3c353913b6a3de2d5ec0507b901dbdf)
* (edit)
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152926#comment-16152926
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #213 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/213/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
9b0f2fa3e225554f6b36028c276f056fe27dfe7e)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18748) Cache pre-warming upon replication
[ https://issues.apache.org/jira/browse/HBASE-18748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152923#comment-16152923 ] stack commented on HBASE-18748: --- What you thinking [~anastas] ? The WAL hosts all writes to hbase. It does not do reads. Our cache is pluggable. You could reference a cache that overloads our default that does a write to WAL (async) whenever we pull in a block? Something like that? I don't think we have any hooks other than what implementation to load in cache implementation currently. > Cache pre-warming upon replication > -- > > Key: HBASE-18748 > URL: https://issues.apache.org/jira/browse/HBASE-18748 > Project: HBase > Issue Type: New Feature >Reporter: Anastasia Braginsky > > HBase's cluster replication is very important and widely used feature. Let's > assume primary cluster is replicated to secondary (backup) cluster using the > WAL of the primary cluster to propagate the changes. Let's also assume the > secondary cluster is a target for failover when needed and should become > primary when needed. > We suggest improving the way the HBase cluster failover works today. Namely, > upon failover, the backup RS's cache is cold. Warming it up to the right > working set takes many minutes. The suggested solution is to selectively > replay read requests at the backup - namely, those reads that caused > cache-ins at the primary. We intend to use WAL replication as transport > protocol (hopefully, as black box), and of course add custom replay > callbacks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18723: -- Status: Patch Available (was: Reopened) > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, HBASE-18723.master.005.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152916#comment-16152916 ] stack commented on HBASE-18723: --- .005 is addendum2. Adds include of a lib that has jspc in it for the antrun jsp precompiles. Also adds to hbase-it a reference to shaded hbase-protocol. See HBASE-18674 for the failures that are showing these holes on build box (Cannot repro. locally). > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, HBASE-18723.master.005.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18723: -- Attachment: HBASE-18723.master.005.patch > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, HBASE-18723.master.005.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152911#comment-16152911
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-1.5 #47 (See
[https://builds.apache.org/job/HBase-1.5/47/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev 8eacd32bebd5ee3af173d6667ea8d7d025362f03)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-10240) Remove 0.94->0.96 migration code
[ https://issues.apache.org/jira/browse/HBASE-10240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152909#comment-16152909 ] Peter Somogyi commented on HBASE-10240: --- Thanks [~chia7712] and [~stack] for the guidance! I will take a look how to get rid of the Writables. > Remove 0.94->0.96 migration code > > > Key: HBASE-10240 > URL: https://issues.apache.org/jira/browse/HBASE-10240 > Project: HBase > Issue Type: Improvement >Reporter: Andrew Purtell >Assignee: Peter Somogyi >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-10240.master.001.patch, > HBASE-10240.master.001.patch > > > Remove the objects and code only needed for supporting migration to 0.96 from > 0.94. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152908#comment-16152908
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #218 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/218/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev 11c17597801435840a4097d5ab0ed4de617b52dc)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Reopened] (HBASE-18723) [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity list the dependencies we exploit
[ https://issues.apache.org/jira/browse/HBASE-18723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack reopened HBASE-18723: --- Reopen. HBASE-18674 still fails. This time it can't find the JspC that is used internally by ant task. We purge JspC transitive includes from hadoop everywhere Poking around, a pretty recent bundling of JspC is in glassfish. It is what jetty suggests on this page: http://www.eclipse.org/jetty/documentation/9.4.x/jetty-jspc-maven-plugin.html Our ant hackery doing precompile needs modernizing. I tried updating it but the mapping is not clean so leaving it as is for now. Here is the error I get from HBASE-18674. I cannot reproduce this stuff locally though I try running the yetus commands locally (maybe if I redo the whole yetus build...) main: [mkdir] Created dir: /testptch/hbase/hbase-rest/target/hbase-webapps [copy] Copying 1 file to /testptch/hbase/hbase-rest/target/hbase-webapps [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 3.768s [INFO] Finished at: Mon Sep 04 04:35:22 UTC 2017 [INFO] Final Memory: 32M/913M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (generate) on project hbase-rest: An Ant BuildException has occured: taskdef class org.apache.jasper.JspC cannot be found > [pom cleanup] Do a pass with dependency:analyze; remove unused and explicity > list the dependencies we exploit > - > > Key: HBASE-18723 > URL: https://issues.apache.org/jira/browse/HBASE-18723 > Project: HBase > Issue Type: Bug > Components: pom >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18723.master.001.patch, > HBASE-18723.master.002.patch, HBASE-18723.master.003.patch, > HBASE-18723.master.004.patch, > HBASE-18723-pom-cleanup-Do-a-pass-with-dependency.addendum.patch > > > Do a pass over our poms. They are sloppy including unused jars and not > listing actually used dependencies. Undo 'required' dependencies like junit > and mockito; not all modules need these anymore. > This cleanup motivated by failures up on jenkins where a build step is not > finding transitive includes; explicit mention is needed (See failures in > HBASE-18674). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152853#comment-16152853
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #202 (See
[https://builds.apache.org/job/HBase-1.3-IT/202/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev e43857d87752a683ba94a9bbcac5b548053c6070)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152850#comment-16152850
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #270 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/270/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev e43857d87752a683ba94a9bbcac5b548053c6070)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18746:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
[~chunhao] Thanks for the patch.
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152842#comment-16152842
]
Hudson commented on HBASE-18746:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #952 (See
[https://builds.apache.org/job/HBase-1.2-IT/952/])
HBASE-18746 Throw exception with job.getStatus().getFailureInfo() when
(chia7712: rev 11c17597801435840a4097d5ab0ed4de617b52dc)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18754) Get rid of Writable from TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18754: --- Summary: Get rid of Writable from TimeRangeTracker (was: Get rid of Writable for TimeRangeTracker) > Get rid of Writable from TimeRangeTracker > - > > Key: HBASE-18754 > URL: https://issues.apache.org/jira/browse/HBASE-18754 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152829#comment-16152829
]
Chia-Ping Tsai commented on HBASE-17980:
*fix:00*
{code}
+
+public class RegionInfoBuilder {
{code}
Add IA.Private to RegionInfoBuilder
*fix:01*
{code}
+ static final Comparator COMPARATOR
{code}
remove the redundant modifier.
*fix:02*
Just deprecate the stale helper methods without coping the impl to
MutableRegionInfo. For example:
# HRegionInfo#getRegionNameAsStringForDisplay
# HRegionInfo#getRegionNameForDisplay
# HRegionInfo#toDelimitedByteArray
I've only skimmed the HRegionInfo. Please double check it. Also, the conversion
(pb <-> our object) methods can be moved to ProtobufUtil.
*fix:03*
Consider adding the tests for RegionInfo built by RegionInfoBuilder. You can
copy the tests from TestHRegionInfo, and replace the HRegionInfo by RegionInfo.
> Any HRegionInfo we give out should be immutable
> ---
>
> Key: HBASE-17980
> URL: https://issues.apache.org/jira/browse/HBASE-17980
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch
>
>
> This is similar to HBASE-15583.
> # Introduce RegionInfo class. HRegionInfo will extend RegionInfo.
> # Deprecate HRegionInfo to be removed in 3.0
> # RegionInfo contain all of the read-only methods of HRegionInfo
> # Add "RegionInfo Builder"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152785#comment-16152785
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.5 #46 (See
[https://builds.apache.org/job/HBase-1.5/46/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
d5033fd3502e24af358dd208b39769bcaee2dc3a)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152800#comment-16152800
]
Hadoop QA commented on HBASE-17980:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
32m 14s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
32s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 43m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-17980 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12885270/HBASE-17980.master.v1.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux f91906fd8859 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 32ddb1f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8462/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8462/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Any HRegionInfo we give out should be immutable
> ---
>
> Key: HBASE-17980
> URL: https://issues.apache.org/jira/browse/HBASE-17980
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 2.0.0
>Reporter: Chia-Ping Tsai
>Assignee: Kuan-Po Tseng
> Labels: beginner
> Fix For: 2.0.0
>
> Attachments:
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152798#comment-16152798
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.4 #901 (See
[https://builds.apache.org/job/HBase-1.4/901/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
c97f0f2f24ab760d61ac74d159ee4f47a7c7d2d6)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152747#comment-16152747
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #216 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/216/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
9b0f2fa3e225554f6b36028c276f056fe27dfe7e)
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan-Po Tseng updated HBASE-17980: -- Attachment: HBASE-17980.master.v1.patch Add missing license and remove trailing space. > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch, HBASE-17980.master.v1.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152707#comment-16152707
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #201 (See
[https://builds.apache.org/job/HBase-1.3-IT/201/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
d59ca63237a064f18ca5b7069b558c3fb21cdfb4)
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152704#comment-16152704
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #268 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/268/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
d59ca63237a064f18ca5b7069b558c3fb21cdfb4)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-17980) Any HRegionInfo we give out should be immutable
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152710#comment-16152710
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
33m 38s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
35s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
7s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 45m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-17980 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12885266/HBASE-17980.master.v0.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 53810d59f0dc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 32ddb1f |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/8461/artifact/patchprocess/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8461/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HBASE-Build/8461/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8461/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Any HRegionInfo we give out should be immutable
> ---
>
> Key: HBASE-17980
> URL:
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152688#comment-16152688
]
Hudson commented on HBASE-18743:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #951 (See
[https://builds.apache.org/job/HBase-1.2-IT/951/])
HBASE-18743 HFiles in use by a table which has the same name and (tedyu: rev
9b0f2fa3e225554f6b36028c276f056fe27dfe7e)
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHFileLink.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java
* (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TableName.java
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are deleted
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-18743:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks for the patch, wenbang.
Thanks for the review, Chia-ping.
> HFiles in use by a table which has the same name and namespace with a default
> table cloned from snapshot may be deleted when that snapshot and default
> table are deleted
>
>
> Key: HBASE-18743
> URL: https://issues.apache.org/jira/browse/HBASE-18743
> Project: HBase
> Issue Type: Bug
> Components: hbase
>Affects Versions: 1.1.12
>Reporter: wenbang
>Assignee: wenbang
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18743-branch-1.patch, HBASE_18743.patch,
> HBASE_18743_v1.patch, HBASE_18743_v2.patch
>
>
> We recently had a critical production issue in which HFiles that were still
> in use by a table were deleted.
> This appears to have been caused by conditions in which table have the same
> namespace and name with a default table cloned from snapshot.when snapshot
> and default table be deleted,HFiles that are still in use may be deleted.
> For example:
> Table with default namespace is: "t1"
> The namespace of the new table is the same as the name of the default table,
> and is generated by snapshot cloned : "t1: t1"
> When the snapshot and the default namespace table are deleted, the new table
> is also deleted in the used HFiles
> This is because the creation of the BackReferenceFile get the table Name is
> not normal, resulting in can not find the reference file, hfilecleaner to
> delete the HFiles in used, when the table has not been major compact
> {code:java}
> public static boolean create(final Configuration conf, final FileSystem fs,
> final Path dstFamilyPath, final TableName linkedTable, final String
> linkedRegion,
> final String hfileName, final boolean createBackRef) throws IOException
> {
> String familyName = dstFamilyPath.getName();
> String regionName = dstFamilyPath.getParent().getName();
> String tableName =
> FSUtils.getTableName(dstFamilyPath.getParent().getParent())
> .getNameAsString();
> {code}
> {code:java}
> public static TableName getTableName(Path tablePath) {
> return TableName.valueOf(tablePath.getParent().getName(),
> tablePath.getName());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan-Po Tseng updated HBASE-17980: -- Status: Patch Available (was: Open) > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-17980) Any HRegionInfo we give out should be immutable
[ https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kuan-Po Tseng updated HBASE-17980: -- Attachment: HBASE-17980.master.v0.patch 1. Introduce RegionInfo class. HRegionInfo implements RegionInfo. 2. Deprecate HRegionInfo to be removed in 3.0 3. Interface RegionInfo contain all of the read-only methods of HRegionInfo 4. Add "RegionInfo Builder" 5. Rename UnmodifyableHRegionInfo.java to ImmutableHRegionInfo.java 6. Replace HRegionInfo in #getOnlineRegions and #getOfflineRegions in HBaseAdmin.java with ImmutableHRegionInfo > Any HRegionInfo we give out should be immutable > --- > > Key: HBASE-17980 > URL: https://issues.apache.org/jira/browse/HBASE-17980 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0 >Reporter: Chia-Ping Tsai >Assignee: Kuan-Po Tseng > Labels: beginner > Fix For: 2.0.0 > > Attachments: HBASE-17980.master.v0.patch > > > This is similar to HBASE-15583. > # Introduce RegionInfo class. HRegionInfo will extend RegionInfo. > # Deprecate HRegionInfo to be removed in 3.0 > # RegionInfo contain all of the read-only methods of HRegionInfo > # Add "RegionInfo Builder" -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18651) Let ChaosMonkeyRunner expose the chaos monkey runner it creates
[ https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152662#comment-16152662 ] Ted Yu commented on HBASE-18651: [~mdrob]: What do you think ? > Let ChaosMonkeyRunner expose the chaos monkey runner it creates > --- > > Key: HBASE-18651 > URL: https://issues.apache.org/jira/browse/HBASE-18651 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Reid Chan > Attachments: HBASE-18651.master.001.patch > > > Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without > keeping track of the instance. > This poses some challenge when ChaosMonkeyRunner is used programmatically > because the caller cannot get hold of the runner. > As [~mdrob] suggested, we should expose the chaos monkey runner. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18753) Introduce the unsynchronized TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18753: --- Summary: Introduce the unsynchronized TimeRangeTracker (was: Introduce the synchronized and unsynchronized TimeRangeTracker) > Introduce the unsynchronized TimeRangeTracker > - > > Key: HBASE-18753 > URL: https://issues.apache.org/jira/browse/HBASE-18753 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > If HBASE-18752 is pushed, it will be better to introduce the unsync > TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18753) Introduce the synchronized and unsynchronized TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18753: --- Summary: Introduce the synchronized and unsynchronized TimeRangeTracker (was: Introduce the synchronized/unsynchronized TimeRangeTracker) > Introduce the synchronized and unsynchronized TimeRangeTracker > -- > > Key: HBASE-18753 > URL: https://issues.apache.org/jira/browse/HBASE-18753 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > If HBASE-18752 is pushed, it will be better to introduce the unsync > TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18751) Revisit the TimeRange and TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18751: --- Summary: Revisit the TimeRange and TimeRangeTracker (was: Revisit the TimeRange/TimeRangeTracker) > Revisit the TimeRange and TimeRangeTracker > -- > > Key: HBASE-18751 > URL: https://issues.apache.org/jira/browse/HBASE-18751 > Project: HBase > Issue Type: Umbrella >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18752) Recalculate the TimeRange in flushing snapshot to store file
[ https://issues.apache.org/jira/browse/HBASE-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18752: --- Description: We drop superfluous cells in flushing, hence the TimeRange from snapshot is inaccurate for the storefile. We should recalculate the TimeRange for the storefile, but the side-effect is the extra cost - we need to extract the timestamp from cell (ByteBufferCell). (was: We drop superfluous cells in flushing, hence the TimeRange from snapshot is inaccurate for the storefile. The side-effect is the extra cost - we need to extract the timestamp from cell (ByteBufferCell).) > Recalculate the TimeRange in flushing snapshot to store file > > > Key: HBASE-18752 > URL: https://issues.apache.org/jira/browse/HBASE-18752 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > We drop superfluous cells in flushing, hence the TimeRange from snapshot is > inaccurate for the storefile. We should recalculate the TimeRange for the > storefile, but the side-effect is the extra cost - we need to extract the > timestamp from cell (ByteBufferCell). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18751) Revisit the TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18751: --- Summary: Revisit the TimeRangeTracker (was: Revisit the TimeRange) > Revisit the TimeRangeTracker > > > Key: HBASE-18751 > URL: https://issues.apache.org/jira/browse/HBASE-18751 > Project: HBase > Issue Type: Umbrella >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18751) Revisit the TimeRange/TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18751: --- Summary: Revisit the TimeRange/TimeRangeTracker (was: Revisit the TimeRangeTracker) > Revisit the TimeRange/TimeRangeTracker > -- > > Key: HBASE-18751 > URL: https://issues.apache.org/jira/browse/HBASE-18751 > Project: HBase > Issue Type: Umbrella >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18754) Get rid of Writable for TimeRangeTracker
Chia-Ping Tsai created HBASE-18754: -- Summary: Get rid of Writable for TimeRangeTracker Key: HBASE-18754 URL: https://issues.apache.org/jira/browse/HBASE-18754 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18753) Introduce the synchronized/unsynchronized TimeRangeTracker
Chia-Ping Tsai created HBASE-18753: -- Summary: Introduce the synchronized/unsynchronized TimeRangeTracker Key: HBASE-18753 URL: https://issues.apache.org/jira/browse/HBASE-18753 Project: HBase Issue Type: Bug Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai If HBASE-18752 is pushed, it will be better to introduce the unsync TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18753) Introduce the synchronized/unsynchronized TimeRangeTracker
[ https://issues.apache.org/jira/browse/HBASE-18753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18753: --- Issue Type: Sub-task (was: Bug) Parent: HBASE-18751 > Introduce the synchronized/unsynchronized TimeRangeTracker > -- > > Key: HBASE-18753 > URL: https://issues.apache.org/jira/browse/HBASE-18753 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > If HBASE-18752 is pushed, it will be better to introduce the unsync > TimeRangeTracker for reducing the cost of recalculation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18752) Recalculate the TimeRange in flushing snapshot to store file
[ https://issues.apache.org/jira/browse/HBASE-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18752: --- Description: We drop superfluous cells in flushing, hence the TimeRange from snapshot is inaccurate for the storefile. The side-effect is the extra cost - we need to extract the timestamp from cell (ByteBufferCell). (was: We drop superfluous cells in flushing, hence the TimeRange from snapshot is inaccurate for the storefile.) > Recalculate the TimeRange in flushing snapshot to store file > > > Key: HBASE-18752 > URL: https://issues.apache.org/jira/browse/HBASE-18752 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > > We drop superfluous cells in flushing, hence the TimeRange from snapshot is > inaccurate for the storefile. The side-effect is the extra cost - we need to > extract the timestamp from cell (ByteBufferCell). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18752) Recalculate the TimeRange in flushing snapshot to store file
Chia-Ping Tsai created HBASE-18752: -- Summary: Recalculate the TimeRange in flushing snapshot to store file Key: HBASE-18752 URL: https://issues.apache.org/jira/browse/HBASE-18752 Project: HBase Issue Type: Sub-task Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai We drop superfluous cells in flushing, hence the TimeRange from snapshot is inaccurate for the storefile. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner
[ https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18749: --- Issue Type: Sub-task (was: Improvement) Parent: HBASE-18751 > Apply the TimeRange from ColumnFamily to filter the segment scanner > --- > > Key: HBASE-18749 > URL: https://issues.apache.org/jira/browse/HBASE-18749 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18749.v0.patch > > > We can evict the unused segment scanner early. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-18751) Revisit the TimeRange
Chia-Ping Tsai created HBASE-18751: -- Summary: Revisit the TimeRange Key: HBASE-18751 URL: https://issues.apache.org/jira/browse/HBASE-18751 Project: HBase Issue Type: Umbrella Reporter: Chia-Ping Tsai Assignee: Chia-Ping Tsai -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152529#comment-16152529 ] Hudson commented on HBASE-18736: FAILURE: Integrated in Jenkins build HBase-2.0 #453 (See [https://builds.apache.org/job/HBase-2.0/453/]) HBASE-18736 Cleanup the HTD/HCD for Admin (chia7712: rev 0e0154483872a9d85dc2e75aab8274f065ea8931) * (edit) hbase-archetypes/hbase-client-project/src/main/java/org/apache/hbase/archetypes/exemplars/client/HelloHBase.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152528#comment-16152528
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-2.0 #453 (See
[https://builds.apache.org/job/HBase-2.0/453/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev a1efda29e9f89f6ded192213e90164c7a221f041)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152507#comment-16152507
]
Hudson commented on HBASE-15497:
SUCCESS: Integrated in Jenkins build HBase-1.2-JDK8 #209 (See
[https://builds.apache.org/job/HBase-1.2-JDK8/209/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 55629b2c675311468caf76069dc3e276421d25c0)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18651) Let ChaosMonkeyRunner expose the chaos monkey runner it creates
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152500#comment-16152500
]
Hadoop QA commented on HBASE-18651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
28s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
40m 15s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
24s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 49m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:47a5614 |
| JIRA Issue | HBASE-18651 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12885231/HBASE-18651.master.001.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux d9e339289f5c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 32ddb1f |
| Default Java | 1.8.0_144 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8460/testReport/ |
| modules | C: hbase-it U: hbase-it |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8460/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Let ChaosMonkeyRunner expose the chaos monkey runner it creates
> ---
>
> Key: HBASE-18651
> URL: https://issues.apache.org/jira/browse/HBASE-18651
> Project: HBase
> Issue Type: Improvement
>Reporter: Ted Yu
>Assignee: Reid Chan
> Attachments: HBASE-18651.master.001.patch
>
>
> Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without
>
[jira] [Updated] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guangxu Cheng updated HBASE-18131:
--
Attachment: HBASE-18131.master.v1.patch
fix UT
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.master.v1.patch, HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152478#comment-16152478
]
Hudson commented on HBASE-15497:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #275 (See
[https://builds.apache.org/job/HBase-1.3-JDK8/275/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 67be2d11e4389d5ced9317c67dabb195afa8a25b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-18651) Let ChaosMonkeyRunner expose the chaos monkey runner it creates
[ https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152447#comment-16152447 ] Reid Chan edited comment on HBASE-18651 at 9/4/17 10:46 AM: First version is based on my comprehension about the discussions in HBASE-18629 (not quite sure if this patch is as expected... Need some suggestions, thank you [~tedyu] was (Author: reidchan): First version is based on my comprehension about the discussion in HBASE-18629 (not quite sure if it is as expected... Need some suggestions, thank you [~tedyu] > Let ChaosMonkeyRunner expose the chaos monkey runner it creates > --- > > Key: HBASE-18651 > URL: https://issues.apache.org/jira/browse/HBASE-18651 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Reid Chan > Attachments: HBASE-18651.master.001.patch > > > Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without > keeping track of the instance. > This poses some challenge when ChaosMonkeyRunner is used programmatically > because the caller cannot get hold of the runner. > As [~mdrob] suggested, we should expose the chaos monkey runner. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guangxu Cheng updated HBASE-18131:
--
Attachment: HBASE-18131.patch
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18651) Let ChaosMonkeyRunner expose the chaos monkey runner it creates
[ https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152447#comment-16152447 ] Reid Chan commented on HBASE-18651: --- First version is based on my comprehension about the discussion in HBASE-18629 (not quite sure if it is as expected... Need some suggestions, thank you [~tedyu] > Let ChaosMonkeyRunner expose the chaos monkey runner it creates > --- > > Key: HBASE-18651 > URL: https://issues.apache.org/jira/browse/HBASE-18651 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Reid Chan > Attachments: HBASE-18651.master.001.patch > > > Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without > keeping track of the instance. > This poses some challenge when ChaosMonkeyRunner is used programmatically > because the caller cannot get hold of the runner. > As [~mdrob] suggested, we should expose the chaos monkey runner. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18750) Document the non-writebuffer for HTable
[
https://issues.apache.org/jira/browse/HBASE-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-18750:
---
Labels: beginner (was: )
> Document the non-writebuffer for HTable
> ---
>
> Key: HBASE-18750
> URL: https://issues.apache.org/jira/browse/HBASE-18750
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Chia-Ping Tsai
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
>
> Cleanup the docs saying "HTable use write buffer"
> {code}
> Default size of the HTable client write buffer in bytes. A bigger buffer
> takes more memory — on both the client and server side since server
> instantiates the passed write buffer to process it — but a larger buffer size
> reduces the number of RPCs made. For an estimate of server-side memory-used,
> evaluate hbase.client.write.buffer * hbase.regionserver.handler.count
> {code}
> {code}
> Put either adds new rows to a table (if the key is new) or can update
> existing rows (if the key already exists). Puts are executed via Table.put
> (writeBuffer) or Table.batch (non-writeBuffer).
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18674) upgrade hbase to commons-lang3
[
https://issues.apache.org/jira/browse/HBASE-18674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152465#comment-16152465
]
Hadoop QA commented on HBASE-18674:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
6s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 51 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 5m
34s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-spark-it hbase-shaded . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
21s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
15s{color} | {color:red} hbase-it in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
9s{color} | {color:red} hbase-rest in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 5m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
19s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
39m 35s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source:
hbase-resource-bundle hbase-spark-it hbase-shaded . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 12m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
34s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
13s{color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
47s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit
[jira] [Updated] (HBASE-18651) Let ChaosMonkeyRunner expose the chaos monkey runner it creates
[ https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-18651: -- Status: Patch Available (was: Open) > Let ChaosMonkeyRunner expose the chaos monkey runner it creates > --- > > Key: HBASE-18651 > URL: https://issues.apache.org/jira/browse/HBASE-18651 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Reid Chan > Attachments: HBASE-18651.master.001.patch > > > Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without > keeping track of the instance. > This poses some challenge when ChaosMonkeyRunner is used programmatically > because the caller cannot get hold of the runner. > As [~mdrob] suggested, we should expose the chaos monkey runner. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18131) Add an hbase shell command to clear deadserver list in ServerManager
[
https://issues.apache.org/jira/browse/HBASE-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152456#comment-16152456
]
Guangxu Cheng commented on HBASE-18131:
---
Upload the first patch for review.Thanks [~carp84]
> Add an hbase shell command to clear deadserver list in ServerManager
>
>
> Key: HBASE-18131
> URL: https://issues.apache.org/jira/browse/HBASE-18131
> Project: HBase
> Issue Type: New Feature
> Components: Operability
>Reporter: Yu Li
>Assignee: Guangxu Cheng
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-18131.patch
>
>
> Currently if a regionserver is aborted due to fatal error or stopped by
> operator on purpose, it will be added into {{ServerManager#deadservers}} list
> and shown as "Dead Servers" in the master UI. This is a valid warn for
> operators to notice the self-aborted servers and give a sanity check to
> avoid further issues. However, after necessary checks, even if operator is
> sure that the node is decommissioned (such as for repair), there's no way to
> clear the dead server list except restarting master. See more details in
> [this
> discussion|http://mail-archives.apache.org/mod_mbox/hbase-user/201705.mbox/%3CCAM7-19%2BD4MLu2b1R94%2BtWQDspjfny2sCy4Qit8JtCgjvTOZzzg%40mail.gmail.com%3E]
> in mail list
> Here we propose to add a hbase shell command to allow clearing dead server
> list in {{ServerManager}} for advanced users, and the command should be
> executed with caution.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18651) Let ChaosMonkeyRunner expose the chaos monkey runner it creates
[ https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-18651: -- Attachment: HBASE-18651.master.001.patch > Let ChaosMonkeyRunner expose the chaos monkey runner it creates > --- > > Key: HBASE-18651 > URL: https://issues.apache.org/jira/browse/HBASE-18651 > Project: HBase > Issue Type: Improvement >Reporter: Ted Yu >Assignee: Reid Chan > Attachments: HBASE-18651.master.001.patch > > > Currently ChaosMonkeyRunner#main() instantiates ChaosMonkeyRunner without > keeping track of the instance. > This poses some challenge when ChaosMonkeyRunner is used programmatically > because the caller cannot get hold of the runner. > As [~mdrob] suggested, we should expose the chaos monkey runner. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18737) Display configured max size of memstore and cache on RS UI
[
https://issues.apache.org/jira/browse/HBASE-18737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152442#comment-16152442
]
Chia-Ping Tsai commented on HBASE-18737:
Would you please attach the complete screenshot for the page? Also, please
retry the QA.
The "Memstore Size" is current memory usage of memstore, but the "Cache size"
is the limit of block cache. It will be better to rename the "Cache size" to
"Cache Limit".
> Display configured max size of memstore and cache on RS UI
> --
>
> Key: HBASE-18737
> URL: https://issues.apache.org/jira/browse/HBASE-18737
> Project: HBase
> Issue Type: Improvement
>Reporter: Biju Nair
>Assignee: Biju Nair
>Priority: Minor
> Attachments: HBASE-18737-WIP.PATCH, RS_UI_AFTER-1.PNG,
> RS_UI_AFTER.PNG, RS_UI.PNG
>
>
> Displaying the configured size of {{memstore}} and {{cache}} will help
> non-admin users understand the cluster capacity. Attached screenshot with
> proposed usability related changes and the current RS UI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18621) Refactor ClusterOptions before applying to code base
[ https://issues.apache.org/jira/browse/HBASE-18621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152424#comment-16152424 ] Reid Chan commented on HBASE-18621: --- thank you [~chia7712] i will continue HBASE-18609 as soon as it is committed > Refactor ClusterOptions before applying to code base > > > Key: HBASE-18621 > URL: https://issues.apache.org/jira/browse/HBASE-18621 > Project: HBase > Issue Type: Improvement >Reporter: Reid Chan >Assignee: Reid Chan > Attachments: HBASE-18621.master.001.patch, > HBASE-18621.master.002.patch, HBASE-18621.master.003.patch, > HBASE-18621.master.004.patch, HBASE-18621.master.005.patch, > HBASE-18621.master.006.patch, HBASE-18621.master.007.patch, > HBASE-18621.master.008.patch > > > So far, ClusterStatus.Options is not so clean that can be applied to code > base. > Refactoring it before next move. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18446) Mark StoreFileScanner as IA.Private
[ https://issues.apache.org/jira/browse/HBASE-18446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152440#comment-16152440 ] Duo Zhang commented on HBASE-18446: --- Let's revive this. So I think we all agree that user should not have the ability to create a StoreFile instance, but for now Phoenix still need to extend StoreFileScanner to support secondary index. So let's mark StoreFileScanner change the comments of preBulkLoadHFile? And also, mark StoreFileScanner as IA.LimitedPrivate(Phoenix)? Thanks. > Mark StoreFileScanner as IA.Private > --- > > Key: HBASE-18446 > URL: https://issues.apache.org/jira/browse/HBASE-18446 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Priority: Critical > Fix For: 2.0.0-alpha-3 > > > Do not see any reason why it is marked as IA.LimitedPrivate. It is not > referenced in any CPs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152419#comment-16152419
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.5 #44 (See
[https://builds.apache.org/job/HBase-1.5/44/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 8ce811c6edd9c745710f31c3781425e75ec49361)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner
[ https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152384#comment-16152384 ] Chia-Ping Tsai commented on HBASE-18749: bq. The issue is not using CF specific TR from Scan. yeah, the CF specific TR is used only in matcher and StoreFileScanner#shouldUseScanner now. bq. On the code, will it be better that the Segments know which Store/CF it belongs to. Than we pass Store instance every time into shouldSeek() method. Per cf we have one MS and that will have N Segments. In Compacting Memstore, already the Store ref is there. That will complicate the construction of Segment...Or just pass the TImeRange to shouldSeek()? The impl needs only the TimeRange. We can refactor the shouldSeek() in the future if any policies are raised. > Apply the TimeRange from ColumnFamily to filter the segment scanner > --- > > Key: HBASE-18749 > URL: https://issues.apache.org/jira/browse/HBASE-18749 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18749.v0.patch > > > We can evict the unused segment scanner early. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152370#comment-16152370
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3655 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3655/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 6e3ffd03e7a27274315b859a3b624736ef0ed20b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
Revert "HBASE-15497 Incorrect javadoc for atomicity guarantee of (chia7712: rev
0a3a9a5417932da30d12dda2baa1464d4294ace4)
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 476973654c297198e33405ff7bc588ffe213aae9)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-16390) Fix documentation around setAutoFlush
[
https://issues.apache.org/jira/browse/HBASE-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152369#comment-16152369
]
Hudson commented on HBASE-16390:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3655 (See
[https://builds.apache.org/job/HBase-Trunk_matrix/3655/])
HBASE-16390 Fix documentation around setAutoFlush (chia7712: rev
a5131a0491e65907d721e571ae6c4f68e905be3d)
* (edit) src/main/asciidoc/_chapters/performance.adoc
> Fix documentation around setAutoFlush
> -
>
> Key: HBASE-16390
> URL: https://issues.apache.org/jira/browse/HBASE-16390
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: stack
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-16390.master.001.patch
>
>
> Our documentation is a little confused around setAutoFlush. Talks of Table
> but setAutoFlush is not in the Table interface. It was on HTable but was
> deprecated and since removed. Clean up the doc:
> {code}
> 100.4. HBase Client: AutoFlush
> When performing a lot of Puts, make sure that setAutoFlush is set to false
> on your Table
>
> instance.
> Otherwise, the Puts will be sent one at a time to the RegionServer. Puts
> added via table.add(Put) and table.add( Put) wind up in the same
> write buffer. If autoFlush = false, these messages are not sent until the
> write-buffer is filled. To explicitly flush the messages, call flushCommits.
> Calling close on the Table instance will invoke flushCommits
> {code}
> Spotted by Jeff Shmain.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152371#comment-16152371 ] Hudson commented on HBASE-18736: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3655 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3655/]) HBASE-18736 Cleanup the HTD/HCD for Admin (chia7712: rev 32ddb1f604666e020e04a02c6fc213b22e5badef) * (edit) hbase-archetypes/hbase-client-project/src/main/java/org/apache/hbase/archetypes/exemplars/client/HelloHBase.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18736) Cleanup the HTD/HCD for Admin
[ https://issues.apache.org/jira/browse/HBASE-18736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18736: --- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change) Release Note: Changed the passed arguments from HTD/HCD to TD/CFD for Admin. Status: Resolved (was: Patch Available) Push to master and branch-2. Thanks for the reviews. [~stack] > Cleanup the HTD/HCD for Admin > - > > Key: HBASE-18736 > URL: https://issues.apache.org/jira/browse/HBASE-18736 > Project: HBase > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18736.v0.patch > > > see the > [discussion|https://issues.apache.org/jira/browse/HBASE-18729?focusedCommentId=16150675=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16150675] > in HBASE-18729. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner
[ https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152299#comment-16152299 ] Anoop Sam John commented on HBASE-18749: The issue is not using CF specific TR from Scan. On the code, will it be better that the Segments know which Store/CF it belongs to. Than we pass Store instance every time into shouldSeek() method. Per cf we have one MS and that will have N Segments. In Compacting Memstore, already the Store ref is there. > Apply the TimeRange from ColumnFamily to filter the segment scanner > --- > > Key: HBASE-18749 > URL: https://issues.apache.org/jira/browse/HBASE-18749 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18749.v0.patch > > > We can evict the unused segment scanner early. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152267#comment-16152267
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #199 (See
[https://builds.apache.org/job/HBase-1.3-IT/199/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 67be2d11e4389d5ced9317c67dabb195afa8a25b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152264#comment-16152264
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #214 (See
[https://builds.apache.org/job/HBase-1.2-JDK7/214/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 55629b2c675311468caf76069dc3e276421d25c0)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152262#comment-16152262
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #267 (See
[https://builds.apache.org/job/HBase-1.3-JDK7/267/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 67be2d11e4389d5ced9317c67dabb195afa8a25b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-15497:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
[~cuijianwei] Thanks for the patch.
Consider using your github email in your patch. Otherwise, the commit won't be
connected to your account in github. I commit the patch with your github email.
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-15497:
---
Fix Version/s: 2.0.0-alpha-3
1.2.7
1.5.0
1.3.2
1.4.0
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152253#comment-16152253
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #950 (See
[https://builds.apache.org/job/HBase-1.2-IT/950/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev 55629b2c675311468caf76069dc3e276421d25c0)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
[
https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152252#comment-16152252
]
Hudson commented on HBASE-15497:
FAILURE: Integrated in Jenkins build HBase-1.4 #899 (See
[https://builds.apache.org/job/HBase-1.4/899/])
HBASE-15497 Incorrect javadoc for atomicity guarantee of Increment and
(chia7712: rev ccaef7c029fb210cf1dfeb992c9d3b4e4427111b)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java
* (edit)
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Append.java
> Incorrect javadoc for atomicity guarantee of Increment and Append
> -
>
> Key: HBASE-15497
> URL: https://issues.apache.org/jira/browse/HBASE-15497
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 2.0.0
>Reporter: Jianwei Cui
>Assignee: Jianwei Cui
>Priority: Minor
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-15497-v1.patch
>
>
> At the front of {{Increment.java}} file, there is comment about read
> atomicity:
> {code}
> * This operation does not appear atomic to readers. Increments are done
> * under a single row lock, so write operations to a row are synchronized, but
> * readers do not take row locks so get and scan operations can see this
> * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated
> [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583]. Currently, the
> readers can be guaranteed to read the whole result of Increment if I am not
> wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}}
> and {{Table#increment(...)}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18740) Upgrade Zookeeper version to 3.4.10
[ https://issues.apache.org/jira/browse/HBASE-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152242#comment-16152242 ] Hudson commented on HBASE-18740: FAILURE: Integrated in Jenkins build HBase-2.0 #452 (See [https://builds.apache.org/job/HBase-2.0/452/]) HBASE-18740 Upgrade Zookeeper version to 3.4.10 (jerryjch: rev 2d5012e7cf11f6939894846e3dea81c033a637a2) * (edit) pom.xml > Upgrade Zookeeper version to 3.4.10 > --- > > Key: HBASE-18740 > URL: https://issues.apache.org/jira/browse/HBASE-18740 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.0, 1.5.0 >Reporter: Jerry He >Assignee: Jerry He > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18740-branch-1.patch, HBASE-18740-branch-1.patch, > HBASE-18740-master.patch > > > Branch 1.4 and branch 1 are still on Zookeeper 3.4.6. > Branch 2 and master branch have upgraded to 3.4.9. > There are some important fixes we'd like to have. See the linked JIRAs. > Another critical fix is ZOOKEEPER-2146, which can be explored maliciously. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18743) HFiles in use by a table which has the same name and namespace with a default table cloned from snapshot may be deleted when that snapshot and default table are delete
[
https://issues.apache.org/jira/browse/HBASE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152240#comment-16152240
]
Hadoop QA commented on HBASE-18743:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
33s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
29s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
41s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
38s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
54s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
16s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
26s{color} | {color:green} branch-1 passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} branch-1 passed with JDK v1.7.0_131 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed with JDK v1.8.0_144 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
17s{color} | {color:green} hbase-common in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed with JDK v1.7.0_131 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} hbase-common in the patch passed with JDK
v1.7.0_131. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} hbase-server-jdk1.7.0_131 with JDK v1.7.0_131
generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
19m 8s{color} | {color:green} The patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} hbase-common in the patch passed with JDK
v1.8.0_144. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} hbase-server-jdk1.8.0_144 with JDK v1.8.0_144
generated 0 new + 3 unchanged - 3 fixed = 3 total (was 6) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} hbase-common in the patch passed with JDK
v1.7.0_131. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} |
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152237#comment-16152237
]
Chia-Ping Tsai commented on HBASE-18746:
Will commit it tomorrow if no objections.
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18749) Apply the TimeRange from ColumnFamily to filter the segment scanner
[ https://issues.apache.org/jira/browse/HBASE-18749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152236#comment-16152236 ] Chia-Ping Tsai commented on HBASE-18749: Will commit it later. > Apply the TimeRange from ColumnFamily to filter the segment scanner > --- > > Key: HBASE-18749 > URL: https://issues.apache.org/jira/browse/HBASE-18749 > Project: HBase > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Minor > Fix For: 2.0.0-alpha-3 > > Attachments: HBASE-18749.v0.patch > > > We can evict the unused segment scanner early. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-16390) Fix documentation around setAutoFlush
[
https://issues.apache.org/jira/browse/HBASE-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-16390:
---
Fix Version/s: 2.0.0-alpha-3
> Fix documentation around setAutoFlush
> -
>
> Key: HBASE-16390
> URL: https://issues.apache.org/jira/browse/HBASE-16390
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: stack
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-16390.master.001.patch
>
>
> Our documentation is a little confused around setAutoFlush. Talks of Table
> but setAutoFlush is not in the Table interface. It was on HTable but was
> deprecated and since removed. Clean up the doc:
> {code}
> 100.4. HBase Client: AutoFlush
> When performing a lot of Puts, make sure that setAutoFlush is set to false
> on your Table
>
> instance.
> Otherwise, the Puts will be sent one at a time to the RegionServer. Puts
> added via table.add(Put) and table.add( Put) wind up in the same
> write buffer. If autoFlush = false, these messages are not sent until the
> write-buffer is filled. To explicitly flush the messages, call flushCommits.
> Calling close on the Table instance will invoke flushCommits
> {code}
> Spotted by Jeff Shmain.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-16390) Fix documentation around setAutoFlush
[
https://issues.apache.org/jira/browse/HBASE-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated HBASE-16390:
---
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks for the patch. [~awked06]
> Fix documentation around setAutoFlush
> -
>
> Key: HBASE-16390
> URL: https://issues.apache.org/jira/browse/HBASE-16390
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Reporter: stack
>Assignee: Sahil Aggarwal
>Priority: Minor
> Labels: beginner
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-16390.master.001.patch
>
>
> Our documentation is a little confused around setAutoFlush. Talks of Table
> but setAutoFlush is not in the Table interface. It was on HTable but was
> deprecated and since removed. Clean up the doc:
> {code}
> 100.4. HBase Client: AutoFlush
> When performing a lot of Puts, make sure that setAutoFlush is set to false
> on your Table
>
> instance.
> Otherwise, the Puts will be sent one at a time to the RegionServer. Puts
> added via table.add(Put) and table.add( Put) wind up in the same
> write buffer. If autoFlush = false, these messages are not sent until the
> write-buffer is filled. To explicitly flush the messages, call flushCommits.
> Calling close on the Table instance will invoke flushCommits
> {code}
> Spotted by Jeff Shmain.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18740) Upgrade Zookeeper version to 3.4.10
[ https://issues.apache.org/jira/browse/HBASE-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152189#comment-16152189 ] Hudson commented on HBASE-18740: FAILURE: Integrated in Jenkins build HBase-1.4 #898 (See [https://builds.apache.org/job/HBase-1.4/898/]) HBASE-18740 Upgrade Zookeeper version to 3.4.10 (jerryjch: rev fd9a29a235cf33602ce938e25de6647558800ed2) * (edit) pom.xml > Upgrade Zookeeper version to 3.4.10 > --- > > Key: HBASE-18740 > URL: https://issues.apache.org/jira/browse/HBASE-18740 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.0, 1.5.0 >Reporter: Jerry He >Assignee: Jerry He > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18740-branch-1.patch, HBASE-18740-branch-1.patch, > HBASE-18740-master.patch > > > Branch 1.4 and branch 1 are still on Zookeeper 3.4.6. > Branch 2 and master branch have upgraded to 3.4.9. > There are some important fixes we'd like to have. See the linked JIRAs. > Another critical fix is ZOOKEEPER-2146, which can be explored maliciously. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18740) Upgrade Zookeeper version to 3.4.10
[ https://issues.apache.org/jira/browse/HBASE-18740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152174#comment-16152174 ] Hudson commented on HBASE-18740: FAILURE: Integrated in Jenkins build HBase-1.5 #43 (See [https://builds.apache.org/job/HBase-1.5/43/]) HBASE-18740 Upgrade Zookeeper version to 3.4.10 (jerryjch: rev 6a5bb3b48c12e3f441fb221d2f954e8a67706334) * (edit) pom.xml > Upgrade Zookeeper version to 3.4.10 > --- > > Key: HBASE-18740 > URL: https://issues.apache.org/jira/browse/HBASE-18740 > Project: HBase > Issue Type: Improvement >Affects Versions: 1.4.0, 1.5.0 >Reporter: Jerry He >Assignee: Jerry He > Fix For: 3.0.0, 1.4.0, 1.5.0, 2.0.0-alpha-3 > > Attachments: HBASE-18740-branch-1.patch, HBASE-18740-branch-1.patch, > HBASE-18740-master.patch > > > Branch 1.4 and branch 1 are still on Zookeeper 3.4.6. > Branch 2 and master branch have upgraded to 3.4.9. > There are some important fixes we'd like to have. See the linked JIRAs. > Another critical fix is ZOOKEEPER-2146, which can be explored maliciously. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18746) Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot fails
[
https://issues.apache.org/jira/browse/HBASE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152156#comment-16152156
]
Chia-Ping Tsai commented on HBASE-18746:
+1
> Throw exception with job.getStatus().getFailureInfo() when ExportSnapshot
> fails
> ---
>
> Key: HBASE-18746
> URL: https://issues.apache.org/jira/browse/HBASE-18746
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce, snapshots
>Reporter: Chia-Ping Tsai
>Assignee: ChunHao
>Priority: Minor
> Labels: beginner
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 2.0.0-alpha-3
>
> Attachments: HBASE-18746.branch-2.v0.patch,
> HBASE-18746.branch-2.v1.patch
>
>
> {code}
> // Run the MR Job
> if (!job.waitForCompletion(true)) {
> // TODO: Replace the fixed string with job.getStatus().getFailureInfo()
> // when it will be available on all the supported versions.
> throw new ExportSnapshotException("Copy Files Map-Reduce Job failed");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
