[GitHub] [hbase] Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-22 Thread GitBox
Apache-HBase commented on issue #526: HBASE-22895 Fix the flakey TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526#issuecomment-524181086
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 43 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 9 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 349 | master passed |
   | +1 | compile | 58 | master passed |
   | +1 | checkstyle | 80 | master passed |
   | +1 | shadedjars | 293 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 36 | master passed |
   | 0 | spotbugs | 264 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 262 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 327 | the patch passed |
   | +1 | compile | 56 | the patch passed |
   | +1 | javac | 56 | the patch passed |
   | -1 | checkstyle | 77 | hbase-server: The patch generated 10 new + 0 
unchanged - 3 fixed = 10 total (was 3) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | -1 | shadedjars | 227 | patch has 10 errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1037 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 40 | the patch passed |
   | +1 | findbugs | 293 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 9027 | hbase-server in the patch passed. |
   | -1 | asflicense | 29 | The patch generated 1 ASF License warnings. |
   | | | 12645 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/526 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux c19b22b7d379 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-526/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/1/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | shadedjars | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/1/artifact/out/patch-shadedjars.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/1/testReport/
 |
   | asflicense | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/1/artifact/out/patch-asflicense-problems.txt
 |
   | Max. process+thread count | 4456 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-526/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913938#comment-16913938
 ] 

Hudson commented on HBASE-22601:


Results for branch branch-1.3
[build #933 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/933/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/933//General_Nightly_Build_Report/]


(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/933//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/933//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Misconfigured addition of peers leads to cluster shutdown.
> --
>
> Key: HBASE-22601
> URL: https://issues.apache.org/jira/browse/HBASE-22601
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.2
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> Recently we added a peer to a production cluster which were in different 
> kerberos realm.
> *Steps to reproduce:*
>  1. Add a misconfigured peer which is in different kerberos realm.
>  2. Remove that peer.
>  3. All region servers will start to crash.
> *RCA*
>  Enabled trace logging on one Region server for a short amount of time.
>  After adding peer, saw the following log lines.
> {noformat}
> 2019-06-18 22:19:20,949 INFO  [main-EventThread] 
> replication.ReplicationTrackerZKImpl - /hbase/replication/peers znode 
> expired, triggering peerListChanged event
> 2019-06-18 22:19:20,992 INFO  [main-EventThread] 
> replication.ReplicationPeersZKImpl - Added new peer 
> cluster=:/hbase
> 2019-06-18 22:19:21,113 INFO  [main-EventThread] 
> zookeeper.RecoverableZooKeeper - Process identifier=hconnection-0x794a56d6 
> connecting to ZooKeeper ensemble=
> 2019-06-18 22:20:01,280 WARN  [main-EventThread] zookeeper.ZKUtil - 
> hconnection-0x794a56d6-0x16b56265fbebb1b, quorum=, 
> baseZNode=/hbase Unable to set watcher on znode (/hbase/hbaseid)
> org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = 
> AuthFailed for /hbase/hbaseid
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:123)
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1102)
> at 
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> at 
> org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:421)
> at 
> org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)
> at 
> org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:105)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:922)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:706)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:638)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at 
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager.createConnection(ConnectionManager.java:432)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager.createConnectionInternal(ConnectionManager.java:341)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager.createConnection(HConnectionManager.java:144)
> at 
> org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.init(HBaseInterClusterReplicationEndpoint.java:135)
> at 
> com.salesforce.hbase.replication.TenantReplicationEndpoint.init(TenantReplicationEndpoint.java:30)
> at 
> 

[jira] [Commented] (HBASE-22898) [DOC] HBaseContext doesn't have hBaseRDD method

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913934#comment-16913934
 ] 

Hudson commented on HBASE-22898:


Results for branch master
[build #1354 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1354/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> [DOC] HBaseContext doesn't have hBaseRDD method
> ---
>
> Key: HBASE-22898
> URL: https://issues.apache.org/jira/browse/HBASE-22898
> Project: HBase
>  Issue Type: Task
>Reporter: Itsuki Toyota
>Assignee: Itsuki Toyota
>Priority: Trivial
> Fix For: 3.0.0
>
>
> The section of _108. Basic Spark_ contains typo.
> _HBaseContext_ doesn't have _hBaseRDD_ method; it has +hbaseRDD+ method.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913933#comment-16913933
 ] 

Hudson commented on HBASE-22891:


Results for branch master
[build #1354 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1354/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913932#comment-16913932
 ] 

Hudson commented on HBASE-22867:


Results for branch master
[build #1354 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1354/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1354//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: 191318.stack, 191318.stack.1, 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22802) Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-22 Thread chenxu (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenxu updated HBASE-22802:
---
Attachment: HBASE-22802-master-v1.patch

> Avoid temp ByteBuffer allocation in FileIOEngine#read
> -
>
> Key: HBASE-22802
> URL: https://issues.apache.org/jira/browse/HBASE-22802
> Project: HBase
>  Issue Type: Improvement
>  Components: BucketCache
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Attachments: HBASE-22802-master-v1.patch, profile_mem_alloc.png, 
> profile_mem_alloc_with_pool.png
>
>
> a temp ByteBuffer was allocated each time FileIOEngine#read was called
> {code:java}
> public Cacheable read(BucketEntry be) throws IOException {
>   long offset = be.offset();
>   int length = be.getLength();
>   Preconditions.checkArgument(length >= 0, "Length of read can not be less 
> than 0.");
>   ByteBuffer dstBuffer = ByteBuffer.allocate(length);
>   ...
> }
> {code}
> we can avoid this by use of ByteBuffAllocator#allocate(length) after 
> HBASE-21879



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22802) Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-22 Thread chenxu (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chenxu updated HBASE-22802:
---
Status: Patch Available  (was: Open)

> Avoid temp ByteBuffer allocation in FileIOEngine#read
> -
>
> Key: HBASE-22802
> URL: https://issues.apache.org/jira/browse/HBASE-22802
> Project: HBase
>  Issue Type: Improvement
>  Components: BucketCache
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
> Attachments: HBASE-22802-master-v1.patch, profile_mem_alloc.png, 
> profile_mem_alloc_with_pool.png
>
>
> a temp ByteBuffer was allocated each time FileIOEngine#read was called
> {code:java}
> public Cacheable read(BucketEntry be) throws IOException {
>   long offset = be.offset();
>   int length = be.getLength();
>   Preconditions.checkArgument(length >= 0, "Length of read can not be less 
> than 0.");
>   ByteBuffer dstBuffer = ByteBuffer.allocate(length);
>   ...
> }
> {code}
> we can avoid this by use of ByteBuffAllocator#allocate(length) after 
> HBASE-21879



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913920#comment-16913920
 ] 

Hudson commented on HBASE-22867:


Results for branch branch-2
[build #2185 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: 191318.stack, 191318.stack.1, 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913921#comment-16913921
 ] 

Hudson commented on HBASE-22891:


Results for branch branch-2
[build #2185 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2185//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] ZhaoBQ opened a new pull request #528: HBASE 22890 Verify the files when RegionServer is starting and BucketCache is in file mode

2019-08-22 Thread GitBox
ZhaoBQ opened a new pull request #528: HBASE 22890 Verify the files when 
RegionServer is starting and BucketCache is in file mode
URL: https://github.com/apache/hbase/pull/528
 
 
   [HBASE 22890](https://issues.apache.org/jira/browse/HBASE-22890?filter=-2)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913912#comment-16913912
 ] 

Hudson commented on HBASE-22891:


Results for branch branch-2.1
[build #1511 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1511/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1511//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1511//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1511//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22890) Verify the files when RegionServer is starting and BucketCache is in file mode

2019-08-22 Thread Zhao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhao updated HBASE-22890:
-
Summary: Verify the files when RegionServer is starting and BucketCache is 
in file mode  (was: Verify the files when RegionServer is started and 
BucketCache is in file mode)

> Verify the files when RegionServer is starting and BucketCache is in file mode
> --
>
> Key: HBASE-22890
> URL: https://issues.apache.org/jira/browse/HBASE-22890
> Project: HBase
>  Issue Type: Bug
>  Components: BucketCache
>Affects Versions: 1.4.6, 1.4.10, 1.3.5
>Reporter: Zhao
>Priority: Major
> Attachments: HBASE-22890.branch-1.0001.patch
>
>
> We use FileIOEngine in BucketCache and have configured 
> .  If the RegionServer is stopped, and the 
> cache data file or the backingMap persistence file is deleted or changed 
> before the RegionServer is restarted. When restart RegionServer, the 
> backingMap and cache data are Inconsistent, and get or scan command will get 
> IOException like follows:
> bucket.BucketCache: Failed reading block 
> 18951416e2ca4e8bbc11523f4f5ea576_1125745279 from bucket cache
>  java.io.IOException: Invalid HFile block magic: 
> \x00\x00\x00\x00\x00\x00\x00\x00
>  at org.apache.hadoop.hbase.io.hfile.BlockType.parse(BlockType.java:154)
>  at org.apache.hadoop.hbase.io.hfile.BlockType.read(BlockType.java:167)
>  at org.apache.hadoop.hbase.io.hfile.HFileBlock.(HFileBlock.java:347)
>  at 
> org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:247)
>  at 
> org.apache.hadoop.hbase.io.hfile.HFileBlock$1.deserialize(HFileBlock.java:226)
>  at 
> org.apache.hadoop.hbase.io.hfile.bucket.BucketCache.getBlock(BucketCache.java:514)
> ..



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913908#comment-16913908
 ] 

Hudson commented on HBASE-22514:


Results for branch HBASE-22514
[build #70 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/70/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/70//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/70//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/70//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
>  Issue Type: Umbrella
>  Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch, 
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public 
> we need to use java api  RSGroupAdminClient  to manager RSG 
> so  RSGroupAdminClient should be public
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913900#comment-16913900
 ] 

Hudson commented on HBASE-22891:


Results for branch branch-1
[build #1023 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1023/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1023//General_Nightly_Build_Report/]


(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1023//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- Something went wrong running this stage, please [check relevant console 
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1023//console].




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913899#comment-16913899
 ] 

Hudson commented on HBASE-22891:


Results for branch branch-2.2
[build #534 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913898#comment-16913898
 ] 

Hudson commented on HBASE-22867:


Results for branch branch-2.2
[build #534 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/534//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: 191318.stack, 191318.stack.1, 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: HBASE-22894-master-v1.patch
HBASE-22894-branch-2.2-v1.patch
HBASE-22894-branch-2.1-v1.patch
HBASE-22894-branch-2-v1.patch

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-branch-2-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-master-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-branch-2.1-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-branch-2.2-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: HBASE-22894-master-v1.patch
HBASE-22894-branch-2.2-v1.patch
HBASE-22894-branch-2.1-v1.patch
HBASE-22894-branch-2-v1.patch

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-master-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-branch-2.2-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-branch-2-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22894) Move testOpenRegionFailedMemoryLeak to dedicated class

2019-08-22 Thread Bing Xiao (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bing Xiao updated HBASE-22894:
--
Attachment: (was: HBASE-22894-branch-2.1-v1.patch)

> Move testOpenRegionFailedMemoryLeak to dedicated class
> --
>
> Key: HBASE-22894
> URL: https://issues.apache.org/jira/browse/HBASE-22894
> Project: HBase
>  Issue Type: Test
>Affects Versions: 3.0.0, 2.2.1, 2.1.6
>Reporter: Bing Xiao
>Assignee: Bing Xiao
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: HBASE-22894-branch-2-v1.patch, 
> HBASE-22894-branch-2.1-v1.patch, HBASE-22894-branch-2.2-v1.patch, 
> HBASE-22894-master-v1.patch
>
>
> testOpenRegionFailedMemoryLeak in TestHRegion will cause UT run timeout, so 
> move testOpenRegionFailedMemoryLeak to dedicated class



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Reidddddd commented on a change in pull request #504: HBASE-22871 Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
Reidd commented on a change in pull request #504: HBASE-22871 Move the 
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/504#discussion_r316964375
 
 

 ##
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java
 ##
 @@ -53,21 +53,22 @@
 
   @ClassRule
   public static final HBaseClassTestRule CLASS_RULE =
-  HBaseClassTestRule.forClass(TestCleanerChore.class);
 
 Review comment:
   Try avoiding this unnecessary change.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Reidddddd commented on a change in pull request #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
Reidd commented on a change in pull request #527: HBASE-22880 Move the 
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r316963513
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/DirScanPool.java
 ##
 @@ -0,0 +1,110 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.master.cleaner;
+
+import java.util.concurrent.ForkJoinPool;
+import java.util.concurrent.ForkJoinTask;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.classification.InterfaceAudience;
+import org.apache.hadoop.hbase.conf.ConfigurationObserver;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * The thread pool used for scan directories
+ */
+@InterfaceAudience.Private
+public class DirScanPool implements ConfigurationObserver {
+private static final Logger LOG = 
LoggerFactory.getLogger(DirScanPool.class);
+private volatile int size;
+private ForkJoinPool pool;
+private int cleanerLatch;
+private boolean reconfigNotification;
+
+public DirScanPool(Configuration conf) {
+String poolSize = conf.get(CleanerChore.CHORE_POOL_SIZE, 
CleanerChore.DEFAULT_CHORE_POOL_SIZE);
+size = CleanerChore.calculatePoolSize(poolSize);
+// poolSize may be 0 or 0.0 from a careless configuration,
+// double check to make sure.
+size = size == 0 ? 
CleanerChore.calculatePoolSize(CleanerChore.DEFAULT_CHORE_POOL_SIZE) : size;
+pool = new ForkJoinPool(size);
+LOG.info("Cleaner pool size is {}", size);
+cleanerLatch = 0;
+}
+
+/**
+ * Checks if pool can be updated. If so, mark for update later.
+ * @param conf configuration
+ */
+@Override
+public synchronized void onConfigurationChange(Configuration conf) {
+int newSize = CleanerChore.calculatePoolSize(
+conf.get(CleanerChore.CHORE_POOL_SIZE, 
CleanerChore.DEFAULT_CHORE_POOL_SIZE));
 
 Review comment:
   Ditto, indents style.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Reidddddd commented on a change in pull request #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
Reidd commented on a change in pull request #527: HBASE-22880 Move the 
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r316963285
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
 ##
 @@ -156,22 +73,9 @@ synchronized void shutDownNow() {
   protected Map params;
   private AtomicBoolean enabled = new AtomicBoolean(true);
 
-  public static void initChorePool(Configuration conf) {
-if (POOL == null) {
-  POOL = new DirScanPool(conf);
-}
-  }
-
-  public static void shutDownChorePool() {
-if (POOL != null) {
-  POOL.shutDownNow();
-  POOL = null;
-}
-  }
-
   public CleanerChore(String name, final int sleepPeriod, final Stoppable s, 
Configuration conf,
-  FileSystem fs, Path oldFileDir, String confKey) {
-this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey, null);
+  FileSystem fs, Path oldFileDir, String confKey, 
DirScanPool pool) {
+this(name, sleepPeriod, s, conf, fs, oldFileDir, confKey,pool, null);
 
 Review comment:
   nit, space between `,pool`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Reidddddd commented on a change in pull request #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
Reidd commented on a change in pull request #527: HBASE-22880 Move the 
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r316963162
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 ##
 @@ -1237,22 +1239,18 @@ private void startServiceThreads() throws IOException {
this.service.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS, 1);
startProcedureExecutor();
 
-// Initial cleaner chore
-CleanerChore.initChorePool(conf);
-   // Start log cleaner thread
-   int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 60 * 
1000);
-   this.logCleaner =
-  new LogCleaner(cleanerInterval,
- this, conf, getMasterFileSystem().getOldLogDir().getFileSystem(conf),
- getMasterFileSystem().getOldLogDir());
-getChoreService().scheduleChore(logCleaner);
-
+// Create cleaner thread pool
+cleanerPool = new DirScanPool(conf);
+// Start log cleaner thread
+int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 600 * 
1000);
+this.logCleaner = new LogCleaner(cleanerInterval, this, conf,
+getMasterFileSystem().getOldLogDir().getFileSystem(conf), 
getMasterFileSystem().getOldLogDir(), cleanerPool);
//start the hfile archive cleaner thread
 Path archiveDir = HFileArchiveUtil.getArchivePath(conf);
 Map params = new HashMap();
 params.put(MASTER, this);
 this.hfileCleaner = new HFileCleaner(cleanerInterval, this, conf, 
getMasterFileSystem()
-.getFileSystem(), archiveDir, params);
+.getFileSystem(), archiveDir, cleanerPool, params);
 
 Review comment:
   nit, usually don't start with '.'


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Reidddddd commented on a change in pull request #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
Reidd commented on a change in pull request #527: HBASE-22880 Move the 
DirScanPool out and do not use static field
URL: https://github.com/apache/hbase/pull/527#discussion_r316963014
 
 

 ##
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
 ##
 @@ -1237,22 +1239,18 @@ private void startServiceThreads() throws IOException {
this.service.startExecutorService(ExecutorType.MASTER_TABLE_OPERATIONS, 1);
startProcedureExecutor();
 
-// Initial cleaner chore
-CleanerChore.initChorePool(conf);
-   // Start log cleaner thread
-   int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 60 * 
1000);
-   this.logCleaner =
-  new LogCleaner(cleanerInterval,
- this, conf, getMasterFileSystem().getOldLogDir().getFileSystem(conf),
- getMasterFileSystem().getOldLogDir());
-getChoreService().scheduleChore(logCleaner);
-
+// Create cleaner thread pool
+cleanerPool = new DirScanPool(conf);
+// Start log cleaner thread
+int cleanerInterval = conf.getInt("hbase.master.cleaner.interval", 600 * 
1000);
+this.logCleaner = new LogCleaner(cleanerInterval, this, conf,
+getMasterFileSystem().getOldLogDir().getFileSystem(conf), 
getMasterFileSystem().getOldLogDir(), cleanerPool);
 
 Review comment:
   nit: two indents


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ZhaoBQ opened a new pull request #527: HBASE-22880 Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
ZhaoBQ opened a new pull request #527: HBASE-22880 Move the DirScanPool out and 
do not use static field
URL: https://github.com/apache/hbase/pull/527
 
 
   [HBASE-22880](https://issues.apache.org/jira/browse/HBASE-22880)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] ZhaoBQ closed pull request #523: [HBASE-22880] Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
ZhaoBQ closed pull request #523: [HBASE-22880] Move the DirScanPool out and do 
not use static field
URL: https://github.com/apache/hbase/pull/523
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop

2019-08-22 Thread GitBox
Apache-HBase commented on issue #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#issuecomment-524155376
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 107 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 2 | No case conflicting files found. |
   | 0 | shelldocs | 2 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 22 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 44 | Maven dependency ordering for branch |
   | +1 | mvninstall | 440 | master passed |
   | +1 | compile | 198 | master passed |
   | +1 | checkstyle | 177 | master passed |
   | +1 | shadedjars | 314 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 192 | master passed |
   | 0 | spotbugs | 31 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | 0 | findbugs | 31 | branch/hbase-assembly no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 328 | the patch passed |
   | +1 | compile | 182 | the patch passed |
   | +1 | javac | 182 | the patch passed |
   | +1 | checkstyle | 160 | the patch passed |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 4 | The patch has no ill-formed XML file. |
   | +1 | shadedjars | 295 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 994 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 198 | the patch passed |
   | 0 | findbugs | 38 | hbase-assembly has no data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 17285 | root in the patch failed. |
   | +1 | asflicense | 112 | The patch does not generate ASF License warnings. |
   | | | 23560 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
   |   | hadoop.hbase.client.TestFromClientSide3 |
   |   | hadoop.hbase.master.TestMasterShutdown |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/42/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/476 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle |
   | uname | Linux c60c78301f49 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 
08:28:49 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/42/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/42/testReport/
 |
   | Max. process+thread count | 5001 (vs. ulimit of 1) |
   | modules | C: hbase-hbtop . hbase-assembly U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/42/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446#issuecomment-524154660
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 92 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 485 | master passed |
   | +1 | compile | 77 | master passed |
   | +1 | checkstyle | 106 | master passed |
   | +1 | shadedjars | 399 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 46 | master passed |
   | 0 | spotbugs | 326 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 323 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 401 | the patch passed |
   | +1 | compile | 71 | the patch passed |
   | +1 | javac | 71 | the patch passed |
   | +1 | checkstyle | 97 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 366 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1240 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 44 | the patch passed |
   | +1 | findbugs | 344 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 18660 | hbase-server in the patch failed. |
   | +1 | asflicense | 46 | The patch does not generate ASF License warnings. |
   | | | 23284 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/69/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/446 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 625b7db2c335 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/69/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/69/testReport/
 |
   | Max. process+thread count | 4652 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/69/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if 
their RSGroup has no highest ve…
URL: https://github.com/apache/hbase/pull/435#issuecomment-524154551
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 76 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 1 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 36 | Maven dependency ordering for branch |
   | +1 | mvninstall | 428 | master passed |
   | +1 | compile | 125 | master passed |
   | +1 | checkstyle | 139 | master passed |
   | +1 | shadedjars | 396 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 86 | master passed |
   | 0 | spotbugs | 299 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 409 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 413 | the patch passed |
   | +1 | compile | 126 | the patch passed |
   | +1 | javac | 126 | the patch passed |
   | -1 | checkstyle | 100 | hbase-server: The patch generated 1 new + 9 
unchanged - 0 fixed = 10 total (was 9) |
   | +1 | shellcheck | 1 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 374 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1256 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 87 | the patch passed |
   | -1 | findbugs | 70 | hbase-common generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 211 | hbase-common in the patch passed. |
   | -1 | unit | 17098 | hbase-server in the patch failed. |
   | +1 | unit | 496 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 82 | The patch does not generate ASF License warnings. |
   | | | 22997 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-common |
   |  |  org.apache.hadoop.hbase.Version.() 
invokes inefficient new String(String) constructor  At Version.java:inefficient 
new String(String) constructor  At Version.java:[line 10] |
   | Failed junit tests | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.master.assignment.TestOpenRegionProcedureHang |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.client.TestFromClientSide3 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/71/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/435 |
   | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc 
unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 0c5fdf39db4b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/71/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/71/artifact/out/new-findbugs-hbase-common.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/71/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/71/testReport/
 |
   | Max. process+thread count | 5031 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server hbase-rsgroup U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/71/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 
findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)

2019-08-22 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-22835:
--
Hadoop Flags: Reviewed
  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError (backport of  HBASE-19863)
> 
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch, 
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch, 
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from 
> the same problem.
>  
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
>  actual hfs offset can be behind, in this case heap.next() is not enough. it 
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key 
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller 
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
>  at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551) 
> at 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150) 
> at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
>  at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
>  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) 
> {code}
> I created a backport patch of -HBASE-19863 and  *HBASE-17958*-.
> Exact same testcase included. And changed StoreScanner due to the difference 
> of codes.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)

2019-08-22 Thread Reid Chan (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913877#comment-16913877
 ] 

Reid Chan commented on HBASE-22835:
---

Pushed to branch-1.3

> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError (backport of  HBASE-19863)
> 
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch, 
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch, 
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from 
> the same problem.
>  
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
>  actual hfs offset can be behind, in this case heap.next() is not enough. it 
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key 
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller 
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
>  at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551) 
> at 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150) 
> at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
>  at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
>  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) 
> {code}
> I created a backport patch of -HBASE-19863 and  *HBASE-17958*-.
> Exact same testcase included. And changed StoreScanner due to the difference 
> of codes.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22835) Scan/Get with setColumn and the store with ROWCOL bloom filter could throw AssertionError (backport of HBASE-19863)

2019-08-22 Thread Reid Chan (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Reid Chan updated HBASE-22835:
--
Component/s: Scanners

> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError (backport of  HBASE-19863)
> 
>
> Key: HBASE-22835
> URL: https://issues.apache.org/jira/browse/HBASE-22835
> Project: HBase
>  Issue Type: Bug
>  Components: Scanners
>Affects Versions: 1.3.5
>Reporter: Jeongmin Kim
>Priority: Major
> Fix For: 1.3.6
>
> Attachments: HBASE-22835.branch-1.3.patch, 
> HBASE-22835.v2.branch-1.3.patch, HBASE-22835.v3.branch-1.3.patch, 
> HBASE-22835.v4.branch-1.3.patch
>
>
> Scan/Get with setColumn and the store with ROWCOL bloom filter could throw 
> AssertionError of scan order check.
> which is resolved by HBASE-19863 for 1.4, 2.x, or later version.
> A same bug exists in branch 1.3 and older, and also my cluster suffered from 
> the same problem.
>  
> When ROWCOL bloomFilter is enabled and fake cell is the prevCell,
>  actual hfs offset can be behind, in this case heap.next() is not enough. it 
> requires reseek to find right next cell.
> {code:java}
> java.lang.AssertionError: Key 
> key167/0:C09/OLDEST_TIMESTAMP/Minimum/vlen=0/seqid=0 followed by a smaller 
> key key167/0:C04/1565596231736/Put/vlen=3/seqid=4 in cf 0 at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.checkScanOrder(StoreScanner.java:969)
>  at 
> org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:551) 
> at 
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:150) 
> at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:6144)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:6307)
>  at 
> org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:6081)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2755)
>  at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2957)
>  at 
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:35072)
>  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2394) at 
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:188) at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:168) 
> {code}
> I created a backport patch of -HBASE-19863 and  *HBASE-17958*-.
> Exact same testcase included. And changed StoreScanner due to the difference 
> of codes.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Reidddddd merged pull request #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…

2019-08-22 Thread GitBox
Reidd merged pull request #484: HBASE-22835 Scan/Get with setColumn and the 
store with ROWCOL bloom f…
URL: https://github.com/apache/hbase/pull/484
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2019-08-22 Thread GitBox
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 
(TinyLFU-based BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#issuecomment-524151075
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 115 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | -1 | hbaseanti | 0 |  The patch appears use Hadoop classification instead 
of HBase. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ branch-1 Compile Tests _ |
   | 0 | mvndep | 369 | Maven dependency ordering for branch |
   | +1 | mvninstall | 240 | branch-1 passed |
   | +1 | compile | 141 | branch-1 passed |
   | +1 | checkstyle | 588 | branch-1 passed |
   | 0 | refguide | 242 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   | -1 | shadedjars | 17 | branch has 10 errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 240 | branch-1 passed |
   | 0 | spotbugs | 566 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 18 | branch/hbase-resource-bundle no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 140 | the patch passed |
   | +1 | compile | 136 | the patch passed |
   | +1 | javac | 136 | the patch passed |
   | +1 | checkstyle | 10 | The patch passed checkstyle in 
hbase-resource-bundle |
   | +1 | checkstyle | 31 | The patch passed checkstyle in hbase-common |
   | +1 | checkstyle | 114 | hbase-server: The patch generated 0 new + 83 
unchanged - 11 fixed = 83 total (was 94) |
   | -1 | checkstyle | 12 | hbase-tinylfu-blockcache: The patch generated 1 new 
+ 0 unchanged - 0 fixed = 1 total (was 0) |
   | -1 | checkstyle | 385 | root: The patch generated 1 new + 92 unchanged - 
11 fixed = 93 total (was 103) |
   | +1 | checkstyle | 31 | The patch passed checkstyle in hbase-it |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | xml | 8 | The patch has no ill-formed XML file. |
   | 0 | refguide | 204 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   | -1 | shadedjars | 15 | patch has 10 errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 343 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2. |
   | +1 | javadoc | 275 | the patch passed |
   | 0 | findbugs | 11 | hbase-resource-bundle has no data from findbugs |
   ||| _ Other Tests _ |
   | -1 | unit | 10255 | root in the patch failed. |
   | +1 | asflicense | 158 | The patch does not generate ASF License warnings. |
   | | | 16118 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.util.TestHBaseFsck |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/251 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml |
   | uname | Linux 4a6f01127b0b 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-251/out/precommit/personality/provided.sh
 |
   | git revision | branch-1 / bb87e3a |
   | Default Java | 1.8.0_222 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/branch-site/book.html
 |
   | shadedjars | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/branch-shadedjars.txt
 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/diff-checkstyle-hbase-tinylfu-blockcache.txt
 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/diff-checkstyle-root.txt
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/patch-site/book.html
 |
   | shadedjars | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/patch-shadedjars.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/artifact/out/patch-unit-root.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/8/testReport/
 |
   | Max. process+thread count | 4322 (vs. ulimit of 1) |
   | modules | C: 

[jira] [Commented] (HBASE-22814) Insufficient set up in TestSecureWALReplay because of test fixture inheritance

2019-08-22 Thread fan jingling (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913865#comment-16913865
 ] 

fan jingling commented on HBASE-22814:
--

thanks for reporting,could u submit a pull request to fix this issue?

> Insufficient set up in TestSecureWALReplay  because of test fixture 
> inheritance
> ---
>
> Key: HBASE-22814
> URL: https://issues.apache.org/jira/browse/HBASE-22814
> Project: HBase
>  Issue Type: Test
>  Components: regionserver
>Affects Versions: 2.1.5
>Reporter: zi peng
>Priority: Minor
>  Labels: test
>
> Description: 
> In _TestSecureWALReplay.java,_ it does not call the test fixture method from 
> the base class _TestWALReplay.java_ while the test fixture in the all other 
> sibling test cases do (e.g., _TestWALReplayBoundedLogWriterCreation.java_)
> Suggestion:
> should call *TestWALReplay.setUpBeforeClass()* in @BeforeClass
> or use test utilities to remove dependencies of the tests.
> {code:java}
> public class TestSecureWALReplay extends TestWALReplay {
> @BeforeClass
> public static void setUpBeforeClass() throws Exception {
>   Configuration conf = AbstractTestWALReplay.TEST_UTIL.getConfiguration();
>   conf.set(HConstants.CRYPTO_KEYPROVIDER_CONF_KEY, 
> KeyProviderForTesting.class.getName());
>   conf.set(HConstants.CRYPTO_MASTERKEY_NAME_CONF_KEY, "hbase");
>   conf.setClass("hbase.regionserver.hlog.reader.impl", 
> SecureProtobufLogReader.class,
>   Reader.class);
>   conf.setClass("hbase.regionserver.hlog.writer.impl", 
> SecureProtobufLogWriter.class,
>   Writer.class);
>   conf.setBoolean(HConstants.ENABLE_WAL_ENCRYPTION, true);
>   AbstractTestWALReplay.setUpBeforeClass();
> }
> }{code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-524148825
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 55 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 37 | Maven dependency ordering for branch |
   | +1 | mvninstall | 398 | master passed |
   | +1 | compile | 100 | master passed |
   | +1 | checkstyle | 130 | master passed |
   | +1 | shadedjars | 351 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 70 | master passed |
   | 0 | spotbugs | 329 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 412 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 19 | Maven dependency ordering for patch |
   | +1 | mvninstall | 380 | the patch passed |
   | +1 | compile | 100 | the patch passed |
   | +1 | javac | 100 | the patch passed |
   | +1 | checkstyle | 134 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 357 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1170 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 68 | the patch passed |
   | +1 | findbugs | 428 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 127 | hbase-client in the patch passed. |
   | -1 | unit | 16108 | hbase-server in the patch failed. |
   | +1 | asflicense | 54 | The patch does not generate ASF License warnings. |
   | | | 20975 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/125/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 3c3da38c8b11 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/125/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/125/testReport/
 |
   | Max. process+thread count | 4795 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/125/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-22 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods 
from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/477#issuecomment-524148440
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 46 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 352 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 86 | master passed |
   | +1 | shadedjars | 292 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 34 | master passed |
   | 0 | spotbugs | 257 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 255 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 335 | the patch passed |
   | +1 | compile | 59 | the patch passed |
   | +1 | javac | 59 | the patch passed |
   | +1 | checkstyle | 83 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 289 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 974 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 36 | the patch passed |
   | +1 | findbugs | 249 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 17771 | hbase-server in the patch failed. |
   | -1 | asflicense | 25 | The patch generated 30 ASF License warnings. |
   | | | 21302 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports |
   |   | hadoop.hbase.client.TestTableFavoredNodes |
   |   | hadoop.hbase.client.TestAsyncProcedureAdminApi |
   |   | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
   |   | 
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL 
|
   |   | hadoop.hbase.regionserver.TestFSErrorsExposed |
   |   | hadoop.hbase.regionserver.TestIsDeleteFailure |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientCloneLinksAfterDelete |
   |   | hadoop.hbase.replication.TestReplicationKillMasterRSCompressed |
   |   | hadoop.hbase.client.TestAsyncTableLocateRegionForDeletedTable |
   |   | hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
   |   | hadoop.hbase.master.TestMasterRepairMode |
   |   | hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
   |   | hadoop.hbase.client.TestAsyncAdminMasterSwitch |
   |   | hadoop.hbase.replication.TestReplicationDroppedTables |
   |   | hadoop.hbase.TestNamespace |
   |   | hadoop.hbase.master.procedure.TestCreateTableProcedure |
   |   | hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor |
   |   | hadoop.hbase.regionserver.TestDeleteMobTable |
   |   | hadoop.hbase.client.TestInvalidMutationDurabilityException |
   |   | hadoop.hbase.client.TestGetProcedureResult |
   |   | hadoop.hbase.master.TestCatalogJanitorInMemoryStates |
   |   | hadoop.hbase.client.TestRawAsyncTableLimitedScanWithFilter |
   |   | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
   |   | hadoop.hbase.master.balancer.TestBalancerStatusTagInJMXMetrics |
   |   | hadoop.hbase.snapshot.TestSnapshotWhenChoreCleaning |
   |   | hadoop.hbase.TestJMXListener |
   |   | hadoop.hbase.regionserver.TestRemoveRegionMetrics |
   |   | hadoop.hbase.client.TestIncrementsFromClientSide |
   |   | hadoop.hbase.quotas.TestQuotaAdmin |
   |   | 
hadoop.hbase.replication.TestReplicationStatusSourceStartedTargetStoppedNoOps |
   |   | hadoop.hbase.master.TestRetainAssignmentOnRestart |
   |   | hadoop.hbase.client.TestMvccConsistentScanner |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.master.procedure.TestSCPWithMeta |
   |   | hadoop.hbase.mob.TestDefaultMobStoreFlusher |
   |   | hadoop.hbase.mob.compactions.TestMobCompactor |
   |   | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
   |   | hadoop.hbase.replication.TestReplicationKillMasterRS |
   |   | hadoop.hbase.master.assignment.TestReportRegionStateTransitionRetry |
   |   | hadoop.hbase.master.TestMigrateNamespaceTable |
   |   | hadoop.hbase.master.procedure.TestSCPWithMetaWithReplicas |
   |   | hadoop.hbase.client.TestScannersFromClientSide |
   |   | hadoop.hbase.client.TestMobSnapshotFromClient |
   |   | hadoop.hbase.master.TestServerCrashProcedureCarryingMetaStuck |
   |   | hadoop.hbase.wal.TestAsyncFSWALCorruptionDueToDanglingByteBuffer |
   |   | 
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting |
   |   

[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913862#comment-16913862
 ] 

Hudson commented on HBASE-22891:


Results for branch branch-1.3
[build #932 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/932/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/932//General_Nightly_Build_Report/]


(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/932//JDK7_Nightly_Build_Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/932//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913850#comment-16913850
 ] 

Hudson commented on HBASE-22891:


Results for branch branch-1.4
[build #972 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/972/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/972//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/972//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/972//JDK8_Nightly_Build_Report_(Hadoop2)/]




(/) {color:green}+1 source release artifact{color}
-- See build output for details.


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913844#comment-16913844
 ] 

Hudson commented on HBASE-22601:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #625 (See 
[https://builds.apache.org/job/HBase-1.3-IT/625/])
[HBASE-22601] Misconfigured addition of peers leads to cluster shutdown. 
(apurtell: rev 6a0c26fff139f75fc1fcab706aa0fe4afa9e9792)
* (edit) 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java


> Misconfigured addition of peers leads to cluster shutdown.
> --
>
> Key: HBASE-22601
> URL: https://issues.apache.org/jira/browse/HBASE-22601
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.2
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> Recently we added a peer to a production cluster which were in different 
> kerberos realm.
> *Steps to reproduce:*
>  1. Add a misconfigured peer which is in different kerberos realm.
>  2. Remove that peer.
>  3. All region servers will start to crash.
> *RCA*
>  Enabled trace logging on one Region server for a short amount of time.
>  After adding peer, saw the following log lines.
> {noformat}
> 2019-06-18 22:19:20,949 INFO  [main-EventThread] 
> replication.ReplicationTrackerZKImpl - /hbase/replication/peers znode 
> expired, triggering peerListChanged event
> 2019-06-18 22:19:20,992 INFO  [main-EventThread] 
> replication.ReplicationPeersZKImpl - Added new peer 
> cluster=:/hbase
> 2019-06-18 22:19:21,113 INFO  [main-EventThread] 
> zookeeper.RecoverableZooKeeper - Process identifier=hconnection-0x794a56d6 
> connecting to ZooKeeper ensemble=
> 2019-06-18 22:20:01,280 WARN  [main-EventThread] zookeeper.ZKUtil - 
> hconnection-0x794a56d6-0x16b56265fbebb1b, quorum=, 
> baseZNode=/hbase Unable to set watcher on znode (/hbase/hbaseid)
> org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = 
> AuthFailed for /hbase/hbaseid
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:123)
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1102)
> at 
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> at 
> org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:421)
> at 
> org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)
> at 
> org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:105)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:922)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:706)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:638)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at 
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager.createConnection(ConnectionManager.java:432)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager.createConnectionInternal(ConnectionManager.java:341)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager.createConnection(HConnectionManager.java:144)
> at 
> org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.init(HBaseInterClusterReplicationEndpoint.java:135)
> at 
> com.salesforce.hbase.replication.TenantReplicationEndpoint.init(TenantReplicationEndpoint.java:30)
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.getReplicationSource(ReplicationSourceManager.java:517)
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.addSource(ReplicationSourceManager.java:273)
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.peerListChanged(ReplicationSourceManager.java:635)
> at 
> org.apache.hadoop.hbase.replication.ReplicationTrackerZKImpl$PeersWatcher.nodeChildrenChanged(ReplicationTrackerZKImpl.java:192)
> at 
> 

[GitHub] [hbase] jatsakthi opened a new pull request #526: HBASE-22895 Fix the flakey TestSpaceQuotas

2019-08-22 Thread GitBox
jatsakthi opened a new pull request #526: HBASE-22895 Fix the flakey 
TestSpaceQuotas
URL: https://github.com/apache/hbase/pull/526
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation

2019-08-22 Thread GitBox
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods 
from Mutation
URL: https://github.com/apache/hbase/pull/478#issuecomment-524128042
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 49 | Maven dependency ordering for branch |
   | +1 | mvninstall | 356 | master passed |
   | +1 | compile | 91 | master passed |
   | +1 | checkstyle | 126 | master passed |
   | +1 | shadedjars | 316 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 60 | master passed |
   | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 343 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 335 | the patch passed |
   | +1 | compile | 95 | the patch passed |
   | +1 | javac | 95 | the patch passed |
   | +1 | checkstyle | 133 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 340 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1076 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 58 | the patch passed |
   | +1 | findbugs | 349 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 107 | hbase-client in the patch passed. |
   | +1 | unit | 9979 | hbase-server in the patch passed. |
   | +1 | asflicense | 46 | The patch does not generate ASF License warnings. |
   | | | 14331 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/37/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/478 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 7e3f3339e4ff 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/37/testReport/
 |
   | Max. process+thread count | 4457 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/37/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Assigned] (HBASE-22902) At regionserver start there's a request to roll the WAL

2019-08-22 Thread Andrew Purtell (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell reassigned HBASE-22902:
--

Assignee: Andrew Purtell

> At regionserver start there's a request to roll the WAL
> ---
>
> Key: HBASE-22902
> URL: https://issues.apache.org/jira/browse/HBASE-22902
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 3.0.0, 1.5.0, 2.3.0
>Reporter: David Manning
>Assignee: Andrew Purtell
>Priority: Minor
>
> See HBASE-22301 for logic that requests to roll the WAL if regionserver 
> encounters a slow write pipeline. In the logs, during regionserver start, I 
> see that the WAL is requested to roll once. It's strange that we roll the WAL 
> because it wasn't a slow sync. It appears when this code executes, we haven't 
> initialized the {{rollOnSyncNs}} variable to use for determining whether it's 
> a slow sync. Current pipeline also shows empty in the logs.
> Disclaimer: I'm experiencing this after backporting this to 1.3.x and 
> building it there - I haven't attempted in 1.5.x, though I'd expect similar 
> results.
> Regionserver logs follow (notice *threshold=0 ms, current pipeline: []*):
> {noformat}
> Tue Aug 20 23:29:50 GMT 2019 Starting regionserver
> ...
> 2019-08-20 23:29:57,824 INFO  wal.FSHLog - WAL configuration: blocksize=256 
> MB, rollsize=243.20 MB, prefix=[truncated]%2C1566343792434, suffix=, 
> logDir=hdfs://[truncated]/hbase/WALs/[truncated],1566343792434, 
> archiveDir=hdfs://[truncated]/hbase/oldWALs
> 2019-08-20 23:29:58,104 INFO  wal.FSHLog - Slow sync cost: 186 ms, current 
> pipeline: []
> 2019-08-20 23:29:58,104 WARN  wal.FSHLog - Requesting log roll because we 
> exceeded slow sync threshold; time=186 ms, threshold=0 ms, current pipeline: 
> []
> 2019-08-20 23:29:58,107 DEBUG regionserver.ReplicationSourceManager - Start 
> tracking logs for wal group [truncated]%2C1566343792434 for peer 1
> 2019-08-20 23:29:58,107 INFO  wal.FSHLog - New WAL 
> /hbase/WALs/[truncated],1566343792434/[truncated]%2C1566343792434.1566343797824
> 2019-08-20 23:29:58,109 DEBUG regionserver.ReplicationSource - Starting up 
> worker for wal group [truncated]%2C1566343792434{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22902) At regionserver start there's a request to roll the WAL

2019-08-22 Thread Andrew Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913813#comment-16913813
 ] 

Andrew Purtell commented on HBASE-22902:


Looks like an oversight. The extra roll isn't harmful but isn't correct either. 
Let me take this

> At regionserver start there's a request to roll the WAL
> ---
>
> Key: HBASE-22902
> URL: https://issues.apache.org/jira/browse/HBASE-22902
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 3.0.0, 1.5.0, 2.3.0
>Reporter: David Manning
>Assignee: Andrew Purtell
>Priority: Minor
>
> See HBASE-22301 for logic that requests to roll the WAL if regionserver 
> encounters a slow write pipeline. In the logs, during regionserver start, I 
> see that the WAL is requested to roll once. It's strange that we roll the WAL 
> because it wasn't a slow sync. It appears when this code executes, we haven't 
> initialized the {{rollOnSyncNs}} variable to use for determining whether it's 
> a slow sync. Current pipeline also shows empty in the logs.
> Disclaimer: I'm experiencing this after backporting this to 1.3.x and 
> building it there - I haven't attempted in 1.5.x, though I'd expect similar 
> results.
> Regionserver logs follow (notice *threshold=0 ms, current pipeline: []*):
> {noformat}
> Tue Aug 20 23:29:50 GMT 2019 Starting regionserver
> ...
> 2019-08-20 23:29:57,824 INFO  wal.FSHLog - WAL configuration: blocksize=256 
> MB, rollsize=243.20 MB, prefix=[truncated]%2C1566343792434, suffix=, 
> logDir=hdfs://[truncated]/hbase/WALs/[truncated],1566343792434, 
> archiveDir=hdfs://[truncated]/hbase/oldWALs
> 2019-08-20 23:29:58,104 INFO  wal.FSHLog - Slow sync cost: 186 ms, current 
> pipeline: []
> 2019-08-20 23:29:58,104 WARN  wal.FSHLog - Requesting log roll because we 
> exceeded slow sync threshold; time=186 ms, threshold=0 ms, current pipeline: 
> []
> 2019-08-20 23:29:58,107 DEBUG regionserver.ReplicationSourceManager - Start 
> tracking logs for wal group [truncated]%2C1566343792434 for peer 1
> 2019-08-20 23:29:58,107 INFO  wal.FSHLog - New WAL 
> /hbase/WALs/[truncated],1566343792434/[truncated]%2C1566343792434.1566343797824
> 2019-08-20 23:29:58,109 DEBUG regionserver.ReplicationSource - Starting up 
> worker for wal group [truncated]%2C1566343792434{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

2019-08-22 Thread GitBox
Apache-HBase commented on issue #479: HBASE-22802 Avoid temp ByteBuffer 
allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/479#issuecomment-524125413
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 46 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 35 | Maven dependency ordering for branch |
   | +1 | mvninstall | 376 | master passed |
   | +1 | compile | 86 | master passed |
   | +1 | checkstyle | 115 | master passed |
   | +1 | shadedjars | 311 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 65 | master passed |
   | 0 | spotbugs | 306 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 373 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 346 | the patch passed |
   | +1 | compile | 93 | the patch passed |
   | +1 | javac | 93 | the patch passed |
   | +1 | checkstyle | 28 | hbase-common: The patch generated 0 new + 48 
unchanged - 2 fixed = 48 total (was 50) |
   | +1 | checkstyle | 84 | The patch passed checkstyle in hbase-server |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 300 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1051 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | -1 | javadoc | 24 | hbase-common generated 4 new + 0 unchanged - 0 fixed = 
4 total (was 0) |
   | +1 | findbugs | 384 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 185 | hbase-common in the patch passed. |
   | +1 | unit | 9115 | hbase-server in the patch passed. |
   | +1 | asflicense | 45 | The patch does not generate ASF License warnings. |
   | | | 13560 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/41/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/479 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ad921c69500a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-479/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | javadoc | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/41/artifact/out/diff-javadoc-javadoc-hbase-common.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/41/testReport/
 |
   | Max. process+thread count | 4673 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-479/41/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in hbase server implementation

2019-08-22 Thread GitBox
Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in 
hbase server implementation
URL: https://github.com/apache/hbase/pull/512#issuecomment-524124796
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 40 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 63 | Maven dependency ordering for branch |
   | +1 | mvninstall | 368 | master passed |
   | +1 | compile | 96 | master passed |
   | +1 | checkstyle | 106 | master passed |
   | +1 | shadedjars | 309 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 64 | master passed |
   | 0 | spotbugs | 302 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 360 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 19 | Maven dependency ordering for patch |
   | +1 | mvninstall | 376 | the patch passed |
   | +1 | compile | 81 | the patch passed |
   | +1 | javac | 81 | the patch passed |
   | +1 | checkstyle | 113 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 312 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1033 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 63 | the patch passed |
   | +1 | findbugs | 375 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 221 | hbase-common in the patch passed. |
   | +1 | unit | 9075 | hbase-server in the patch passed. |
   | +1 | asflicense | 51 | The patch does not generate ASF License warnings. |
   | | | 13574 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/14/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/512 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 69801d5ae7e0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-512/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/14/testReport/
 |
   | Max. process+thread count | 4742 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/14/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and load classes in client module

2019-08-22 Thread GitBox
Apache-HBase commented on issue #519: HBASE-22744 Removed deprecated status and 
load classes in client module
URL: https://github.com/apache/hbase/pull/519#issuecomment-524123957
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 6 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 36 | Maven dependency ordering for branch |
   | +1 | mvninstall | 318 | master passed |
   | +1 | compile | 121 | master passed |
   | +1 | checkstyle | 137 | master passed |
   | +1 | shadedjars | 274 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 89 | master passed |
   | 0 | spotbugs | 235 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 381 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 299 | the patch passed |
   | +1 | compile | 122 | the patch passed |
   | +1 | javac | 122 | the patch passed |
   | +1 | checkstyle | 32 | hbase-client: The patch generated 0 new + 180 
unchanged - 3 fixed = 180 total (was 183) |
   | +1 | checkstyle | 11 | The patch passed checkstyle in hbase-zookeeper |
   | +1 | checkstyle | 74 | The patch passed checkstyle in hbase-server |
   | +1 | checkstyle | 16 | The patch passed checkstyle in hbase-rest |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 278 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 945 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 86 | the patch passed |
   | +1 | findbugs | 412 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 103 | hbase-client in the patch passed. |
   | +1 | unit | 46 | hbase-zookeeper in the patch passed. |
   | +1 | unit | 8688 | hbase-server in the patch passed. |
   | +1 | unit | 292 | hbase-rest in the patch passed. |
   | +1 | asflicense | 83 | The patch does not generate ASF License warnings. |
   | | | 13300 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/519 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 43c588d1d032 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-519/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/3/testReport/
 |
   | Max. process+thread count | 4525 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-zookeeper hbase-server hbase-rest U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-519/3/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and the store with ROWCOL bloom f…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #484: HBASE-22835 Scan/Get with setColumn and 
the store with ROWCOL bloom f…
URL: https://github.com/apache/hbase/pull/484#issuecomment-524123147
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 48 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ branch-1.3 Compile Tests _ |
   | +1 | mvninstall | 450 | branch-1.3 passed |
   | +1 | compile | 43 | branch-1.3 passed |
   | +1 | checkstyle | 110 | branch-1.3 passed |
   | -1 | shadedjars | 12 | branch has 10 errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 40 | branch-1.3 passed |
   | 0 | spotbugs | 148 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 146 | branch-1.3 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 113 | the patch passed |
   | +1 | compile | 41 | the patch passed |
   | +1 | javac | 41 | the patch passed |
   | +1 | checkstyle | 104 | hbase-server: The patch generated 0 new + 372 
unchanged - 23 fixed = 372 total (was 395) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | -1 | shadedjars | 10 | patch has 10 errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 586 | Patch does not cause any errors with Hadoop 2.4.1 
2.5.2 2.6.5 2.7.7. |
   | +1 | javadoc | 31 | the patch passed |
   | +1 | findbugs | 143 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 6651 | hbase-server in the patch failed. |
   | +1 | asflicense | 28 | The patch does not generate ASF License warnings. |
   | | | 8644 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.trace.TestHTraceHooks |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/484 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 2b6815fa53f6 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-484/out/precommit/personality/provided.sh
 |
   | git revision | branch-1.3 / 6a0c26f |
   | Default Java | 1.8.0_222 |
   | shadedjars | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/branch-shadedjars.txt
 |
   | shadedjars | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/patch-shadedjars.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/testReport/
 |
   | Max. process+thread count | 4246 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-484/17/console |
   | versions | git=1.9.1 maven=3.0.5 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #501: HBASE-22699 refactor isMetaClearingException

2019-08-22 Thread GitBox
Apache-HBase commented on issue #501: HBASE-22699 refactor 
isMetaClearingException
URL: https://github.com/apache/hbase/pull/501#issuecomment-524122540
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 33 | Maven dependency ordering for branch |
   | +1 | mvninstall | 306 | master passed |
   | +1 | compile | 77 | master passed |
   | +1 | checkstyle | 101 | master passed |
   | +1 | shadedjars | 272 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 55 | master passed |
   | 0 | spotbugs | 253 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 320 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 290 | the patch passed |
   | +1 | compile | 75 | the patch passed |
   | +1 | javac | 75 | the patch passed |
   | +1 | checkstyle | 99 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 262 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 896 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 53 | the patch passed |
   | +1 | findbugs | 338 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 103 | hbase-client in the patch passed. |
   | -1 | unit | 8976 | hbase-server in the patch failed. |
   | +1 | asflicense | 44 | The patch does not generate ASF License warnings. |
   | | | 12715 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestMetaCache |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/26/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/501 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux af8ba0f9fc12 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-501/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/26/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/26/testReport/
 |
   | Max. process+thread count | 4317 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-501/26/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp

2019-08-22 Thread GitBox
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in 
table jsp
URL: https://github.com/apache/hbase/pull/510#issuecomment-524122199
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 310 | master passed |
   | +1 | compile | 73 | master passed |
   | +1 | checkstyle | 102 | master passed |
   | +1 | shadedjars | 263 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 52 | master passed |
   | 0 | spotbugs | 249 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 313 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 289 | the patch passed |
   | +1 | compile | 76 | the patch passed |
   | +1 | javac | 76 | the patch passed |
   | +1 | checkstyle | 99 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 265 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 898 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 53 | the patch passed |
   | +1 | findbugs | 336 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 105 | hbase-client in the patch passed. |
   | +1 | unit | 8970 | hbase-server in the patch passed. |
   | +1 | asflicense | 45 | The patch does not generate ASF License warnings. |
   | | | 12711 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/16/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/510 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 6af653fad53e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/16/testReport/
 |
   | Max. process+thread count | 4627 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/16/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts 
of TokenUtil off into a Clien…
URL: https://github.com/apache/hbase/pull/361#issuecomment-524120880
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 74 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 35 | Maven dependency ordering for branch |
   | +1 | mvninstall | 332 | master passed |
   | +1 | compile | 76 | master passed |
   | +1 | checkstyle | 105 | master passed |
   | +1 | shadedjars | 270 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 53 | master passed |
   | 0 | spotbugs | 256 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 322 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 15 | Maven dependency ordering for patch |
   | +1 | mvninstall | 299 | the patch passed |
   | +1 | compile | 77 | the patch passed |
   | +1 | javac | 77 | the patch passed |
   | +1 | checkstyle | 104 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 272 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 925 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 64 | the patch passed |
   | +1 | findbugs | 321 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 107 | hbase-client in the patch passed. |
   | -1 | unit | 17875 | hbase-server in the patch failed. |
   | +1 | asflicense | 52 | The patch does not generate ASF License warnings. |
   | | | 21760 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.replication.TestReplicationKillSlaveRS |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.client.TestFromClientSide3 |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/124/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/361 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 21b625d5a885 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/124/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/124/testReport/
 |
   | Max. process+thread count | 5093 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/124/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory

2019-08-22 Thread GitBox
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot 
will fail if hfile is in archive directory
URL: https://github.com/apache/hbase/pull/509#issuecomment-524120294
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 38 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 323 | master passed |
   | +1 | compile | 53 | master passed |
   | +1 | checkstyle | 73 | master passed |
   | +1 | shadedjars | 268 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 33 | master passed |
   | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 239 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 294 | the patch passed |
   | +1 | compile | 54 | the patch passed |
   | +1 | javac | 54 | the patch passed |
   | +1 | checkstyle | 70 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 266 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 984 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 34 | the patch passed |
   | +1 | findbugs | 270 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 8627 | hbase-server in the patch passed. |
   | +1 | asflicense | 21 | The patch does not generate ASF License warnings. |
   | | | 12024 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/16/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/509 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ac7a3357d2d3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/16/testReport/
 |
   | Max. process+thread count | 4738 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/16/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in hbase server implementation

2019-08-22 Thread GitBox
Apache-HBase commented on issue #512: HBASE-22881 Fix non-daemon threads in 
hbase server implementation
URL: https://github.com/apache/hbase/pull/512#issuecomment-524118455
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 124 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 68 | Maven dependency ordering for branch |
   | +1 | mvninstall | 399 | master passed |
   | +1 | compile | 88 | master passed |
   | +1 | checkstyle | 104 | master passed |
   | +1 | shadedjars | 321 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 61 | master passed |
   | 0 | spotbugs | 254 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 308 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 18 | Maven dependency ordering for patch |
   | +1 | mvninstall | 338 | the patch passed |
   | +1 | compile | 84 | the patch passed |
   | +1 | javac | 84 | the patch passed |
   | +1 | checkstyle | 103 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 325 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1164 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 61 | the patch passed |
   | +1 | findbugs | 336 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 186 | hbase-common in the patch passed. |
   | -1 | unit | 20423 | hbase-server in the patch failed. |
   | +1 | asflicense | 97 | The patch does not generate ASF License warnings. |
   | | | 25047 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | 
hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.replication.TestReplicationSmallTests |
   |   | hadoop.hbase.replication.TestReplicationSmallTestsSync |
   |   | hadoop.hbase.replication.TestReplicationKillSlaveRS |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.master.TestMasterShutdown |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.client.TestFromClientSide3 |
   |   | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/13/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/512 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ca0702f4af0f 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-512/out/precommit/personality/provided.sh
 |
   | git revision | master / 288d1f2769 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/13/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/13/testReport/
 |
   | Max. process+thread count | 4944 (vs. ulimit of 1) |
   | modules | C: hbase-common hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-512/13/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility

2019-08-22 Thread GitBox
Apache-HBase commented on issue #477: HBASE-22834 Removed deprecated methods 
from HBaseTestingUtility
URL: https://github.com/apache/hbase/pull/477#issuecomment-524117722
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 113 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 46 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 358 | master passed |
   | +1 | compile | 54 | master passed |
   | +1 | checkstyle | 81 | master passed |
   | +1 | shadedjars | 281 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 35 | master passed |
   | 0 | spotbugs | 249 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 245 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 317 | the patch passed |
   | +1 | compile | 55 | the patch passed |
   | +1 | javac | 55 | the patch passed |
   | +1 | checkstyle | 78 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 279 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 972 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 34 | the patch passed |
   | +1 | findbugs | 271 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 19517 | hbase-server in the patch failed. |
   | -1 | asflicense | 32 | The patch generated 51 ASF License warnings. |
   | | | 23121 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.master.TestMasterFailover |
   |   | hadoop.hbase.master.TestServerCrashProcedureStuck |
   |   | hadoop.hbase.client.TestSplitOrMergeAtTableLevel |
   |   | hadoop.hbase.client.TestAsyncResultScannerCursor |
   |   | hadoop.hbase.master.assignment.TestWakeUpUnexpectedProcedure |
   |   | hadoop.hbase.client.TestClientScannerRPCTimeout |
   |   | hadoop.hbase.replication.TestSyncReplicationStandBy |
   |   | hadoop.hbase.client.TestMobCloneSnapshotFromClientNormal |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientError |
   |   | hadoop.hbase.regionserver.TestMobStoreScanner |
   |   | 
hadoop.hbase.replication.regionserver.TestRaceWhenCreatingReplicationSource |
   |   | hadoop.hbase.replication.TestReplicationMetricsforUI |
   |   | hadoop.hbase.regionserver.TestRegionReplicas |
   |   | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed |
   |   | hadoop.hbase.client.TestTableFavoredNodes |
   |   | 
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL |
   |   | 
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting |
   |   | hadoop.hbase.quotas.TestSuperUserQuotaPermissions |
   |   | hadoop.hbase.master.assignment.TestSplitTableRegionProcedure |
   |   | hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput |
   |   | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation |
   |   | hadoop.hbase.master.TestClusterRestartSplitWithoutZk |
   |   | hadoop.hbase.client.TestAsyncRegionAdminApi2 |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.wal.TestWALSplitCompressed |
   |   | hadoop.hbase.TestInfoServers |
   |   | hadoop.hbase.replication.TestReplicationSyncUpTool |
   |   | hadoop.hbase.master.replication.TestModifyPeerProcedureRetryBackoff |
   |   | hadoop.hbase.master.procedure.TestSCPWithoutZKCoordinated |
   |   | hadoop.hbase.quotas.TestMasterQuotasObserver |
   |   | hadoop.hbase.master.TestRollingRestart |
   |   | hadoop.hbase.procedure.TestProcedureManager |
   |   | hadoop.hbase.master.TestClusterRestartFailoverSplitWithoutZk |
   |   | hadoop.hbase.TestHBaseOnOtherDfsCluster |
   |   | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
   |   | hadoop.hbase.io.encoding.TestChangingEncoding |
   |   | hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
   |   | hadoop.hbase.replication.TestReplicationEmptyWALRecovery |
   |   | hadoop.hbase.replication.TestReplicationChangingPeerRegionservers |
   |   | hadoop.hbase.master.procedure.TestDeleteTableProcedure |
   |   | hadoop.hbase.replication.TestReplicationWithTags |
   |   | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
   |   | hadoop.hbase.TestGlobalMemStoreSize |
   |   | hadoop.hbase.util.TestRegionSplitter |
   |   | hadoop.hbase.client.TestReplicaWithCluster |
   |   | hadoop.hbase.coprocessor.TestPassCustomCellViaRegionObserver |
   |   | hadoop.hbase.TestHBaseTestingUtility |
   |   | hadoop.hbase.client.TestMobRestoreSnapshotFromClientGetCompactionState 
|
   |   | 

[jira] [Commented] (HBASE-22867) The ForkJoinPool in CleanerChore will spawn thousands of threads in our cluster with thousands table

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913801#comment-16913801
 ] 

Hudson commented on HBASE-22867:


Results for branch branch-2.1
[build #1510 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1510/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1510//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1510//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1510//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> The ForkJoinPool in CleanerChore will spawn thousands of threads in our 
> cluster with thousands table
> 
>
> Key: HBASE-22867
> URL: https://issues.apache.org/jira/browse/HBASE-22867
> Project: HBase
>  Issue Type: Bug
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Critical
> Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6
>
> Attachments: 191318.stack, 191318.stack.1, 31162.stack.1
>
>
> The thousands of spawned  threads make the safepoint cost 80+s in our Master 
> JVM processs.
> {code}
> 2019-08-15,19:35:35,861 INFO [main-SendThread(zjy-hadoop-prc-zk02.bj:11000)] 
> org.apache.zookeeper.ClientCnxn: Client session timed out, have not heard 
> from server in 82260ms for sessionid 0x1691332e2d3aae5, closing socket 
> connection and at
> tempting reconnect
> {code}
> The stdout from JVM (can see from here there're 9126 threads & sync cost 80+s)
> {code}
> vmop[threads: total initially_running wait_to_block]
> [time: spin block sync cleanup vmop] page_trap_count
> 32358.859: ForceAsyncSafepoint  [9126 67
> 474]  [ 128 8659687   101]  0
> {code}
> Also we got the jstack: 
> {code}
> $ cat 31162.stack.1  | grep 'ForkJoinPool-1-worker' | wc -l
> 8648
> {code}
> It's a dangerous bug, make it as blocker.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (HBASE-22902) At regionserver start there's a request to roll the WAL

2019-08-22 Thread David Manning (Jira)
David Manning created HBASE-22902:
-

 Summary: At regionserver start there's a request to roll the WAL
 Key: HBASE-22902
 URL: https://issues.apache.org/jira/browse/HBASE-22902
 Project: HBase
  Issue Type: Bug
  Components: wal
Affects Versions: 3.0.0, 1.5.0, 2.3.0
Reporter: David Manning


See HBASE-22301 for logic that requests to roll the WAL if regionserver 
encounters a slow write pipeline. In the logs, during regionserver start, I see 
that the WAL is requested to roll once. It's strange that we roll the WAL 
because it wasn't a slow sync. It appears when this code executes, we haven't 
initialized the {{rollOnSyncNs}} variable to use for determining whether it's a 
slow sync. Current pipeline also shows empty in the logs.

Disclaimer: I'm experiencing this after backporting this to 1.3.x and building 
it there - I haven't attempted in 1.5.x, though I'd expect similar results.

Regionserver logs follow (notice *threshold=0 ms, current pipeline: []*):
{noformat}
Tue Aug 20 23:29:50 GMT 2019 Starting regionserver
...
2019-08-20 23:29:57,824 INFO  wal.FSHLog - WAL configuration: blocksize=256 MB, 
rollsize=243.20 MB, prefix=[truncated]%2C1566343792434, suffix=, 
logDir=hdfs://[truncated]/hbase/WALs/[truncated],1566343792434, 
archiveDir=hdfs://[truncated]/hbase/oldWALs
2019-08-20 23:29:58,104 INFO  wal.FSHLog - Slow sync cost: 186 ms, current 
pipeline: []
2019-08-20 23:29:58,104 WARN  wal.FSHLog - Requesting log roll because we 
exceeded slow sync threshold; time=186 ms, threshold=0 ms, current pipeline: []
2019-08-20 23:29:58,107 DEBUG regionserver.ReplicationSourceManager - Start 
tracking logs for wal group [truncated]%2C1566343792434 for peer 1
2019-08-20 23:29:58,107 INFO  wal.FSHLog - New WAL 
/hbase/WALs/[truncated],1566343792434/[truncated]%2C1566343792434.1566343797824
2019-08-20 23:29:58,109 DEBUG regionserver.ReplicationSource - Starting up 
worker for wal group [truncated]%2C1566343792434{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-22 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913798#comment-16913798
 ] 

HBase QA commented on HBASE-22852:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue}  0m  
0s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green}  0m 
 0s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  2m 49s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/1/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/525 |
| JIRA Issue | HBASE-22852 |
| Optional Tests | dupname asflicense shellcheck shelldocs |
| uname | Linux a9df786f01a0 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
| git revision | master / 767bb15112 |
| Max. process+thread count | 42 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-22 Thread GitBox
Apache-HBase commented on issue #525: [HBASE-22852] Stop gpg agent daemons in 
hbase nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524115650
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 78 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 0 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 16 | The patch does not generate ASF License warnings. |
   | | | 169 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=18.09.7 Server=18.09.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/525 |
   | JIRA Issue | HBASE-22852 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux a9df786f01a0 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-525/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Max. process+thread count | 42 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-525/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot will fail if hfile is in archive directory

2019-08-22 Thread GitBox
Apache-HBase commented on issue #509: HBASE-22877 WebHDFS based export snapshot 
will fail if hfile is in archive directory
URL: https://github.com/apache/hbase/pull/509#issuecomment-524115390
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 63 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 337 | master passed |
   | +1 | compile | 56 | master passed |
   | +1 | checkstyle | 77 | master passed |
   | +1 | shadedjars | 273 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | master passed |
   | 0 | spotbugs | 273 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 271 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 310 | the patch passed |
   | +1 | compile | 52 | the patch passed |
   | +1 | javac | 52 | the patch passed |
   | +1 | checkstyle | 72 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 270 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 972 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 34 | the patch passed |
   | +1 | findbugs | 248 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 20321 | hbase-server in the patch failed. |
   | +1 | asflicense | 85 | The patch does not generate ASF License warnings. |
   | | | 23882 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.tool.TestSecureBulkLoadHFiles |
   |   | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   |   | hadoop.hbase.master.procedure.TestProcedurePriority |
   |   | hadoop.hbase.client.TestFromClientSide |
   |   | hadoop.hbase.tool.TestBulkLoadHFiles |
   |   | hadoop.hbase.client.TestAdmin2 |
   |   | hadoop.hbase.namespace.TestNamespaceAuditor |
   |   | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory |
   |   | hadoop.hbase.client.TestSnapshotTemporaryDirectory |
   |   | hadoop.hbase.master.procedure.TestTruncateTableProcedure |
   |   | hadoop.hbase.util.TestFromClientSide3WoUnsafe |
   |   | hadoop.hbase.client.TestFromClientSide3 |
   |   | hadoop.hbase.client.TestAsyncTableAdminApi |
   |   | hadoop.hbase.client.TestCloneSnapshotFromClientNormal |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/15/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/509 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 26258c33d8dd 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-509/out/precommit/personality/provided.sh
 |
   | git revision | master / 288d1f2769 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/15/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/15/testReport/
 |
   | Max. process+thread count | 4958 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-509/15/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #524: HBASE-22846 Internal Error 500 when Using 
HBASE REST API to Create Na…
URL: https://github.com/apache/hbase/pull/524#issuecomment-524114802
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 108 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-2.1 Compile Tests _ |
   | +1 | mvninstall | 414 | branch-2.1 passed |
   | +1 | compile | 31 | branch-2.1 passed |
   | +1 | checkstyle | 19 | branch-2.1 passed |
   | +1 | shadedjars | 281 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 23 | branch-2.1 passed |
   | 0 | spotbugs | 59 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 56 | branch-2.1 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 318 | the patch passed |
   | +1 | compile | 30 | the patch passed |
   | +1 | javac | 30 | the patch passed |
   | -1 | checkstyle | 17 | hbase-rest: The patch generated 1 new + 9 unchanged 
- 0 fixed = 10 total (was 9) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 267 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1335 | Patch does not cause any errors with Hadoop 
2.7.7 2.8.5 or 3.0.3 3.1.2. |
   | +1 | javadoc | 23 | the patch passed |
   | +1 | findbugs | 64 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 388 | hbase-rest in the patch failed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3803 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.rest.TestNamespacesInstanceResource |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=18.09.7 Server=18.09.7 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/524 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux e79530be5c7e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 
22:49:08 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-524/out/precommit/personality/provided.sh
 |
   | git revision | branch-2.1 / 2881b4ebfc |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/1/artifact/out/diff-checkstyle-hbase-rest.txt
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/1/artifact/out/patch-unit-hbase-rest.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/1/testReport/
 |
   | Max. process+thread count | 2330 (vs. ulimit of 1) |
   | modules | C: hbase-rest U: hbase-rest |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-524/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-22 Thread GitBox
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when 
doing bulkload
URL: https://github.com/apache/hbase/pull/494#issuecomment-524109057
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 98 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ branch-2 Compile Tests _ |
   | 0 | mvndep | 22 | Maven dependency ordering for branch |
   | +1 | mvninstall | 448 | branch-2 passed |
   | +1 | compile | 145 | branch-2 passed |
   | +1 | checkstyle | 161 | branch-2 passed |
   | +1 | shadedjars | 332 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 81 | branch-2 passed |
   | 0 | spotbugs | 249 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 525 | branch-2 passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 425 | the patch passed |
   | +1 | compile | 156 | the patch passed |
   | +1 | cc | 156 | the patch passed |
   | +1 | javac | 156 | the patch passed |
   | -1 | checkstyle | 113 | hbase-server: The patch generated 1 new + 302 
unchanged - 0 fixed = 303 total (was 302) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 350 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1316 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | hbaseprotoc | 131 | the patch passed |
   | +1 | javadoc | 83 | the patch passed |
   | -1 | findbugs | 263 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 47 | hbase-protocol-shaded in the patch passed. |
   | +1 | unit | 244 | hbase-client in the patch passed. |
   | -1 | unit | 15849 | hbase-server in the patch failed. |
   | +1 | asflicense | 79 | The patch does not generate ASF License warnings. |
   | | | 21811 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List,
 CellScanner, String, String, String) makes inefficient use of keySet iterator 
instead of entrySet iterator  At ReplicationSink.java:makes inefficient use of 
keySet iterator instead of entrySet iterator  At ReplicationSink.java:[line 
257] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/24/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/494 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
   | uname | Linux 2e53380d352f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 77f0510c40 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/24/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/24/artifact/out/new-findbugs-hbase-server.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/24/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/24/testReport/
 |
   | Max. process+thread count | 4439 (vs. ulimit of 1) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/24/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

2019-08-22 Thread GitBox
Apache-HBase commented on issue #251: HBASE-22114 Port HBASE-15560 
(TinyLFU-based BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#issuecomment-524106119
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 1262 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 1 | No case conflicting files found. |
   | -1 | hbaseanti | 0 |  The patch appears use Hadoop classification instead 
of HBase. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ branch-1 Compile Tests _ |
   | 0 | mvndep | 357 | Maven dependency ordering for branch |
   | +1 | mvninstall | 200 | branch-1 passed |
   | +1 | compile | 103 | branch-1 passed with JDK v1.8.0_222 |
   | +1 | compile | 102 | branch-1 passed with JDK v1.7.0_232 |
   | +1 | checkstyle | 432 | branch-1 passed |
   | 0 | refguide | 201 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   | +1 | shadedjars | 171 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 181 | branch-1 passed with JDK v1.8.0_222 |
   | +1 | javadoc | 305 | branch-1 passed with JDK v1.7.0_232 |
   | 0 | spotbugs | 647 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | 0 | findbugs | 16 | branch/hbase-resource-bundle no findbugs output file 
(findbugsXml.xml) |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 116 | the patch passed |
   | +1 | compile | 106 | the patch passed with JDK v1.8.0_222 |
   | +1 | javac | 106 | the patch passed |
   | +1 | compile | 104 | the patch passed with JDK v1.7.0_232 |
   | +1 | javac | 104 | the patch passed |
   | +1 | checkstyle | 10 | The patch passed checkstyle in 
hbase-resource-bundle |
   | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-common |
   | +1 | checkstyle | 86 | hbase-server: The patch generated 0 new + 83 
unchanged - 11 fixed = 83 total (was 94) |
   | +1 | checkstyle | 26 | The patch passed checkstyle in hbase-it |
   | +1 | checkstyle | 275 | root: The patch generated 0 new + 92 unchanged - 
11 fixed = 92 total (was 103) |
   | -1 | checkstyle | 12 | hbase-tinylfu-blockcache: The patch generated 1 new 
+ 0 unchanged - 0 fixed = 1 total (was 0) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | -1 | xml | 1 | The patch has 5 ill-formed XML file(s). |
   | 0 | refguide | 163 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   | -1 | shadedjars | 14 | patch has 7 errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 301 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2. |
   | -1 | javadoc | 11 | hbase-it in the patch failed with JDK v1.8.0_222. |
   | -1 | javadoc | 103 | root in the patch failed with JDK v1.8.0_222. |
   | -1 | javadoc | 12 | hbase-tinylfu-blockcache in the patch failed with JDK 
v1.7.0_232. |
   | 0 | findbugs | 12 | hbase-resource-bundle has no data from findbugs |
   | -1 | findbugs | 10 | hbase-tinylfu-blockcache in the patch failed. |
   ||| _ Other Tests _ |
   | -1 | unit | 10285 | root in the patch failed. |
   | +1 | asflicense | 117 | The patch does not generate ASF License warnings. |
   | | | 17521 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | XML | Parsing Error(s): |
   |   | hbase-common/src/main/resources/hbase-default.xml |
   |   | hbase-it/pom.xml |
   |   | hbase-resource-bundle/src/main/resources/supplemental-models.xml |
   |   | hbase-tinylfu-blockcache/pom.xml |
   |   | pom.xml |
   | Failed junit tests | 
hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-251/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/251 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile refguide xml |
   | uname | Linux 8810d2571d4c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-251/out/precommit/personality/provided.sh
 |
   | git revision | branch-1 / c066b06 |
   | Default Java | 1.7.0_232 |
   | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 |
   | refguide | 

[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation

2019-08-22 Thread GitBox
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods 
from Mutation
URL: https://github.com/apache/hbase/pull/478#issuecomment-524105062
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 116 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 35 | Maven dependency ordering for branch |
   | +1 | mvninstall | 375 | master passed |
   | +1 | compile | 86 | master passed |
   | +1 | checkstyle | 128 | master passed |
   | +1 | shadedjars | 318 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 66 | master passed |
   | 0 | spotbugs | 274 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 346 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for patch |
   | +1 | mvninstall | 380 | the patch passed |
   | +1 | compile | 95 | the patch passed |
   | +1 | javac | 95 | the patch passed |
   | +1 | checkstyle | 127 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 312 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1092 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 59 | the patch passed |
   | +1 | findbugs | 300 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 109 | hbase-client in the patch passed. |
   | +1 | unit | 15562 | hbase-server in the patch passed. |
   | +1 | asflicense | 58 | The patch does not generate ASF License warnings. |
   | | | 20017 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/36/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/478 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux e26ce6e472bf 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 
18:22:20 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/36/testReport/
 |
   | Max. process+thread count | 4867 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/36/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…

2019-08-22 Thread GitBox
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case 
TestStoreScanner.testScanSameTimes…
URL: https://github.com/apache/hbase/pull/446#issuecomment-524104768
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 176 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 490 | master passed |
   | +1 | compile | 76 | master passed |
   | +1 | checkstyle | 112 | master passed |
   | +1 | shadedjars | 375 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 48 | master passed |
   | 0 | spotbugs | 316 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 313 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 339 | the patch passed |
   | +1 | compile | 60 | the patch passed |
   | +1 | javac | 60 | the patch passed |
   | +1 | checkstyle | 90 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 306 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1108 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 38 | the patch passed |
   | +1 | findbugs | 268 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 14415 | hbase-server in the patch passed. |
   | +1 | asflicense | 30 | The patch does not generate ASF License warnings. |
   | | | 18685 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/68/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/446 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 8fa735f1187e 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 
10:55:24 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/68/testReport/
 |
   | Max. process+thread count | 4911 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/68/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-17165) Add retry to LoadIncrementalHFiles tool

2019-08-22 Thread Zach York (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-17165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913755#comment-16913755
 ] 

Zach York commented on HBASE-17165:
---

[~sreenivasulureddy] Please create a new JIRA if you're interested in 
backporting this JIRA. I can help with reviews.

> Add retry to LoadIncrementalHFiles tool
> ---
>
> Key: HBASE-17165
> URL: https://issues.apache.org/jira/browse/HBASE-17165
> Project: HBase
>  Issue Type: Improvement
>  Components: HFile, tooling
>Affects Versions: 1.2.3, 2.0.0
>Reporter: Mike Grimes
>Assignee: Mike Grimes
>Priority: Critical
>  Labels: s3
> Fix For: 2.0.0
>
> Attachments: HBASE-17165.branch-1.001.patch, 
> HBASE-17165.branch-1.001.patch, HBASE-17165.branch-1.002.patch, 
> HBASE-17165.branch-1.002.patch, HBASE-17165.branch-1.2.001.patch, 
> HBASE-17165.branch-1.2.002.patch, HBASE-17165.branch-1.2.003.patch, 
> HBASE-17165.branch-1.2.004.patch, HBASE-17165.master.001.patch, 
> HBASE-17165.master.002.patch, HBASE-17165.master.003.patch, 
> HBASE-17165.master.004.patch, HBASE-17165.master.004.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> As using the LoadIncrementalHFiles tool with S3 as the filesystem is prone to 
> failing due to FileNotFoundExceptions due to inconsistency, simple, 
> configurable retry logic was added.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in table jsp

2019-08-22 Thread GitBox
Apache-HBase commented on issue #510: HBASE-22878 Show table throttle quotas in 
table jsp
URL: https://github.com/apache/hbase/pull/510#issuecomment-524099235
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 221 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ master Compile Tests _ |
   | 0 | mvndep | 35 | Maven dependency ordering for branch |
   | +1 | mvninstall | 315 | master passed |
   | +1 | compile | 78 | master passed |
   | +1 | checkstyle | 106 | master passed |
   | +1 | shadedjars | 268 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 55 | master passed |
   | 0 | spotbugs | 251 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 316 | master passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 14 | Maven dependency ordering for patch |
   | +1 | mvninstall | 336 | the patch passed |
   | +1 | compile | 76 | the patch passed |
   | +1 | javac | 76 | the patch passed |
   | +1 | checkstyle | 100 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 267 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 998 | Patch does not cause any errors with Hadoop 2.8.5 
2.9.2 or 3.1.2. |
   | +1 | javadoc | 54 | the patch passed |
   | +1 | findbugs | 328 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 96 | hbase-client in the patch passed. |
   | +1 | unit | 15691 | hbase-server in the patch passed. |
   | +1 | asflicense | 66 | The patch does not generate ASF License warnings. |
   | | | 19851 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/15/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/510 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 96912ce83582 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 
13:14:43 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-510/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/15/testReport/
 |
   | Max. process+thread count | 5305 (vs. ulimit of 1) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-510/15/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22880) [Backport] HBASE-22871 to branch-1

2019-08-22 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913736#comment-16913736
 ] 

HBase QA commented on HBASE-22880:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m 17s{color} 
| {color:red} https://github.com/apache/hbase/pull/523 does not apply to 
branch-1. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| GITHUB PR | https://github.com/apache/hbase/pull/523 |
| JIRA Issue | HBASE-22880 |
| Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-523/2/console |
| versions | git=2.7.4 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |


This message was automatically generated.



> [Backport] HBASE-22871 to branch-1
> --
>
> Key: HBASE-22880
> URL: https://issues.apache.org/jira/browse/HBASE-22880
> Project: HBase
>  Issue Type: Improvement
>Reporter: Reid Chan
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi resolved HBASE-22901.
---
Resolution: Duplicate

The test is already fixed but the flaky dashboard was not yet reflecting this. 
Resolving as duplicate.

> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots, test
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #523: [HBASE-22880] Move the DirScanPool out and do not use static field

2019-08-22 Thread GitBox
Apache-HBase commented on issue #523: [HBASE-22880] Move the DirScanPool out 
and do not use static field
URL: https://github.com/apache/hbase/pull/523#issuecomment-524098779
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 0 | Docker mode activated. |
   | -1 | patch | 17 | https://github.com/apache/hbase/pull/523 does not apply 
to branch-1. Rebase required? Wrong Branch? See 
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for 
help. |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | GITHUB PR | https://github.com/apache/hbase/pull/523 |
   | JIRA Issue | HBASE-22880 |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-523/2/console |
   | versions | git=2.7.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913733#comment-16913733
 ] 

Peter Somogyi commented on HBASE-22901:
---

Looks like already fixed, my bad.

> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots, test
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913732#comment-16913732
 ] 

Peter Somogyi commented on HBASE-22901:
---

Bisect came back with this commit:

* eb6b617d92 - (refs/bisect/bad) HBASE-22810 Initialize an separate 
ThreadPoolExecutor for taking/restoring snapshot (#486) (8 days ago) 

> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots, test
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-22901:
--
Component/s: test
 snapshots

> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>  Components: snapshots, test
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Somogyi updated HBASE-22901:
--
Priority: Critical  (was: Major)

> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Work started] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


 [ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-22901 started by Peter Somogyi.
-
> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Critical
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913722#comment-16913722
 ] 

Peter Somogyi commented on HBASE-22901:
---

I started bisecting to find out where the test started to fail.

> TestFlushSnapshotFromClient is failing
> --
>
> Key: HBASE-22901
> URL: https://issues.apache.org/jira/browse/HBASE-22901
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.5.0, 1.4.11
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Major
> Fix For: 1.5.0, 1.4.11
>
>
> TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails 
> on branch-1 and branch-1.4.
> {noformat}
> java.lang.AssertionError: We expect at least 1 snapshot of table2 
>   at 
> org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (HBASE-22901) TestFlushSnapshotFromClient is failing

2019-08-22 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-22901:
-

 Summary: TestFlushSnapshotFromClient is failing
 Key: HBASE-22901
 URL: https://issues.apache.org/jira/browse/HBASE-22901
 Project: HBase
  Issue Type: Bug
Affects Versions: 1.5.0, 1.4.11
Reporter: Peter Somogyi
Assignee: Peter Somogyi
 Fix For: 1.5.0, 1.4.11


TestFlushSnapshotFromClient#testConcurrentSnapshottingAttempts always fails on 
branch-1 and branch-1.4.

{noformat}
java.lang.AssertionError: We expect at least 1 snapshot of table2 
at 
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient.testConcurrentSnapshottingAttempts(TestFlushSnapshotFromClient.java:503)
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] shahrs87 commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-22 Thread GitBox
shahrs87 commented on issue #525: [HBASE-22852] Stop gpg agent daemons in hbase 
nightlies.
URL: https://github.com/apache/hbase/pull/525#issuecomment-524092242
 
 
   Once reviewed, I will create PR for other branches.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22852) hbase nightlies leaking gpg-agents

2019-08-22 Thread Rushabh S Shah (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913716#comment-16913716
 ] 

Rushabh S Shah commented on HBASE-22852:


Created a PR for this: https://github.com/apache/hbase/pull/525

> hbase nightlies leaking gpg-agents
> --
>
> Key: HBASE-22852
> URL: https://issues.apache.org/jira/browse/HBASE-22852
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Reporter: Allen Wittenauer
>Priority: Major
>
> FYI, just triggered yetus master, which includes code to find and kill 
> long-running processes still attached to the Jenkins workspace directory.  It 
> came up with this:
> https://builds.apache.org/view/S-Z/view/Yetus/job/yetus-github-multibranch/job/master/134/console
> {code}
> USER   PID %CPU %MEMVSZ   RSS TTY  STAT START   TIME COMMAND
>  jenkins752  0.0  0.0  93612   584 ?Ss   Aug12   0:00 gpg-agent 
> --homedir 
> /home/jenkins/jenkins-slave/workspace/HBase_Nightly_HBASE-20952/downloads-hadoop-2/.gpg
>  --use-standard-socket --daemon
>  Killing 752 ***
> {code}
> (repeat 10s of times, which slightly different dates, pids, versions, etc)
> Also, be aware that any other process running on the node (such as the other 
> executor) has extremely easy access to whatever gpg creds you are using...



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] shahrs87 opened a new pull request #525: [HBASE-22852] Stop gpg agent daemons in hbase nightlies.

2019-08-22 Thread GitBox
shahrs87 opened a new pull request #525: [HBASE-22852] Stop gpg agent daemons 
in hbase nightlies.
URL: https://github.com/apache/hbase/pull/525
 
 
   https://issues.apache.org/jira/browse/HBASE-22852


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22891) Use HBaseQA in HBase-PreCommit-GitHub-PR job

2019-08-22 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913712#comment-16913712
 ] 

Hudson commented on HBASE-22891:


SUCCESS: Integrated in Jenkins build HBase-1.3-IT #624 (See 
[https://builds.apache.org/job/HBase-1.3-IT/624/])
HBASE-22891 Use HBaseQA in HBase-PreCommit-GitHub-PR job (#518) (zhangduo: rev 
cd7bf7001b92438a9229cddb799ef0204333b083)
* (edit) dev-support/Jenkinsfile_GitHub


> Use HBaseQA in HBase-PreCommit-GitHub-PR job
> 
>
> Key: HBASE-22891
> URL: https://issues.apache.org/jira/browse/HBASE-22891
> Project: HBase
>  Issue Type: Sub-task
>  Components: build, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>  Labels: trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11, 2.0.7
>
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent

2019-08-22 Thread GitBox
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of 
RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#issuecomment-524086263
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 37 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 326 | master passed |
   | +1 | compile | 23 | master passed |
   | +1 | checkstyle | 14 | master passed |
   | +1 | shadedjars | 275 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 21 | master passed |
   | 0 | spotbugs | 49 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 48 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 291 | the patch passed |
   | +1 | compile | 25 | the patch passed |
   | +1 | javac | 25 | the patch passed |
   | +1 | checkstyle | 13 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 278 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1008 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 18 | the patch passed |
   | +1 | findbugs | 50 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 356 | hbase-rsgroup in the patch passed. |
   | +1 | asflicense | 11 | The patch does not generate ASF License warnings. |
   | | | 3150 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/115/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/387 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux ff0472a47b07 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/115/testReport/
 |
   | Max. process+thread count | 4492 (vs. ulimit of 1) |
   | modules | C: hbase-rsgroup U: hbase-rsgroup |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/115/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #494: HBASE-22380 break circle replication when doing bulkload

2019-08-22 Thread GitBox
Apache-HBase commented on issue #494: HBASE-22380 break circle replication when 
doing bulkload
URL: https://github.com/apache/hbase/pull/494#issuecomment-524083925
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 77 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ branch-2 Compile Tests _ |
   | 0 | mvndep | 17 | Maven dependency ordering for branch |
   | +1 | mvninstall | 427 | branch-2 passed |
   | +1 | compile | 147 | branch-2 passed |
   | +1 | checkstyle | 166 | branch-2 passed |
   | +1 | shadedjars | 347 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 96 | branch-2 passed |
   | 0 | spotbugs | 269 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 554 | branch-2 passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 19 | Maven dependency ordering for patch |
   | +1 | mvninstall | 384 | the patch passed |
   | +1 | compile | 152 | the patch passed |
   | +1 | cc | 152 | the patch passed |
   | +1 | javac | 152 | the patch passed |
   | -1 | checkstyle | 105 | hbase-server: The patch generated 1 new + 302 
unchanged - 0 fixed = 303 total (was 302) |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 338 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1244 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | hbaseprotoc | 142 | the patch passed |
   | +1 | javadoc | 88 | the patch passed |
   | -1 | findbugs | 283 | hbase-server generated 1 new + 0 unchanged - 0 fixed 
= 1 total (was 0) |
   ||| _ Other Tests _ |
   | +1 | unit | 50 | hbase-protocol-shaded in the patch passed. |
   | +1 | unit | 243 | hbase-client in the patch passed. |
   | -1 | unit | 18756 | hbase-server in the patch failed. |
   | +1 | asflicense | 131 | The patch does not generate ASF License warnings. |
   | | | 24670 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-server |
   |  |  
org.apache.hadoop.hbase.replication.regionserver.ReplicationSink.replicateEntries(List,
 CellScanner, String, String, String) makes inefficient use of keySet iterator 
instead of entrySet iterator  At ReplicationSink.java:makes inefficient use of 
keySet iterator instead of entrySet iterator  At ReplicationSink.java:[line 
257] |
   | Failed junit tests | 
hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
   |   | hadoop.hbase.master.procedure.TestSCPWithReplicas |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/23/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/494 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
   | uname | Linux 869e9750820d 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-494/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 4275c5f374 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/23/artifact/out/diff-checkstyle-hbase-server.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/23/artifact/out/new-findbugs-hbase-server.html
 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/23/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/23/testReport/
 |
   | Max. process+thread count | 4278 (vs. ulimit of 1) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-494/23/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache 

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-22 Thread Rushabh S Shah (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913704#comment-16913704
 ] 

Rushabh S Shah commented on HBASE-22601:


> Merged the PR and picked it to branch-1.4 and branch-1. Sorry for the delay. 
> Resolving.
Thank you [~apurtell] for reviews and commit !

> Misconfigured addition of peers leads to cluster shutdown.
> --
>
> Key: HBASE-22601
> URL: https://issues.apache.org/jira/browse/HBASE-22601
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.2
>Reporter: Rushabh S Shah
>Assignee: Rushabh S Shah
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
> Recently we added a peer to a production cluster which were in different 
> kerberos realm.
> *Steps to reproduce:*
>  1. Add a misconfigured peer which is in different kerberos realm.
>  2. Remove that peer.
>  3. All region servers will start to crash.
> *RCA*
>  Enabled trace logging on one Region server for a short amount of time.
>  After adding peer, saw the following log lines.
> {noformat}
> 2019-06-18 22:19:20,949 INFO  [main-EventThread] 
> replication.ReplicationTrackerZKImpl - /hbase/replication/peers znode 
> expired, triggering peerListChanged event
> 2019-06-18 22:19:20,992 INFO  [main-EventThread] 
> replication.ReplicationPeersZKImpl - Added new peer 
> cluster=:/hbase
> 2019-06-18 22:19:21,113 INFO  [main-EventThread] 
> zookeeper.RecoverableZooKeeper - Process identifier=hconnection-0x794a56d6 
> connecting to ZooKeeper ensemble=
> 2019-06-18 22:20:01,280 WARN  [main-EventThread] zookeeper.ZKUtil - 
> hconnection-0x794a56d6-0x16b56265fbebb1b, quorum=, 
> baseZNode=/hbase Unable to set watcher on znode (/hbase/hbaseid)
> org.apache.zookeeper.KeeperException$AuthFailedException: KeeperErrorCode = 
> AuthFailed for /hbase/hbaseid
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:123)
> at 
> org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.exists(ZooKeeper.java:1102)
> at 
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.exists(RecoverableZooKeeper.java:220)
> at 
> org.apache.hadoop.hbase.zookeeper.ZKUtil.checkExists(ZKUtil.java:421)
> at 
> org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:65)
> at 
> org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:105)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:922)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:706)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.(ConnectionManager.java:638)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native 
> Method)
> at 
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at 
> org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager.createConnection(ConnectionManager.java:432)
> at 
> org.apache.hadoop.hbase.client.ConnectionManager.createConnectionInternal(ConnectionManager.java:341)
> at 
> org.apache.hadoop.hbase.client.HConnectionManager.createConnection(HConnectionManager.java:144)
> at 
> org.apache.hadoop.hbase.replication.regionserver.HBaseInterClusterReplicationEndpoint.init(HBaseInterClusterReplicationEndpoint.java:135)
> at 
> com.salesforce.hbase.replication.TenantReplicationEndpoint.init(TenantReplicationEndpoint.java:30)
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.getReplicationSource(ReplicationSourceManager.java:517)
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.addSource(ReplicationSourceManager.java:273)
> at 
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.peerListChanged(ReplicationSourceManager.java:635)
> at 
> org.apache.hadoop.hbase.replication.ReplicationTrackerZKImpl$PeersWatcher.nodeChildrenChanged(ReplicationTrackerZKImpl.java:192)
> at 
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher.process(ZooKeeperWatcher.java:643)
> at 
> org.apache.zookeeper.ClientCnxn$EventThread.processEvent(ClientCnxn.java:544)
> at 
> 

[GitHub] [hbase] Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to have 100 percent …

2019-08-22 Thread GitBox
Apache-HBase commented on issue #520: HBASE-22766 Code Coverage Improvement: 
Create Unit Tests for ResultStatsUtil. Added unit tests for ResultStatsUtil to 
have 100 percent …
URL: https://github.com/apache/hbase/pull/520#issuecomment-524083544
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 41 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 1 new or modified test 
files. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 366 | master passed |
   | +1 | compile | 27 | master passed |
   | +1 | checkstyle | 33 | master passed |
   | +1 | shadedjars | 312 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 26 | master passed |
   | 0 | spotbugs | 78 | Used deprecated FindBugs config; considering switching 
to SpotBugs. |
   | +1 | findbugs | 75 | master passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 338 | the patch passed |
   | +1 | compile | 25 | the patch passed |
   | +1 | javac | 25 | the patch passed |
   | +1 | checkstyle | 30 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 306 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1085 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 24 | the patch passed |
   | +1 | findbugs | 86 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 114 | hbase-client in the patch passed. |
   | +1 | asflicense | 13 | The patch does not generate ASF License warnings. |
   | | | 3314 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/4/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/520 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux b7e089762a7c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-520/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | Default Java | 1.8.0_181 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/4/testReport/
 |
   | Max. process+thread count | 286 (vs. ulimit of 1) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-520/4/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22862) Region Server crash with: Added a key not lexically larger than previous

2019-08-22 Thread Alex Batyrshin (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913702#comment-16913702
 ] 

Alex Batyrshin commented on HBASE-22862:


Still getting this errors

> Region Server crash with: Added a key not lexically larger than previous
> 
>
> Key: HBASE-22862
> URL: https://issues.apache.org/jira/browse/HBASE-22862
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 1.4.10
> Environment: {code}
> openjdk version "1.8.0_181"
> OpenJDK Runtime Environment (Zulu 8.31.0.1-linux64) (build 1.8.0_181-b02)
> OpenJDK 64-Bit Server VM (Zulu 8.31.0.1-linux64) (build 25.181-b02, mixed 
> mode)
> {code}
>Reporter: Alex Batyrshin
>Priority: Critical
>
> We observe error "Added a key not lexically larger than previous” that cause 
> most of our region-servers to crash in our cluster.
> {code}
> 2019-08-15 18:02:10,554 INFO  [MemStoreFlusher.0] regionserver.HRegion: 
> Flushing 1/1 column families, memstore=56.08 MB
> 2019-08-15 18:02:10,727 WARN  [MemStoreFlusher.0] regionserver.HStore: Failed 
> flushing store file, retrying num=0
> java.io.IOException: Added a key not lexically larger than previous. Current 
> cell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
>  lastCell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at 
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at 
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at 
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.flush(HRegion.java:2125)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:512)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.flushRegion(MemStoreFlusher.java:482)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher.access$900(MemStoreFlusher.java:76)
>at 
> org.apache.hadoop.hbase.regionserver.MemStoreFlusher$FlushHandler.run(MemStoreFlusher.java:264)
>at java.lang.Thread.run(Thread.java:748)
> 2019-08-15 18:02:21,776 WARN  [MemStoreFlusher.0] regionserver.HStore: Failed 
> flushing store file, retrying num=9
> java.io.IOException: Added a key not lexically larger than previous. Current 
> cell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/DeleteColumn/vlen=0/seqid=44456567,
>  lastCell = 
> \x0901820448218>wGavb'/d:elr/1565881054828/Put/vlen=1/seqid=44457770
>at 
> org.apache.hadoop.hbase.io.hfile.AbstractHFileWriter.checkKey(AbstractHFileWriter.java:204)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV2.append(HFileWriterV2.java:279)
>at 
> org.apache.hadoop.hbase.io.hfile.HFileWriterV3.append(HFileWriterV3.java:87)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFile$Writer.append(StoreFile.java:1127)
>at 
> org.apache.hadoop.hbase.regionserver.StoreFlusher.performFlush(StoreFlusher.java:139)
>at 
> org.apache.hadoop.hbase.regionserver.DefaultStoreFlusher.flushSnapshot(DefaultStoreFlusher.java:75)
>at 
> org.apache.hadoop.hbase.regionserver.HStore.flushCache(HStore.java:1003)
>at 
> org.apache.hadoop.hbase.regionserver.HStore$StoreFlusherImpl.flushCache(HStore.java:2523)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushCacheAndCommit(HRegion.java:2622)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2352)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.internalFlushcache(HRegion.java:2314)
>at 
> org.apache.hadoop.hbase.regionserver.HRegion.flushcache(HRegion.java:2200)
>at 
> 

[jira] [Commented] (HBASE-22601) Misconfigured addition of peers leads to cluster shutdown.

2019-08-22 Thread HBase QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913697#comment-16913697
 ] 

HBase QA commented on HBASE-22601:
--

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 38m 
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.3 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
30s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
58s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 7s{color} | {color:green} branch-1.3 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
46s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} branch-1.3 passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} branch-1.3 passed with JDK v1.7.0_232 {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  3m 
47s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
43s{color} | {color:green} branch-1.3 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  2m 
 5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  3m 
44s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
13m  8s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.1 2.5.2 2.6.5 2.7.7. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} the patch passed with JDK v1.7.0_232 {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}148m  9s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
28s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | 

[jira] [Commented] (HBASE-22874) Canary should not be IA.Public

2019-08-22 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913696#comment-16913696
 ] 

Hadoop QA commented on HBASE-22874:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 
15s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
10s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
42s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
35s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} branch-2 passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  4m 
26s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
23s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
35s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
20m 17s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
25s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}314m 16s{color} 
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
36s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}385m 40s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAdmin3 |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-515/7/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hbase/pull/515 |
| JIRA Issue | HBASE-22874 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 33f1975c9a0e 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-515/out/precommit/personality/provided.sh
 |
| git revision | branch-2 / 

[GitHub] [hbase] Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of peers leads to cluster shutdown.

2019-08-22 Thread GitBox
Apache-HBase commented on issue #490: [HBASE-22601] Misconfigured addition of 
peers leads to cluster shutdown.
URL: https://github.com/apache/hbase/pull/490#issuecomment-524075299
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 2315 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-1.3 Compile Tests _ |
   | +1 | mvninstall | 510 | branch-1.3 passed |
   | +1 | compile | 49 | branch-1.3 passed with JDK v1.8.0_222 |
   | +1 | compile | 58 | branch-1.3 passed with JDK v1.7.0_232 |
   | +1 | checkstyle | 127 | branch-1.3 passed |
   | +1 | shadedjars | 226 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 46 | branch-1.3 passed with JDK v1.8.0_222 |
   | +1 | javadoc | 53 | branch-1.3 passed with JDK v1.7.0_232 |
   | 0 | spotbugs | 227 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 223 | branch-1.3 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 164 | the patch passed |
   | +1 | compile | 53 | the patch passed with JDK v1.8.0_222 |
   | +1 | javac | 53 | the patch passed |
   | +1 | compile | 54 | the patch passed with JDK v1.7.0_232 |
   | +1 | javac | 54 | the patch passed |
   | +1 | checkstyle | 125 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 224 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 788 | Patch does not cause any errors with Hadoop 2.4.1 
2.5.2 2.6.5 2.7.7. |
   | +1 | javadoc | 39 | the patch passed with JDK v1.8.0_222 |
   | +1 | javadoc | 52 | the patch passed with JDK v1.7.0_232 |
   | +1 | findbugs | 224 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 8889 | hbase-server in the patch failed. |
   | +1 | asflicense | 28 | The patch does not generate ASF License warnings. |
   | | | 14356 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.regionserver.TestZKLessSplitOnCluster |
   |   | hadoop.hbase.TestZooKeeper |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/14/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/490 |
   | JIRA Issue | HBASE-22601 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 4f49e619549f 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-490/out/precommit/personality/provided.sh
 |
   | git revision | branch-1.3 / cd7bf70 |
   | Default Java | 1.7.0_232 |
   | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/14/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/14/testReport/
 |
   | Max. process+thread count | 4162 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-490/14/console |
   | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #515: [HBASE-22874] Mark Canary as LA(Tools)

2019-08-22 Thread GitBox
Apache-HBase commented on issue #515: [HBASE-22874] Mark Canary as LA(Tools)
URL: https://github.com/apache/hbase/pull/515#issuecomment-524074993
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 80 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | hbaseanti | 0 |  Patch does not have any anti-patterns. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -0 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ branch-2 Compile Tests _ |
   | +1 | mvninstall | 435 | branch-2 passed |
   | +1 | compile | 70 | branch-2 passed |
   | +1 | checkstyle | 102 | branch-2 passed |
   | +1 | shadedjars | 335 | branch has no errors when building our shaded 
downstream artifacts. |
   | +1 | javadoc | 45 | branch-2 passed |
   | 0 | spotbugs | 266 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 263 | branch-2 passed |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 395 | the patch passed |
   | +1 | compile | 75 | the patch passed |
   | +1 | javac | 75 | the patch passed |
   | +1 | checkstyle | 105 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedjars | 335 | patch has no errors when building our shaded 
downstream artifacts. |
   | +1 | hadoopcheck | 1217 | Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. |
   | +1 | javadoc | 44 | the patch passed |
   | +1 | findbugs | 265 | the patch passed |
   ||| _ Other Tests _ |
   | -1 | unit | 18856 | hbase-server in the patch failed. |
   | +1 | asflicense | 36 | The patch does not generate ASF License warnings. |
   | | | 23140 | |
   
   
   | Reason | Tests |
   |---:|:--|
   | Failed junit tests | hadoop.hbase.client.TestAdmin3 |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-515/7/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/515 |
   | JIRA Issue | HBASE-22874 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
   | uname | Linux 33f1975c9a0e 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 
05:29:03 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-515/out/precommit/personality/provided.sh
 |
   | git revision | branch-2 / 4275c5f374 |
   | Default Java | 1.8.0_181 |
   | unit | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-515/7/artifact/out/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-515/7/testReport/
 |
   | Max. process+thread count | 4674 (vs. ulimit of 1) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-515/7/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [hbase] Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot feature

2019-08-22 Thread GitBox
Apache-HBase commented on issue #496: HBASE-22625 documet use scan snapshot 
feature
URL: https://github.com/apache/hbase/pull/496#issuecomment-524074288
 
 
   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | 0 | reexec | 39 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | 0 | shelldocs | 1 | Shelldocs was not available. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   ||| _ master Compile Tests _ |
   | +1 | mvninstall | 347 | master passed |
   | 0 | refguide | 343 | branch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Patch Compile Tests _ |
   | +1 | mvninstall | 302 | the patch passed |
   | +1 | shellcheck | 0 | There were no new shellcheck issues. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | 0 | refguide | 350 | patch has no errors when building the reference 
guide. See footer for rendered docs, which you should manually inspect. |
   ||| _ Other Tests _ |
   | +1 | asflicense | 22 | The patch does not generate ASF License warnings. |
   | | | 1461 | |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | Client=19.03.1 Server=19.03.1 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/26/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/496 |
   | Optional Tests | dupname asflicense shellcheck shelldocs refguide |
   | uname | Linux 41f32a5ba476 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-496/out/precommit/personality/provided.sh
 |
   | git revision | master / 767bb15112 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/26/artifact/out/branch-site/book.html
 |
   | refguide | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/26/artifact/out/patch-site/book.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 1) |
   | modules | C: . U: . |
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-496/26/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (HBASE-22846) Internal Error 500 when Using HBASE REST API to Create Namespace.

2019-08-22 Thread Wellington Chevreuil (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913690#comment-16913690
 ] 

Wellington Chevreuil commented on HBASE-22846:
--

Submitted an initial PR for branch-2.1. Noticed additional two issues that may 
be good to address in separate jiras:

1) Lack of UTs for resources;

2) REST API documentation in the ref guides don't describe the payload format.

> Internal Error 500 when Using HBASE REST API to Create Namespace.
> -
>
> Key: HBASE-22846
> URL: https://issues.apache.org/jira/browse/HBASE-22846
> Project: HBase
>  Issue Type: Improvement
>  Components: hbase-connectors
>Affects Versions: 2.1.1
>Reporter: Sailesh Patel
>Assignee: Wellington Chevreuil
>Priority: Major
>
> When trying to the following URL to create namespace:
> Secured cluster: curl --negotiate -u : -i -k -vi -X POST 
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest;
>  UnSecured cluster: curl -vi -X POST 
> "http://HBASE_REST_API_HOST:20550/namespaces/datasparktest;
> The following is returned on the console:
>  HTTP/1.1 500 Request failed.
> The Error in Hbase REST Server log is:
> 2019-08-13 15:44:55,080 WARN org.eclipse.jetty.servlet.ServletHandler: 
> javax.servlet.ServletException: java.lang.NullPointerException
>  at 
> org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:489)
>  at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
> ...
> Caused by: java.lang.NullPointerException
>  at 
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.createOrUpdate(NamespacesInstanceResource.java:250)
>  at 
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.processUpdate(NamespacesInstanceResource.java:243)
>  at 
> org.apache.hadoop.hbase.rest.NamespacesInstanceResource.post(NamespacesInstanceResource.java:183)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at 
> org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
>  at 
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
>  at 
> org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (HBASE-22900) Multiple httpcore and httpclient versions included in binary package (branch-1.3)

2019-08-22 Thread Andrew Purtell (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-22900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913687#comment-16913687
 ] 

Andrew Purtell commented on HBASE-22900:


Only branch-1.3 and branch-1.4 are affected.

> Multiple httpcore and httpclient versions included in binary package 
> (branch-1.3)
> -
>
> Key: HBASE-22900
> URL: https://issues.apache.org/jira/browse/HBASE-22900
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.3.5
>Reporter: Andrew Purtell
>Priority: Minor
> Fix For: 1.3.6, 1.4.11
>
>
> We are including multiple versions of httpcore and httpclient in the binary 
> package. 
> {noformat}
> httpclient-4.1.2.jar
> httpclient-4.2.5.jar  
> httpclient-4.4.1.jar
> httpcore-4.1.2.jar
> httpcore-4.2.4.jar
> httpcore-4.4.1.jar
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [hbase] wchevreuil opened a new pull request #524: HBASE-22846 Internal Error 500 when Using HBASE REST API to Create Na…

2019-08-22 Thread GitBox
wchevreuil opened a new pull request #524: HBASE-22846 Internal Error 500 when 
Using HBASE REST API to Create Na…
URL: https://github.com/apache/hbase/pull/524
 
 
   HBASE-22846:
   
   First PR based on branch-2.1. Apparently, jersey does not support more than 
one method mapped for the very same endpoint path, so merged post with 
postNobody, as well as put and putNobody. Additional refactoring applied to 
avoid code duplication.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   >