[GitHub] [hbase] ddupg commented on a change in pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
ddupg commented on a change in pull request #2126: URL: https://github.com/apache/hbase/pull/2126#discussion_r479612845 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -709,6 +713,22 @@ private void

[GitHub] [hbase] ddupg commented on a change in pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
ddupg commented on a change in pull request #2126: URL: https://github.com/apache/hbase/pull/2126#discussion_r479611730 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -592,7 +594,13 @@ private synchronized void

[GitHub] [hbase] Apache-HBase commented on pull request #2325: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fa…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2325: URL: https://github.com/apache/hbase/pull/2325#issuecomment-683240071 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2325: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fa…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2325: URL: https://github.com/apache/hbase/pull/2325#issuecomment-683239752 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2325: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fa…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2325: URL: https://github.com/apache/hbase/pull/2325#issuecomment-683239613 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ddupg opened a new pull request #2325: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fa…

2020-08-28 Thread GitBox
ddupg opened a new pull request #2325: URL: https://github.com/apache/hbase/pull/2325 …llback feature This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hbase] Apache-HBase commented on pull request #2284: HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-683236670 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-24966) The methods in AsyncTableRegionLocator should not throw IOException directly

2020-08-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24966: - Summary: The methods in AsyncTableRegionLocator should not throw IOException directly Key: HBASE-24966 URL: https://issues.apache.org/jira/browse/HBASE-24966 Project:

[jira] [Updated] (HBASE-24965) Use RegionLocator instead of MetaTableAccessor's get regions and locations methods if possible

2020-08-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24965: -- Component/s: meta > Use RegionLocator instead of MetaTableAccessor's get regions and locations >

[jira] [Created] (HBASE-24965) Use RegionLocator instead of MetaTableAccessor's get regions and locations methods if possible

2020-08-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24965: - Summary: Use RegionLocator instead of MetaTableAccessor's get regions and locations methods if possible Key: HBASE-24965 URL: https://issues.apache.org/jira/browse/HBASE-24965

[jira] [Updated] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-08-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24964: -- Component/s: meta > Remove MetaTableAccessor.tableExists > > >

[jira] [Assigned] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-08-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24964: - Assignee: Duo Zhang > Remove MetaTableAccessor.tableExists >

[jira] [Work started] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-08-28 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24964 started by Duo Zhang. - > Remove MetaTableAccessor.tableExists > > >

[jira] [Created] (HBASE-24964) Remove MetaTableAccessor.tableExists

2020-08-28 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-24964: - Summary: Remove MetaTableAccessor.tableExists Key: HBASE-24964 URL: https://issues.apache.org/jira/browse/HBASE-24964 Project: HBase Issue Type: Sub-task

[GitHub] [hbase] Apache-HBase commented on pull request #2284: HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-683229640 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-683221824 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-683221202 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-683219233 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-683218675 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-683218156 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2324: URL: https://github.com/apache/hbase/pull/2324#issuecomment-683215647 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24937) table.rb use LocalDateTime to replace Instant

2020-08-28 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24937: --- Status: Patch Available (was: Open) > table.rb use LocalDateTime to replace Instant >

[GitHub] [hbase] cuibo01 opened a new pull request #2324: HBASE-24937 table.rb use LocalDateTime to replace Instant

2020-08-28 Thread GitBox
cuibo01 opened a new pull request #2324: URL: https://github.com/apache/hbase/pull/2324 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2284: HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2284: URL: https://github.com/apache/hbase/pull/2284#issuecomment-683213415 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-683213358 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-683209562 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-683208368 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24760) Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186861#comment-17186861 ] Hudson commented on HBASE-24760: Results for branch master [build #26 on

[GitHub] [hbase] bharathv commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
bharathv commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r479581668 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] bharathv commented on a change in pull request #2284: HBASE-24764: Add support of adding default peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread GitBox
bharathv commented on a change in pull request #2284: URL: https://github.com/apache/hbase/pull/2284#discussion_r479576404 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/replication/ReplicationPeerManager.java ## @@ -232,6 +233,9 @@ public void

[jira] [Commented] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186845#comment-17186845 ] Bharath Vissapragada commented on HBASE-24764: -- [~wchevreuil] I linked the PR manually. I

[GitHub] [hbase] Apache-HBase commented on pull request #2320: HBASE-24954 Corrected value for AuthUtil.HBASE_CLIENT_KERBEROS_PRINCIPAL

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2320: URL: https://github.com/apache/hbase/pull/2320#issuecomment-683174530 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-683164673 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r479540958 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -863,13 +863,15 @@ private RegionLocations

[GitHub] [hbase-filesystem] apurtell commented on pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread GitBox
apurtell commented on pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15#issuecomment-683115709 When I compile a custom stack based on Hadoop 3.3.0, HBase 2.3.1, and ZooKeeper 3.5.8, such that all of Hadoop, HBase, and ZK versions are harmonized across those

[GitHub] [hbase-filesystem] apurtell edited a comment on pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread GitBox
apurtell edited a comment on pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15#issuecomment-683113896 I tried mvn clean install -Dhadoop.profile=3 -Dhadoop3.version=3.3.0 -Dhbase.profile=2 -Dhbase2.version=2.3.1 [INFO] Running

[GitHub] [hbase-filesystem] apurtell commented on pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread GitBox
apurtell commented on pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15#issuecomment-683113896 I tried mvn clean install -Dhadoop.profile=3 -Dhadoop3.version=3.3.0 -Dhbase.profile=2 -Dhbase2.version=2.3.1 [INFO] Running

[GitHub] [hbase-filesystem] joshelser commented on pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread GitBox
joshelser commented on pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15#issuecomment-683089142 ``` [INFO] Running org.apache.hadoop.hbase.oss.contract.TestHBOSSContractRenameS3A [ERROR] Tests run: 10, Failures: 1, Errors: 1, Skipped: 0, Time elapsed: 9.049 s

[GitHub] [hbase-filesystem] wchevreuil opened a new pull request #15: HBASE-24963 [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread GitBox
wchevreuil opened a new pull request #15: URL: https://github.com/apache/hbase-filesystem/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (HBASE-24963) [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-24963: - Component/s: hboss Filesystem Integration > [HBOSS] UTs

[jira] [Created] (HBASE-24963) [HBOSS] UTs failing when running against hadoop 3.3.

2020-08-28 Thread Wellington Chevreuil (Jira)
Wellington Chevreuil created HBASE-24963: Summary: [HBOSS] UTs failing when running against hadoop 3.3. Key: HBASE-24963 URL: https://issues.apache.org/jira/browse/HBASE-24963 Project: HBase

[GitHub] [hbase] saintstack commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
saintstack commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r479460586 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] apurtell commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-28 Thread GitBox
apurtell commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r479441606 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[jira] [Commented] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186642#comment-17186642 ] Hudson commented on HBASE-24898: Results for branch branch-1 [build #12 on

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-682717459 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24916) Region hole contains wrong regions pair when hole is created by first region deletion

2020-08-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186617#comment-17186617 ] Wellington Chevreuil commented on HBASE-24916: -- {quote} Suppose a cluster with two tables

[jira] [Commented] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186587#comment-17186587 ] Wellington Chevreuil commented on HBASE-24764: -- Thanks for the contribution, [~jainankit].

[jira] [Comment Edited] (HBASE-24764) Add support of adding base peer configs via hbase-site.xml for all replication peers.

2020-08-28 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186587#comment-17186587 ] Wellington Chevreuil edited comment on HBASE-24764 at 8/28/20, 2:52 PM:

[GitHub] [hbase] bsglz commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
bsglz commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682620054 The failure on jdk11 seems strange, i think it is unrelated to this pr. This is an automated message from the

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-682601286 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] infraio commented on a change in pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
infraio commented on a change in pull request #2126: URL: https://github.com/apache/hbase/pull/2126#discussion_r479244607 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -709,6 +713,22 @@ private void

[GitHub] [hbase] infraio commented on a change in pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
infraio commented on a change in pull request #2126: URL: https://github.com/apache/hbase/pull/2126#discussion_r479243818 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -592,7 +594,13 @@ private synchronized void

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-682484664 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-682481541 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-682477579 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-682457981 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-682454594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-682454268 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2308: HBASE-20598 - Upgrade to JRuby 9.2

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2308: URL: https://github.com/apache/hbase/pull/2308#issuecomment-682450525 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2255: HBASE-24877 Add option to avoid aborting RS process upon uncaught exc…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2255: URL: https://github.com/apache/hbase/pull/2255#issuecomment-682437651 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682430800 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24760) Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-28 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186400#comment-17186400 ] Guanghao Zhang commented on HBASE-24760: [~Ddupg] Please upload a PR for branch-2. Thanks. >

[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #14: HBASE-24961 [HBOSS] HBaseObjectStoreSemantics.close should call super.close to make sure its own instance always get r

2020-08-28 Thread GitBox
wchevreuil commented on a change in pull request #14: URL: https://github.com/apache/hbase-filesystem/pull/14#discussion_r478988871 ## File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java ## @@ -180,9 +196,12 @@ protected boolean

[jira] [Commented] (HBASE-24892) config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-28 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186396#comment-17186396 ] Guanghao Zhang commented on HBASE-24892: [~wenfeiyi666] There is a "Edit" button below the issue

[jira] [Updated] (HBASE-24892) config 'hbase.hregion.memstore.mslab.indexchunksize' not be used

2020-08-28 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24892: --- Release Note: Remove the config "hbase.hregion.memstore.mslab.indexchunksize" which never

[GitHub] [hbase] infraio merged pull request #2149: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-28 Thread GitBox
infraio merged pull request #2149: URL: https://github.com/apache/hbase/pull/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-682400463 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #1994: HBASE-24654 Allow unset table's rsgroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #1994: URL: https://github.com/apache/hbase/pull/1994#issuecomment-682397041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Persisting configuration of default rsgroup

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-682395934 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] KanakaKumar commented on a change in pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-28 Thread GitBox
KanakaKumar commented on a change in pull request #2304: URL: https://github.com/apache/hbase/pull/2304#discussion_r478925062 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitorCluster.java ## @@ -231,4 +234,86 @@ public void

[GitHub] [hbase] utf7 commented on pull request #2209: HBASE-24831 Avoid invoke Counter using reflection in SnapshotInputFormat

2020-08-28 Thread GitBox
utf7 commented on pull request #2209: URL: https://github.com/apache/hbase/pull/2209#issuecomment-682383944 done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2254: URL: https://github.com/apache/hbase/pull/2254#issuecomment-682380919 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682370120 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682369021 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
virajjasani commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682357184 Got it, let me just trigger build one last time. Thanks This is an automated message from the Apache Git

[GitHub] [hbase] bsglz commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
bsglz commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682355900 No, it will success no matter the timezone, i mean it could be merged with no more change. Thanks. @virajjasani

[GitHub] [hbase] Apache-HBase commented on pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2254: URL: https://github.com/apache/hbase/pull/2254#issuecomment-682354584 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on pull request #2270: HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult…

2020-08-28 Thread GitBox
virajjasani commented on pull request #2270: URL: https://github.com/apache/hbase/pull/2270#issuecomment-682348869 @bsglz This was still failing for PDT timezone right? I didn't get your concern. You are saying we don't need this patch at all?

[jira] [Resolved] (HBASE-24898) Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider

2020-08-28 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24898. -- Resolution: Fixed > Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis()

[GitHub] [hbase] virajjasani closed pull request #2319: HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…

2020-08-28 Thread GitBox
virajjasani closed pull request #2319: URL: https://github.com/apache/hbase/pull/2319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2149: HBASE-24760 Add a config hbase.rsgroup.fallback.enable for RSGroup fallback feature

2020-08-28 Thread GitBox
Apache-HBase commented on pull request #2149: URL: https://github.com/apache/hbase/pull/2149#issuecomment-682343603 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m