[GitHub] [hbase] Apache-HBase commented on pull request #2304: HBASE-24916: Region hole contains wrong regions pair when hole is cre…

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2304: URL: https://github.com/apache/hbase/pull/2304#issuecomment-683380180 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2330: HBASE-24964 Remove MetaTableAccessor.tableExists

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2330: URL: https://github.com/apache/hbase/pull/2330#issuecomment-683377405 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache9 commented on a change in pull request #2329: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-29 Thread GitBox
Apache9 commented on a change in pull request #2329: URL: https://github.com/apache/hbase/pull/2329#discussion_r479720531 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/MetaCellComparator.java ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software

[GitHub] [hbase] Apache9 opened a new pull request #2330: HBASE-24964 Remove MetaTableAccessor.tableExists

2020-08-29 Thread GitBox
Apache9 opened a new pull request #2330: URL: https://github.com/apache/hbase/pull/2330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache9 commented on pull request #2328: HBASE-24925 SCP reduce unnecessary get requests

2020-08-29 Thread GitBox
Apache9 commented on pull request #2328: URL: https://github.com/apache/hbase/pull/2328#issuecomment-683373349 So you mean we should all the table states in memory? For now it is cached on demand. This is an automated

[GitHub] [hbase] shahrs87 commented on pull request #2323: [HBASE-24957] ZKTableStateClientSideReader#isDisabledTable doesn't check if table exists or not.

2020-08-29 Thread GitBox
shahrs87 commented on pull request #2323: URL: https://github.com/apache/hbase/pull/2323#issuecomment-683372226 @virajjasani @bharathv Could you please help review this change ? Thank you ! This is an automated message

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-683371480 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] brfrn169 commented on a change in pull request #2228: HBASE-24602 Add Increment and Append support to CheckAndMutate

2020-08-29 Thread GitBox
brfrn169 commented on a change in pull request #2228: URL: https://github.com/apache/hbase/pull/2228#discussion_r479714896 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java ## @@ -742,36 +741,35 @@ private Result increment(final

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-29 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r479713606 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/LockTimeoutException.java ## @@ -0,0 +1,32 @@ +/** + * + * Licensed to the Apache

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-08-29 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r479713547 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionConfiguration.java ## @@ -117,6 +119,11 @@ this.writeRpcTimeout

[jira] [Commented] (HBASE-24949) Optimize FSTableDescriptors.get to not always go to fs when cache miss

2020-08-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187119#comment-17187119 ] Hudson commented on HBASE-24949: Results for branch master [build #27 on

[GitHub] [hbase] Apache-HBase commented on pull request #2329: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2329: URL: https://github.com/apache/hbase/pull/2329#issuecomment-683344263 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2329: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2329: URL: https://github.com/apache/hbase/pull/2329#issuecomment-683343594 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2329: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2329: URL: https://github.com/apache/hbase/pull/2329#issuecomment-683330357 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminProtos.AdminLogEntry getLogEntries(RpcController

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminProtos.AdminLogEntry getLogEntries(RpcController

[GitHub] [hbase] virajjasani opened a new pull request #2329: HBASE-24968 : Move META_COMPARATOR to subclass MetaCellComparator

2020-08-29 Thread GitBox
virajjasani opened a new pull request #2329: URL: https://github.com/apache/hbase/pull/2329 Jira: https://issues.apache.org/jira/browse/HBASE-24968 * Break subclass referencing of MetaCellComparator from superclass CellComparatorImpl static initializer

[jira] [Created] (HBASE-24968) One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator

2020-08-29 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-24968: Summary: One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator Key: HBASE-24968 URL: https://issues.apache.org/jira/browse/HBASE-24968

[jira] [Assigned] (HBASE-24968) One of static initializers of CellComparatorImpl referring to subclass MetaCellComparator

2020-08-29 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24968: Assignee: Viraj Jasani > One of static initializers of CellComparatorImpl referring to

[jira] [Updated] (HBASE-24949) Optimize FSTableDescriptors.get to not always go to fs when cache miss

2020-08-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24949: -- Fix Version/s: 2.4.0 3.0.0-alpha-1 > Optimize FSTableDescriptors.get to not always

[jira] [Resolved] (HBASE-24949) Optimize FSTableDescriptors.get to not always go to fs when cache miss

2020-08-29 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24949. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to master and branch-2. Thanks [~zghao] for

[GitHub] [hbase] Apache9 merged pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-29 Thread GitBox
Apache9 merged pull request #2317: URL: https://github.com/apache/hbase/pull/2317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-29 Thread GitBox
Apache9 commented on pull request #2317: URL: https://github.com/apache/hbase/pull/2317#issuecomment-683297792 OK we run out of space again... Anyway, let me merge since the UTs are all fine now. This is an automated

[GitHub] [hbase] Apache-HBase commented on pull request #2328: HBASE-24925 SCP reduce unnecessary get requests

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2328: URL: https://github.com/apache/hbase/pull/2328#issuecomment-683284129 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminLogEntry getLogEntries(RpcController controller,

[GitHub] [hbase] virajjasani edited a comment on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani edited a comment on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminLogEntry getLogEntries(RpcController controller,

[GitHub] [hbase] virajjasani commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-683283809 We have two separate RPC APIs generic for Master and RS Rpcs: **RSRpcServices:** ``` public AdminLogEntry getLogEntries(RpcController controller,

[GitHub] [hbase] Apache-HBase commented on pull request #2328: HBASE-24925 SCP reduce unnecessary get requests

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2328: URL: https://github.com/apache/hbase/pull/2328#issuecomment-683283301 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Refuse to update configuration of default group

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-683283131 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Refuse to update configuration of default group

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-683277601 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-08-29 Thread GitBox
virajjasani commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r478596596 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ## @@ -4212,4 +4213,29 @@ private void

[GitHub] [hbase] wchevreuil commented on pull request #2255: HBASE-24877 Add option to avoid aborting RS process upon uncaught exc…

2020-08-29 Thread GitBox
wchevreuil commented on pull request #2255: URL: https://github.com/apache/hbase/pull/2255#issuecomment-683274583 It looks like this is causing some of the UTs to timeout. Let me dig into it further. This is an automated

[jira] [Comment Edited] (HBASE-24925) SCP reduce unnecessary get requests

2020-08-29 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186924#comment-17186924 ] Bo Cui edited comment on HBASE-24925 at 8/29/20, 10:50 AM: ---

[GitHub] [hbase] Apache-HBase commented on pull request #2328: HBASE-24925 SCP reduce unnecessary get requests

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2328: URL: https://github.com/apache/hbase/pull/2328#issuecomment-683269844 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2326: URL: https://github.com/apache/hbase/pull/2326#issuecomment-683269558 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2327: URL: https://github.com/apache/hbase/pull/2327#issuecomment-683267934 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24925) SCP reduce unnecessary get requests

2020-08-29 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186924#comment-17186924 ] Bo Cui commented on HBASE-24925: !image-2020-08-29-17-46-00-900.png! If the thread pool is not used,

[jira] [Updated] (HBASE-24925) SCP reduce unnecessary get requests

2020-08-29 Thread Bo Cui (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Cui updated HBASE-24925: --- Attachment: image-2020-08-29-17-46-00-900.png > SCP reduce unnecessary get requests >

[jira] [Updated] (HBASE-24967) The table.jsp cost long time to load if the table include closed regions

2020-08-29 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24967: --- Description: The reason is that, the compaction state of table need to iterate all regions to call

[GitHub] [hbase] cuibo01 opened a new pull request #2328: HBASE-24925 SCP reduce unnecessary get requests

2020-08-29 Thread GitBox
cuibo01 opened a new pull request #2328: URL: https://github.com/apache/hbase/pull/2328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-24967) The table.jsp cost long time to load if the table include closed regions

2020-08-29 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24967: --- Description: The reason is that, the compaction state of table need to iterate all regions to call

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-683263056 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2126: HBASE-24759 Refuse to update configuration of default group

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2126: URL: https://github.com/apache/hbase/pull/2126#issuecomment-683262907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2326: URL: https://github.com/apache/hbase/pull/2326#issuecomment-683262166 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-24759) Refuse to update configuration of default group

2020-08-29 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24759: Summary: Refuse to update configuration of default group (was: Persisting configuration of default

[jira] [Updated] (HBASE-24759) Persisting configuration of default rsgroup

2020-08-29 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin updated HBASE-24759: Description: In the current scenario, we didn't store the default rsgroup information. But after 

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-683256149 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2317: URL: https://github.com/apache/hbase/pull/2317#issuecomment-683249545 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2317: HBASE-24949 Optimize FSTableDescriptors.get to not always go to fs wh…

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2317: URL: https://github.com/apache/hbase/pull/2317#issuecomment-683249148 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ankitjain64 opened a new pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers

2020-08-29 Thread GitBox
ankitjain64 opened a new pull request #2327: URL: https://github.com/apache/hbase/pull/2327 JIRA: https://issues.apache.org/jira/browse/HBASE-24764 JIRA Description: Today, if a user needs to apply some common base peer configs to all the replication peers on the cluster,

[GitHub] [hbase] Apache-HBase commented on pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2326: URL: https://github.com/apache/hbase/pull/2326#issuecomment-683246168 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bsglz opened a new pull request #2326: HBASE-24967 The table.jsp cost long time to load if the table include…

2020-08-29 Thread GitBox
bsglz opened a new pull request #2326: URL: https://github.com/apache/hbase/pull/2326 … closed regions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (HBASE-24967) The table.jsp cost long time to load if the table include closed regions

2020-08-29 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24967: --- Description: The reason is that, the compaction state of table need to iterate all regions to call

[jira] [Created] (HBASE-24967) The table.jsp cost long time to load if the table include closed regions

2020-08-29 Thread Zheng Wang (Jira)
Zheng Wang created HBASE-24967: -- Summary: The table.jsp cost long time to load if the table include closed regions Key: HBASE-24967 URL: https://issues.apache.org/jira/browse/HBASE-24967 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2158: HBASE-24769 Auto scale RSGroup

2020-08-29 Thread GitBox
Apache-HBase commented on pull request #2158: URL: https://github.com/apache/hbase/pull/2158#issuecomment-683243195 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m