[GitHub] [hbase] bsglz commented on pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-09-15 Thread GitBox
bsglz commented on pull request #2254: URL: https://github.com/apache/hbase/pull/2254#issuecomment-693182303 Thanks a lot. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hbase] Reidddddd commented on a change in pull request #2396: [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp

2020-09-15 Thread GitBox
Reidd commented on a change in pull request #2396: URL: https://github.com/apache/hbase/pull/2396#discussion_r489154603 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java ## @@ -5028,73 +5028,70 @@ public void

[GitHub] [hbase] Reidddddd commented on a change in pull request #2396: [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp

2020-09-15 Thread GitBox
Reidd commented on a change in pull request #2396: URL: https://github.com/apache/hbase/pull/2396#discussion_r489154523 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java ## @@ -5028,73 +5028,70 @@ public void

[jira] [Commented] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-09-15 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196665#comment-17196665 ] Zheng Wang commented on HBASE-24875: Thanks for all comments. > Remove the force param for unassign

[jira] [Commented] (HBASE-25021) Nightly job should skip hadoop-2 integration test for master

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196655#comment-17196655 ] Hudson commented on HBASE-25021: Results for branch HBASE-25021 [build #8 on

[jira] [Resolved] (HBASE-24875) Remove the force param for unassign since it dose not take effect any more

2020-09-15 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-24875. - Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed > Remove the force param for unassign

[GitHub] [hbase] busbey merged pull request #2254: HBASE-24875 Remove the force param for unassign since it dose not take effect any more

2020-09-15 Thread GitBox
busbey merged pull request #2254: URL: https://github.com/apache/hbase/pull/2254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] ankitjain64 commented on pull request #2327: Hbase-24764 : Add support of adding base peer configs via hbase-site.xml for all replication peers

2020-09-15 Thread GitBox
ankitjain64 commented on pull request #2327: URL: https://github.com/apache/hbase/pull/2327#issuecomment-693136239 @bharathv : Can you take a look at this. Thanks. This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-25034) Table regions details on master GUI display slowly.

2020-09-15 Thread DingSheng Li (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] DingSheng Li updated HBASE-25034: - Summary: Table regions details on master GUI display slowly. (was: Master GUI displays table

[jira] [Commented] (HBASE-25034) Master GUI displays table regions slowly.

2020-09-15 Thread freedom1993 feng (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196618#comment-17196618 ] freedom1993 feng commented on HBASE-25034: -- we have the same problem. > Master GUI displays

[jira] [Created] (HBASE-25034) Master GUI displays table regions slowly.

2020-09-15 Thread DingSheng Li (Jira)
DingSheng Li created HBASE-25034: Summary: Master GUI displays table regions slowly. Key: HBASE-25034 URL: https://issues.apache.org/jira/browse/HBASE-25034 Project: HBase Issue Type:

[GitHub] [hbase] infraio merged pull request #2379: HBASE-25009: Hbck chore logs wrong message when loading regions from RS

2020-09-15 Thread GitBox
infraio merged pull request #2379: URL: https://github.com/apache/hbase/pull/2379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] infraio merged pull request #2395: HBASE-25014 ScheduledChore is never triggered when initalDelay > 1.5*…

2020-09-15 Thread GitBox
infraio merged pull request #2395: URL: https://github.com/apache/hbase/pull/2395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196609#comment-17196609 ] Hudson commented on HBASE-24831: Results for branch master [build #48 on

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-693097288 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-693096819 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-693092325 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-693090757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR

2020-09-15 Thread GitBox
apurtell commented on a change in pull request #2280: URL: https://github.com/apache/hbase/pull/2280#discussion_r489027430 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java ## @@ -56,6 +56,7 @@ /** Set this key to {@code true}

[GitHub] [hbase] apurtell commented on a change in pull request #2280: HBASE-18095 branch-1 umbrella PR

2020-09-15 Thread GitBox
apurtell commented on a change in pull request #2280: URL: https://github.com/apache/hbase/pull/2280#discussion_r489026637 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MasterRegistry.java ## @@ -0,0 +1,266 @@ +/* + * + * Licensed to the Apache

[GitHub] [hbase] apurtell commented on a change in pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-15 Thread GitBox
apurtell commented on a change in pull request #2261: URL: https://github.com/apache/hbase/pull/2261#discussion_r489023341 ## File path: hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto ## @@ -693,6 +694,14 @@ message SwitchExceedThrottleQuotaResponse {

[GitHub] [hbase] shahrs87 commented on a change in pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-09-15 Thread GitBox
shahrs87 commented on a change in pull request #2322: URL: https://github.com/apache/hbase/pull/2322#discussion_r489018057 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java ## @@ -968,6 +968,19 @@ private RegionLocations

[GitHub] [hbase] Apache-HBase commented on pull request #2322: [HBASE-24956] ConnectionManager#locateRegionInMeta waits for user region lock indefinitely.

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2322: URL: https://github.com/apache/hbase/pull/2322#issuecomment-693004287 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196571#comment-17196571 ] Hudson commented on HBASE-24831: Results for branch branch-2.3 [build #44 on

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-692999736 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2261: HBASE-24528 : BalancerDecision queue implementation in HMaster with Admin API

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2261: URL: https://github.com/apache/hbase/pull/2261#issuecomment-692988092 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25033) Provide an option for do-release-docker to ignore svn ci

2020-09-15 Thread Viraj Jasani (Jira)
Viraj Jasani created HBASE-25033: Summary: Provide an option for do-release-docker to ignore svn ci Key: HBASE-25033 URL: https://issues.apache.org/jira/browse/HBASE-25033 Project: HBase

[jira] [Created] (HBASE-25032) Wait for region server to become online before considering it online in Master

2020-09-15 Thread Sandeep Guggilam (Jira)
Sandeep Guggilam created HBASE-25032: Summary: Wait for region server to become online before considering it online in Master Key: HBASE-25032 URL: https://issues.apache.org/jira/browse/HBASE-25032

[jira] [Commented] (HBASE-25032) Wait for region server to become online before considering it online in Master

2020-09-15 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196506#comment-17196506 ] Sandeep Guggilam commented on HBASE-25032: -- FYI [~apurtell] > Wait for region server to become

[jira] [Updated] (HBASE-25032) Wait for region server to become online before adding it to online servers in Master

2020-09-15 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Guggilam updated HBASE-25032: - Summary: Wait for region server to become online before adding it to online servers in

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-692928190 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24984) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used with multi operation

2020-09-15 Thread Liu Junhong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196500#comment-17196500 ] Liu Junhong edited comment on HBASE-24984 at 9/15/20, 7:20 PM: --- The

[jira] [Commented] (HBASE-24984) WAL corruption due to early DBBs re-use when Durability.ASYNC_WAL is used with multi operation

2020-09-15 Thread Liu Junhong (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196500#comment-17196500 ] Liu Junhong commented on HBASE-24984: - The cleanUp in ServerCall may be called more than once. So we

[GitHub] [hbase] wchevreuil commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-09-15 Thread GitBox
wchevreuil commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-692904135 > Please create addendum first and then backport it to branch-2? Sure, addendum is created here: https://github.com/apache/hbase/pull/2400 > And now, seems we will

[jira] [Commented] (HBASE-25021) Nightly job should skip hadoop-2 integration test for master

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196468#comment-17196468 ] Hudson commented on HBASE-25021: Results for branch HBASE-25021 [build #7 on

[GitHub] [hbase] Apache-HBase commented on pull request #2404: HBASE-25023 NPE while shutdown master node

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2404: URL: https://github.com/apache/hbase/pull/2404#issuecomment-692901606 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-692857776 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-692857511 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #1708: HBASE-19577 Use log4j2 instead of log4j for logging

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #1708: URL: https://github.com/apache/hbase/pull/1708#issuecomment-692852041 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-692844518 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-692842768 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] ndimiduk commented on a change in pull request #2163: HBASE-24789 When table level quota is set and violated, pre existing …

2020-09-15 Thread GitBox
ndimiduk commented on a change in pull request #2163: URL: https://github.com/apache/hbase/pull/2163#discussion_r488798591 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java ## @@ -284,6 +285,9 @@ public void delete() throws

[GitHub] [hbase] ndimiduk commented on a change in pull request #2163: HBASE-24789 When table level quota is set and violated, pre existing …

2020-09-15 Thread GitBox
ndimiduk commented on a change in pull request #2163: URL: https://github.com/apache/hbase/pull/2163#discussion_r488798201 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaBasicFunctioning.java ## @@ -257,4 +258,35 @@ public boolean

[GitHub] [hbase] virajjasani commented on a change in pull request #2396: [Flaky Test][branch-1] TestFromClientSide#testCheckAndDeleteWithCompareOp

2020-09-15 Thread GitBox
virajjasani commented on a change in pull request #2396: URL: https://github.com/apache/hbase/pull/2396#discussion_r488786977 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java ## @@ -5028,73 +5028,70 @@ public void

[jira] [Resolved] (HBASE-24227) [JDK11] shell fails to launch

2020-09-15 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-24227. -- Resolution: Cannot Reproduce Thanks for checking. > [JDK11] shell fails to launch >

[jira] [Commented] (HBASE-25022) Remove 'hbase.testing.nocluster' config

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196251#comment-17196251 ] Hudson commented on HBASE-25022: Results for branch branch-2 [build #41 on

[jira] [Commented] (HBASE-25002) Create simple pattern matching query for retrieving metrics matching the pattern

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196252#comment-17196252 ] Hudson commented on HBASE-25002: Results for branch branch-2 [build #41 on

[jira] [Commented] (HBASE-25016) Should close ResultScanner in MetaTableAccessor.scanByRegionEncodedName

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196250#comment-17196250 ] Hudson commented on HBASE-25016: Results for branch branch-2 [build #41 on

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-692800409 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-24831. -- Hadoop Flags: Reviewed Resolution: Fixed > Avoid invoke Counter using reflection in

[GitHub] [hbase] Apache-HBase commented on pull request #2385: HBASE-24950 Another solution for Splittable Meta

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2385: URL: https://github.com/apache/hbase/pull/2385#issuecomment-692773866 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2392: HBASE-25013 Avoid reset the backup master root cache every time when …

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2392: URL: https://github.com/apache/hbase/pull/2392#issuecomment-692773503 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] virajjasani closed pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
virajjasani closed pull request #2403: URL: https://github.com/apache/hbase/pull/2403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2400: HBASE-24877 addendum: additional checks to avoid one extra possible race control in the initialize loop

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2400: URL: https://github.com/apache/hbase/pull/2400#issuecomment-692758869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692757969 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692751481 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692748757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2402: HBASE-25031 [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2402: URL: https://github.com/apache/hbase/pull/2402#issuecomment-692739879 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25021) Nightly job should skip hadoop-2 integration test for master

2020-09-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196171#comment-17196171 ] Duo Zhang commented on HBASE-25021: --- Some updates here, finally I successfully skipped the hadoop 2

[GitHub] [hbase] virajjasani commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
virajjasani commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692728676 > Thanks for finding out this. In general, I do not think we should expose these methods to end users but since they are there already, we'b better follow the compatibility

[GitHub] [hbase] Apache-HBase commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692726849 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2400: HBASE-24877 addendum: additional checks to avoid one extra possible race control in the initialize loop

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2400: URL: https://github.com/apache/hbase/pull/2400#issuecomment-692726295 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2401: HBASE-25030 [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2401: URL: https://github.com/apache/hbase/pull/2401#issuecomment-692724183 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 7m

[GitHub] [hbase] Apache-HBase commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692723313 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2403: URL: https://github.com/apache/hbase/pull/2403#issuecomment-692718203 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Joseph295 opened a new pull request #2404: HBASE-25023 NPE while shutdown master node

2020-09-15 Thread GitBox
Joseph295 opened a new pull request #2404: URL: https://github.com/apache/hbase/pull/2404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-24929) Introduce a special CellComparator for master local region

2020-09-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24929: -- Fix Version/s: HBASE-24950 > Introduce a special CellComparator for master local region >

[jira] [Resolved] (HBASE-24929) Introduce a special CellComparator for master local region

2020-09-15 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-24929. --- Hadoop Flags: Reviewed Resolution: Fixed Merged tp branch HBASE-24950. Thanks [~zghao] for

[jira] [Commented] (HBASE-24227) [JDK11] shell fails to launch

2020-09-15 Thread Zhuoyue Huang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196134#comment-17196134 ] Zhuoyue Huang commented on HBASE-24227: --- Can't reproduce it {code:java} $

[GitHub] [hbase] Apache9 merged pull request #2378: HBASE-24929 Introduce a special CellComparator for master local region

2020-09-15 Thread GitBox
Apache9 merged pull request #2378: URL: https://github.com/apache/hbase/pull/2378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache9 commented on a change in pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
Apache9 commented on a change in pull request #2403: URL: https://github.com/apache/hbase/pull/2403#discussion_r488650450 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableRecordReaderImpl.java ## @@ -267,6 +288,15 @@ private void

[GitHub] [hbase] virajjasani opened a new pull request #2403: HBASE-24831 : Addendum for source compatibility

2020-09-15 Thread GitBox
virajjasani opened a new pull request #2403: URL: https://github.com/apache/hbase/pull/2403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-692681451 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196073#comment-17196073 ] Viraj Jasani edited comment on HBASE-24831 at 9/15/20, 11:51 AM: -

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-692664491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2397: HBASE-24999 Master manages ReplicationServers

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2397: URL: https://github.com/apache/hbase/pull/2397#issuecomment-692663236 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-692661722 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2397: HBASE-24999 Master manages ReplicationServers

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2397: URL: https://github.com/apache/hbase/pull/2397#issuecomment-692661371 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196073#comment-17196073 ] Viraj Jasani edited comment on HBASE-24831 at 9/15/20, 11:38 AM: -

[jira] [Reopened] (HBASE-24831) Avoid invoke Counter using reflection in SnapshotInputFormat

2020-09-15 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reopened HBASE-24831: -- Reopening since this is breaking source compatibility by removing protected methods of IA.Public

[GitHub] [hbase] Reidddddd opened a new pull request #2402: HBASE-25031 [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer

2020-09-15 Thread GitBox
Reidd opened a new pull request #2402: URL: https://github.com/apache/hbase/pull/2402 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (HBASE-25031) [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer

2020-09-15 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25031: -- Fix Version/s: 1.7.0 > [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer >

[jira] [Created] (HBASE-25031) [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer

2020-09-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25031: - Summary: [Flaky Test] TestReplicationDisableInactivePeer#testDisableInactivePeer Key: HBASE-25031 URL: https://issues.apache.org/jira/browse/HBASE-25031 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-692629711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Reidddddd commented on pull request #2401: HBASE-25030 [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread GitBox
Reidd commented on pull request #2401: URL: https://github.com/apache/hbase/pull/2401#issuecomment-692626322 The fix is easy, after cluster restart, we should regain the connection. This is an automated message from the

[GitHub] [hbase] Reidddddd opened a new pull request #2401: HBASE-25030 [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread GitBox
Reidd opened a new pull request #2401: URL: https://github.com/apache/hbase/pull/2401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hbase] Apache-HBase commented on pull request #2384: HBASE-25012 HBASE-24359 causes replication missed log of some RemoteE…

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2384: URL: https://github.com/apache/hbase/pull/2384#issuecomment-692624415 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25030) [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread Reid Chan (Jira)
Reid Chan created HBASE-25030: - Summary: [Flaky Test] TestRestartCluster#testClusterRestart Key: HBASE-25030 URL: https://issues.apache.org/jira/browse/HBASE-25030 Project: HBase Issue Type:

[GitHub] [hbase] Apache-HBase commented on pull request #2400: HBASE-24877 addendum: additional checks to avoid one extra possible race control in the initialize loop

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2400: URL: https://github.com/apache/hbase/pull/2400#issuecomment-692624238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25030) [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196038#comment-17196038 ] Reid Chan commented on HBASE-25030: --- cc [~andrew.purt...@gmail.com] > [Flaky Test]

[jira] [Updated] (HBASE-25030) [Flaky Test] TestRestartCluster#testClusterRestart

2020-09-15 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-25030: -- Fix Version/s: 1.7.0 > [Flaky Test] TestRestartCluster#testClusterRestart >

[GitHub] [hbase] Apache-HBase commented on pull request #2384: HBASE-25012 HBASE-24359 causes replication missed log of some RemoteE…

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2384: URL: https://github.com/apache/hbase/pull/2384#issuecomment-692620692 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil commented on pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-09-15 Thread GitBox
wchevreuil commented on pull request #2191: URL: https://github.com/apache/hbase/pull/2191#issuecomment-692612301 > I left a few suggestions, but I think this is also looks fine as-is. Thanks for reviewing it @joshelser . Added the TRACE logging, replied on the other suggestions.

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-09-15 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r488543053 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java ## @@ -324,4 +326,51 @@ void

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-09-15 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r488540526 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceShipper.java ## @@ -324,4 +326,51 @@ void

[GitHub] [hbase] wchevreuil commented on a change in pull request #2191: HBASE-24813 ReplicationSource should clear buffer usage on Replicatio…

2020-09-15 Thread GitBox
wchevreuil commented on a change in pull request #2191: URL: https://github.com/apache/hbase/pull/2191#discussion_r488539725 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java ## @@ -626,14 +626,12 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2399: HBASE-24877 Add option to avoid aborting RS process upon uncaught exceptions happen on replication source

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2399: URL: https://github.com/apache/hbase/pull/2399#issuecomment-692602921 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil opened a new pull request #2400: HBASE-24877 addendum: additional checks to avoid one extra possible race control in the initialize loop

2020-09-15 Thread GitBox
wchevreuil opened a new pull request #2400: URL: https://github.com/apache/hbase/pull/2400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hbase] Apache-HBase commented on pull request #2397: HBASE-24999 Master manages ReplicationServers

2020-09-15 Thread GitBox
Apache-HBase commented on pull request #2397: URL: https://github.com/apache/hbase/pull/2397#issuecomment-692594904 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25021) Nightly job should skip hadoop-2 integration test for master

2020-09-15 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196009#comment-17196009 ] Hudson commented on HBASE-25021: Results for branch HBASE-25021 [build #6 on

  1   2   >