[GitHub] [hbase] huaxiangsun commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r509003475 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] Apache-HBase commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-713318222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-713312633 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25210) RegionInfo.isOffline is now a duplication with RegionInfo.isSplit

2020-10-20 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25210: - Summary: RegionInfo.isOffline is now a duplication with RegionInfo.isSplit Key: HBASE-25210 URL: https://issues.apache.org/jira/browse/HBASE-25210 Project: HBase

[GitHub] [hbase] Apache-HBase commented on pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2541: URL: https://github.com/apache/hbase/pull/2541#issuecomment-713282433 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Updated] (HBASE-25207) Revisit the implementation and usage of RegionStates.include

2020-10-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25207: -- Component/s: Region Assignment > Revisit the implementation and usage of RegionStates.include >

[GitHub] [hbase] Apache-HBase commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-713274238 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
Apache9 commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508960285 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713267715 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-713259579 On a high level design, we used to have a `hbase.meta.replicas.use` config to control whether to make use meta replicas at client side. Do we want to deprecate this config and

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-20 Thread GitBox
anoopsjohn commented on a change in pull request #2483: URL: https://github.com/apache/hbase/pull/2483#discussion_r508268448 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -9143,4 +9162,8 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713243775 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713237969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713236711 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache-HBase commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713207495 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2523: URL: https://github.com/apache/hbase/pull/2523#issuecomment-713198337 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] sandeepvinayak commented on pull request #2556: HBASE-25193: Add support for row prefix and type in the WAL Pretty Printer

2020-10-20 Thread GitBox
sandeepvinayak commented on pull request #2556: URL: https://github.com/apache/hbase/pull/2556#issuecomment-713193016 @wchevreuil This makes sense, I added both the options keeping them mutually exclusive. This is an

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r508884289 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -140,39 +188,76 @@ private static

[GitHub] [hbase] ndimiduk commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
ndimiduk commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r508883897 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -71,38 +76,81 @@ static final

[GitHub] [hbase] brfrn169 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
brfrn169 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-713182063 Thank you for reviewing this! @Apache9 > If you do not mind, I plan to open an issue first to address the problem of the include method, and then we could come back to

[GitHub] [hbase] brfrn169 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-20 Thread GitBox
brfrn169 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-713179853 Thank you very much! @Apache9 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713154876 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508824027 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508823274 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508821616 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508821616 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaSimpleChooser.java ## @@ -0,0 +1,248 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508821332 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaChooser.java ## @@ -0,0 +1,53 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508819430 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaChooser.java ## @@ -0,0 +1,53 @@ +/** + *

[GitHub] [hbase] huaxiangsun commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508813012 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaChooser.java ## @@ -0,0 +1,53 @@ +/** + *

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713115395 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-713089262 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-713087298 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Resolved] (HBASE-25209) Add CLI support to remove a particular configuration from ReplicationPeerConfig.

2020-10-20 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Jain resolved HBASE-25209. Resolution: Not A Problem > Add CLI support to remove a particular configuration from >

[jira] [Commented] (HBASE-25209) Add CLI support to remove a particular configuration from ReplicationPeerConfig.

2020-10-20 Thread Ankit Jain (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217879#comment-17217879 ] Ankit Jain commented on HBASE-25209: Closing this out as we can set an empty string as part of the

[GitHub] [hbase] saintstack commented on a change in pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
saintstack commented on a change in pull request #2570: URL: https://github.com/apache/hbase/pull/2570#discussion_r508765010 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetaReplicaLoadBalanceReplicaChooser.java ## @@ -0,0 +1,53 @@ +/** + * Licensed

[jira] [Commented] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217866#comment-17217866 ] Hudson commented on HBASE-25204: Results for branch master [build #101 on

[jira] [Commented] (HBASE-25166) MobFileCompactionChore is closing the master's shared cluster connection

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217865#comment-17217865 ] Hudson commented on HBASE-25166: Results for branch master [build #101 on

[jira] [Commented] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217864#comment-17217864 ] Hudson commented on HBASE-25194: Results for branch master [build #101 on

[jira] [Commented] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217867#comment-17217867 ] Hudson commented on HBASE-25203: Results for branch master [build #101 on

[jira] [Created] (HBASE-25209) Add CLI support to remove a particular configuration from ReplicationPeerConfig.

2020-10-20 Thread Ankit Jain (Jira)
Ankit Jain created HBASE-25209: -- Summary: Add CLI support to remove a particular configuration from ReplicationPeerConfig. Key: HBASE-25209 URL: https://issues.apache.org/jira/browse/HBASE-25209

[GitHub] [hbase] Apache-HBase commented on pull request #2483: HBASE-25026 - Create a metric to track scans that have no start row and/or stop row

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2483: URL: https://github.com/apache/hbase/pull/2483#issuecomment-713046815 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] pankaj72981 commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
pankaj72981 commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-713036605 @saintstack Sir, Do you know why continuous-integration/jenkins/pr-merge can't be build? This is an

[GitHub] [hbase] busbey commented on a change in pull request #2419: HBASE-25050 - We initialize Filesystems more than once.

2020-10-20 Thread GitBox
busbey commented on a change in pull request #2419: URL: https://github.com/apache/hbase/pull/2419#discussion_r508709843 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java ## @@ -82,7 +82,10 @@ public HFileSystem(Configuration conf, boolean

[GitHub] [hbase] Apache-HBase commented on pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2570: URL: https://github.com/apache/hbase/pull/2570#issuecomment-713008034 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Assigned] (HBASE-25158) Enhance balancer to make sure no meta primary/replica regions are going to be assigned to one same region server.

2020-10-20 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-25158: Assignee: Huaxiang Sun > Enhance balancer to make sure no meta primary/replica regions

[jira] [Commented] (HBASE-25126) Add load balance logic in hbase-client to distribute read load over meta replica regions.

2020-10-20 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217749#comment-17217749 ] Huaxiang Sun commented on HBASE-25126: -- a patch is posted for review. > Add load balance logic in

[jira] [Work started] (HBASE-25126) Add load balance logic in hbase-client to distribute read load over meta replica regions.

2020-10-20 Thread Huaxiang Sun (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-25126 started by Huaxiang Sun. > Add load balance logic in hbase-client to distribute read load over meta >

[jira] [Created] (HBASE-25208) Running an hbase-shell command in non-interactive mode should not complain about missing files when it fails to talk to the cluster.

2020-10-20 Thread Sean Busbey (Jira)
Sean Busbey created HBASE-25208: --- Summary: Running an hbase-shell command in non-interactive mode should not complain about missing files when it fails to talk to the cluster. Key: HBASE-25208 URL:

[GitHub] [hbase] huaxiangsun opened a new pull request #2570: HBASE-25126 Add load balance logic in hbase-client to distribute read…

2020-10-20 Thread GitBox
huaxiangsun opened a new pull request #2570: URL: https://github.com/apache/hbase/pull/2570 … load over meta replica regions It adds load balance support. With "hbase.meta.replicas.use" set to true, client support meta replica feature. The existing mode is called HighAvailable,

[GitHub] [hbase] Apache-HBase commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712971925 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712968715 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217685#comment-17217685 ] Duo Zhang commented on HBASE-25200: ---

[jira] [Commented] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217684#comment-17217684 ] Hudson commented on HBASE-25204: Results for branch branch-2.2 [build #104 on

[jira] [Commented] (HBASE-25093) the RSGroupBasedLoadBalancer#retainAssignment throws NPE

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217681#comment-17217681 ] Hudson commented on HBASE-25093: Results for branch branch-2.2 [build #104 on

[jira] [Commented] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217683#comment-17217683 ] Hudson commented on HBASE-25203: Results for branch branch-2.2 [build #104 on

[jira] [Commented] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217682#comment-17217682 ] Hudson commented on HBASE-25194: Results for branch branch-2.2 [build #104 on

[jira] [Created] (HBASE-25207) Revisit the implementation and usage of RegionStates.include

2020-10-20 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25207: - Summary: Revisit the implementation and usage of RegionStates.include Key: HBASE-25207 URL: https://issues.apache.org/jira/browse/HBASE-25207 Project: HBase

[GitHub] [hbase] Apache9 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712919691 Oh it is in HBASE-14614, where the patch is several MB, which means we can not know the actual reason on why the code is like this... If you do not mind, I plan to open an

[GitHub] [hbase] Apache9 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712916667 Oh the logic is already there before HBASE-23187. In HBASE-23187 we just add checks for RegionInfo. Let me check for earlier changes.

[GitHub] [hbase] Apache-HBase commented on pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2541: URL: https://github.com/apache/hbase/pull/2541#issuecomment-712914852 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] Apache9 commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712914659 They are added by this issue. https://issues.apache.org/jira/browse/HBASE-23187 Let me take a look on the PR about why we add these checks.

[GitHub] [hbase] wchevreuil commented on a change in pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
wchevreuil commented on a change in pull request #2568: URL: https://github.com/apache/hbase/pull/2568#discussion_r508578218 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -5301,7 +5301,7 @@ private long

[GitHub] [hbase] Apache9 commented on a change in pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache9 commented on a change in pull request #2569: URL: https://github.com/apache/hbase/pull/2569#discussion_r508577459 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java ## @@ -100,6 +101,12 @@ protected Flow

[GitHub] [hbase] Apache-HBase commented on pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2541: URL: https://github.com/apache/hbase/pull/2541#issuecomment-712901977 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2565: HBASE-25003 Backport HBASE-24350 and HBASE-24779 to branch-2.2

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2565: URL: https://github.com/apache/hbase/pull/2565#issuecomment-712897746 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] Apache9 commented on pull request #2498: HBASE-24996 Support CheckAndMutate in Region.batchMutate()

2020-10-20 Thread GitBox
Apache9 commented on pull request #2498: URL: https://github.com/apache/hbase/pull/2498#issuecomment-712891186 Sorry for the late reply... This is a big change, need to find a suitable large block of time to review it... Will do this soon this week.

[GitHub] [hbase] Apache-HBase commented on pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2569: URL: https://github.com/apache/hbase/pull/2569#issuecomment-712882044 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-20 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-25206: - Description: Steps to reproduce are as follows: 1. Create a table and put some data

[GitHub] [hbase] brfrn169 opened a new pull request #2569: HBASE-25206 Data loss can happen if a cloned table loses original spl…

2020-10-20 Thread GitBox
brfrn169 opened a new pull request #2569: URL: https://github.com/apache/hbase/pull/2569 …it region(delete table) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-712844065 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25206) Data loss can happen if a cloned table loses original split region(delete table)

2020-10-20 Thread Toshihiro Suzuki (Jira)
Toshihiro Suzuki created HBASE-25206: Summary: Data loss can happen if a cloned table loses original split region(delete table) Key: HBASE-25206 URL: https://issues.apache.org/jira/browse/HBASE-25206

[GitHub] [hbase] Apache-HBase commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-712829053 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2568: URL: https://github.com/apache/hbase/pull/2568#issuecomment-712796440 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2541: HBASE-25173 Remove owner related methods in TableDescriptor/TableDescriptorBuilder

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2541: URL: https://github.com/apache/hbase/pull/2541#issuecomment-712780072 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-712776166 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-712772630 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] virajjasani commented on a change in pull request #2523: HBASE-25167 Normalizer support for hot config reloading

2020-10-20 Thread GitBox
virajjasani commented on a change in pull request #2523: URL: https://github.com/apache/hbase/pull/2523#discussion_r508380812 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java ## @@ -140,39 +188,76 @@ private static

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-712751518 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217485#comment-17217485 ] Hudson commented on HBASE-25203: Results for branch branch-2 [build #79 on

[jira] [Commented] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217486#comment-17217486 ] Hudson commented on HBASE-25204: Results for branch branch-2 [build #79 on

[jira] [Commented] (HBASE-25194) Do not publish workspace in flaky find job

2020-10-20 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217484#comment-17217484 ] Hudson commented on HBASE-25194: Results for branch branch-2 [build #79 on

[jira] [Commented] (HBASE-25200) Try enlarge the flaky test timeout for branch-2.2

2020-10-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217481#comment-17217481 ] Duo Zhang commented on HBASE-25200: --- I've deleted the broken builds for both nightly and flaky, now

[jira] [Resolved] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-25204. Fix Version/s: 2.2.7 1.4.14 2.4.0

[jira] [Created] (HBASE-25205) Corrupted hfiles append timestamp every time the region is trying to open

2020-10-20 Thread Junhong Xu (Jira)
Junhong Xu created HBASE-25205: -- Summary: Corrupted hfiles append timestamp every time the region is trying to open Key: HBASE-25205 URL: https://issues.apache.org/jira/browse/HBASE-25205 Project: HBase

[GitHub] [hbase] infraio merged pull request #2567: HBASE-25204 Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread GitBox
infraio merged pull request #2567: URL: https://github.com/apache/hbase/pull/2567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (HBASE-24840) Avoid shows closing region task when create table

2020-10-20 Thread Zheng Wang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang resolved HBASE-24840. Fix Version/s: 3.0.0-alpha-1 Resolution: Fixed > Avoid shows closing region task when

[GitHub] [hbase] Joseph295 opened a new pull request #2568: HBASE-25205 Corrupted hfiles append timestamp every time the region i…

2020-10-20 Thread GitBox
Joseph295 opened a new pull request #2568: URL: https://github.com/apache/hbase/pull/2568 …s trying to open This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Updated] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25203: -- Fix Version/s: 2.2.7 1.4.14 2.4.0 1.7.0

[jira] [Resolved] (HBASE-25203) Change the reference url to flaky list in our jenkins jobs

2020-10-20 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25203. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to all active branches. Thanks [~zghao] for

[jira] [Assigned] (HBASE-25204) Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang reassigned HBASE-25204: -- Assignee: Guanghao Zhang > Nightly job failed as the name of jdk and maven changed

[GitHub] [hbase] Apache9 merged pull request #2566: HBASE-25203 Change the reference url to flaky list in our jenkins jobs

2020-10-20 Thread GitBox
Apache9 merged pull request #2566: URL: https://github.com/apache/hbase/pull/2566 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-712670788 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
Apache-HBase commented on pull request #2537: URL: https://github.com/apache/hbase/pull/2537#issuecomment-712671103 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache9 commented on a change in pull request #2567: HBASE-25204 Nightly job failed as the name of jdk and maven changed

2020-10-20 Thread GitBox
Apache9 commented on a change in pull request #2567: URL: https://github.com/apache/hbase/pull/2567#discussion_r508266887 ## File path: dev-support/adhoc_run_tests/Jenkinsfile ## @@ -51,10 +51,10 @@ pipeline { stages { stage ('run tests') { tools { -

[GitHub] [hbase] pankaj72981 closed pull request #2537: HBASE-24977 Meta table shouldn't be modified as read only

2020-10-20 Thread GitBox
pankaj72981 closed pull request #2537: URL: https://github.com/apache/hbase/pull/2537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] pankaj72981 opened a new pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-10-20 Thread GitBox
pankaj72981 opened a new pull request #2313: URL: https://github.com/apache/hbase/pull/2313 Added "hbase.master.scp.retain.assignment" configuration parameter to contol the retain assignment during SCP. This is an automated

[GitHub] [hbase] pankaj72981 closed pull request #2313: HBASE-24900 Make retain assignment configurable during SCP

2020-10-20 Thread GitBox
pankaj72981 closed pull request #2313: URL: https://github.com/apache/hbase/pull/2313 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] symat commented on pull request #2539: HBASE-25181 Configure hash algorithm in wrapped encryption keys

2020-10-20 Thread GitBox
symat commented on pull request #2539: URL: https://github.com/apache/hbase/pull/2539#issuecomment-712646028 @busbey what do you think about the comment / question above? Do you think my approach (failing in case of unexpected hash algorithm) is OK, or do you think we should try to open /