[GitHub] [hbase] virajjasani commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
virajjasani commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573489127 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[jira] [Updated] (HBASE-25558) Adding audit log for execMasterService

2021-02-09 Thread lujie (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated HBASE-25558: -- Issue Type: Improvement (was: Bug) > Adding audit log for execMasterService >

[GitHub] [hbase] arshadmohammad commented on pull request #2883: HBASE-25492: Create table with rsgroup

2021-02-09 Thread GitBox
arshadmohammad commented on pull request #2883: URL: https://github.com/apache/hbase/pull/2883#issuecomment-776441988 @saintstack please review This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] Apache-HBase commented on pull request #2946: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2.4

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2946: URL: https://github.com/apache/hbase/pull/2946#issuecomment-776417872 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2946: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2.4

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2946: URL: https://github.com/apache/hbase/pull/2946#issuecomment-776414907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[jira] [Commented] (HBASE-25507) Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic"

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282171#comment-17282171 ] Hudson commented on HBASE-25507: Results for branch branch-2.4 [build #48 on

[jira] [Commented] (HBASE-25559) Terminate threads of oldsources while RS is closing

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282172#comment-17282172 ] Hudson commented on HBASE-25559: Results for branch branch-2.4 [build #48 on

[jira] [Commented] (HBASE-25542) Add client detail to scan name so when lease expires, we have clue on who was scanning

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282170#comment-17282170 ] Hudson commented on HBASE-25542: Results for branch branch-2.4 [build #48 on

[jira] [Commented] (HBASE-25431) MAX_FILESIZE and MEMSTORE_FLUSHSIZE should not be set negative number

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282169#comment-17282169 ] Hudson commented on HBASE-25431: Results for branch branch-2.4 [build #48 on

[GitHub] [hbase] Apache-HBase commented on pull request #2946: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2.4

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2946: URL: https://github.com/apache/hbase/pull/2946#issuecomment-776368521 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25534) Honor TableDescriptor settings earlier in normalization

2021-02-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25534: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed to master and

[GitHub] [hbase] ndimiduk merged pull request #2946: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2.4

2021-02-09 Thread GitBox
ndimiduk merged pull request #2946: URL: https://github.com/apache/hbase/pull/2946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-25534) Honor TableDescriptor settings earlier in normalization

2021-02-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25534: - Fix Version/s: 2.4.2 3.0.0-alpha-1 Status: Patch Available (was:

[GitHub] [hbase] Apache-HBase commented on pull request #2945: [HBASE-25539] Adding replication log queue

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2945: URL: https://github.com/apache/hbase/pull/2945#issuecomment-776350616 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk opened a new pull request #2946: Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2.4

2021-02-09 Thread GitBox
ndimiduk opened a new pull request #2946: URL: https://github.com/apache/hbase/pull/2946 Signed-off-by: Nick Dimiduk This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (HBASE-25534) Honor TableDescriptor settings earlier in normalization

2021-02-09 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25534: - Summary: Honor TableDescriptor settings earlier in normalization (was: Improve the

[GitHub] [hbase] ndimiduk merged pull request #2917: HBASE-25534 Honor TableDescriptor settings earlier in normalization

2021-02-09 Thread GitBox
ndimiduk merged pull request #2917: URL: https://github.com/apache/hbase/pull/2917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] Apache-HBase commented on pull request #2945: [HBASE-25539] Adding replication log queue

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2945: URL: https://github.com/apache/hbase/pull/2945#issuecomment-776325230 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-776303080 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-776300810 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] shahrs87 commented on a change in pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-09 Thread GitBox
shahrs87 commented on a change in pull request #2943: URL: https://github.com/apache/hbase/pull/2943#discussion_r573298803 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -148,12 +148,10 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #2945: [HBASE-25539] Adding replication log queue

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2945: URL: https://github.com/apache/hbase/pull/2945#issuecomment-776265180 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2934: URL: https://github.com/apache/hbase/pull/2934#issuecomment-776241222 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2945: [HBASE-25539] Adding replication log queue

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2945: URL: https://github.com/apache/hbase/pull/2945#issuecomment-776235323 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [hbase] Apache-HBase commented on pull request #2945: [HBASE-25539] Adding replication log queue

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2945: URL: https://github.com/apache/hbase/pull/2945#issuecomment-776231613 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-02-09 Thread Danil Lipovoy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282015#comment-17282015 ] Danil Lipovoy commented on HBASE-23887: --- [~vjasani] Thanks for reasonable comments! Fixed >

[GitHub] [hbase] shahrs87 opened a new pull request #2945: [HBASE-25539] Adding replication log queue

2021-02-09 Thread GitBox
shahrs87 opened a new pull request #2945: URL: https://github.com/apache/hbase/pull/2945 Still in draft phase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573208568 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573208486 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573208223 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573208070 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573207460 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573207051 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573206391 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573206341 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573206052 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[GitHub] [hbase] pustota2009 commented on a change in pull request #2934: HBASE-23887 AdaptiveLRU cache

2021-02-09 Thread GitBox
pustota2009 commented on a change in pull request #2934: URL: https://github.com/apache/hbase/pull/2934#discussion_r573205983 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java ## @@ -0,0 +1,1442 @@ +/** + * Licensed to the

[jira] [Commented] (HBASE-25559) Terminate threads of oldsources while RS is closing

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281976#comment-17281976 ] Hudson commented on HBASE-25559: Results for branch branch-2.2 [build #168 on

[jira] [Commented] (HBASE-25512) May throw StringIndexOutOfBoundsException when construct illegal tablename error

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281946#comment-17281946 ] Hudson commented on HBASE-25512: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-25507) Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic"

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281948#comment-17281948 ] Hudson commented on HBASE-25507: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-25550) More readable Competition Time

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281944#comment-17281944 ] Hudson commented on HBASE-25550: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-25560) Remove unused parameter named peerId in the constructor method of CatalogReplicationSourcePeer

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281943#comment-17281943 ] Hudson commented on HBASE-25560: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-25559) Terminate threads of oldsources while RS is closing

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281949#comment-17281949 ] Hudson commented on HBASE-25559: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-24772) Use GetoptLong or OptionParser in hbase-shell

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281947#comment-17281947 ] Hudson commented on HBASE-24772: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-25542) Add client detail to scan name so when lease expires, we have clue on who was scanning

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281945#comment-17281945 ] Hudson commented on HBASE-25542: Results for branch branch-2 [build #173 on

[jira] [Commented] (HBASE-25507) Leak of ESTABLISHED sockets when compaction encountered "java.io.IOException: Invalid HFile block magic"

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281903#comment-17281903 ] Hudson commented on HBASE-25507: Results for branch branch-2.3 [build #166 on

[GitHub] [hbase] Apache-HBase commented on pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2780: URL: https://github.com/apache/hbase/pull/2780#issuecomment-776074292 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-09 Thread GitBox
saintstack commented on a change in pull request #2943: URL: https://github.com/apache/hbase/pull/2943#discussion_r573040113 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -148,12 +148,10 @@

[GitHub] [hbase] Apache-HBase commented on pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2780: URL: https://github.com/apache/hbase/pull/2780#issuecomment-776070593 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2944: HBASE-25519 BLOCKSIZE needs to support pretty print (branch-2)

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2944: URL: https://github.com/apache/hbase/pull/2944#issuecomment-776041004 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2944: HBASE-25519 BLOCKSIZE needs to support pretty print (branch-2)

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2944: URL: https://github.com/apache/hbase/pull/2944#issuecomment-776039914 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2944: HBASE-25519 BLOCKSIZE needs to support pretty print (branch-2)

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2944: URL: https://github.com/apache/hbase/pull/2944#issuecomment-776036652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Resolved] (HBASE-25519) BLOCKSIZE needs to support pretty print

2021-02-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25519. --- Fix Version/s: 2.5.0 Resolution: Fixed Resovling again after applying to branch-2.

[jira] [Reopened] (HBASE-25519) BLOCKSIZE needs to support pretty print

2021-02-09 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reopened HBASE-25519: --- Reopen to apply branch-2 PR > BLOCKSIZE needs to support pretty print >

[GitHub] [hbase] saintstack merged pull request #2944: HBASE-25519 BLOCKSIZE needs to support pretty print (branch-2)

2021-02-09 Thread GitBox
saintstack merged pull request #2944: URL: https://github.com/apache/hbase/pull/2944 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-25519) BLOCKSIZE needs to support pretty print

2021-02-09 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281833#comment-17281833 ] Baiqiang Zhao commented on HBASE-25519: --- Thanks for review [~stack]. PR for branch-2 has been put

[GitHub] [hbase] ZhaoBQ opened a new pull request #2944: HBASE-25519 BLOCKSIZE needs to support pretty print (branch-2)

2021-02-09 Thread GitBox
ZhaoBQ opened a new pull request #2944: URL: https://github.com/apache/hbase/pull/2944 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache-HBase commented on pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2780: URL: https://github.com/apache/hbase/pull/2780#issuecomment-775983543 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate

2021-02-09 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281808#comment-17281808 ] Viraj Jasani commented on HBASE-23887: -- [~pustota], left few comments on PR. Please take a look

[GitHub] [hbase] sanjeetnishad95 commented on a change in pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
sanjeetnishad95 commented on a change in pull request #2780: URL: https://github.com/apache/hbase/pull/2780#discussion_r572895744 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java ## @@ -621,4 +622,38 @@ public void

[GitHub] [hbase] sanjeetnishad95 commented on a change in pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
sanjeetnishad95 commented on a change in pull request #2780: URL: https://github.com/apache/hbase/pull/2780#discussion_r572895333 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java ## @@ -621,4 +622,38 @@ public void

[GitHub] [hbase] sanjeetnishad95 commented on a change in pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
sanjeetnishad95 commented on a change in pull request #2780: URL: https://github.com/apache/hbase/pull/2780#discussion_r572894873 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsAdmin1.java ## @@ -621,4 +622,38 @@ public void

[GitHub] [hbase] sanjeetnishad95 commented on a change in pull request #2780: HBASE-25301 NPE while running balance_rsgroup if any split region is …

2021-02-09 Thread GitBox
sanjeetnishad95 commented on a change in pull request #2780: URL: https://github.com/apache/hbase/pull/2780#discussion_r572894248 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java ## @@ -1130,6 +1130,12 @@ private boolean

[jira] [Commented] (HBASE-25512) May throw StringIndexOutOfBoundsException when construct illegal tablename error

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281777#comment-17281777 ] Hudson commented on HBASE-25512: Results for branch master [build #206 on

[jira] [Commented] (HBASE-25542) Add client detail to scan name so when lease expires, we have clue on who was scanning

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281778#comment-17281778 ] Hudson commented on HBASE-25542: Results for branch master [build #206 on

[jira] [Commented] (HBASE-25550) More readable Competition Time

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281775#comment-17281775 ] Hudson commented on HBASE-25550: Results for branch master [build #206 on

[jira] [Commented] (HBASE-25519) BLOCKSIZE needs to support pretty print

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281776#comment-17281776 ] Hudson commented on HBASE-25519: Results for branch master [build #206 on

[jira] [Commented] (HBASE-25560) Remove unused parameter named peerId in the constructor method of CatalogReplicationSourcePeer

2021-02-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281774#comment-17281774 ] Hudson commented on HBASE-25560: Results for branch master [build #206 on

[GitHub] [hbase] Apache-HBase commented on pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2943: URL: https://github.com/apache/hbase/pull/2943#issuecomment-775896915 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2943: URL: https://github.com/apache/hbase/pull/2943#issuecomment-775865394 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying

2021-02-09 Thread GitBox
wchevreuil commented on a change in pull request #2943: URL: https://github.com/apache/hbase/pull/2943#discussion_r572766045 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -148,12 +148,10 @@

[jira] [Comment Edited] (HBASE-25559) Terminate threads of oldsources while RS is closing

2021-02-09 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281654#comment-17281654 ] Sun Xin edited comment on HBASE-25559 at 2/9/21, 9:29 AM: -- Merged to master and

[GitHub] [hbase] aimiebell commented on a change in pull request #2936: HBASE-21674 Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-09 Thread GitBox
aimiebell commented on a change in pull request #2936: URL: https://github.com/apache/hbase/pull/2936#discussion_r572623116 ## File path: hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/generated/TIncrement.java ## @@ -11,7 +11,7 @@ * For increments that are not

[jira] [Resolved] (HBASE-25559) Terminate threads of oldsources while RS is closing

2021-02-09 Thread Sun Xin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sun Xin resolved HBASE-25559. - Fix Version/s: 2.4.2 2.3.5 2.2.7 3.0.0-alpha-1

[GitHub] [hbase] Apache-HBase commented on pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying'

2021-02-09 Thread GitBox
Apache-HBase commented on pull request #2943: URL: https://github.com/apache/hbase/pull/2943#issuecomment-775788321 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-09 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-21674: -- Fix Version/s: 1.7.0 > Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from

[GitHub] [hbase] Reidddddd commented on pull request #2941: HBASE-21674:Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

2021-02-09 Thread GitBox
Reidd commented on pull request #2941: URL: https://github.com/apache/hbase/pull/2941#issuecomment-775765450 ping @apurtell @busbey > major version 52 is newer than 51, the highest major version supported by this compiler. It is recommended that the compiler be upgraded. is

[GitHub] [hbase] ddupg merged pull request #2938: HBASE-25559 Terminate threads of oldsources while RS is closing

2021-02-09 Thread GitBox
ddupg merged pull request #2938: URL: https://github.com/apache/hbase/pull/2938 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hbase] ddupg opened a new pull request #2943: HBASE-25562 ReplicationSourceWALReader log and handle exception immediately without retrying'

2021-02-09 Thread GitBox
ddupg opened a new pull request #2943: URL: https://github.com/apache/hbase/pull/2943 …iately without retrying This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and