Apache-HBase commented on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-831033118
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
anoopsjohn commented on a change in pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#discussion_r624854957
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java
##
@@ -196,13 +202,17 @@ public void
Apache-HBase commented on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830995845
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3218:
URL: https://github.com/apache/hbase/pull/3218#issuecomment-830981043
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Apache-HBase commented on pull request #3218:
URL: https://github.com/apache/hbase/pull/3218#issuecomment-830970392
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3219:
URL: https://github.com/apache/hbase/pull/3219#issuecomment-830970289
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3219:
URL: https://github.com/apache/hbase/pull/3219#issuecomment-830960493
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
Apache-HBase commented on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830917678
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3219:
URL: https://github.com/apache/hbase/pull/3219#issuecomment-830915350
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3218:
URL: https://github.com/apache/hbase/pull/3218#issuecomment-830915161
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #251:
URL: https://github.com/apache/hbase/pull/251#issuecomment-830877037
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s
[
https://issues.apache.org/jira/browse/HBASE-25836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25836:
Status: Patch Available (was: Open)
> RegionStates#getAssignmentsForBalancer
apurtell commented on pull request #3218:
URL: https://github.com/apache/hbase/pull/3218#issuecomment-830875112
Tested in an integration cluster test scenario (see
https://github.com/apache/hbase/pull/3208) but let's see what the unit test
results in the CR report looks like.
--
This
apurtell commented on pull request #3219:
URL: https://github.com/apache/hbase/pull/3219#issuecomment-830875094
Tested in an integration cluster test scenario (see
https://github.com/apache/hbase/pull/3208) but let's see what the unit test
results in the CR report looks like.
--
This
apurtell opened a new pull request #3219:
URL: https://github.com/apache/hbase/pull/3219
RegionStates#getAssignmentsForBalancer is used by the HMaster to collect all
regions of interest to the balancer for the next chore iteration. We check if a
table is in disabled state to exclude
[
https://issues.apache.org/jira/browse/HBASE-25835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25835:
Status: Patch Available (was: Open)
> Ignore duplicate split requests from
apurtell opened a new pull request #3218:
URL: https://github.com/apache/hbase/pull/3218
A SplitTableRegionProcedure may already be running when a regionserver
report is received that includes a split request. The outcome is multiple
SplitTableRegionProcedure procedures scheduled for the
apurtell edited a comment on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830869393
This issue was only recently found because you have to get ~1000 files into
the set before it manifests:
Error: java.lang.IllegalArgumentException: Row length
[
https://issues.apache.org/jira/browse/HBASE-25836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-25836:
Description:
RegionStates#getAssignmentsForBalancer is used by the HMaster to
Andrew Kyle Purtell created HBASE-25836:
---
Summary: RegionStates#getAssignmentsForBalancer should only care
about OPEN or OPENING regions
Key: HBASE-25836
URL:
Andrew Kyle Purtell created HBASE-25835:
---
Summary: Ignore duplicate split requests from regionserver reports
Key: HBASE-25835
URL: https://issues.apache.org/jira/browse/HBASE-25835
Project:
apurtell edited a comment on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830869393
This issue was only recently found because you have to get ~1000 files into
the set before it manifests:
Error: java.lang.IllegalArgumentException: Row length
apurtell edited a comment on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830869393
One more issue, found during verify, have to get ~1000 files into the set
before seeing it.
Error: java.lang.IllegalArgumentException: Row length 73872 is >
apurtell edited a comment on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830869393
One more issue, found during verify, have to get ~1000 files into the set
before seeing it.
Error: java.lang.IllegalArgumentException: Row length 73872 is >
apurtell commented on pull request #3208:
URL: https://github.com/apache/hbase/pull/3208#issuecomment-830869393
One more issue, found during verify, have to get ~1000 files into the set
before seeing it.
Error: java.lang.IllegalArgumentException: Row length 73872 is > 32767
Apache-HBase commented on pull request #3217:
URL: https://github.com/apache/hbase/pull/3217#issuecomment-830855423
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#issuecomment-830847650
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#issuecomment-830847229
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-22105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338089#comment-17338089
]
Ankit Singhal commented on HBASE-22105:
---
I'm not working on this currently, so [~saksham.gangwar],
[
https://issues.apache.org/jira/browse/HBASE-22105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal reassigned HBASE-22105:
-
Assignee: (was: Ankit Singhal)
> Snapshot of the table fails when region is
Apache-HBase commented on pull request #3217:
URL: https://github.com/apache/hbase/pull/3217#issuecomment-830845055
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
Apache-HBase commented on pull request #3213:
URL: https://github.com/apache/hbase/pull/3213#issuecomment-830839476
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m
[
https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338068#comment-17338068
]
Zhuoyue Huang commented on HBASE-25790:
---
[~vjasani] I will provide a screenshot and create a PR
GeorryHuang commented on pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#issuecomment-830832807
> I verified this locally. @GeorryHuang please create PR against branch-2.
> Thanks
no problem
--
This is an automated message from the Apache Git Service.
To
GeorryHuang commented on pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#issuecomment-830832718
> @GeorryHuang Before I commit, can you once execute new shell command
locally and provide a screenshot of how result looks like? Please build latest
code as per this PR.
virajjasani commented on pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#issuecomment-830831235
I verified this locally. @GeorryHuang please create PR against branch-2.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
Apache-HBase commented on pull request #3213:
URL: https://github.com/apache/hbase/pull/3213#issuecomment-830831473
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
virajjasani merged pull request #3182:
URL: https://github.com/apache/hbase/pull/3182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
Apache-HBase commented on pull request #3217:
URL: https://github.com/apache/hbase/pull/3217#issuecomment-830830091
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 7m
Apache-HBase commented on pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#issuecomment-830821887
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache9 opened a new pull request #3217:
URL: https://github.com/apache/hbase/pull/3217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/HBASE-25834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25834:
--
Component/s: Balancer
> Remove balanceTable method from LoadBalancer interface
>
[
https://issues.apache.org/jira/browse/HBASE-25834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25834:
--
Summary: Remove balanceTable method from LoadBalancer interface (was: The
balanceTable method is
[
https://issues.apache.org/jira/browse/HBASE-25834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25834:
--
Description: The balanceTable method is never called outside balancer
implementation, so let's remove
[
https://issues.apache.org/jira/browse/HBASE-25834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25834:
-
Assignee: Duo Zhang
> The balanceTable method is never called outside balancer implementation
[
https://issues.apache.org/jira/browse/HBASE-25826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25826:
--
Component/s: Balancer
> Revisit the synchronization of balancer implementation
>
[
https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-25698:
-
Component/s: BucketCache
> Persistent IllegalReferenceCountException at scanner open when using
Duo Zhang created HBASE-25834:
-
Summary: The balanceTable method is never called outside balancer
implementation
Key: HBASE-25834
URL: https://issues.apache.org/jira/browse/HBASE-25834
Project: HBase
[
https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338025#comment-17338025
]
Viraj Jasani commented on HBASE-25698:
--
Looks like some info related to CombinedBlockCache is
[
https://issues.apache.org/jira/browse/HBASE-25826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25826:
-
Assignee: Duo Zhang
> Revisit the synchronization of balancer implementation
>
[
https://issues.apache.org/jira/browse/HBASE-25826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25826:
--
Issue Type: Umbrella (was: Improvement)
> Revisit the synchronization of balancer implementation
>
Apache-HBase commented on pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#issuecomment-830814534
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
virajjasani commented on a change in pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#discussion_r624699556
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
##
@@ -890,4 +892,89 @@ public void testDBEShipped() throws
Apache-HBase commented on pull request #3213:
URL: https://github.com/apache/hbase/pull/3213#issuecomment-830812538
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25832:
-
Assignee: Duo Zhang
> Performance improvements for StochasticLoadBalancer
>
[
https://issues.apache.org/jira/browse/HBASE-25832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-25832:
--
Issue Type: Umbrella (was: Improvement)
> Performance improvements for StochasticLoadBalancer
>
Apache9 commented on a change in pull request #3204:
URL: https://github.com/apache/hbase/pull/3204#discussion_r624692362
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
##
@@ -641,8 +641,8 @@ public void
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-25833.
---
Fix Version/s: 3.0.0-alpha-1
Hadoop Flags: Reviewed
Resolution: Fixed
Merged to master.
Apache9 merged pull request #3216:
URL: https://github.com/apache/hbase/pull/3216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
Apache9 commented on a change in pull request #3213:
URL: https://github.com/apache/hbase/pull/3213#discussion_r624691199
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestSyncReplicationStandbyKillRS.java
##
@@ -72,16 +72,26 @@ public void
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338005#comment-17338005
]
Duo Zhang commented on HBASE-25833:
---
You need to be added to the contributor list first. This is about
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang reassigned HBASE-25833:
-
Assignee: Che Xun
> HBase Configuration File Descriptions has some description errors or
>
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337990#comment-17337990
]
Che Xun edited comment on HBASE-25833 at 5/2/21, 12:29 PM:
---
Hi , [~zhangduo],
chexunn edited a comment on pull request #3216:
URL: https://github.com/apache/hbase/pull/3216#issuecomment-830785759
Hi , @Apache9 , @ndimiduk, @apurtell
Could you please review this PR and provide feedback?
Thanks,
Che Xun
--
This is an automated message from the
anoopsjohn commented on a change in pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#discussion_r624684605
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/TinyLfuBlockCache.java
##
@@ -177,6 +177,7 @@ public Cacheable
Apache-HBase commented on pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#issuecomment-830795122
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#issuecomment-830794259
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
Apache-HBase commented on pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#issuecomment-830793171
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
Apache-HBase commented on pull request #3216:
URL: https://github.com/apache/hbase/pull/3216#issuecomment-830788256
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
Apache-HBase commented on pull request #3216:
URL: https://github.com/apache/hbase/pull/3216#issuecomment-830786241
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337990#comment-17337990
]
Che Xun edited comment on HBASE-25833 at 5/2/21, 10:26 AM:
---
Hi , [~zhangduo]
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Che Xun updated HBASE-25833:
Attachment: (was: HBASE-25833.patch)
> HBase Configuration File Descriptions has some description
Apache-HBase commented on pull request #3216:
URL: https://github.com/apache/hbase/pull/3216#issuecomment-830785745
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m
chexunn commented on pull request #3216:
URL: https://github.com/apache/hbase/pull/3216#issuecomment-830785759
Hi , @Apache9
Could you please review this PR and provide feedback?
Thanks,
Che Xun
--
This is an automated message from the Apache Git Service.
To respond to
chexunn opened a new pull request #3216:
URL: https://github.com/apache/hbase/pull/3216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Che Xun updated HBASE-25833:
Description:
In Apache HBase ™ Reference Guide
*Need to modify part1：*
_3 Configuration Files->HBase
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337990#comment-17337990
]
Che Xun commented on HBASE-25833:
-
This is my first time to contribute to HBase, how to assign this
[
https://issues.apache.org/jira/browse/HBASE-25833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Che Xun updated HBASE-25833:
Attachment: HBASE-25833.patch
> HBase Configuration File Descriptions has some description errors or
>
Apache-HBase commented on pull request #3182:
URL: https://github.com/apache/hbase/pull/3182#issuecomment-830779060
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m
Che Xun created HBASE-25833:
---
Summary: HBase Configuration File Descriptions has some
description errors or inaccurate
Key: HBASE-25833
URL: https://issues.apache.org/jira/browse/HBASE-25833
Project: HBase
Apache-HBase commented on pull request #3215:
URL: https://github.com/apache/hbase/pull/3215#issuecomment-830770616
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m
[
https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337968#comment-17337968
]
Viraj Jasani commented on HBASE-25790:
--
[~GeorryHuang] Can you please also create PR against
[
https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337967#comment-17337967
]
Viraj Jasani commented on HBASE-25790:
--
FYI [~apurtell], a new shell command that provides balancer
[
https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337966#comment-17337966
]
Viraj Jasani edited comment on HBASE-25790 at 5/2/21, 7:31 AM:
---
[
https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337966#comment-17337966
]
Viraj Jasani commented on HBASE-25790:
--
[~GeorryHuang] can you once execute new shell command
virajjasani commented on a change in pull request #3213:
URL: https://github.com/apache/hbase/pull/3213#discussion_r624646868
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestSyncReplicationStandbyKillRS.java
##
@@ -72,16 +72,26 @@ public void
[
https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-25698 started by Viraj Jasani.
> Persistent IllegalReferenceCountException at scanner open when using
>
[
https://issues.apache.org/jira/browse/HBASE-25698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viraj Jasani updated HBASE-25698:
-
Status: Patch Available (was: In Progress)
> Persistent IllegalReferenceCountException at
virajjasani opened a new pull request #3215:
URL: https://github.com/apache/hbase/pull/3215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
89 matches
Mail list logo
