[GitHub] [hbase-connectors] Apache-HBase commented on pull request #78: HBASE-25579 HBase Connectors pom should include nexus staging repo management

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #78: URL: https://github.com/apache/hbase-connectors/pull/78#issuecomment-836213138 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec |

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-836165849 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3249: URL: https://github.com/apache/hbase/pull/3249#issuecomment-836135674 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-09 Thread Baiqiang Zhao (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341642#comment-17341642 ] Baiqiang Zhao commented on HBASE-25861: --- Put up a PR. Ping [~zhangduo], [~stack], [~ndimiduk], if

[GitHub] [hbase] ZhaoBQ opened a new pull request #3249: HBASE-25861 Correct the usage of Configuration#addDeprecation

2021-05-09 Thread GitBox
ZhaoBQ opened a new pull request #3249: URL: https://github.com/apache/hbase/pull/3249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-836091985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341636#comment-17341636 ] Hudson commented on HBASE-25790: Results for branch branch-2.4 [build #113 on

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-836053080 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-836051555 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache9 commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
Apache9 commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-836045614 So we will only compress value? As we will do batching when writing WAL entries out, is it possible to compress when flushing? The data will be larger and compress may

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-835946972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r628956456 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -220,6 +223,8 @@ public ByteString

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r628956646 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -220,6 +223,8 @@ public ByteString

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-09 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r628956456 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java ## @@ -220,6 +223,8 @@ public ByteString

[GitHub] [hbase] joshelser commented on a change in pull request #3124: HBASE-25711 Setting wrong data block encoding through ColumnFamilyDes…

2021-05-09 Thread GitBox
joshelser commented on a change in pull request #3124: URL: https://github.com/apache/hbase/pull/3124#discussion_r628936662 ## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/util/ColumnFamilyAttributeValidator.java ## @@ -0,0 +1,102 @@ +/** + * + * Licensed to

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835856286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-25790) NamedQueue 'BalancerRejection' for recent history of balancer skipping

2021-05-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341581#comment-17341581 ] Hudson commented on HBASE-25790: Results for branch branch-2 [build #246 on

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835842946 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25873) Revisit the implementation of CostFunctions

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341538#comment-17341538 ] Duo Zhang commented on HBASE-25873: ---

[jira] [Assigned] (HBASE-25873) Revisit the implementation of CostFunctions

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25873: - Assignee: Duo Zhang > Revisit the implementation of CostFunctions >

[jira] [Updated] (HBASE-25873) Revisit the implementation of CostFunctions

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25873: -- Component/s: Performance Balancer > Revisit the implementation of CostFunctions >

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835822126 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Created] (HBASE-25873) Revisit the implementation of CostFunctions

2021-05-09 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25873: - Summary: Revisit the implementation of CostFunctions Key: HBASE-25873 URL: https://issues.apache.org/jira/browse/HBASE-25873 Project: HBase Issue Type: Sub-task

[jira] [Updated] (HBASE-25863) [hbase-thirdparty] Shade javax.ws.rs package for use with shaded Jersey

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25863: -- Summary: [hbase-thirdparty] Shade javax.ws.rs package for use with shaded Jersey (was: Shade

[jira] [Updated] (HBASE-25868) [hbase-thirdparty] Shade jackson-jaxrs-json-provider for use with shaded jersey

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25868: -- Summary: [hbase-thirdparty] Shade jackson-jaxrs-json-provider for use with shaded jersey (was: Shade

[jira] [Commented] (HBASE-25860) Add metric for successful wal roll requests.

2021-05-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341510#comment-17341510 ] Hudson commented on HBASE-25860: Results for branch master [build #287 on

[jira] [Commented] (HBASE-25774) ServerManager.getOnlineServer may miss some region servers when refreshing state in some procedure implementations

2021-05-09 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341509#comment-17341509 ] Hudson commented on HBASE-25774: Results for branch master [build #287 on

[jira] [Updated] (HBASE-25872) Add documentation for LoadBalancer about synchronization

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25872: -- Component/s: documentation Balancer > Add documentation for LoadBalancer about

[jira] [Assigned] (HBASE-25872) Add documentation for LoadBalancer about synchronization

2021-05-09 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-25872: - Assignee: Duo Zhang > Add documentation for LoadBalancer about synchronization >

[jira] [Created] (HBASE-25872) Add documentation for LoadBalancer about synchronization

2021-05-09 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-25872: - Summary: Add documentation for LoadBalancer about synchronization Key: HBASE-25872 URL: https://issues.apache.org/jira/browse/HBASE-25872 Project: HBase Issue

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835743860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3248: HBASE-25852 Move all the intialization work of LoadBalancer implement…

2021-05-09 Thread GitBox
Apache-HBase commented on pull request #3248: URL: https://github.com/apache/hbase/pull/3248#issuecomment-835722207 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m