[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844723701 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25899) Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-25899: --- Attachment: cleaner-result.png > Improve efficiency of SnapshotHFileCleaner >

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844713121 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635778623 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/BoundedDelegatingInputStream.java ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844698814 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844690212 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844683025 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348031#comment-17348031 ] Andrew Kyle Purtell commented on HBASE-25841: - I don’t have a strong opinion either way

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348030#comment-17348030 ] Andrew Kyle Purtell commented on HBASE-24623: - Not sure. The idea didn’t pan out, so if it

[GitHub] [hbase] Apache-HBase commented on pull request #3280: HBASE-25899 Improve efficiency of SnapshotHFileCleaner

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3280: URL: https://github.com/apache/hbase/pull/3280#issuecomment-844658762 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348028#comment-17348028 ] Anoop Sam John commented on HBASE-24623: So ur jira was never committed Andy? > SIGSEGV v

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844648566 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348027#comment-17348027 ] Anoop Sam John commented on HBASE-24623: Oh.. Thanks for those details Andy. Now I remember ur

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844641501 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635699848 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/BoundedDelegatingInputStream.java ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844628225 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[GitHub] [hbase] bharathv edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844625565 > SNAPPY+copy had a 10x loss, now SNAPPY+no-copy has a 10x gain. I double checked these findings and it seems correct. I will re-run the benchmark when measuring for the

[jira] [Comment Edited] (HBASE-25869) WAL value compression

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342054#comment-17342054 ] Andrew Kyle Purtell edited comment on HBASE-25869 at 5/20/21, 2:06 AM:

[GitHub] [hbase] bharathv commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844625565 > SNAPPY+copy had a 10x loss, now SNAPPY+no-copy has a 10x gain. I double checked these findings and it seems correct. I will re-run the benchmark when measuring for the other

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844624849 SNAPPY or ZSTD are recommended, all other options provided for comparison. (LZMA is included as a sanity check that indeed an expensive algorithm really is expensive.)

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844612699 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 10m

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348004#comment-17348004 ] Duo Zhang commented on HBASE-25032: --- Was wondering whether we need to commit this to branch-2.4 and

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844602944 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635659322 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplitValueCompression.java ## @@ -0,0 +1,44 @@ +/** + * Licensed to the

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635658814 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@

[GitHub] [hbase] ndimiduk commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
ndimiduk commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635657600 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java ## @@ -18,37 +18,117 @@ package

[jira] [Resolved] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25861. -- Resolution: Fixed Re-resolving. After several iterations of running all tests in

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844574860 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844561641 I am redoing microbenchmarks with the latest patch and will update here soon. Improvements have unlocked IO performance improvement from the compression.

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844561641 I am redoing microbenchmarks with the latest patch and will update here soon. Improvements have unlocked IO performance improvement from the compression.

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347979#comment-17347979 ] Nick Dimiduk commented on HBASE-25032: -- I had several other things come up this afternoon, but

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844561641 I am redoing microbenchmarks with the latest patch and will update here soon. Removing the extra copy unlocked IO performance improvement from the compression.

[GitHub] [hbase] apurtell edited a comment on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell edited a comment on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844459128 @bharathv I wrote a simple bounded delegating input stream impl to avoid the unnecessary copy at decompression time. Rebased on master. -- This is an automated message

[jira] [Reopened] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk reopened HBASE-25861: -- I see test failure on branch-2. > Correct the usage of Configuration#addDeprecation >

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635636372 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@ public

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844551687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844513107 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844510331 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Updated] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25887: Fix Version/s: 2.4.4 2.3.6 2.5.0

[jira] [Commented] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347869#comment-17347869 ] Andrew Kyle Purtell commented on HBASE-25887: - Updated fix versions > Corrupt wal while

[GitHub] [hbase] sandeepvinayak commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844485056 @apurtell @gjacoby126 Changed the interface audience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635582196 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,39 @@

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844467585 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635591707 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
apurtell commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635588417 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,39 @@ +/**

[GitHub] [hbase] gjacoby126 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
gjacoby126 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635573592 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,39 @@

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844459128 @bharathv I wrote a simple bounded delegating input stream impl to avoid the unnecessary copy at decompression time. Rebased on master. Let me collect updated

[jira] [Updated] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25875: Fix Version/s: (was: 2.4.3) > RegionServer failed to start due to

[jira] [Reopened] (HBASE-25875) RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reopened HBASE-25875: - Revert for now from branch-2.4. > RegionServer failed to start due to

[jira] [Updated] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25032: Fix Version/s: (was: 2.4.3) > Do not assign regions to region server which

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347835#comment-17347835 ] Andrew Kyle Purtell commented on HBASE-25032: - Ok, I will reopen both JIRAs and revert both

[jira] [Reopened] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reopened HBASE-25032: - Revert for now from branch-2.4. > Do not assign regions to region server which has

[jira] [Commented] (HBASE-25032) Do not assign regions to region server which has not called regionServerReport yet

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347834#comment-17347834 ] Nick Dimiduk commented on HBASE-25032: -- Head's up [~apurtell], it looks like there's a test

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347832#comment-17347832 ] Nick Dimiduk commented on HBASE-25841: -- [~apurtell] is this something you'd be interested in

[GitHub] [hbase] Apache-HBase commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-844387979 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Updated] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25841: - Resolution: Fixed Status: Resolved (was: Patch Available) > Add basic jshell support >

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347831#comment-17347831 ] Nick Dimiduk commented on HBASE-25841: -- Merged to master and branch-2. > Add basic jshell support

[jira] [Updated] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25841: - Fix Version/s: 2.5.0 > Add basic jshell support > > >

[GitHub] [hbase] ndimiduk merged pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
ndimiduk merged pull request #3284: URL: https://github.com/apache/hbase/pull/3284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] Apache-HBase commented on pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3284: URL: https://github.com/apache/hbase/pull/3284#issuecomment-844385294 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347829#comment-17347829 ] Nick Dimiduk commented on HBASE-25841: -- Head's up: there's a [known

[jira] [Resolved] (HBASE-25889) Provide javadoc strings for all significant public symbols in o.a.h.h.client.*

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk resolved HBASE-25889. -- Resolution: Invalid > Provide javadoc strings for all significant public symbols in

[jira] [Commented] (HBASE-25889) Provide javadoc strings for all significant public symbols in o.a.h.h.client.*

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347828#comment-17347828 ] Nick Dimiduk commented on HBASE-25889: -- Oh, I see. This is a [known

[jira] [Commented] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-19 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347827#comment-17347827 ] Bharath Vissapragada commented on HBASE-25887: -- I have another theory of what is happening

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635506795 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@ public

[jira] [Updated] (HBASE-25887) Corrupt wal while region server is aborting.

2021-05-19 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharath Vissapragada updated HBASE-25887: - Affects Version/s: 2.5.0 3.0.0-alpha-1 > Corrupt wal

[GitHub] [hbase] bharathv commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
bharathv commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-844379331 > That's what I was trying to bring up in one of our internal discussion. After bumping Disruptor version on branch-1, our current Disruptor c'tor is deprecated and the one

[GitHub] [hbase] wchevreuil commented on a change in pull request #3232: HBASE-25839 Bulk Import fails with java.io.IOException: Type mismatch in value from map

2021-05-19 Thread GitBox
wchevreuil commented on a change in pull request #3232: URL: https://github.com/apache/hbase/pull/3232#discussion_r632524231 ## File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java ## @@ -135,9 +135,7 @@ public CellWritableComparable(Cell kv)

[GitHub] [hbase] Apache-HBase commented on pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3283: URL: https://github.com/apache/hbase/pull/3283#issuecomment-844377542 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3284: URL: https://github.com/apache/hbase/pull/3284#issuecomment-844375907 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m

[GitHub] [hbase] Apache-HBase commented on pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3284: URL: https://github.com/apache/hbase/pull/3284#issuecomment-844374432 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] ndimiduk opened a new pull request #3284: Backport "HBASE-25841 Add basic jshell support" to branch-2

2021-05-19 Thread GitBox
ndimiduk opened a new pull request #3284: URL: https://github.com/apache/hbase/pull/3284 Signed-off-by: Bharath Vissapragada Signed-off-by: Pankaj Kumar Signed-off-by: Duo Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hbase] Apache-HBase commented on pull request #3224: HBASE-25841 Add basic jshell support

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3224: URL: https://github.com/apache/hbase/pull/3224#issuecomment-844368639 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3224: HBASE-25841 Add basic jshell support

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3224: URL: https://github.com/apache/hbase/pull/3224#issuecomment-844368393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[jira] [Updated] (HBASE-25841) Add basic jshell support

2021-05-19 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25841: - Fix Version/s: 3.0.0-alpha-1 > Add basic jshell support > > >

[GitHub] [hbase] ndimiduk merged pull request #3224: HBASE-25841 Add basic jshell support

2021-05-19 Thread GitBox
ndimiduk merged pull request #3224: URL: https://github.com/apache/hbase/pull/3224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635489204 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635483682 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@ public

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635482591 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,36 @@

[GitHub] [hbase] apurtell commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635482369 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/DelegatingInputStream.java ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844355147 > just extend FIS and add setDelegate (that makes it small). Oh, I misunderstood. Sure, I can do that. -- This is an automated message from the Apache Git Service. To

[GitHub] [hbase] sandeepvinayak commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635481243 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReader.java ## @@ -165,6 +165,12 @@

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635476647 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,36 @@ +/**

[jira] [Commented] (HBASE-25861) Correct the usage of Configuration#addDeprecation

2021-05-19 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347811#comment-17347811 ] Hudson commented on HBASE-25861: Results for branch branch-2 [build #254 on

[GitHub] [hbase] shahrs87 commented on a change in pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
shahrs87 commented on a change in pull request #3283: URL: https://github.com/apache/hbase/pull/3283#discussion_r635472479 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntryFilterRetryableException.java ## @@ -0,0 +1,36 @@ +/**

[jira] [Commented] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347810#comment-17347810 ] Wellington Chevreuil commented on HBASE-25885: -- Thanks for reviewing it, [~psomogyi]! >

[jira] [Updated] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25885: - Fix Version/s: hbase-operator-tools-1.2.0 > [hbase-operator-tools] Extra checks

[jira] [Updated] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25885: - Affects Version/s: hbase-operator-tools-1.1.0 > [hbase-operator-tools] Extra

[jira] [Resolved] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil resolved HBASE-25885. -- Resolution: Fixed > [hbase-operator-tools] Extra checks on RegionsMerger to

[jira] [Updated] (HBASE-25885) [hbase-operator-tools] Extra checks on RegionsMerger to avoid submitting merge requests for regions with merge qualifiers

2021-05-19 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil updated HBASE-25885: - Component/s: hbase-operator-tools > [hbase-operator-tools] Extra checks on

[GitHub] [hbase-operator-tools] wchevreuil merged pull request #87: HBASE-25885 [hbase-operator-tools] Extra checks on RegionsMerger to a…

2021-05-19 Thread GitBox
wchevreuil merged pull request #87: URL: https://github.com/apache/hbase-operator-tools/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [hbase] Apache-HBase commented on pull request #3276: HBASE-25894 Improve the performance for region load and region count related cost functions

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3276: URL: https://github.com/apache/hbase/pull/3276#issuecomment-844336972 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635463483 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/DelegatingInputStream.java ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] Apache-HBase commented on pull request #3281: HBASE-25897 TestRetainAssignmentOnRestart is flaky after HBASE-25032

2021-05-19 Thread GitBox
Apache-HBase commented on pull request #3281: URL: https://github.com/apache/hbase/pull/3281#issuecomment-844335051 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] bharathv commented on a change in pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
bharathv commented on a change in pull request #3244: URL: https://github.com/apache/hbase/pull/3244#discussion_r635463483 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/DelegatingInputStream.java ## @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache

[GitHub] [hbase] sandeepvinayak opened a new pull request #3283: HBASE-25848: Add flexibility to backup replication in case replication filter throws an exception

2021-05-19 Thread GitBox
sandeepvinayak opened a new pull request #3283: URL: https://github.com/apache/hbase/pull/3283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Comment Edited] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347793#comment-17347793 ] Andrew Kyle Purtell edited comment on HBASE-24623 at 5/19/21, 5:23 PM:

[jira] [Commented] (HBASE-24623) SIGSEGV v ~StubRoutines::jbyte_disjoint_arraycopy

2021-05-19 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347793#comment-17347793 ] Andrew Kyle Purtell commented on HBASE-24623: - {quote}There was a jira that

[GitHub] [hbase] bharathv commented on pull request #3264: HBASE-25887 Wait for appendExecutor to shutdown running tasks

2021-05-19 Thread GitBox
bharathv commented on pull request #3264: URL: https://github.com/apache/hbase/pull/3264#issuecomment-844307527 I'm reading the disruptor shutdown code and now I'm a bit confused, lets hold off on merging this until I get back (by EOD). -- This is an automated message from the Apache

[GitHub] [hbase] apurtell commented on pull request #3244: HBASE-25869 WAL value compression

2021-05-19 Thread GitBox
apurtell commented on pull request #3244: URL: https://github.com/apache/hbase/pull/3244#issuecomment-844301569 Unit test failure is not related. TestJMXListener.setupBeforeClass:68 » IO Shutting down Going to merge today unless objection. -- This is an automated

  1   2   >